<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>224483</bug_id>
          
          <creation_ts>2021-04-13 05:59:48 -0700</creation_ts>
          <short_desc>text-decoration-thickness property doesn&apos;t always trigger repaint when changed</short_desc>
          <delta_ts>2023-01-08 13:14:13 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Text</component>
          <version>Safari 14</version>
          <rep_platform>Mac (Intel)</rep_platform>
          <op_sys>macOS 10.15</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://github.com/web-platform-tests/wpt/pull/37799</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Vanita Barrett-Smith">vanita.barrett</reporter>
          <assigned_to name="Tim Nguyen (:ntim)">ntim</assigned_to>
          <cc>mmaxfield</cc>
    
    <cc>ntim</cc>
    
    <cc>oliver.byford</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1749661</commentid>
    <comment_count>0</comment_count>
      <attachid>425866</attachid>
    <who name="Vanita Barrett-Smith">vanita.barrett</who>
    <bug_when>2021-04-13 05:59:48 -0700</bug_when>
    <thetext>Created attachment 425866
HTML example (alternative to CodePen)

## Steps to reproduce
1. Open https://codepen.io/36degrees/pen/LYxQBbm or the attached example.html
2. Hover over both links of the links on the line “17px link / with colour change” - text decoration thickness property expands to 3px
3. Hover over both of the links on the line “19px link / with colour change” - text decoration thickness property only expands to 3px on the link with colour change.

## Expected Behaviour 
The text underline thickness should increase to 3px on all links when hovered.

## Actual Behaviour
In this example, the text-decoration-thickness only increases to 3px on hover on links up to a font-size of 19px, unless the link also has a colour change on hover.

The font-size at which the text-decoration-thickness property stops working changes depending on the thickness being set on hover. In the CodePen / attached example, text-decoration-thickness is set to 3px on hover and stops working at links of font-size: 19px. Other examples:

text-decoration-thickness on hover: 2px 
font-size value at which it stops working: 15px

text-decoration-thickness on hover: 5px 
font-size value at which it stops working: 27px</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1749881</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2021-04-13 14:55:58 -0700</bug_when>
    <thetext>In Safari 14.1, the underlines for 19px+ links are not painted at all (but the color ones are). Not sure if we&apos;d want to track this aspect as a separate bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1752235</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-04-20 06:00:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/76895249&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1923915</commentid>
    <comment_count>3</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2023-01-07 23:31:46 -0800</bug_when>
    <thetext>I have a fix for this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1923916</commentid>
    <comment_count>4</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2023-01-08 00:00:06 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/8372</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1923917</commentid>
    <comment_count>5</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2023-01-08 00:01:22 -0800</bug_when>
    <thetext>Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/37799</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1923968</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-01-08 13:14:10 -0800</bug_when>
    <thetext>Committed 258641@main (6be98ae1629f): &lt;https://commits.webkit.org/258641@main&gt;

Reviewed commits have been landed. Closing PR #8372 and removing active labels.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>425866</attachid>
            <date>2021-04-13 05:59:48 -0700</date>
            <delta_ts>2021-04-13 05:59:48 -0700</delta_ts>
            <desc>HTML example (alternative to CodePen)</desc>
            <filename>reported-bug.html</filename>
            <type>text/html</type>
            <size>2763</size>
            <attacher name="Vanita Barrett-Smith">vanita.barrett</attacher>
            
              <data encoding="base64">PCFET0NUWVBFIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KPGhlYWQ+CiAgPG1ldGEgY2hhcnNldD0i
dXRmLTgiPgogIDx0aXRsZT50ZXh0LWRlY29yYXRpb24tdGhpY2tuZXNzPC90aXRsZT4KCiAgPHN0
eWxlPgogICAgLmxpbms6bGluaywKICAgIC5saW5rOnZpc2l0ZWQgewogICAgICB0ZXh0LWRlY29y
YXRpb246IHVuZGVybGluZTsKICAgICAgdGV4dC1kZWNvcmF0aW9uLXRoaWNrbmVzczogMXB4Owog
ICAgfQoKICAgIC5saW5rOmhvdmVyIHsKICAgICAgdGV4dC1kZWNvcmF0aW9uLXRoaWNrbmVzczog
M3B4OwogICAgfQoKICAgIC5saW5rLWNvbG9yLWNoYW5nZTpob3ZlciB7CiAgICAgIGNvbG9yOiBy
ZWQ7CiAgICB9CiAgPC9zdHlsZT4KPC9oZWFkPgo8Ym9keT4KICA8ZGl2IHN0eWxlPSJmb250LXNp
emU6IDE0cHg7Ij4KICAgIDxhIGNsYXNzPSJsaW5rIiBocmVmPSIjIj4xNHB4IGxpbms8L2E+IC8K
ICAgIDxhIGNsYXNzPSJsaW5rIGxpbmstY29sb3ItY2hhbmdlIiBocmVmPSIjIj53aXRoIGNvbG91
ciBjaGFuZ2U8L2E+CiAgPC9kaXY+CgogIDxkaXYgc3R5bGU9ImZvbnQtc2l6ZTogMTVweDsiPgog
ICAgPGEgY2xhc3M9ImxpbmsiIGhyZWY9IiMiPjE1cHggbGluazwvYT4gLwogICAgPGEgY2xhc3M9
ImxpbmsgbGluay1jb2xvci1jaGFuZ2UiIGhyZWY9IiMiPndpdGggY29sb3VyIGNoYW5nZTwvYT4K
ICA8L2Rpdj4KCiAgPGRpdiBzdHlsZT0iZm9udC1zaXplOiAxNnB4OyI+CiAgICA8YSBjbGFzcz0i
bGluayIgaHJlZj0iIyI+MTZweCBsaW5rPC9hPiAvCiAgICA8YSBjbGFzcz0ibGluayBsaW5rLWNv
bG9yLWNoYW5nZSIgaHJlZj0iIyI+d2l0aCBjb2xvdXIgY2hhbmdlPC9hPgogIDwvZGl2PgoKICA8
ZGl2IHN0eWxlPSJmb250LXNpemU6IDE3cHg7Ij4KICAgIDxhIGNsYXNzPSJsaW5rIiBocmVmPSIj
Ij4xN3B4IGxpbms8L2E+IC8KICAgIDxhIGNsYXNzPSJsaW5rIGxpbmstY29sb3ItY2hhbmdlIiBo
cmVmPSIjIj53aXRoIGNvbG91ciBjaGFuZ2U8L2E+CiAgPC9kaXY+CgogIDxkaXYgc3R5bGU9ImZv
bnQtc2l6ZTogMThweDsiPgogICAgPGEgY2xhc3M9ImxpbmsiIGhyZWY9IiMiPjE4cHggbGluazwv
YT4gLwogICAgPGEgY2xhc3M9ImxpbmsgbGluay1jb2xvci1jaGFuZ2UiIGhyZWY9IiMiPndpdGgg
Y29sb3VyIGNoYW5nZTwvYT4KICA8L2Rpdj4KCiAgPGRpdiBzdHlsZT0iZm9udC1zaXplOiAxOXB4
OyI+CiAgICA8YSBjbGFzcz0ibGluayIgaHJlZj0iIyI+MTlweCBsaW5rPC9hPiAvCiAgICA8YSBj
bGFzcz0ibGluayBsaW5rLWNvbG9yLWNoYW5nZSIgaHJlZj0iIyI+d2l0aCBjb2xvdXIgY2hhbmdl
PC9hPgogIDwvZGl2PgoKICA8ZGl2IHN0eWxlPSJmb250LXNpemU6IDIwcHg7Ij4KICAgIDxhIGNs
YXNzPSJsaW5rIiBocmVmPSIjIj4yMHB4IGxpbms8L2E+IC8KICAgIDxhIGNsYXNzPSJsaW5rIGxp
bmstY29sb3ItY2hhbmdlIiBocmVmPSIjIj53aXRoIGNvbG91ciBjaGFuZ2U8L2E+CiAgPC9kaXY+
CgogIDxkaXYgc3R5bGU9ImZvbnQtc2l6ZTogMjFweDsiPgogICAgPGEgY2xhc3M9ImxpbmsiIGhy
ZWY9IiMiPjIxcHggbGluazwvYT4gLwogICAgPGEgY2xhc3M9ImxpbmsgbGluay1jb2xvci1jaGFu
Z2UiIGhyZWY9IiMiPndpdGggY29sb3VyIGNoYW5nZTwvYT4KICA8L2Rpdj4KCiAgPGRpdiBzdHls
ZT0iZm9udC1zaXplOiAyMnB4OyI+CiAgICA8YSBjbGFzcz0ibGluayIgaHJlZj0iIyI+MjJweCBs
aW5rPC9hPiAvCiAgICA8YSBjbGFzcz0ibGluayBsaW5rLWNvbG9yLWNoYW5nZSIgaHJlZj0iIyI+
d2l0aCBjb2xvdXIgY2hhbmdlPC9hPgogIDwvZGl2PgoKICA8ZGl2IHN0eWxlPSJmb250LXNpemU6
IDIzcHg7Ij4KICAgIDxhIGNsYXNzPSJsaW5rIiBocmVmPSIjIj4yM3B4IGxpbms8L2E+IC8KICAg
IDxhIGNsYXNzPSJsaW5rIGxpbmstY29sb3ItY2hhbmdlIiBocmVmPSIjIj53aXRoIGNvbG91ciBj
aGFuZ2U8L2E+CiAgPC9kaXY+CgogIDxkaXYgc3R5bGU9ImZvbnQtc2l6ZTogMjRweDsiPgogICAg
PGEgY2xhc3M9ImxpbmsiIGhyZWY9IiMiPjI0cHggbGluazwvYT4gLwogICAgPGEgY2xhc3M9Imxp
bmsgbGluay1jb2xvci1jaGFuZ2UiIGhyZWY9IiMiPndpdGggY29sb3VyIGNoYW5nZTwvYT4KICA8
L2Rpdj4KCiAgPGRpdiBzdHlsZT0iZm9udC1zaXplOiAyNXB4OyI+CiAgICA8YSBjbGFzcz0ibGlu
ayIgaHJlZj0iIyI+MjVweCBsaW5rPC9hPiAvCiAgICA8YSBjbGFzcz0ibGluayBsaW5rLWNvbG9y
LWNoYW5nZSIgaHJlZj0iIyI+d2l0aCBjb2xvdXIgY2hhbmdlPC9hPgogIDwvZGl2PgoKICA8ZGl2
IHN0eWxlPSJmb250LXNpemU6IDI2cHg7Ij4KICAgIDxhIGNsYXNzPSJsaW5rIiBocmVmPSIjIj4y
NnB4IGxpbms8L2E+IC8KICAgIDxhIGNsYXNzPSJsaW5rIGxpbmstY29sb3ItY2hhbmdlIiBocmVm
PSIjIj53aXRoIGNvbG91ciBjaGFuZ2U8L2E+CiAgPC9kaXY+CgogIDxkaXYgc3R5bGU9ImZvbnQt
c2l6ZTogMjdweDsiPgogICAgPGEgY2xhc3M9ImxpbmsiIGhyZWY9IiMiPjI3cHggbGluazwvYT4g
LwogICAgPGEgY2xhc3M9ImxpbmsgbGluay1jb2xvci1jaGFuZ2UiIGhyZWY9IiMiPndpdGggY29s
b3VyIGNoYW5nZTwvYT4KICA8L2Rpdj4KCiAgPGRpdiBzdHlsZT0iZm9udC1zaXplOiAyOHB4OyI+
CiAgICA8YSBjbGFzcz0ibGluayIgaHJlZj0iIyI+MjhweCBsaW5rPC9hPiAvCiAgICA8YSBjbGFz
cz0ibGluayBsaW5rLWNvbG9yLWNoYW5nZSIgaHJlZj0iIyI+d2l0aCBjb2xvdXIgY2hhbmdlPC9h
PgogIDwvZGl2Pgo8L2JvZHk+CjwvaHRtbD4K
</data>

          </attachment>
      

    </bug>

</bugzilla>