224464 2021-04-12 17:19:09 -0700 Remove SharedBuffer's equality operators with Ref<SharedBuffer> 2021-04-13 12:52:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez jer.noble webkit-bug-importer oldest_to_newest 1749464 0 achristensen 2021-04-12 17:19:09 -0700 Remove SharedBuffer's equality operators with Ref<SharedBuffer> 1749465 1 425814 achristensen 2021-04-12 17:21:26 -0700 Created attachment 425814 Patch 1749480 2 425814 cdumez 2021-04-12 17:43:58 -0700 Comment on attachment 425814 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425814&action=review > Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:588 > + if (anyOf(sessionKeys, [&](const Ref<SharedBuffer>& sessionKey) { The new code looks worse? What's wrong with comparing a Ref<> with a C++ reference? I can compare a RefPtr<> with a raw pointer already so why is this different? 1749796 3 achristensen 2021-04-13 12:31:19 -0700 That's exactly what I'm trying to do in bug 224412 but can't until I do this. This compares a Ref<SharedBuffer> and a SharedBuffer& by calling SharedBuffer::operator== which compares the bytes contained in the SharedBuffer's segments. What I want is a pointer comparison, which is why I have to make these two call sites look worse before introducing a generic Ref equality operator without breaking them. 1749797 4 425814 cdumez 2021-04-13 12:33:17 -0700 Comment on attachment 425814 Patch Oh, I missed that. Yes, I agree then. 1749811 5 ews-feeder 2021-04-13 12:51:33 -0700 Committed r275900 (236465@main): <https://commits.webkit.org/236465@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425814. 1749812 6 webkit-bug-importer 2021-04-13 12:52:14 -0700 <rdar://problem/76605767> 425814 2021-04-12 17:21:26 -0700 2021-04-13 12:51:34 -0700 Patch bug-224464-20210412172125.patch text/plain 5754 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1ODMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTU2ZjRlZWFlZTI5ZWIw ZTdiNmVhOGU0ODNmY2JlNDdhNDRhMjdmZC4uMGZiNzdiOGNmMGVhYWM4YzI3ZWU5ZDdhM2Y3OTcy YmEzZTczM2FkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA0LTEyICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3Zl IFNoYXJlZEJ1ZmZlcidzIGVxdWFsaXR5IG9wZXJhdG9ycyB3aXRoIFJlZjxTaGFyZWRCdWZmZXI+ CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ0NjQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBjaGFu Z2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgSSdtIGRvaW5nIHRoaXMgdG8gbWFrZSBhIFJlZiBj b21wYXJhdG9yIGZvciBhbGwgUmVmcyB0byByZW1vdmUgYW5vdGhlciByZWFzb24gd2UgdXNlIFJl ZlB0ciBpbnN0ZWFkIG9mIFJlZiwgZXZlbiB3aGVuIHRoZXkncmUgYWxsIG5vbi1udWxsLgorICAg ICAgICBTZWUgYnVnIDIyNDQxMgorCisgICAgICAgICogcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmg6 CisgICAgICAgIChXZWJDb3JlOjpvcGVyYXRvcj09KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNv cmU6Om9wZXJhdG9yIT0pOiBEZWxldGVkLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2 Zm91bmRhdGlvbi9vYmpjL0NETUluc3RhbmNlRmFpclBsYXlTdHJlYW1pbmdBVkZPYmpDLm1tOgor ICAgICAgICAoV2ViQ29yZTo6Q0RNSW5zdGFuY2VGYWlyUGxheVN0cmVhbWluZ0FWRk9iakM6OnNl c3Npb25Gb3JLZXlJRHMgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6Q0RNSW5zdGFuY2VTZXNz aW9uRmFpclBsYXlTdHJlYW1pbmdBVkZPYmpDOjp1cGRhdGVMaWNlbnNlKToKKwogMjAyMS0wNC0x MiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBv cnQgZm9yIFJUQ0VuY29kZWRGcmFtZSBtZXRhZGF0YQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFy ZWRCdWZmZXIuaAppbmRleCA1ZWU2ZDk4ZWZkNDc3NzUzMGU2MGViNjA4YzBiOWFhNmU3NTRlY2Iz Li42OGJkZTZjNjhkZjAxMjIzNzA5OTM0NDFlMjEzZTQ2MzFjMzA3N2Q1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIuaApAQCAtMjMwLDE2ICsyMzAsNiBAQCBwcml2YXRlOgog I2VuZGlmCiB9OwogCi1pbmxpbmUgYm9vbCBvcGVyYXRvcj09KGNvbnN0IFJlZjxTaGFyZWRCdWZm ZXI+JiBsZWZ0LCBjb25zdCBTaGFyZWRCdWZmZXImIHJpZ2h0KQotewotICAgIHJldHVybiBsZWZ0 LmdldCgpID09IHJpZ2h0OwotfQotCi1pbmxpbmUgYm9vbCBvcGVyYXRvciE9KGNvbnN0IFJlZjxT aGFyZWRCdWZmZXI+JiBsZWZ0LCBjb25zdCBTaGFyZWRCdWZmZXImIHJpZ2h0KQotewotICAgIHJl dHVybiBsZWZ0LmdldCgpICE9IHJpZ2h0OwotfQotCiBjbGFzcyBXRUJDT1JFX0VYUE9SVCBTaGFy ZWRCdWZmZXJEYXRhVmlldyB7CiBwdWJsaWM6CiAgICAgU2hhcmVkQnVmZmVyRGF0YVZpZXcoUmVm PFNoYXJlZEJ1ZmZlcjo6RGF0YVNlZ21lbnQ+JiYsIHNpemVfdCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9DRE1JbnN0YW5j ZUZhaXJQbGF5U3RyZWFtaW5nQVZGT2JqQy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL0NETUluc3RhbmNlRmFpclBsYXlTdHJlYW1pbmdBVkZP YmpDLm1tCmluZGV4IDkwZjQzMjY3OTliZGEyMmYwNGExOTgxZmE5YjE0MTEyZjRiYTMxOGEuLjI4 NDQ3YmQwYzg0M2NkYTQ0OWY0YTQyZTRhYWFiNDkxZWVmYTc2ZTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL0NETUluc3RhbmNl RmFpclBsYXlTdHJlYW1pbmdBVkZPYmpDLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL0NETUluc3RhbmNlRmFpclBsYXlTdHJlYW1pbmdB VkZPYmpDLm1tCkBAIC01ODUsMTAgKzU4NSwxMiBAQCBDRE1JbnN0YW5jZVNlc3Npb25GYWlyUGxh eVN0cmVhbWluZ0FWRk9iakMqIENETUluc3RhbmNlRmFpclBsYXlTdHJlYW1pbmdBVkZPYmpDOgog ICAgICAgICAgICAgY29udGludWU7CiAKICAgICAgICAgYXV0byBzZXNzaW9uS2V5cyA9IHNlc3Np b25JbnRlcmZhY2UtPmtleUlEcygpOwotICAgICAgICBpZiAoYW55T2Yoc2Vzc2lvbktleXMsIFsm XShhdXRvJiBzZXNzaW9uS2V5KSB7Ci0gICAgICAgICAgICByZXR1cm4ga2V5SURzLmNvbnRhaW5z KHNlc3Npb25LZXkpOworICAgICAgICBpZiAoYW55T2Yoc2Vzc2lvbktleXMsIFsmXShjb25zdCBS ZWY8U2hhcmVkQnVmZmVyPiYgc2Vzc2lvbktleSkgeworICAgICAgICAgICAgcmV0dXJuIGtleUlE cy5maW5kTWF0Y2hpbmcoWyZdKGNvbnN0IFJlZjxTaGFyZWRCdWZmZXI+JiBrZXlJRCkgeworICAg ICAgICAgICAgICAgIHJldHVybiBrZXlJRC5nZXQoKSA9PSBzZXNzaW9uS2V5LmdldCgpOworICAg ICAgICAgICAgfSkgIT0gbm90Rm91bmQ7CiAgICAgICAgIH0pKQotICAgICAgICAgICAgcmV0dXJu IHNlc3Npb25JbnRlcmZhY2UuZ2V0KCk7CisgICAgICAgIHJldHVybiBzZXNzaW9uSW50ZXJmYWNl LmdldCgpOwogICAgIH0KICAgICByZXR1cm4gbnVsbHB0cjsKIH0KQEAgLTg1NCw3ICs4NTYsOSBA QCB2b2lkIENETUluc3RhbmNlU2Vzc2lvbkZhaXJQbGF5U3RyZWFtaW5nQVZGT2JqQzo6dXBkYXRl TGljZW5zZShjb25zdCBTdHJpbmcmLCBMaQogICAgICAgICAgICAgYXV0byBrZXlJRCA9IFNoYXJl ZEJ1ZmZlcjo6Y3JlYXRlKFdURk1vdmUoa2V5SURWZWN0b3IpKTsKICAgICAgICAgICAgIGF1dG8g Zm91bmRJbmRleCA9IG1fY3VycmVudFJlcXVlc3QudmFsdWUoKS5yZXF1ZXN0cy5maW5kTWF0Y2hp bmcoWyZdIChhdXRvJiByZXF1ZXN0KSB7CiAgICAgICAgICAgICAgICAgYXV0byBrZXlJRHMgPSBr ZXlJRHNGb3JSZXF1ZXN0KHJlcXVlc3QuZ2V0KCkpOwotICAgICAgICAgICAgICAgIHJldHVybiBr ZXlJRHMuY29udGFpbnMoa2V5SUQpOworICAgICAgICAgICAgICAgIHJldHVybiBrZXlJRHMuZmlu ZE1hdGNoaW5nKFsmXShjb25zdCBSZWY8U2hhcmVkQnVmZmVyPiYgaWQpIHsKKyAgICAgICAgICAg ICAgICAgICAgcmV0dXJuIGlkLmdldCgpID09IGtleUlELmdldCgpOworICAgICAgICAgICAgICAg IH0pICE9IG5vdEZvdW5kOwogICAgICAgICAgICAgfSk7CiAgICAgICAgICAgICBpZiAoZm91bmRJ bmRleCA9PSBub3RGb3VuZCkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CmRpZmYgLS1n aXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzA0MDEwMTIyYjY2 YmE0YjYzMTU0MGQxMTJiNWI0ODRmODE3ZGMyYi4uNWUxZTA0ZDJkNDQyZDA4YWFlZjQyMmRkMDY2 MjYzNWEyYzNjYTlhZSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0No YW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA0LTEyICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIFNoYXJlZEJ1ZmZlcidz IGVxdWFsaXR5IG9wZXJhdG9ycyB3aXRoIFJlZjxTaGFyZWRCdWZmZXI+CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ0NjQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMv V2ViQ29yZS9TaGFyZWRCdWZmZXIuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVF9G KToKKwogMjAyMS0wNC0xMSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNzU4MDEuCmRpZmYgLS1naXQgYS9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvU2hhcmVkQnVmZmVyLmNwcCBiL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9TaGFyZWRCdWZmZXIuY3BwCmluZGV4IDc5YzVk ZTIyN2Q5YTE1MDM1ZWQ0MTIyNTJkNjQ0MWI5Y2NlMDFjMGMuLmJlYzdkMTE5ZWE4MTliMDE5OWE4 NzNmMDIwNzY2ZDQxOTIwMWFjMmEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViQ29yZS9TaGFyZWRCdWZmZXIuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViQ29yZS9TaGFyZWRCdWZmZXIuY3BwCkBAIC0yMDcsMTQgKzIwNywxNCBAQCBURVNUX0Yo U2hhcmVkQnVmZmVyVGVzdCwgaXNFcXVhbFRvKQogICAgICAgICByZXR1cm4gYnVmZmVyOwogICAg IH07CiAgICAgYXV0byBidWZmZXIxID0gbWFrZUJ1ZmZlcih7eydhJywgJ2InLCAnYycsICdkJ319 KTsKLSAgICBFWFBFQ1RfRVEoYnVmZmVyMSwgYnVmZmVyMSk7CisgICAgRVhQRUNUX0VRKGJ1ZmZl cjEuZ2V0KCksIGJ1ZmZlcjEuZ2V0KCkpOwogCiAgICAgYnVmZmVyMS0+YXBwZW5kKFZlY3Rvcjxj aGFyPih7J2EnLCAnYicsICdjJywgJ2QnfSkpOwotICAgIEVYUEVDVF9FUShidWZmZXIxLCBtYWtl QnVmZmVyKHt7J2EnLCAnYicsICdjJywgJ2QnLCAnYScsICdiJywgJ2MnLCAnZCd9fSkpOwotICAg IEVYUEVDVF9FUShtYWtlQnVmZmVyKHt7J2EnfSwgeydiJywgJ2MnfSwgeydkJ319KSwgbWFrZUJ1 ZmZlcih7eydhJywgJ2InfSwgeydjJywgJ2QnfX0pKTsKLSAgICBFWFBFQ1RfTkUobWFrZUJ1ZmZl cih7eydhJywgJ2InfX0pLCBtYWtlQnVmZmVyKHt7J2EnLCAnYicsICdjJ319KSk7Ci0gICAgRVhQ RUNUX05FKG1ha2VCdWZmZXIoe3snYScsICdiJ319KSwgbWFrZUJ1ZmZlcih7eydiJywgJ2MnfX0p KTsKLSAgICBFWFBFQ1RfTkUobWFrZUJ1ZmZlcih7eydhJ30sIHsnYid9fSksIG1ha2VCdWZmZXIo e3snYSd9LCB7J2EnfX0pKTsKKyAgICBFWFBFQ1RfRVEoYnVmZmVyMS5nZXQoKSwgbWFrZUJ1ZmZl cih7eydhJywgJ2InLCAnYycsICdkJywgJ2EnLCAnYicsICdjJywgJ2QnfX0pLmdldCgpKTsKKyAg ICBFWFBFQ1RfRVEobWFrZUJ1ZmZlcih7eydhJ30sIHsnYicsICdjJ30sIHsnZCd9fSkuZ2V0KCks IG1ha2VCdWZmZXIoe3snYScsICdiJ30sIHsnYycsICdkJ319KS5nZXQoKSk7CisgICAgRVhQRUNU X05FKG1ha2VCdWZmZXIoe3snYScsICdiJ319KS5nZXQoKSwgbWFrZUJ1ZmZlcih7eydhJywgJ2In LCAnYyd9fSkuZ2V0KCkpOworICAgIEVYUEVDVF9ORShtYWtlQnVmZmVyKHt7J2EnLCAnYid9fSku Z2V0KCksIG1ha2VCdWZmZXIoe3snYicsICdjJ319KS5nZXQoKSk7CisgICAgRVhQRUNUX05FKG1h a2VCdWZmZXIoe3snYSd9LCB7J2InfX0pLmdldCgpLCBtYWtlQnVmZmVyKHt7J2EnfSwgeydhJ319 KS5nZXQoKSk7CiB9CiAKIFRFU1RfRihTaGFyZWRCdWZmZXJUZXN0LCB0b0hleFN0cmluZykK