<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>224457</bug_id>
          
          <creation_ts>2021-04-12 15:56:12 -0700</creation_ts>
          <short_desc>Fix some issues hidden by unified build</short_desc>
          <delta_ts>2021-04-12 19:07:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Peng Liu">peng.liu6</reporter>
          <assigned_to name="Peng Liu">peng.liu6</assigned_to>
          <cc>eric.carlson</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>jer.noble</cc>
    
    <cc>philipj</cc>
    
    <cc>sergio</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1749420</commentid>
    <comment_count>0</comment_count>
    <who name="Peng Liu">peng.liu6</who>
    <bug_when>2021-04-12 15:56:12 -0700</bug_when>
    <thetext>Fix some issues hidden by unified build</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1749423</commentid>
    <comment_count>1</comment_count>
      <attachid>425801</attachid>
    <who name="Peng Liu">peng.liu6</who>
    <bug_when>2021-04-12 16:02:05 -0700</bug_when>
    <thetext>Created attachment 425801
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1749434</commentid>
    <comment_count>2</comment_count>
      <attachid>425801</attachid>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2021-04-12 16:20:39 -0700</bug_when>
    <thetext>Comment on attachment 425801
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425801&amp;action=review

&gt; Source/WebKitLegacy/mac/DOM/DOMTokenList.mm:-26
&gt; -

This is unrelated.

&gt; Source/WebKitLegacy/mac/Plugins/WebPluginController.mm:-29
&gt; -

Ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1749443</commentid>
    <comment_count>3</comment_count>
      <attachid>425801</attachid>
    <who name="Peng Liu">peng.liu6</who>
    <bug_when>2021-04-12 16:33:42 -0700</bug_when>
    <thetext>Comment on attachment 425801
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425801&amp;action=review

&gt;&gt; Source/WebKitLegacy/mac/DOM/DOMTokenList.mm:-26
&gt;&gt; -
&gt; 
&gt; This is unrelated.

Yes, just removed an empty line.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1749504</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-04-12 19:06:37 -0700</bug_when>
    <thetext>Committed r275857 (236422@main): &lt;https://commits.webkit.org/236422@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425801.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1749505</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-04-12 19:07:13 -0700</bug_when>
    <thetext>&lt;rdar://problem/76569928&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>425801</attachid>
            <date>2021-04-12 16:02:05 -0700</date>
            <delta_ts>2021-04-12 19:06:37 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-224457-20210412160204.patch</filename>
            <type>text/plain</type>
            <size>5654</size>
            <attacher name="Peng Liu">peng.liu6</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1ODA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn
YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k
ZXggZTU3Y2NiMmMwZmFjZjk3NDc4YzI5Mzg0NGU3YmQwYzRiMDgxNTcxMy4uMTUwOWYxMGJlZjli
YTljYTU0YjNiZDI3NTY0NDZjOTBjOWFmYzM0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl
Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA0LTEyICBQZW5nIExpdSAgPHBlbmcubGl1NkBhcHBs
ZS5jb20+CisKKyAgICAgICAgRml4IHNvbWUgaXNzdWVzIGhpZGRlbiBieSB1bmlmaWVkIGJ1aWxk
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ0NTcK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb21lIHNt
YWxsIGZpeGVzIGFuZCBjbGVhbi11cC4gVGhlIGlzc3VlcyBhcmUgaGlkZGVuIGJ5IHRoZSB1bmlm
aWVkIGJ1aWxkIG1lY2hhbmlzbQorICAgICAgICBhbmQgd2VyZSBmb3VuZCBpbiBhIGxvY2FsIGJ1
aWxkLgorCisgICAgICAgICogRE9NL0RPTVRva2VuTGlzdC5tbToKKyAgICAgICAgKiBQbHVnaW5z
L1dlYlBsdWdpbkNvbnRyb2xsZXIubW06CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViRnJh
bWVMb2FkZXJDbGllbnQuaDoKKyAgICAgICAgKiBXZWJWaWV3L1dlYkRhdGFTb3VyY2UubW06Cisg
ICAgICAgICogV2ViVmlldy9XZWJGcmFtZVZpZXcubW06CisgICAgICAgICogV2ViVmlldy9XZWJI
VE1MVmlld0ludGVybmFsLmg6CisgICAgICAgICogV2ViVmlldy9XZWJJbW1lZGlhdGVBY3Rpb25D
b250cm9sbGVyLm1tOgorICAgICAgICAqIFdlYlZpZXcvV2ViUERGVmlldy5tbToKKwogMjAyMS0w
NC0wMiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIEhhc2hl
ciBtb3JlLCByZW1vdmUgSW50ZWdlckhhc2hlciwgZml4IGhhc2hpbmctcmVsYXRlZCBtaXN0YWtl
cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvRE9NL0RPTVRva2VuTGlzdC5t
bSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0RPTS9ET01Ub2tlbkxpc3QubW0KaW5kZXggMWQx
MWVlNGNmOTFmMTQ3OTQ0NzdjMjUyNmExMjNlYmM1YzZjNTJiMC4uYzBiYTc0ZjdlODZhNGYzYzA2
NzA5MDdkNDQ2Y2JiMmExMjA1NTE0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9t
YWMvRE9NL0RPTVRva2VuTGlzdC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9ET00v
RE9NVG9rZW5MaXN0Lm1tCkBAIC0yMyw3ICsyMyw2IEBACiAgKiBPRiBUSElTIFNPRlRXQVJFLCBF
VkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAK
LQogI2ltcG9ydCAiRE9NVG9rZW5MaXN0SW50ZXJuYWwuaCIKIAogI2ltcG9ydCAiRE9NSW50ZXJu
YWwuaCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1BsdWdpbnMvV2ViUGx1
Z2luQ29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1BsdWdpbnMvV2ViUGx1
Z2luQ29udHJvbGxlci5tbQppbmRleCBhMzc0ZWRhYWE3ZWMzMDM2MzQ5ZmQ3MmQ1N2I2MWRlNmNl
N2U0NGNjLi5iOGU4ODZiYWQ0MmM2NmFhODA5M2ZlNmQzYzY4Zjk4MTFkNTQ2ZTNhIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9QbHVnaW5zL1dlYlBsdWdpbkNvbnRyb2xsZXIu
bW0KKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvUGx1Z2lucy9XZWJQbHVnaW5Db250cm9s
bGVyLm1tCkBAIC0yNiw3ICsyNiw2IEBACiAgKiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklT
RUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKLQogI2ltcG9ydCAi
V2ViUGx1Z2luQ29udHJvbGxlci5oIgogCiAjaW1wb3J0ICJET01Ob2RlSW50ZXJuYWwuaCIKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1l
TG9hZGVyQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJDb3JlU3VwcG9ydC9X
ZWJGcmFtZUxvYWRlckNsaWVudC5oCmluZGV4IGUwNGQzZDlhMWViODM4MDFjOTIxYzYwODNlZTJi
YzNlZjNkZGVlOGQuLjYzNTFjMmVhMDY2NTczOWNkNzFlMGM0N2UzN2E0N2FkMDYxMTQzNzggMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1l
TG9hZGVyQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViQ29yZVN1cHBv
cnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuaApAQCAtMzQsNiArMzQsNyBAQAogI2ltcG9ydCA8d3Rm
L1dlYWtPYmpDUHRyLmg+CiAjaW1wb3J0IDx3dGYvV2Vha1B0ci5oPgogCitAY2xhc3MgV2ViRGF0
YVNvdXJjZTsKIEBjbGFzcyBXZWJEb3dubG9hZDsKIEBjbGFzcyBXZWJGcmFtZTsKIEBjbGFzcyBX
ZWJGcmFtZVBvbGljeUxpc3RlbmVyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9t
YWMvV2ViVmlldy9XZWJEYXRhU291cmNlLm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2Vi
Vmlldy9XZWJEYXRhU291cmNlLm1tCmluZGV4IDRkZjU0ZDdkNjk3OTlhOTY0NThmMTIyNDMwYWI1
MmU4YjIxMTJhOTkuLjI4OWMwMDI5YmY5MTM0MThkMGIyOTlmOTBhNGQ5NzExM2JjNThhNGIgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViRGF0YVNvdXJjZS5t
bQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYkRhdGFTb3VyY2UubW0K
QEAgLTY3LDYgKzY3LDcgQEAKICNpbXBvcnQgPHd0Zi9SZXRhaW5QdHIuaD4KICNpbXBvcnQgPHd0
Zi9SdW5Mb29wLmg+CiAjaW1wb3J0IDx3dGYvVVJMLmg+CisjaW1wb3J0IDx3dGYvY29jb2EvVmVj
dG9yQ29jb2EuaD4KIAogI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCiAjaW1wb3J0ICJXZWJQREZW
aWV3SU9TLmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dl
YkZyYW1lVmlldy5tbSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViRnJhbWVW
aWV3Lm1tCmluZGV4IGUzZThjN2JhZDAzNTg5OTYzMTJhOTFlZmRiNGVmYzc2MGVlMmYzOGIuLmU5
YTdiZTY0OTk0ZjI5MWJlMTEzOWY0ZWJmY2Q0MjYwYTMyZmEzYTMgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViRnJhbWVWaWV3Lm1tCisrKyBiL1NvdXJjZS9X
ZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViRnJhbWVWaWV3Lm1tCkBAIC0zNSw2ICszNSw3IEBA
CiAjaW1wb3J0ICJXZWJEeW5hbWljU2Nyb2xsQmFyc1ZpZXdJbnRlcm5hbC5oIgogI2ltcG9ydCAi
V2ViRnJhbWUuaCIKICNpbXBvcnQgIldlYkZyYW1lSW50ZXJuYWwuaCIKKyNpbXBvcnQgIldlYkZy
YW1lTG9hZGVyQ2xpZW50LmgiCiAjaW1wb3J0ICJXZWJGcmFtZVZpZXdJbnRlcm5hbC5oIgogI2lt
cG9ydCAiV2ViRnJhbWVWaWV3UHJpdmF0ZS5oIgogI2ltcG9ydCAiV2ViSGlzdG9yeUl0ZW1JbnRl
cm5hbC5oIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJI
VE1MVmlld0ludGVybmFsLmggYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYkhU
TUxWaWV3SW50ZXJuYWwuaAppbmRleCA2ZjVlNTdkM2ZjZTczNGM1NmY2MmNiM2U3MjNjZjk0NWU1
MTNiYzBmLi5hYzE4NWE3NzE2YzM0MmIwMTA5NTAzYjY4MDUwMGEyNmNlNTRlMWYyIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3SW50ZXJuYWwu
aAorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3SW50ZXJu
YWwuaApAQCAtMjksNiArMjksNyBAQAogLy8gVGhpbmdzIGludGVybmFsIHRvIHRoZSBXZWJLaXQg
ZnJhbWV3b3JrOyBub3QgU1BJLgogCiAjaW1wb3J0ICJXZWJIVE1MVmlld1ByaXZhdGUuaCIKKyNp
bXBvcnQgPHd0Zi9OYWtlZFB0ci5oPgogCiBAY2xhc3MgQ0FMYXllcjsKIEBjbGFzcyBXZWJGcmFt
ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViSW1tZWRp
YXRlQWN0aW9uQ29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcv
V2ViSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlci5tbQppbmRleCBmOWE5ZTQ2YzkzNTg2YTg0YTZl
MTc0MjlmNGI1NDcwY2I5ZWRlNmNlLi4wYTAxMjJjMjM0MmUxYjczMzM3YzFjOGNkYTg4ODY3NTc4
MzFhNmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYklt
bWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMv
V2ViVmlldy9XZWJJbW1lZGlhdGVBY3Rpb25Db250cm9sbGVyLm1tCkBAIC00OCwxMCArNDgsMTIg
QEAKICNpbXBvcnQgPFdlYkNvcmUvSFRNTENvbnZlcnRlci5oPgogI2ltcG9ydCA8V2ViQ29yZS9O
b2RlUmVuZGVyU3R5bGUuaD4KICNpbXBvcnQgPFdlYkNvcmUvUGFnZS5oPgorI2ltcG9ydCA8V2Vi
Q29yZS9SYW5nZS5oPgogI2ltcG9ydCA8V2ViQ29yZS9SZW5kZXJFbGVtZW50Lmg+CiAjaW1wb3J0
IDxXZWJDb3JlL1JlbmRlck9iamVjdC5oPgogI2ltcG9ydCA8V2ViQ29yZS9SdW50aW1lQXBwbGlj
YXRpb25DaGVja3MuaD4KICNpbXBvcnQgPFdlYkNvcmUvVGV4dEluZGljYXRvci5oPgorI2ltcG9y
dCA8V2ViQ29yZS9UZXh0SXRlcmF0b3IuaD4KICNpbXBvcnQgPG9iamMvb2JqYy1jbGFzcy5oPgog
I2ltcG9ydCA8b2JqYy9vYmpjLmg+CiAjaW1wb3J0IDxwYWwvc3BpL21hYy9EYXRhRGV0ZWN0b3Jz
U1BJLmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlBE
RlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlBERlZpZXcubW0K
aW5kZXggZjczYWU5YTBkMDA2ZDIwNmNjMTZkMjg5YzUwZTdlMTlmYTA0YmJiNy4uZGUxMmM3YWQ2
ZDhkNTk3ZjM3MTBlYzEyYzUyYTZkMmMzOTU0OTY3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp
dExlZ2FjeS9tYWMvV2ViVmlldy9XZWJQREZWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdh
Y3kvbWFjL1dlYlZpZXcvV2ViUERGVmlldy5tbQpAQCAtNjEsOCArNjEsMTAgQEAKICNpbXBvcnQg
PFdlYkNvcmUvTGVnYWN5TlNQYXN0ZWJvYXJkVHlwZXMuaD4KICNpbXBvcnQgPFdlYkNvcmUvTW91
c2VFdmVudC5oPgogI2ltcG9ydCA8V2ViQ29yZS9QbGF0Zm9ybUV2ZW50RmFjdG9yeU1hYy5oPgor
I2ltcG9ydCA8V2ViQ29yZS9SYW5nZS5oPgogI2ltcG9ydCA8V2ViQ29yZS9SZWZlcnJlclBvbGlj
eS5oPgogI2ltcG9ydCA8V2ViQ29yZS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaD4KKyNpbXBv
cnQgPFdlYkNvcmUvU2ltcGxlUmFuZ2UuaD4KICNpbXBvcnQgPFdlYkNvcmUvV2ViTlNBdHRyaWJ1
dGVkU3RyaW5nRXh0cmFzLmg+CiAjaW1wb3J0IDx3dGYvQXNzZXJ0aW9ucy5oPgogI2ltcG9ydCA8
d3RmL1VSTC5oPgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>