224402 2021-04-09 18:06:48 -0700 Force the WebAuthn compatible mode to always show UI 2021-04-14 14:39:24 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jiewen_tan jiewen_tan bfulgham darin garrett_davidson jiewen_tan webkit-bug-importer oldest_to_newest 1748934 0 jiewen_tan 2021-04-09 18:06:48 -0700 Force the WebAuthn compatible mode to always show UI. 1748935 1 jiewen_tan 2021-04-09 18:07:03 -0700 rdar://75757362 1748937 2 425672 jiewen_tan 2021-04-09 18:09:42 -0700 Created attachment 425672 Patch 1749235 3 garrett_davidson 2021-04-12 09:01:05 -0700 Can you update the commit message with how you tested this? 1749437 4 425672 bfulgham 2021-04-12 16:24:03 -0700 Comment on attachment 425672 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425672&action=review r=me > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:102 > +#if USE(APPLE_INTERNAL_SDK) Does this need a macOS check? or is it correct for iOS, too? 1749438 5 425672 jiewen_tan 2021-04-12 16:26:20 -0700 Comment on attachment 425672 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425672&action=review Thanks Brent for r+ this patch. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:102 >> +#if USE(APPLE_INTERNAL_SDK) > > Does this need a macOS check? or is it correct for iOS, too? This method is only used by the compatible mode which is now only on macOS. 1749451 6 ews-feeder 2021-04-12 16:54:07 -0700 Committed r275847 (236412@main): <https://commits.webkit.org/236412@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425672. 1749808 7 425672 darin 2021-04-13 12:46:05 -0700 Comment on attachment 425672 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425672&action=review > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:103 > + // A quirk to force the compatible mode to always show UI. This comment should say *why* we are doing this, not just say that "it’s a quirk". 1750275 8 425672 jiewen_tan 2021-04-14 12:24:25 -0700 Comment on attachment 425672 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425672&action=review >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:103 >> + // A quirk to force the compatible mode to always show UI. > > This comment should say *why* we are doing this, not just say that "it’s a quirk". I was trying to write a why here. But then it's hard to not reveal the feature and explain it clearly. Let me try rewrite it with a vague why. 1750344 9 jiewen_tan 2021-04-14 14:39:24 -0700 Land a comment fix per Darin's comment. Committed r275966: <https://commits.webkit.org/r275966> Committed r275966 (236519@main): <https://commits.webkit.org/236519@main> 425672 2021-04-09 18:09:42 -0700 2021-04-12 16:54:07 -0700 Patch bug-224402-20210409180942.patch text/plain 1685 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1Njc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJiZGNhZGM4ODUyN2Q5NjM0 MDAyYTcwMWMxNDhmZTNlZjBkNzJkOGIuLjMzMTZiMGQ2NTg4MzY5NDNhMGU1ZTJkYzNmYzhiMTUy ODIyZmIwZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDQtMDkgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBGb3JjZSB0aGUgV2ViQXV0aG4g Y29tcGF0aWJsZSBtb2RlIHRvIGFsd2F5cyBzaG93IFVJCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ0MDIKKyAgICAgICAgPHJkYXI6Ly83NTc1NzM2 Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3Zl cmVkIGJ5IG1hbnVhbCB0ZXN0cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJBdXRoZW50aWNh dGlvbi9Db2NvYS9Mb2NhbENvbm5lY3Rpb24ubW06CisgICAgICAgIChXZWJLaXQ6OkxvY2FsQ29u bmVjdGlvbjo6dmVyaWZ5VXNlcik6CisKIDIwMjEtMDQtMDggIERlYW4gSmFja3NvbiAgPGRpbm9A YXBwbGUuY29tPgogCiAgICAgICAgIFNwZWNpZnkgU3dpZnQgdmVyc2lvbiBpbiBjb25maWd1cmF0 aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlv bi9Db2NvYS9Mb2NhbENvbm5lY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJB dXRoZW50aWNhdGlvbi9Db2NvYS9Mb2NhbENvbm5lY3Rpb24ubW0KaW5kZXggYjIyMThiMjg5Mzhh MTFkZGM5MzUyNmFmZTlkMGI4NjBkMzRiZDg2Yi4uY2ZhMTYwN2Y5YjAzMWYyNGY2YmU3MzI2NzY0 MDczOTA1OGJiOTg3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0 aGVudGljYXRpb24vQ29jb2EvTG9jYWxDb25uZWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0xvY2FsQ29ubmVjdGlvbi5tbQpAQCAt OTksNiArOTksMTQgQEAgdm9pZCBMb2NhbENvbm5lY3Rpb246OnZlcmlmeVVzZXIoY29uc3QgU3Ry aW5nJiBycElkLCBDbGllbnREYXRhVHlwZSB0eXBlLCBTZWNBY2MKICAgICAgICAgfSk7CiAgICAg fSk7CiAKKyNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQorICAgIC8vIEEgcXVpcmsgdG8gZm9y Y2UgdGhlIGNvbXBhdGlibGUgbW9kZSB0byBhbHdheXMgc2hvdyBVSS4KKyAgICBpZiAoc2hvdWxk VXNlQWx0ZXJuYXRlQXR0cmlidXRlcygpKSB7CisgICAgICAgIFttX2NvbnRleHQgZXZhbHVhdGVQ b2xpY3k6TEFQb2xpY3lEZXZpY2VPd25lckF1dGhlbnRpY2F0aW9uIG9wdGlvbnM6b3B0aW9ucy5n ZXQoKSByZXBseTpyZXBseS5nZXQoKV07CisgICAgICAgIHJldHVybjsKKyAgICB9CisjZW5kaWYK KwogICAgIFttX2NvbnRleHQgZXZhbHVhdGVBY2Nlc3NDb250cm9sOmFjY2Vzc0NvbnRyb2wgb3Bl cmF0aW9uOkxBQWNjZXNzQ29udHJvbE9wZXJhdGlvblVzZUtleVNpZ24gb3B0aW9uczpvcHRpb25z LmdldCgpIHJlcGx5OnJlcGx5LmdldCgpXTsKIH0KIAo=