224395 2021-04-09 15:45:11 -0700 [iOS WK2] CADisplayLink in the web process is used unintentionally 2022-03-21 12:09:50 -0700 1 1 1 Unclassified WebKit WebKit Misc. Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=234923 InRadar P2 Normal --- 1 simon.fraser simon.fraser aakash_jain graouts ryanhaddad sabouhallawa simon.fraser thorton webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1748893 0 simon.fraser 2021-04-09 15:45:11 -0700 When we try to make the first DisplayLink in iOS WK2, we intend to get one via the factory from the DrawingArea, but at this point m_page.drawingArea() is null (we're inside the RemoteLayerTreeDrawingArea ctor) so we end up falling back to DisplayRefreshMonitorIOS which is supposed to only be used for WebKit1. * frame #0: 0x0000000289db17b0 WebKit`WebKit::WebChromeClient::displayRefreshMonitorFactory(this=0x00007fa097632e50) const at WebChromeClient.cpp:918:12 frame #1: 0x00000002ad29c4e3 WebCore`WebCore::Page::windowScreenDidChange(this=0x00007fa08780fa00, displayID=4294967273, nominalFramesPerSecond=Optional<unsigned int> @ 0x00007ffee03807f8) at Page.cpp:1188:153 frame #2: 0x00000002ad1a91f0 WebCore`WebCore::Chrome::windowScreenDidChange(this=0x00007fa0976320c0, displayID=4294967273, nominalFrameInterval=<unavailable>) at Chrome.cpp:551:12 frame #3: 0x000000028a03ef8e WebKit`WebKit::WebPage::windowScreenDidChange(this=0x00007fa0b780f208, displayID=4294967273, nominalFramesPerSecond=Optional<unsigned int> @ 0x00007ffee0380930) at WebPage.cpp:2138:22 frame #4: 0x0000000288792135 WebKit`WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea(this=0x00007fa0a7518900, webPage=0x00007fa0b780f208, parameters=0x00007ffee0381420) at RemoteLayerTreeDrawingArea.mm:75:13 frame #5: 0x00000002887935f5 WebKit`WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea(this=0x00007fa0a7518900, webPage=0x00007fa0b780f208, parameters=0x00007ffee0381420) at RemoteLayerTreeDrawingArea.mm:64:1 frame #6: 0x0000000289e33699 WebKit`std::__1::__unique_if<WebKit::RemoteLayerTreeDrawingArea>::__unique_single std::__1::make_unique<WebKit::RemoteLayerTreeDrawingArea, WebKit::WebPage&, WebKit::WebPageCreationParameters const&>(__args=0x00007fa0b780f208, __args=0x00007ffee0381420) at memory:2755:32 frame #7: 0x0000000289e30e6b WebKit`decltype(args=0x00007fa0b780f208, args=0x00007ffee0381420) WTF::makeUnique<WebKit::RemoteLayerTreeDrawingArea, WebKit::WebPage&, WebKit::WebPageCreationParameters const&>(WebKit::WebPage&, WebKit::WebPageCreationParameters const&) at StdLibExtras.h:507:12 frame #8: 0x0000000289e30de6 WebKit`WebKit::DrawingArea::create(webPage=0x00007fa0b780f208, parameters=0x00007ffee0381420) at DrawingArea.cpp:56:16 frame #9: 0x000000028a03090b WebKit`WebKit::WebPage::WebPage(this=0x00007fa0b780f208, pageID=(m_identifier = 22), parameters=0x00007ffee0381420) at WebPage.cpp:652:21 frame #10: 0x000000028a02edd5 WebKit`WebKit::WebPage::WebPage(this=0x00007fa0b780f208, pageID=(m_identifier = 22), parameters=0x00007ffee0381420) at WebPage.cpp:529:1 frame #11: 0x000000028a02ecc8 WebKit`WebKit::WebPage::create(pageID=(m_identifier = 22), parameters=0x00007ffee0381420) at WebPage.cpp:427:39 frame #12: 0x0000000289a25764 WebKit`WebKit::WebProcess::createWebPage(this=0x00007fa0b75042d0, pageID=(m_identifier = 22), parameters=0x00007ffee0381420) at WebProcess.cpp:758:34 frame #13: 0x000000028a2fc3fc WebKit`void IPC::callMemberFunctionImpl<WebKit::WebProcess, void (WebKit::WebProcess::*)(WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WebKit::WebPageCreationParameters&&), std::__1::tuple<WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WebKit::WebPageCreationParameters>, 0ul, 1ul>(object=0x00007fa0b75042d0, function=80 56 a2 89 02 00 00 00 00 00 00 00 00 00 00 00, args=size=2, (null)=std::__1::index_sequence<0UL, 1UL> @ 0x00007ffee0381358)(WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WebKit::WebPageCreationParameters&&), std::__1::tuple<WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WebKit::WebPageCreationParameters>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) at HandleMessage.h:43:5 frame #14: 0x000000028a2faef0 WebKit`void IPC::callMemberFunction<WebKit::WebProcess, void (WebKit::WebProcess::*)(WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WebKit::WebPageCreationParameters&&), std::__1::tuple<WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WebKit::WebPageCreationParameters>, std::__1::integer_sequence<unsigned long, 0ul, 1ul> >(args=size=2, object=0x00007fa0b75042d0, function=80 56 a2 89 02 00 00 00 00 00 00 00 00 00 00 00)(WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WebKit::WebPageCreationParameters&&)) at HandleMessage.h:49:5 frame #15: 0x000000028a2f531e WebKit`void IPC::handleMessage<Messages::WebProcess::CreateWebPage, WebKit::WebProcess, void (WebKit::WebProcess::*)(WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WebKit::WebPageCreationParameters&&)>(decoder=0x00007fa097504310, object=0x00007fa0b75042d0, function=80 56 a2 89 02 00 00 00 00 00 00 00 00 00 00 00)(WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WebKit::WebPageCreationParameters&&)) at HandleMessage.h:121:5 frame #16: 0x000000028a2f322c WebKit`WebKit::WebProcess::didReceiveWebProcessMessage(this=0x00007fa0b75042d0, connection=0x00007fa097404150, decoder=0x00007fa097504310) at WebProcessMessageReceiver.cpp:341:16 frame #17: 0x0000000289a26166 WebKit`WebKit::WebProcess::didReceiveMessage(this=0x00007fa0b75042d0, connection=0x00007fa097404150, decoder=0x00007fa097504310) at WebProcess.cpp:824:9 frame #18: 0x000000028812b784 WebKit`IPC::Connection::dispatchMessage(this=0x00007fa097404150, decoder=0x00007fa097504310) at Connection.cpp:1020:14 1748905 1 425662 simon.fraser 2021-04-09 16:37:16 -0700 Created attachment 425662 Patch 1748928 2 425662 thorton 2021-04-09 17:23:28 -0700 Comment on attachment 425662 Patch Have you hosed macOS RemoteLayerTreeDrawingArea even more than it already is? I think you need something ... somewhere else, too, maybe? 1748958 3 ews-feeder 2021-04-09 21:09:12 -0700 Committed r275792 (236363@main): <https://commits.webkit.org/236363@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425662. 1748959 4 webkit-bug-importer 2021-04-09 21:10:16 -0700 <rdar://problem/76483765> 1749191 5 aakash_jain 2021-04-12 05:31:14 -0700 (In reply to EWS from comment #3) > Committed r275792 (236363@main): <https://commits.webkit.org/236363@main> Following API test seems to be failing after this commit: TestWebKitAPI.IndexedDB.DatabaseProcessKill. EWS also indicated this failure in https://ews-build.webkit.org/#/builders/9/builds/44625 History: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.IndexedDB.DatabaseProcessKill 1853284 6 graouts 2022-03-21 12:09:50 -0700 This caused bug 234923. 425662 2021-04-09 16:37:16 -0700 2021-04-09 21:09:13 -0700 Patch bug-224395-20210409163715.patch text/plain 4252 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDlkNWJmOGRiMDYyMWRmYWUx MWI3YTc1YzhjYzBhODhjMTcwZmE1MzEuLjE1ODMwMmVkYjJiOGNiODYwODVkNmMxZGJmMDc3OTg3 MzhmOTNhYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjEtMDQtMDkgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPUyBXSzJdIENBRGlz cGxheUxpbmsgaW4gdGhlIHdlYiBwcm9jZXNzIGlzIHVzZWQgdW5pbnRlbnRpb25hbGx5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQzOTUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIFJlbW90ZUxh eWVyVHJlZURyYXdpbmdBcmVhIGNhbGxlZCB3aW5kb3dTY3JlZW5EaWRDaGFuZ2UoKSBmcm9tIGl0 cyBjb25zdHJ1Y3RvciwKKyAgICAgICAgbV9wYWdlLmRyYXdpbmdBcmVhKCkgd2FzIG51bGwgd2hp Y2ggcmVzdWx0ZWQgaW4gRGlzcGxheVJlZnJlc2hNb25pdG9yOjpjcmVhdGUoKQorICAgICAgICBy ZWNlaXZpbmcgYSBudWxsIERpc3BsYXlSZWZyZXNoTW9uaXRvckZhY3RvcnkqLCBzbyBpdCBmZWxs IGJhY2sgdG8gdGhlIGxlZ2FjeQorICAgICAgICBEaXNwbGF5UmVmcmVzaE1vbml0b3JJT1MsIGlu c3RlYWQgb2YgdXNpbmcgUmVtb3RlTGF5ZXJUcmVlRGlzcGxheVJlZnJlc2hNb25pdG9yLgorCisg ICAgICAgIEZpeCBieSBzZW5kaW5nIHdpbmRvd1NjcmVlbkRpZENoYW5nZSgpIGZyb20gdGhlIFVJ IHByb2Nlc3MsIHdpdGggdGhlIHN5bnRoZXRpYworICAgICAgICBEaXNwbGF5SUQgZ2VuZXJhdGVk IGZyb20gdGhlIHdlYlBhZ2VJRCgpLiBUaGlzIGhhcyB0aGUgYWR2YW50YWdlIHRoYXQKKyAgICAg ICAgV2ViUGFnZVByb3h5IHdpbGwgYWxzbyBzdG9yZSB0aGUgY29ycmVjdCBEaXNwbGF5SUQsIGFu ZCBpcyBtb3JlIHNpbWlsYXIgdG8gbWFjT1MuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXcubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX2NvbW1vbkluaXRpYWxp emF0aW9uV2l0aFByb2Nlc3NQb29sOmNvbmZpZ3VyYXRpb246XSk6CisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJQYWdlL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS5t bToKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWE6OlJlbW90ZUxh eWVyVHJlZURyYXdpbmdBcmVhKToKKwogMjAyMS0wNC0wOCAgU2lodWkgTGl1ICA8c2lodWlfbGl1 QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgbG9nZ2luZyBmb3IgaW52ZXN0aWdhdGluZyBo dHRwL3Rlc3RzL0luZGV4ZWREQi9zdG9yYWdlLWxpbWl0LTEuaHRtbCBmYWlsdXJlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1tCmluZGV4IDEyNjZkOTAwYjkx M2NiZTVmNjdhNzMwM2Y4ZjcyYjhiODk4NWFlMWQuLmZkMDY2NjU4YWMzOTA5OTRhNmU3ZWZkZjQx NDEzYWYyNjc0ZjhkZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9X S0NvbnRlbnRWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3Lm1tCkBAIC0xNzIsNiArMTcyLDEzIEBAIC0gKGluc3RhbmNldHlwZSlfY29tbW9uSW5p dGlhbGl6YXRpb25XaXRoUHJvY2Vzc1Bvb2w6KFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2wmKXByCiAg ICAgX3BhZ2UtPnNldERlbGVnYXRlc1Njcm9sbGluZyh0cnVlKTsKICAgICBfcGFnZS0+c2V0U2Ny ZWVuSXNCZWluZ0NhcHR1cmVkKFtbW3NlbGYgd2luZG93XSBzY3JlZW5dIGlzQ2FwdHVyZWRdKTsK IAorICAgIC8vIEluIG9yZGVyIHRvIGVuc3VyZSB0aGF0IHdlIGdldCBhIHVuaXF1ZSBEaXNwbGF5 UmVmcmVzaE1vbml0b3IgcGVyLURyYXdpbmdBcmVhIChuZWNlc3NhcnkgYmVjYXVzZSBEaXNwbGF5 UmVmcmVzaE1vbml0b3IKKyAgICAvLyBpcyBkcml2ZW4gYnkgdGhpcyBjbGFzcyksIGdpdmUgZWFj aCBwYWdlIGEgdW5pcXVlIERpc3BsYXlJRCBkZXJpdmVkIGZyb20gV2ViUGFnZSdzIHVuaXF1ZSBJ RC4KKyAgICAvLyBGSVhNRTogV2hpbGUgdXNpbmcgdGhlIGhpZ2ggZW5kIG9mIHRoZSByYW5nZSBv ZiBEaXNwbGF5SURzIG1ha2VzIGEgY29sbGlzaW9uIHdpdGggcmVhbCwgbm9uLVJlbW90ZUxheWVy VHJlZURyYXdpbmdBcmVhCisgICAgLy8gRGlzcGxheUlEcyBsZXNzIGxpa2VseSwgaXQgaXMgbm90 IGVudGlyZWx5IHNhZmUgdG8gaGF2ZSBhIFJlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhIGFuZCBU aWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYQorICAgIC8vIGNvZWV4aXN0IGluIHRoZSBzYW1l IHByb2Nlc3MuCisgICAgX3BhZ2UtPndpbmRvd1NjcmVlbkRpZENoYW5nZShzdGQ6Om51bWVyaWNf bGltaXRzPHVpbnQzMl90Pjo6bWF4KCkgLSBfcGFnZS0+d2ViUGFnZUlEKCkudG9VSW50NjQoKSwg V1RGOjpudWxsb3B0KTsKKwogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKICAgICBfcGFnZS0+ c2V0RnVsbHNjcmVlbkNsaWVudChtYWtlVW5pcXVlPFdlYktpdDo6RnVsbHNjcmVlbkNsaWVudD4o c2VsZi53ZWJWaWV3KSk7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9XZWJQYWdlL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS5t bSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1JlbW90ZUxheWVyVHJlZS9SZW1v dGVMYXllclRyZWVEcmF3aW5nQXJlYS5tbQppbmRleCBhMzg4MTMzNWE0ZWY3ZGEwYTI4ZmI3NjAy YjhhMjk3YTgwNjg1MzM0Li42ZjM1NjVhOTA4YWFjYzJkNTg3MmEyMjBjZGY0ZjM1Mzc5YWQ5OGEx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9SZW1vdGVMYXll clRyZWUvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEubW0KKysrIGIvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL1dlYlBhZ2UvUmVtb3RlTGF5ZXJUcmVlL1JlbW90ZUxheWVyVHJlZURyYXdpbmdB cmVhLm1tCkBAIC02NywxMyArNjcsNiBAQCBSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYTo6UmVt b3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEoV2ViUGFnZSYgd2ViUGFnZSwgY29uc3QgVwogCiAgICAg bV9jb21taXRRdWV1ZSA9IGFkb3B0T1NPYmplY3QoZGlzcGF0Y2hfcXVldWVfY3JlYXRlKCJjb20u YXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEuQ29tbWl0 UXVldWUiLCBudWxscHRyKSk7CiAKLSAgICAvLyBJbiBvcmRlciB0byBlbnN1cmUgdGhhdCB3ZSBn ZXQgYSB1bmlxdWUgRGlzcGxheVJlZnJlc2hNb25pdG9yIHBlci1EcmF3aW5nQXJlYSAobmVjZXNz YXJ5IGJlY2F1c2UgRGlzcGxheVJlZnJlc2hNb25pdG9yCi0gICAgLy8gaXMgZHJpdmVuIGJ5IHRo aXMgY2xhc3MpLCBnaXZlIGVhY2ggcGFnZSBhIHVuaXF1ZSBEaXNwbGF5SUQgZGVyaXZlZCBmcm9t IFdlYlBhZ2UncyB1bmlxdWUgSUQuCi0gICAgLy8gRklYTUU6IFdoaWxlIHVzaW5nIHRoZSBoaWdo IGVuZCBvZiB0aGUgcmFuZ2Ugb2YgRGlzcGxheUlEcyBtYWtlcyBhIGNvbGxpc2lvbiB3aXRoIHJl YWwsIG5vbi1SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYQotICAgIC8vIERpc3BsYXlJRHMgbGVz cyBsaWtlbHksIGl0IGlzIG5vdCBlbnRpcmVseSBzYWZlIHRvIGhhdmUgYSBSZW1vdGVMYXllclRy ZWVEcmF3aW5nQXJlYSBhbmQgVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEKLSAgICAvLyBj b2VleGlzdCBpbiB0aGUgc2FtZSBwcm9jZXNzLgotICAgIHdlYlBhZ2Uud2luZG93U2NyZWVuRGlk Q2hhbmdlKHN0ZDo6bnVtZXJpY19saW1pdHM8dWludDMyX3Q+OjptYXgoKSAtIHdlYlBhZ2UuaWRl bnRpZmllcigpLnRvVUludDY0KCksIFdURjo6bnVsbG9wdCk7Ci0KICAgICBpZiAoYXV0byB2aWV3 RXhwb3NlZFJlY3QgPSBwYXJhbWV0ZXJzLnZpZXdFeHBvc2VkUmVjdCkKICAgICAgICAgc2V0Vmll d0V4cG9zZWRSZWN0KHZpZXdFeHBvc2VkUmVjdCk7CiB9Cg==