224394 2021-04-09 15:05:29 -0700 scrollingTreeNodeDidScroll() should just trigger a rendering udpate 2021-04-20 12:45:42 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser alex cmarcelo ews-watchlist fred.wang jamesr luiz simon.fraser thorton tonikitoo webkit-bug-importer oldest_to_newest 1748879 0 simon.fraser 2021-04-09 15:05:29 -0700 scrollingTreeNodeDidScroll() should just trigger a rendering udpate 1748894 1 425660 simon.fraser 2021-04-09 15:47:46 -0700 Created attachment 425660 Patch 1748944 2 ews-feeder 2021-04-09 19:11:09 -0700 Committed r275790 (236361@main): <https://commits.webkit.org/236361@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425660. 1748945 3 webkit-bug-importer 2021-04-09 19:16:05 -0700 <rdar://problem/76481198> 1750564 4 alex 2021-04-15 04:05:56 -0700 This patch broke the async scrolling for gtk and wpe, we do not have the call to synchronizeStateFromScrollingTree in Nicosia implementation. I could fix adding a willStartRenderingUpdate implementation to Nicosia that syncs but I'll take this failure as an opportunitty to review the whole synchronization because maybe we have other differences that can cause trouble in the future. 1752381 5 alex 2021-04-20 12:45:42 -0700 Created bug 224824 to solve the regression in WPE and GTK. 425660 2021-04-09 15:47:46 -0700 2021-04-09 19:41:13 -0700 Patch bug-224394-20210409154745.patch text/plain 7063 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTYyM2MzYTU5OTYwYmEw YzRhNDRlNmE1NmFiZmQwYzc1ZGE4NzlkNS4uNmUyYWU5NWNiNmQwMTE5MGMxNWM3NGI1ZDcyZGNj ZTEzNGI5YzAxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIxLTA0LTA5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIHNjcm9sbGluZ1Ry ZWVOb2RlRGlkU2Nyb2xsKCkgc2hvdWxkIGp1c3QgdHJpZ2dlciBhIHJlbmRlcmluZyB1ZHBhdGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDM5NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIGhh bmRsaW5nIHdoZWVsIGV2ZW50cyBvbiB0aGUgc2Nyb2xsaW5nIHRocmVhZCwKKyAgICAgICAgVGhy ZWFkZWRTY3JvbGxpbmdUcmVlOjpzY3JvbGxpbmdUcmVlTm9kZURpZFNjcm9sbCgpIGFwcGVuZHMg dG8gYSBxdWV1ZSBvZiBwZW5kaW5nIHVwZGF0ZXMKKyAgICAgICAgYW5kIHRoZW4gdHJpZ2dlcnMg YXBwbHlQZW5kaW5nU2Nyb2xsVXBkYXRlcygpIG9uIHRoZSBtYWluIHRocmVhZCB0byBwcm9jZXNz IHRob3NlIHVwZGF0ZXMuCisgICAgICAgIEhvd2V2ZXIsIGV2ZXJ5IHJlbmRlcmluZyB1cGRhdGUg YWxzbyBwcm9jZXNzZXMgcGVuZGluZyBzY3JvbGwgdXBkYXRlcyB2aWEKKyAgICAgICAgc3luY2hy b25pemVTdGF0ZUZyb21TY3JvbGxpbmdUcmVlKCksIHNvIGl0J3Mgc2ltcGxlciBpZiB3ZSBqdXN0 IHRyaWdnZXIgYSByZW5kZXJpbmcgdXBkYXRlLgorCisgICAgICAgICogcGFnZS9zY3JvbGxpbmcv QXN5bmNTY3JvbGxpbmdDb29yZGluYXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBc3luY1Nj cm9sbGluZ0Nvb3JkaW5hdG9yOjpzY3JvbGxpbmdUaHJlYWRBZGRlZFBlbmRpbmdVcGRhdGUpOgor ICAgICAgICAoV2ViQ29yZTo6QXN5bmNTY3JvbGxpbmdDb29yZGluYXRvcjo6c2NoZWR1bGVSZW5k ZXJpbmdVcGRhdGUpOgorICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29v cmRpbmF0b3IuaDoKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9UaHJlYWRlZFNjcm9sbGluZ1Ry ZWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGhyZWFkZWRTY3JvbGxpbmdUcmVlOjpzY3JvbGxp bmdUcmVlTm9kZURpZFNjcm9sbCk6CisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvbWFjL1Njcm9s bGluZ0Nvb3JkaW5hdG9yTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nQ29vcmRp bmF0b3JNYWM6OnNjaGVkdWxlVHJlZVN0YXRlQ29tbWl0KToKKyAgICAgICAgKiBwYWdlL3Njcm9s bGluZy9uaWNvc2lhL1Njcm9sbGluZ0Nvb3JkaW5hdG9yTmljb3NpYS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvck5pY29zaWE6OnNjaGVkdWxlVHJlZVN0YXRlQ29t bWl0KToKKwogMjAyMS0wNC0wOCAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4KIAog ICAgICAgICBSZW1vdmUgbG9nZ2luZyBmb3IgaW52ZXN0aWdhdGluZyBodHRwL3Rlc3RzL0luZGV4 ZWREQi9zdG9yYWdlLWxpbWl0LTEuaHRtbCBmYWlsdXJlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL3Njcm9sbGluZy9Bc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCmlu ZGV4IGQzYTdjMTFjYWE1ZWU2YTMxZWE3YjIxNTljMGViNWE3MTk0NTBhMTkuLjgzZGM3ODZkMmYy MGQ4YThiOTU4ODBkZWY0YzIxNTUzNWI0ZmRlMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCkBA IC02OSw2ICs2OSwxMSBAQCB2b2lkIEFzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNjcm9sbGlu Z1N0YXRlVHJlZVByb3BlcnRpZXNDaGFuZ2VkKCkKICAgICBzY2hlZHVsZVRyZWVTdGF0ZUNvbW1p dCgpOwogfQogCit2b2lkIEFzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNjcm9sbGluZ1RocmVh ZEFkZGVkUGVuZGluZ1VwZGF0ZSgpCit7CisgICAgc2NoZWR1bGVSZW5kZXJpbmdVcGRhdGUoKTsK K30KKwogI2lmIFBMQVRGT1JNKENPQ09BKQogdm9pZCBBc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9y OjpoYW5kbGVXaGVlbEV2ZW50UGhhc2UoU2Nyb2xsaW5nTm9kZUlEIG5vZGVJRCwgUGxhdGZvcm1X aGVlbEV2ZW50UGhhc2UgcGhhc2UpCiB7CkBAIC0zMDUsNiArMzEwLDExIEBAIHZvaWQgQXN5bmNT Y3JvbGxpbmdDb29yZGluYXRvcjo6YXBwbHlQZW5kaW5nU2Nyb2xsVXBkYXRlcygpCiAgICAgfQog fQogCit2b2lkIEFzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNjaGVkdWxlUmVuZGVyaW5nVXBk YXRlKCkKK3sKKyAgICBtX3BhZ2UtPnNjaGVkdWxlUmVuZGVyaW5nVXBkYXRlKFJlbmRlcmluZ1Vw ZGF0ZVN0ZXA6OlNjcm9sbGluZ1RyZWVVcGRhdGUpOworfQorCiBGcmFtZVZpZXcqIEFzeW5jU2Ny b2xsaW5nQ29vcmRpbmF0b3I6OmZyYW1lVmlld0ZvclNjcm9sbGluZ05vZGUoU2Nyb2xsaW5nTm9k ZUlEIHNjcm9sbGluZ05vZGVJRCkgY29uc3QKIHsKICAgICBpZiAoIW1fc2Nyb2xsaW5nU3RhdGVU cmVlLT5yb290U3RhdGVOb2RlKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Nj cm9sbGluZy9Bc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L3Njcm9sbGluZy9Bc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmgKaW5kZXggNDdkNWU5ZDM3NGQ2 ZDUyMzMyYTlhNDc0ZGY1NzA5M2FkNWFiNDk0ZC4uODcxNDk4ZWY2NDY0OWM5Zjc4ZmZlMmEyNTNm Yjk2MzRmNGVhNGY3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcv QXN5bmNTY3JvbGxpbmdDb29yZGluYXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Ny b2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaApAQCAtNTAsNiArNTAsNyBAQCBwdWJs aWM6CiAgICAgU2Nyb2xsaW5nVHJlZSogc2Nyb2xsaW5nVHJlZSgpIGNvbnN0IHsgcmV0dXJuIG1f c2Nyb2xsaW5nVHJlZS5nZXQoKTsgfQogCiAgICAgdm9pZCBzY3JvbGxpbmdTdGF0ZVRyZWVQcm9w ZXJ0aWVzQ2hhbmdlZCgpOworICAgIHZvaWQgc2Nyb2xsaW5nVGhyZWFkQWRkZWRQZW5kaW5nVXBk YXRlKCk7CiAKICAgICB2b2lkIGFwcGx5UGVuZGluZ1Njcm9sbFVwZGF0ZXMoKTsKIApAQCAtODcs NiArODgsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgV0VCQ09SRV9FWFBPUlQgU3RyaW5nIHNjcm9sbGlu Z1RyZWVBc1RleHQoU2Nyb2xsaW5nU3RhdGVUcmVlQXNUZXh0QmVoYXZpb3IgPSBTY3JvbGxpbmdT dGF0ZVRyZWVBc1RleHRCZWhhdmlvck5vcm1hbCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgV0VCQ09S RV9FWFBPUlQgdm9pZCB3aWxsQ29tbWl0VHJlZSgpIG92ZXJyaWRlOwogICAgIHZvaWQgc3luY2hy b25pemVTdGF0ZUZyb21TY3JvbGxpbmdUcmVlKCk7CisgICAgdm9pZCBzY2hlZHVsZVJlbmRlcmlu Z1VwZGF0ZSgpOwogCiAgICAgYm9vbCBldmVudFRyYWNraW5nUmVnaW9uc0RpcnR5KCkgY29uc3Qg eyByZXR1cm4gbV9ldmVudFRyYWNraW5nUmVnaW9uc0RpcnR5OyB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1RocmVhZGVkU2Nyb2xsaW5nVHJlZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9UaHJlYWRlZFNjcm9sbGluZ1RyZWUuY3BwCmlu ZGV4IGQ3OGJhNmJlNmFjZjg4NmI1NzdmNzY4NzRlNWFkZTU5OGU3ZDIwMmUuLmMwYzc2MDhkNjQ0 YmRiMmNiNWJhYTRiNzYxNGIyOGQxZTY0N2NhZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2Uvc2Nyb2xsaW5nL1RocmVhZGVkU2Nyb2xsaW5nVHJlZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3JvbGxpbmdUcmVlLmNwcApAQCAtMjEwLDcg KzIxMCw3IEBAIHZvaWQgVGhyZWFkZWRTY3JvbGxpbmdUcmVlOjpzY3JvbGxpbmdUcmVlTm9kZURp ZFNjcm9sbChTY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kCiAgICAgICAgIHJldHVybjsKICAgICB9 CiAKLSAgICBMT0dfV0lUSF9TVFJFQU0oU2Nyb2xsaW5nLCBzdHJlYW0gPDwgIlRocmVhZGVkU2Ny b2xsaW5nVHJlZTo6c2Nyb2xsaW5nVHJlZU5vZGVEaWRTY3JvbGwgIiA8PCBub2RlLnNjcm9sbGlu Z05vZGVJRCgpIDw8ICIgdG8gIiA8PCBzY3JvbGxQb3NpdGlvbiA8PCAiIGJvdW5jaW5nIHRvIG1h aW4gdGhyZWFkIik7CisgICAgTE9HX1dJVEhfU1RSRUFNKFNjcm9sbGluZywgc3RyZWFtIDw8ICJU aHJlYWRlZFNjcm9sbGluZ1RyZWU6OnNjcm9sbGluZ1RyZWVOb2RlRGlkU2Nyb2xsICIgPDwgbm9k ZS5zY3JvbGxpbmdOb2RlSUQoKSA8PCAiIHRvICIgPDwgc2Nyb2xsUG9zaXRpb24gPDwgIiB0cmln Z2VyaW5nIG1haW4gdGhyZWFkIHJlbmRlcmluZyB1cGRhdGUiKTsKIAogICAgIGF1dG8gc2Nyb2xs VXBkYXRlID0gU2Nyb2xsVXBkYXRlIHsgbm9kZS5zY3JvbGxpbmdOb2RlSUQoKSwgc2Nyb2xsUG9z aXRpb24sIGxheW91dFZpZXdwb3J0T3JpZ2luLCBzY3JvbGxpbmdMYXllclBvc2l0aW9uQWN0aW9u IH07CiAgICAgYWRkUGVuZGluZ1Njcm9sbFVwZGF0ZShXVEZNb3ZlKHNjcm9sbFVwZGF0ZSkpOwpA QCAtMjE4LDcgKzIxOCw3IEBAIHZvaWQgVGhyZWFkZWRTY3JvbGxpbmdUcmVlOjpzY3JvbGxpbmdU cmVlTm9kZURpZFNjcm9sbChTY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kCiAgICAgYXV0byBkZWZl cnJlciA9IFdoZWVsRXZlbnRUZXN0TW9uaXRvckNvbXBsZXRpb25EZWZlcnJlciB7IHdoZWVsRXZl bnRUZXN0TW9uaXRvcigpLCByZWludGVycHJldF9jYXN0PFdoZWVsRXZlbnRUZXN0TW9uaXRvcjo6 U2Nyb2xsYWJsZUFyZWFJZGVudGlmaWVyPihub2RlLnNjcm9sbGluZ05vZGVJRCgpKSwgV2hlZWxF dmVudFRlc3RNb25pdG9yOjpTY3JvbGxpbmdUaHJlYWRTeW5jTmVlZGVkIH07CiAgICAgUnVuTG9v cDo6bWFpbigpLmRpc3BhdGNoKFtzdHJvbmdUaGlzID0gbWFrZVJlZigqdGhpcyksIGRlZmVycmVy ID0gV1RGTW92ZShkZWZlcnJlcildIHsKICAgICAgICAgaWYgKGF1dG8qIHNjcm9sbGluZ0Nvb3Jk aW5hdG9yID0gc3Ryb25nVGhpcy0+bV9zY3JvbGxpbmdDb29yZGluYXRvci5nZXQoKSkKLSAgICAg ICAgICAgIHNjcm9sbGluZ0Nvb3JkaW5hdG9yLT5hcHBseVBlbmRpbmdTY3JvbGxVcGRhdGVzKCk7 CisgICAgICAgICAgICBzY3JvbGxpbmdDb29yZGluYXRvci0+c2Nyb2xsaW5nVGhyZWFkQWRkZWRQ ZW5kaW5nVXBkYXRlKCk7CiAgICAgfSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdDb29yZGluYXRvck1hYy5tbSBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdDb29yZGluYXRvck1hYy5tbQppbmRl eCBlYTc3ZjllMWI3ZjkxYzAxNWQzYzQyNjc2NmYxMmE0M2JjZmJmZmZlLi41NWEwYjdjYWY2NjVk ZjljNzlkMTY4M2FjMzY5ODExZTg0MGRjZDQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWMubW0KKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbWFjL1Njcm9sbGluZ0Nvb3JkaW5hdG9yTWFjLm1tCkBA IC0xMDIsOCArMTAyLDcgQEAgdm9pZCBTY3JvbGxpbmdDb29yZGluYXRvck1hYzo6d2hlZWxFdmVu dFdhc1Byb2Nlc3NlZEJ5TWFpblRocmVhZChjb25zdCBQbGF0Zm9ybVcKIAogdm9pZCBTY3JvbGxp bmdDb29yZGluYXRvck1hYzo6c2NoZWR1bGVUcmVlU3RhdGVDb21taXQoKQogewotICAgIC8vIEZJ WE1FOiBUaGlzIG9uZSBuZWVkcyB3b3JrLgotICAgIG1fcGFnZS0+c2NoZWR1bGVSZW5kZXJpbmdV cGRhdGUoUmVuZGVyaW5nVXBkYXRlU3RlcDo6U2Nyb2xsaW5nVHJlZVVwZGF0ZSk7CisgICAgc2No ZWR1bGVSZW5kZXJpbmdVcGRhdGUoKTsKIH0KIAogdm9pZCBTY3JvbGxpbmdDb29yZGluYXRvck1h Yzo6Y29tbWl0VHJlZVN0YXRlSWZOZWVkZWQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9zY3JvbGxpbmcvbmljb3NpYS9TY3JvbGxpbmdDb29yZGluYXRvck5pY29zaWEuY3BwIGIv U291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbmljb3NpYS9TY3JvbGxpbmdDb29yZGluYXRv ck5pY29zaWEuY3BwCmluZGV4IDc1NWRhNDRlMDJlODRiY2FhZTQ3ODMyYjg4ZTUwMGQ3MmQ4OGNl MmUuLjM4MmZiOWNmM2Q4YWUwN2ViMmY3ZTZiNmU4ODg2NDA3NTQyM2JhZDkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL25pY29zaWEvU2Nyb2xsaW5nQ29vcmRpbmF0 b3JOaWNvc2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9uaWNvc2lh L1Njcm9sbGluZ0Nvb3JkaW5hdG9yTmljb3NpYS5jcHAKQEAgLTg5LDYgKzg5LDcgQEAgdm9pZCBT Y3JvbGxpbmdDb29yZGluYXRvck5pY29zaWE6OndoZWVsRXZlbnRXYXNQcm9jZXNzZWRCeU1haW5U aHJlYWQoY29uc3QgUGxhdGYKIAogdm9pZCBTY3JvbGxpbmdDb29yZGluYXRvck5pY29zaWE6OnNj aGVkdWxlVHJlZVN0YXRlQ29tbWl0KCkKIHsKKyAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgcHJv YmFibHkganVzdCBjYWxsIHNjaGVkdWxlUmVuZGVyaW5nVXBkYXRlKCkuCiAgICAgaWYgKCFtX3Nj cm9sbGluZ1N0YXRlVHJlZUNvbW1pdHRlclRpbWVyLmlzQWN0aXZlKCkpCiAgICAgICAgIG1fc2Ny b2xsaW5nU3RhdGVUcmVlQ29tbWl0dGVyVGltZXIuc3RhcnRPbmVTaG90KDBfcyk7CiB9Cg==