224373 2021-04-09 09:05:23 -0700 [ews] Improve step description when compile-webkit step is skipped 2021-04-16 05:36:41 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224666 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1748749 0 aakash_jain 2021-04-09 09:05:23 -0700 Improve step description when compile-webkit step is skipped. Currently it says: "Compiled WebKit (skipped)", it should instead say something like: "Skipped compiling WebKit" or "Skipped compiling WebKit in fast cq mode". 1748750 1 aakash_jain 2021-04-09 09:05:55 -0700 e.g.: step 13 in https://ews-build.webkit.org/#/builders/28/builds/10875 1748752 2 425624 aakash_jain 2021-04-09 09:08:16 -0700 Created attachment 425624 [fast-cq] Patch 1748989 3 ews-feeder 2021-04-10 04:20:58 -0700 Committed r275795 (236366@main): <https://commits.webkit.org/236366@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425624. 1748990 4 webkit-bug-importer 2021-04-10 04:21:13 -0700 <rdar://problem/76490605> 425624 2021-04-09 09:08:16 -0700 2021-04-10 04:20:58 -0700 [fast-cq] Patch bug-224373-20210409120815.patch text/plain 2529 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NTc2MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA0LTA5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBJbXByb3ZlIHN0ZXAgZGVzY3JpcHRpb24gd2hlbiBjb21waWxlLXdlYmtp dCBzdGVwIGlzIHNraXBwZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIyNDM3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKENvbXBp bGVXZWJLaXQuZ2V0UmVzdWx0U3VtbWFyeSk6IFNldCBjdXN0b20gc3VtbWFyeSB3aGVuIHRoaXMg c3RlcCBpcyBza2lwcGVkLgorICAgICAgICAqIENJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5p dHRlc3QucHk6IFVwZGF0ZWQgdW5pdC10ZXN0cy4KKwogMjAyMS0wNC0wOSAgQWRpdHlhIEtlZXJ0 aGkgIDxha2VlcnRoaUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU11bRkNSXSBVc2UgY29udGV4 dCBtZW51cyBmb3IgdGV4dCBpbnB1dCBkYXRhbGlzdCBkcm9wZG93bnMKSW5kZXg6IFRvb2xzL0NJ U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ0lTdXBwb3J0 L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjc1NzYzKQorKysgVG9vbHMvQ0lTdXBwb3J0 L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtMTU5NSw2ICsxNTk1LDEwIEBA IGNsYXNzIENvbXBpbGVXZWJLaXQoc2hlbGwuQ29tcGlsZSk6CiAgICAgZGVmIGdldFJlc3VsdFN1 bW1hcnkoc2VsZik6CiAgICAgICAgIGlmIHNlbGYucmVzdWx0cyA9PSBGQUlMVVJFOgogICAgICAg ICAgICAgcmV0dXJuIHsnc3RlcCc6ICdGYWlsZWQgdG8gY29tcGlsZSBXZWJLaXQnfQorICAgICAg ICBpZiBzZWxmLnJlc3VsdHMgPT0gU0tJUFBFRDoKKyAgICAgICAgICAgIGlmIHNlbGYuZ2V0UHJv cGVydHkoJ2Zhc3RfY29tbWl0X3F1ZXVlJyk6CisgICAgICAgICAgICAgICAgcmV0dXJuIHsnc3Rl cCc6ICdTa2lwcGVkIGNvbXBpbGluZyBXZWJLaXQgaW4gZmFzdC1jcSBtb2RlJ30KKyAgICAgICAg ICAgIHJldHVybiB7J3N0ZXAnOiAnU2tpcHBlZCBjb21waWxpbmcgV2ViS2l0J30KICAgICAgICAg cmV0dXJuIHNoZWxsLkNvbXBpbGUuZ2V0UmVzdWx0U3VtbWFyeShzZWxmKQogCiAKSW5kZXg6IFRv b2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjc1 NzYzKQorKysgVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29y a2luZyBjb3B5KQpAQCAtMTEyMSw3ICsxMTIxLDcgQEAgY2xhc3MgVGVzdENvbXBpbGVXZWJLaXQo QnVpbGRTdGVwTWl4aW5BZAogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdidWlsZGVybmFtZScs ICdDb21taXQtUXVldWUnKQogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdjb25maWd1cmF0aW9u JywgJ2RlYnVnJykKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnZmFzdF9jb21taXRfcXVldWUn LCBUcnVlKQotICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PVNLSVBQRUQsIHN0YXRl X3N0cmluZz0nQ29tcGlsZWQgV2ViS2l0IChza2lwcGVkKScpCisgICAgICAgIHNlbGYuZXhwZWN0 T3V0Y29tZShyZXN1bHQ9U0tJUFBFRCwgc3RhdGVfc3RyaW5nPSdTa2lwcGVkIGNvbXBpbGluZyBX ZWJLaXQgaW4gZmFzdC1jcSBtb2RlJykKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAK IApAQCAtMTE2OSw3ICsxMTY5LDcgQEAgY2xhc3MgVGVzdENvbXBpbGVXZWJLaXRXaXRob3V0UGF0 Y2goQnVpbAogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdmdWxsUGxhdGZvcm0nLCAnaW9zLXNp bXVsYXRvci0xMScpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2NvbmZpZ3VyYXRpb24nLCAn cmVsZWFzZScpCiAgICAgICAgIHNlbGYuZXhwZWN0SGlkZGVuKFRydWUpCi0gICAgICAgIHNlbGYu ZXhwZWN0T3V0Y29tZShyZXN1bHQ9U0tJUFBFRCwgc3RhdGVfc3RyaW5nPSdDb21waWxlZCBXZWJL aXQgKHNraXBwZWQpJykKKyAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1TS0lQUEVE LCBzdGF0ZV9zdHJpbmc9J1NraXBwZWQgY29tcGlsaW5nIFdlYktpdCcpCiAgICAgICAgIHJldHVy biBzZWxmLnJ1blN0ZXAoKQogCiAK