224349 2021-04-08 16:41:24 -0700 [macOS] WebProcessProxy::sendAudioComponentRegistrations leaks CFDataRef 2021-04-09 10:10:46 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson darin jer.noble webkit-bug-importer oldest_to_newest 1748546 0 eric.carlson 2021-04-08 16:41:24 -0700 WebProcessProxy::sendAudioComponentRegistrations leaks CFDataRef 1748548 1 eric.carlson 2021-04-08 16:42:30 -0700 <rdar://problem/76176827> 1748552 2 425561 eric.carlson 2021-04-08 16:58:28 -0700 Created attachment 425561 Patch 1748558 3 ews-feeder 2021-04-08 17:39:23 -0700 Committed r275735 (236322@main): <https://commits.webkit.org/236322@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425561. 1748772 4 425561 darin 2021-04-09 10:10:46 -0700 Comment on attachment 425561 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425561&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:299 > + RunLoop::main().dispatch([protectedThis = WTFMove(protectedThis), registrations = adoptCF(registrations)] () mutable { We always try to keep the adoptCF as close as possible to the call that returns the retained object. Here it’s pretty close, but so easy to miss! I kind of wish there was a more straightforward way to write this. On the other hand this is clearly correct code that does the right thing now. 425561 2021-04-08 16:58:28 -0700 2021-04-08 17:39:23 -0700 Patch bug-224349-20210408165827.patch text/plain 2001 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDlkNWJmOGRiMDYyMWRmYWUx MWI3YTc1YzhjYzBhODhjMTcwZmE1MzEuLjhlY2M4OTc2NjYyZTg4MmMwMzY0MjkyNmMwYmFiYzEx NGY4Njc3OTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDQtMDggIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBXZWJQcm9j ZXNzUHJveHk6OnNlbmRBdWRpb0NvbXBvbmVudFJlZ2lzdHJhdGlvbnMgbGVha3MgQ0ZEYXRhUmVm CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQzNDkK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc2MTc2ODI3PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RlZCBtYW51YWxseS4KKworICAgICAgICAq IFVJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUHJveHlDb2NvYS5tbToKKyAgICAgICAgKFdlYktp dDo6V2ViUHJvY2Vzc1Byb3h5OjpzZW5kQXVkaW9Db21wb25lbnRSZWdpc3RyYXRpb25zKTogVGhl IENGRGljdGlvbmFyeQorICAgICAgICByZXR1cm5lZCBieSBBdWRpb0NvbXBvbmVudEZldGNoU2Vy dmVyUmVnaXN0cmF0aW9ucyBpcyBuZXdseSBhbGxvY2F0ZWQsIHNvIGFkb3B0CisgICAgICAgIGl0 IGludG8gdGhlIFJldGFpblB0ciBzbyB3ZSBkb24ndCBpbmNyZWFzZSB0aGUgcmV0YWluIGNvdW50 LgorCiAyMDIxLTA0LTA4ICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgogCiAgICAg ICAgIFJlbW92ZSBsb2dnaW5nIGZvciBpbnZlc3RpZ2F0aW5nIGh0dHAvdGVzdHMvSW5kZXhlZERC L3N0b3JhZ2UtbGltaXQtMS5odG1sIGZhaWx1cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQcm94eUNvY29hLm1tIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Byb3h5Q29jb2EubW0KaW5kZXggYTNjN2EyODM4ZWJk MDQ3MzRhZDNlN2E2MWRkNzZhZDhhMWRhNTlhNC4uYTU0Mzc2NDM1MTFhMmFhNDgxMGMxZTg1MjEz ODQ1ODMyZTk3NGRlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2Ev V2ViUHJvY2Vzc1Byb3h5Q29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29j b2EvV2ViUHJvY2Vzc1Byb3h5Q29jb2EubW0KQEAgLTI5Niw3ICsyOTYsNyBAQCB2b2lkIFdlYlBy b2Nlc3NQcm94eTo6c2VuZEF1ZGlvQ29tcG9uZW50UmVnaXN0cmF0aW9ucygpCiAgICAgICAgIGlm IChub0VyciAhPSBBdWRpb0NvbXBvbmVudEZldGNoU2VydmVyUmVnaXN0cmF0aW9ucygmcmVnaXN0 cmF0aW9ucykgfHwgIXJlZ2lzdHJhdGlvbnMpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAg ICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFtwcm90ZWN0ZWRUaGlzID0gV1RGTW92ZShwcm90 ZWN0ZWRUaGlzKSwgcmVnaXN0cmF0aW9ucyA9IHJldGFpblB0cihyZWdpc3RyYXRpb25zKV0gKCkg bXV0YWJsZSB7CisgICAgICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbcHJvdGVjdGVkVGhp cyA9IFdURk1vdmUocHJvdGVjdGVkVGhpcyksIHJlZ2lzdHJhdGlvbnMgPSBhZG9wdENGKHJlZ2lz dHJhdGlvbnMpXSAoKSBtdXRhYmxlIHsKICAgICAgICAgICAgIGF1dG8gcmVnaXN0cmF0aW9uRGF0 YSA9IFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlKHJlZ2lzdHJhdGlvbnMuZ2V0KCkpOwogICAgICAgICAg ICAgcHJvdGVjdGVkVGhpcy0+c2VuZChNZXNzYWdlczo6V2ViUHJvY2Vzczo6Q29uc3VtZUF1ZGlv Q29tcG9uZW50UmVnaXN0cmF0aW9ucyh7IHJlZ2lzdHJhdGlvbkRhdGEgfSksIDApOwogICAgICAg ICB9KTsK