224347 2021-04-08 16:10:39 -0700 Fix incorrect compile-time macro for CFNETWORK_NSURLSESSION_ATTRIBUTED_BUNDLE_IDENTIFIER 2021-04-08 17:55:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney bfulgham webkit-bug-importer oldest_to_newest 1748534 0 katherine_cheney 2021-04-08 16:10:39 -0700 Fix incorrect compile-time macro for CFNETWORK_NSURLSESSION_ATTRIBUTED_BUNDLE_IDENTIFIER 1748535 1 425556 katherine_cheney 2021-04-08 16:11:33 -0700 Created attachment 425556 Patch 1748537 2 katherine_cheney 2021-04-08 16:14:03 -0700 rdar://76353792 1748538 3 425556 bfulgham 2021-04-08 16:14:30 -0700 Comment on attachment 425556 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425556&action=review Thank you for fixing this. r=me. > Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:250 > +#if HAVE(CFNETWORK_NSURLSESSION_ATTRIBUTED_BUNDLE_IDENTIFIER) OMG. :-( 1748562 4 ews-feeder 2021-04-08 17:54:08 -0700 Committed r275736 (236323@main): <https://commits.webkit.org/236323@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425556. 1748563 5 webkit-bug-importer 2021-04-08 17:55:19 -0700 <rdar://problem/76430719> 425556 2021-04-08 16:11:33 -0700 2021-04-08 17:54:08 -0700 Patch bug-224347-20210408161133.patch text/plain 3916 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCA2ODZjYmJm ZDU5OGZkYWRmNzI0ZDJkOWYwY2NjYmI5YTM4OWQyYTEyLi4yNDZmYmZjNDY5NWQ0ODgwNzJiM2Y0 NjhiMWNkNzMyZGQ1MzNkZTQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAyMS0wNC0wOCAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxlLmNvbT4KKwor ICAgICAgICBGaXggaW5jb3JyZWN0IGNvbXBpbGUtdGltZSBtYWNybyBmb3IgQ0ZORVRXT1JLX05T VVJMU0VTU0lPTl9BVFRSSUJVVEVEX0JVTkRMRV9JREVOVElGSUVSCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQzNDcKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzc2MzUzNzkyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcGFsL3NwaS9jZi9DRk5ldHdvcmtTUEkuaDoKKwogMjAyMS0wNC0wNyAgSmVy IE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxk IGZpeCBhZnRlciByMjc1NjE0OyBhZGQgc29mdCBsaW5rZWQgY2xhc3MuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDlk NWJmOGRiMDYyMWRmYWUxMWI3YTc1YzhjYzBhODhjMTcwZmE1MzEuLmEzMGUyZGFjN2EyMjNlOGMw MmVhYjBhYzcxNzViZTllMGYzMTdjNWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEt MDQtMDggIEthdGUgQ2hlbmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAg ICAgRml4IGluY29ycmVjdCBjb21waWxlLXRpbWUgbWFjcm8gZm9yIENGTkVUV09SS19OU1VSTFNF U1NJT05fQVRUUklCVVRFRF9CVU5ETEVfSURFTlRJRklFUgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MzQ3CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS83NjM1Mzc5Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIE5ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW06CisgICAg ICAgIChXZWJLaXQ6Ok5ldHdvcmtTZXNzaW9uQ29jb2E6Ok5ldHdvcmtTZXNzaW9uQ29jb2EpOgor ICAgICAgICAoV2ViS2l0OjpOZXR3b3JrU2Vzc2lvbkNvY29hOjpTZXNzaW9uU2V0Ojppbml0aWFs aXplRXBoZW1lcmFsU3RhdGVsZXNzU2Vzc2lvbklmTmVlZGVkKToKKwogMjAyMS0wNC0wOCAgU2lo dWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgbG9nZ2luZyBm b3IgaW52ZXN0aWdhdGluZyBodHRwL3Rlc3RzL0luZGV4ZWREQi9zdG9yYWdlLWxpbWl0LTEuaHRt bCBmYWlsdXJlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9jZi9DRk5l dHdvcmtTUEkuaCBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NmL0NGTmV0d29ya1NQSS5o CmluZGV4IDFhYTZmYzllNWE5ZGQ0MjJiZTdiNTNjMWM1MTM2YjA5ZWM4OTFiZTkuLjY1NDllZDlj NTVjZWQ5NDM5ZGM0MmJmZjgzNjdkMmZjYmRhYWI1NWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL1BBTC9wYWwvc3BpL2NmL0NGTmV0d29ya1NQSS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BB TC9wYWwvc3BpL2NmL0NGTmV0d29ya1NQSS5oCkBAIC0yNDcsNyArMjQ3LDcgQEAgdHlwZWRlZiBO U19FTlVNKE5TSW50ZWdlciwgTlNVUkxTZXNzaW9uQ29tcGFuaW9uUHJveHlQcmVmZXJlbmNlKSB7 CiBAcHJvcGVydHkgKHJlYWR3cml0ZSwgYXNzaWduKSBOU0ludGVnZXIgX2Nvbm5lY3Rpb25DYWNo ZU51bUZhc3RMYW5lczsKIEBwcm9wZXJ0eSAocmVhZHdyaXRlLCBhc3NpZ24pIE5TSW50ZWdlciBf Y29ubmVjdGlvbkNhY2hlTWluaW11bUZhc3RMYW5lUHJpb3JpdHk7CiAjZW5kaWYKLSNpZiBIQVZF KEhBVkVfQ0ZORVRXT1JLX05TVVJMU0VTU0lPTl9BVFRSSUJVVEVEX0JVTkRMRV9JREVOVElGSUVS KQorI2lmIEhBVkUoQ0ZORVRXT1JLX05TVVJMU0VTU0lPTl9BVFRSSUJVVEVEX0JVTkRMRV9JREVO VElGSUVSKQogQHByb3BlcnR5IChudWxsYWJsZSwgY29weSkgTlNTdHJpbmcgKl9hdHRyaWJ1dGVk QnVuZGxlSWRlbnRpZmllcjsKICNlbmRpZgogQGVuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tIGIvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tCmluZGV4IGVi MmI3ZDg5ODVhMWEzOWJhMWZjNDk0MjAwMzI1NDkxMWM4ODExZTYuLjY4MzZlZTFjZDE0YjAyMjRi NzA4YjQ5YmMyZjBjMGU0Y2JkMTM5MjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0KQEAgLTEyMTcsNyAr MTIxNyw3IEBAIE5ldHdvcmtTZXNzaW9uQ29jb2E6Ok5ldHdvcmtTZXNzaW9uQ29jb2EoTmV0d29y a1Byb2Nlc3MmIG5ldHdvcmtQcm9jZXNzLCBOZXR3b3JrCiAgICAgaWYgKCFtX3NvdXJjZUFwcGxp Y2F0aW9uU2Vjb25kYXJ5SWRlbnRpZmllci5pc0VtcHR5KCkpCiAgICAgICAgIGNvbmZpZ3VyYXRp b24uX3NvdXJjZUFwcGxpY2F0aW9uU2Vjb25kYXJ5SWRlbnRpZmllciA9IG1fc291cmNlQXBwbGlj YXRpb25TZWNvbmRhcnlJZGVudGlmaWVyOwogCi0jaWYgSEFWRShIQVZFX0NGTkVUV09SS19OU1VS TFNFU1NJT05fQVRUUklCVVRFRF9CVU5ETEVfSURFTlRJRklFUikKKyNpZiBIQVZFKENGTkVUV09S S19OU1VSTFNFU1NJT05fQVRUUklCVVRFRF9CVU5ETEVfSURFTlRJRklFUikKICAgICBpZiAoIW1f YXR0cmlidXRlZEJ1bmRsZUlkZW50aWZpZXIuaXNFbXB0eSgpKSB7CiAgICAgICAgIGlmIChbY29u ZmlndXJhdGlvbiByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF9hdHRyaWJ1dGVkQnVuZGxl SWRlbnRpZmllcildKQogICAgICAgICAgICAgY29uZmlndXJhdGlvbi5fYXR0cmlidXRlZEJ1bmRs ZUlkZW50aWZpZXIgPSBtX2F0dHJpYnV0ZWRCdW5kbGVJZGVudGlmaWVyOwpAQCAtMTMzNiw3ICsx MzM2LDcgQEAgU2Vzc2lvbldyYXBwZXImIE5ldHdvcmtTZXNzaW9uQ29jb2E6OlNlc3Npb25TZXQ6 OmluaXRpYWxpemVFcGhlbWVyYWxTdGF0ZWxlc3NTZXMKICNpZiBQTEFURk9STShJT1NfRkFNSUxZ KQogICAgIGNvbmZpZ3VyYXRpb24uX0NURGF0YUNvbm5lY3Rpb25TZXJ2aWNlVHlwZSA9IGV4aXN0 aW5nQ29uZmlndXJhdGlvbi5fQ1REYXRhQ29ubmVjdGlvblNlcnZpY2VUeXBlOwogI2VuZGlmCi0j aWYgSEFWRShIQVZFX0NGTkVUV09SS19OU1VSTFNFU1NJT05fQVRUUklCVVRFRF9CVU5ETEVfSURF TlRJRklFUikKKyNpZiBIQVZFKENGTkVUV09SS19OU1VSTFNFU1NJT05fQVRUUklCVVRFRF9CVU5E TEVfSURFTlRJRklFUikKICAgICBpZiAoW2NvbmZpZ3VyYXRpb24gcmVzcG9uZHNUb1NlbGVjdG9y OkBzZWxlY3RvcihfYXR0cmlidXRlZEJ1bmRsZUlkZW50aWZpZXIpXSkKICAgICAgICAgY29uZmln dXJhdGlvbi5fYXR0cmlidXRlZEJ1bmRsZUlkZW50aWZpZXIgPSBleGlzdGluZ0NvbmZpZ3VyYXRp b24uX2F0dHJpYnV0ZWRCdW5kbGVJZGVudGlmaWVyOwogI2VuZGlmCg==