224343 2021-04-08 15:26:08 -0700 REGRESSION (r275150): set-webkit-configuration is too aggressive at deleting config files when coverage/sanitizer switch is not set 2021-04-08 16:05:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224009 InRadar P2 Normal --- 176131 1 ddkilzer ddkilzer mark.lam webkit-bug-importer oldest_to_newest 1748505 0 ddkilzer 2021-04-08 15:26:08 -0700 The set-webkit-configuration is too aggressive at deleting config files when coverage/sanitizer switch is not set. This regressed in r275150 for Bug 176131. See also Bug 224009, which fixed the non-coverage/non-sanitizer switches. 1748510 1 425549 ddkilzer 2021-04-08 15:30:08 -0700 Created attachment 425549 Patch v1 1748515 2 425549 mark.lam 2021-04-08 15:40:45 -0700 Comment on attachment 425549 Patch v1 r=me 1748529 3 425549 ddkilzer 2021-04-08 16:01:09 -0700 Comment on attachment 425549 Patch v1 Marking cq+ since all build queues have finished building. 1748531 4 ews-feeder 2021-04-08 16:04:53 -0700 Committed r275686 (236320@main): <https://commits.webkit.org/236320@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425549. 1748532 5 webkit-bug-importer 2021-04-08 16:05:15 -0700 <rdar://problem/76426292> 425549 2021-04-08 15:30:08 -0700 2021-04-08 16:04:54 -0700 Patch v1 bug-224343-20210408153009.patch text/plain 3144 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NjgyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDFiOWJjNzkwZjhiNWE0YjIzODBjMjcwYmJmNTBjMzM5 ZDUzYTRlYy4uYzgxYTgyMjgzZWI0ZDNiYjc1NGVkNTVhYjM5NTNhNzgyMmFlNjY4ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTA0LTA4ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgUkVHUkVTU0lPTiAocjI3NTE1MCk6IHNldC13ZWJraXQtY29uZmlndXJhdGlvbiBpcyB0 b28gYWdncmVzc2l2ZSBhdCBkZWxldGluZyBjb25maWcgZmlsZXMgd2hlbiBjb3ZlcmFnZS9zYW5p dGl6ZXIgc3dpdGNoIGlzIG5vdCBzZXQKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIy NDM0Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvc2V0LXdlYmtpdC1jb25maWd1cmF0aW9uOgorICAgICAgICAodXBkYXRlT3JEZWxl dGVDb25maWd1cmF0aW9uRmlsZSk6CisgICAgICAgIC0gQ2hhbmdlIHRvIHRha2UgZW5hYmxlZCBh bmQgZGlzYWJsZWQgYXJndW1lbnRzLCBhbmQgb25seQorICAgICAgICAgIHJlc2V0ICh1bmxpbmsp IGEgY29uZmlnIGZpbGUgaWYgdGhlIC0tbm8tPG9wdGlvbj4gaXMKKyAgICAgICAgICBleHBsaWNp dGx5IHNldC4KKwogMjAyMS0wNC0wOCAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgdGVzdCBpbmZyYXN0cnVjdHVyZSBmb3IgYXBwIGJvdW5k IHJlcXVlc3QgY29udGV4dCBzdHJpbmcKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvc2V0LXdl YmtpdC1jb25maWd1cmF0aW9uIGIvVG9vbHMvU2NyaXB0cy9zZXQtd2Via2l0LWNvbmZpZ3VyYXRp b24KaW5kZXggZTY4NzY0NWNkMDg3NzI2YjdmNGJiMGQzNzZjZDhiZDA1MTkwZDI5Yi4uNWQ2ZDky YWY3ZjliODVhZjg1NGNjMzIxN2FlNmNkMzcwMGVlOTdhZCAxMDA3NTUKLS0tIGEvVG9vbHMvU2Ny aXB0cy9zZXQtd2Via2l0LWNvbmZpZ3VyYXRpb24KKysrIGIvVG9vbHMvU2NyaXB0cy9zZXQtd2Vi a2l0LWNvbmZpZ3VyYXRpb24KQEAgLTUxLDcgKzUxLDcgQEAgRU9GCiAKIHN1YiBwcmludEN1cnJl bnRTZXR0aW5ncygpOwogc3ViIHByaW50VXNhZ2UoKTsKLXN1YiB1cGRhdGVPckRlbGV0ZUNvbmZp Z3VyYXRpb25GaWxlKCQkKTsKK3N1YiB1cGRhdGVPckRlbGV0ZUNvbmZpZ3VyYXRpb25GaWxlKCQk JCk7CiAKIG15ICRjb25maWd1cmF0aW9uID0gcGFzc2VkQ29uZmlndXJhdGlvbigpOwogbXkgJGFy Y2hpdGVjdHVyZSA9IHBhc3NlZEFyY2hpdGVjdHVyZSgpOwpAQCAtMTI5LDE5ICsxMjksNiBAQCBp ZiAoJGZvcmNlT3B0aW1pemF0aW9uTGV2ZWwKICAgICBleGl0IDE7CiB9CiAKLXN1YiB1cGRhdGVP ckRlbGV0ZUNvbmZpZ3VyYXRpb25GaWxlKCQkKQotewotICAgIG15ICgkZmlsZU5hbWUsICRjb250 ZW50cykgPSBAXzsKLSAgICBteSAkZmlsZVBhdGggPSBGaWxlOjpTcGVjLT5jYXRmaWxlKCRiYXNl UHJvZHVjdERpciwgJGZpbGVOYW1lKTsKLSAgICBpZiAoJGNvbnRlbnRzKSB7Ci0gICAgICAgb3Bl biBGSUxFLCAiPiIsICRmaWxlUGF0aCBvciBkaWU7Ci0gICAgICAgcHJpbnQgRklMRSAkY29udGVu dHM7Ci0gICAgICAgY2xvc2UgRklMRTsKLSAgICB9IGVsc2UgewotICAgICAgICB1bmxpbmsgJGZp bGVQYXRoOwotICAgIH0KLX0KLQogaWYgKCRjb25maWd1cmF0aW9uKSB7CiAgICAgb3BlbiBDT05G SUdVUkFUSU9OLCAiPiIsICIkYmFzZVByb2R1Y3REaXIvQ29uZmlndXJhdGlvbiIgb3IgZGllOwog ICAgIHByaW50IENPTkZJR1VSQVRJT04gJGNvbmZpZ3VyYXRpb247CkBAIC0xNTgsMTAgKzE0NSwx MCBAQCBpZiAoJGFyY2hpdGVjdHVyZSkgewogICAgIH0KIH0KIAotdXBkYXRlT3JEZWxldGVDb25m aWd1cmF0aW9uRmlsZSgiQVNhbiIsICRlbmFibGVBU0FOID8gIllFUyIgOiB1bmRlZik7Ci11cGRh dGVPckRlbGV0ZUNvbmZpZ3VyYXRpb25GaWxlKCJDb3ZlcmFnZSIsICRlbmFibGVDb3ZlcmFnZSA/ ICJZRVMiIDogdW5kZWYpOwotdXBkYXRlT3JEZWxldGVDb25maWd1cmF0aW9uRmlsZSgiVFNhbiIs ICRlbmFibGVUU0FOID8gIllFUyIgOiB1bmRlZik7Ci11cGRhdGVPckRlbGV0ZUNvbmZpZ3VyYXRp b25GaWxlKCJVQlNhbiIsICRlbmFibGVVQlNBTiA/ICJZRVMiIDogdW5kZWYpOwordXBkYXRlT3JE ZWxldGVDb25maWd1cmF0aW9uRmlsZSgiQVNhbiIsICRlbmFibGVBU0FOLCAkZGlzYWJsZUFTQU4p OwordXBkYXRlT3JEZWxldGVDb25maWd1cmF0aW9uRmlsZSgiQ292ZXJhZ2UiLCAkZW5hYmxlQ292 ZXJhZ2UsICRkaXNhYmxlQ292ZXJhZ2UpOwordXBkYXRlT3JEZWxldGVDb25maWd1cmF0aW9uRmls ZSgiVFNhbiIsICRlbmFibGVUU0FOLCAkZGlzYWJsZVRTQU4pOwordXBkYXRlT3JEZWxldGVDb25m aWd1cmF0aW9uRmlsZSgiVUJTYW4iLCAkZW5hYmxlVUJTQU4sICRkaXNhYmxlVUJTQU4pOwogCiBp ZiAoJGZvcmNlT3B0aW1pemF0aW9uTGV2ZWwgJiYgJGZvcmNlT3B0aW1pemF0aW9uTGV2ZWwgZXEg Im5vbmUiKSB7CiAgICAgdW5saW5rICIkYmFzZVByb2R1Y3REaXIvRm9yY2VPcHRpbWl6YXRpb25M ZXZlbCI7CkBAIC0yMDEsMyArMTg4LDE2IEBAIHN1YiBwcmludFVzYWdlKCkKICAgICBwcmludCBT VERFUlIgJHVzYWdlLCAiXG4iOwogICAgIHByaW50Q3VycmVudFNldHRpbmdzKCk7CiB9CisKK3N1 YiB1cGRhdGVPckRlbGV0ZUNvbmZpZ3VyYXRpb25GaWxlKCQkJCkKK3sKKyAgICBteSAoJGZpbGVO YW1lLCAkc2hvdWxkRW5hYmxlLCAkc2hvdWxkRGlzYWJsZSkgPSBAXzsKKyAgICBteSAkZmlsZVBh dGggPSBGaWxlOjpTcGVjLT5jYXRmaWxlKCRiYXNlUHJvZHVjdERpciwgJGZpbGVOYW1lKTsKKyAg ICBpZiAoJHNob3VsZEVuYWJsZSkgeworICAgICAgIG9wZW4gRklMRSwgIj4iLCAkZmlsZVBhdGgg b3IgZGllOworICAgICAgIHByaW50IEZJTEUgIllFUyI7CisgICAgICAgY2xvc2UgRklMRTsKKyAg ICB9IGVsc2lmICgkc2hvdWxkRGlzYWJsZSkgeworICAgICAgICB1bmxpbmsgJGZpbGVQYXRoOwor ICAgIH0KK30K