224337 2021-04-08 13:00:29 -0700 [Metal-ANGLE] Support GPU power preferences, select low-power GPU by default. 2021-04-09 03:27:08 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kpiddington webkit-unassigned dino ews-watchlist graouts jonlee kkinnunen kondapallykalyan webkit-bug-importer oldest_to_newest 1748440 0 kpiddington 2021-04-08 13:00:29 -0700 [Metal-ANGLE] Support GPU power preferences, select low-power GPU by default. 1748441 1 425537 kpiddington 2021-04-08 13:01:28 -0700 Created attachment 425537 Patch 1748443 2 ews-watchlist 2021-04-08 13:02:16 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1748507 3 jonlee 2021-04-08 15:27:13 -0700 rdar://75823830 1748517 4 425537 dino 2021-04-08 15:43:41 -0700 Comment on attachment 425537 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425537&action=review > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm:278 > + //TODO: External GPU support. Do we prefer high power / low bandwidth for general WebGL applications? > + // Can we support hot-swapping in GPU's? This is a good question. I would assume that if someone has an external GPU they want to use it. And it is likely that their display is running through it or, even if it's a laptop, they are using it as the primary display. So we should probably use any external GPU before even checking for the low-power/high-power flag. But this doesn't need to be fixed now. 1748526 5 ews-feeder 2021-04-08 15:54:27 -0700 Committed r275685 (236319@main): <https://commits.webkit.org/236319@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425537. 1748678 6 425537 kkinnunen 2021-04-09 03:27:08 -0700 Comment on attachment 425537 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425537&action=review > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm:432 > + outExtensions->powerPreference = true; This is not really correct, I don't think the implementation supports the methods defined in the extension.. 425537 2021-04-08 13:01:28 -0700 2021-04-08 15:54:28 -0700 Patch bug-224337-20210408130127.patch text/plain 6735 kpiddington U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMThkMjE5Y2I2NDVlZDJiOTU3OWM0ZWIyZjhhNTM4OGZlOWUyNWM3NC4uMjliMTQ2MmE4M2Rj OWFjNmFlNTk1NDJlODU4MjA1ZDBjODQzM2Q1OCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA0LTA4ICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW01ldGFsLUFOR0xFXSBTdXBwb3J0IEdQVSBwb3dl ciBwcmVmZXJlbmNlcywgc2VsZWN0IGxvdy1wb3dlciBHUFUgYnkgZGVmYXVsdC4KKyAgICAgICAg UmVzcG9uZCB0byBHUFUgcG93ZXIgcHJlZmVyZW5jZSBmbGFncywgZXhwb3NlIGV4dGVuc2lvbiwg YW5kIGF2b2lkIGNyZWF0aW5nIGEgaGlnaC1wb3dlcmVkIEdQVSBieSBkZWZhdWx0LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MzM3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzcmMvbGliQU5HTEUv cmVuZGVyZXIvbWV0YWwvRGlzcGxheU10bC5oOgorICAgICAgICAqIHNyYy9saWJBTkdMRS9yZW5k ZXJlci9tZXRhbC9EaXNwbGF5TXRsLm1tOgorICAgICAgICAocng6OkRpc3BsYXlNdGw6OmluaXRp YWxpemVJbXBsKToKKyAgICAgICAgKHJ4OjpEaXNwbGF5TXRsOjpnZXRNZXRhbERldmljZU1hdGNo aW5nQXR0cmlidXRlKToKKyAgICAgICAgKHJ4OjpEaXNwbGF5TXRsOjpnZW5lcmF0ZUV4dGVuc2lv bnMgY29uc3QpOgorCiAyMDIxLTA0LTA3ICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGluZ3RvbkBh cHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggaW4gY29uZm9ybWFuY2UyL3RleHR1cmVzL21pc2Mv Y29tcHJlc3NlZC10ZXgtaW1hZ2UuaHRtbCB3aXRoIEFOR0xFK01FVEFMCmRpZmYgLS1naXQgYS9T b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvRGlzcGxh eU10bC5oIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21l dGFsL0Rpc3BsYXlNdGwuaAppbmRleCAyNDE3MTIyMGM1YTY1MGFlYTM4YzkyNGU0YWZkMjRhZGFh ZjM5NjlkLi4yZjJmZmEzNjk0NmU1ODgxNjA4NjQ3MmVhMDM5ZTFhN2I3OTY5YWFjIDEwMDY0NAot LS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwv RGlzcGxheU10bC5oCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9y ZW5kZXJlci9tZXRhbC9EaXNwbGF5TXRsLmgKQEAgLTE2NSw3ICsxNjUsNyBAQCBjbGFzcyBEaXNw bGF5TXRsIDogcHVibGljIERpc3BsYXlJbXBsCiAgICAgdm9pZCBpbml0aWFsaXplVGV4dHVyZUNh cHMoKSBjb25zdDsKICAgICB2b2lkIGluaXRpYWxpemVGZWF0dXJlcygpOwogICAgIHZvaWQgaW5p dGlhbGl6ZUxpbWl0YXRpb25zKCk7Ci0KKyAgICBpZDxNVExEZXZpY2U+IGdldE1ldGFsRGV2aWNl TWF0Y2hpbmdBdHRyaWJ1dGUoY29uc3QgZWdsOjpBdHRyaWJ1dGVNYXAgJmF0dHJpYnMpOwogICAg IGFuZ2xlOjpSZXN1bHQgaW5pdGlhbGl6ZVNoYWRlckxpYnJhcnkoKTsKIAogICAgIG10bDo6QXV0 b09iakNQdHI8aWQ8TVRMRGV2aWNlPj4gbU1ldGFsRGV2aWNlID0gbmlsOwpkaWZmIC0tZ2l0IGEv U291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL0Rpc3Bs YXlNdGwubW0gYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIv bWV0YWwvRGlzcGxheU10bC5tbQppbmRleCAwNjJhNWFmOGY4ZTVkMDIyNTYyMGNlNGYwYzgxOTA1 YWViYjk1ZmYzLi5mYTZjOWE2ZDM2MTYzMzNiZTBmYjc2NjBmOTYwMGNlOWE1NTg1ZmQzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0 YWwvRGlzcGxheU10bC5tbQorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5H TEUvcmVuZGVyZXIvbWV0YWwvRGlzcGxheU10bC5tbQpAQCAtMTMyLDI5ICsxMzIsMTIgQEAgYW5n bGU6OlJlc3VsdCBEaXNwbGF5TXRsOjppbml0aWFsaXplSW1wbChlZ2w6OkRpc3BsYXkgKmRpc3Bs YXkpCiB7CiAgICAgQU5HTEVfTVRMX09CSkNfU0NPUEUKICAgICB7Ci0jaWYgZGVmaW5lZChBTkdM RV9QTEFURk9STV9NQUNPUykgfHwgZGVmaW5lZChBTkdMRV9QTEFURk9STV9NQUNDQVRBTFlTVCkK LSAgICAgICAgY29uc3Qgc3RkOjpzdHJpbmcgYW5nbGVQcmVmZXJyZWREZXZpY2UgPSBhbmdsZTo6 R2V0RW52aXJvbm1lbnRWYXIoa0FOR0xFUHJlZmVycmVkRGV2aWNlRW52KTsKLSAgICAgICAgaWYg KGFuZ2xlUHJlZmVycmVkRGV2aWNlICE9ICIiKQotICAgICAgICB7Ci0gICAgICAgICAgICBOU0Fy cmF5PGlkPE1UTERldmljZT4+ICpkZXZpY2VzID0gW01UTENvcHlBbGxEZXZpY2VzKCkgQU5HTEVf TVRMX0FVVE9SRUxFQVNFXTsKLSAgICAgICAgICAgIGZvciAoaWQ8TVRMRGV2aWNlPiBkZXZpY2Ug aW4gZGV2aWNlcykKLSAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICBpZiAoW2RldmljZS5u YW1lLmxvd2VyY2FzZVN0cmluZwotICAgICAgICAgICAgICAgICAgICAgICAgY29udGFpbnNTdHJp bmc6W05TU3RyaW5nIHN0cmluZ1dpdGhVVEY4U3RyaW5nOmFuZ2xlUHJlZmVycmVkRGV2aWNlLmNf c3RyKCldCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLmxvd2Vy Y2FzZVN0cmluZ10pCi0gICAgICAgICAgICAgICAgewotICAgICAgICAgICAgICAgICAgICBOU0xv ZyhAIlVzaW5nIE1ldGFsIERldmljZTogJUAiLCBbZGV2aWNlIG5hbWVdKTsKLSAgICAgICAgICAg ICAgICAgICAgbU1ldGFsRGV2aWNlID0gW2RldmljZSBBTkdMRV9NVExfQVVUT1JFTEVBU0VdOwot ICAgICAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAg ICB9Ci0gICAgICAgIH0KLSNlbmRpZgotICAgICAgICBpZiAoIW1NZXRhbERldmljZSkKKyAgICAg ICAgbU1ldGFsRGV2aWNlID0gW2dldE1ldGFsRGV2aWNlTWF0Y2hpbmdBdHRyaWJ1dGUoZGlzcGxh eS0+Z2V0QXR0cmlidXRlTWFwKCkpIEFOR0xFX01UTF9BVVRPUkVMRUFTRV07CisgICAgICAgIC8v SWYgd2UgY2FuJ3QgY3JlYXRlIGEgZGV2aWNlLCBmYWlsIGluaXRpYWxpemF0aW9uLgorICAgICAg ICBpZighbU1ldGFsRGV2aWNlLmdldCgpKQogICAgICAgICB7Ci0gICAgICAgICAgICBtTWV0YWxE ZXZpY2UgPSBbTVRMQ3JlYXRlU3lzdGVtRGVmYXVsdERldmljZSgpIEFOR0xFX01UTF9BVVRPUkVM RUFTRV07CisgICAgICAgICAgICByZXR1cm4gYW5nbGU6OlJlc3VsdDo6U3RvcDsKICAgICAgICAg fQotCiAgICAgICAgIG1NZXRhbERldmljZVZlbmRvcklkID0gbXRsOjpHZXREZXZpY2VWZW5kb3JJ ZChtTWV0YWxEZXZpY2UpOwogCiAgICAgICAgIG1DbWRRdWV1ZS5zZXQoW1ttTWV0YWxEZXZpY2Uu Z2V0KCkgbmV3Q29tbWFuZFF1ZXVlXSBBTkdMRV9NVExfQVVUT1JFTEVBU0VdKTsKQEAgLTI1Myw2 ICsyMzYsNjggQEAgZWdsOjpFcnJvciBEaXNwbGF5TXRsOjp2YWxpZGF0ZUNsaWVudEJ1ZmZlcihj b25zdCBlZ2w6OkNvbmZpZyAqY29uZmlndXJhdGlvbiwKICAgICByZXR1cm4gZWdsOjpOb0Vycm9y KCk7CiB9CiAKKworaWQ8TVRMRGV2aWNlPiBEaXNwbGF5TXRsOjpnZXRNZXRhbERldmljZU1hdGNo aW5nQXR0cmlidXRlKGNvbnN0IGVnbDo6QXR0cmlidXRlTWFwICZhdHRyaWJzKQoreworI2lmIGRl ZmluZWQoQU5HTEVfUExBVEZPUk1fTUFDT1MpIHx8IGRlZmluZWQoQU5HTEVfUExBVEZPUk1fTUFD Q0FUQUxZU1QpCisgICAgY29uc3Qgc3RkOjpzdHJpbmcgYW5nbGVQcmVmZXJyZWREZXZpY2UgPSBh bmdsZTo6R2V0RW52aXJvbm1lbnRWYXIoa0FOR0xFUHJlZmVycmVkRGV2aWNlRW52KTsKKyAgICBO U0FycmF5PGlkPE1UTERldmljZT4+ICpkZXZpY2VMaXN0ID0gTVRMQ29weUFsbERldmljZXMoKTsK KyAgICBpZiAoYW5nbGVQcmVmZXJyZWREZXZpY2UgIT0gIiIpCisgICAgeworICAgICAgICBmb3Ig KGlkPE1UTERldmljZT4gZGV2aWNlIGluIGRldmljZUxpc3QpCisgICAgICAgIHsKKyAgICAgICAg ICAgIGlmIChbZGV2aWNlLm5hbWUubG93ZXJjYXNlU3RyaW5nCisgICAgICAgICAgICAgICAgICAg IGNvbnRhaW5zU3RyaW5nOltOU1N0cmluZyBzdHJpbmdXaXRoVVRGOFN0cmluZzphbmdsZVByZWZl cnJlZERldmljZS5jX3N0cigpXQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgLmxvd2VyY2FzZVN0cmluZ10pCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgTlNM b2coQCJVc2luZyBNZXRhbCBEZXZpY2U6ICVAIiwgW2RldmljZSBuYW1lXSk7CisgICAgICAgICAg ICAgICAgcmV0dXJuICBkZXZpY2U7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAg ICB9CisgICAgICAgIH0KKyAgICB9CisKKyAgICBOU011dGFibGVBcnJheTxpZDxNVExEZXZpY2U+ PiAqZXh0ZXJuYWxHUFVzID0gW1tOU011dGFibGVBcnJheSBhbGxvY10gaW5pdF07CisgICAgTlNN dXRhYmxlQXJyYXk8aWQ8TVRMRGV2aWNlPj4gKmludGVncmF0ZWRHUFVzID0gW1tOU011dGFibGVB cnJheSBhbGxvY10gaW5pdF07CisgICAgTlNNdXRhYmxlQXJyYXk8aWQ8TVRMRGV2aWNlPj4gKmRp c2NyZXRlR1BVcyA9IFtbTlNNdXRhYmxlQXJyYXkgYWxsb2NdIGluaXRdOworICAgIGZvciAoaWQg PE1UTERldmljZT4gZGV2aWNlIGluIGRldmljZUxpc3QpIHsKKyAgICAgICAgaWYgKGRldmljZS5y ZW1vdmFibGUpCisgICAgICAgIHsKKyAgICAgICAgICAgIFtleHRlcm5hbEdQVXMgYWRkT2JqZWN0 OmRldmljZV07CisgICAgICAgIH0KKyAgICAgICAgZWxzZSBpZiAoZGV2aWNlLmxvd1Bvd2VyKQor ICAgICAgICB7CisgICAgICAgICAgICBbaW50ZWdyYXRlZEdQVXMgYWRkT2JqZWN0OmRldmljZV07 CisgICAgICAgIH0KKyAgICAgICAgZWxzZQorICAgICAgICB7CisgICAgICAgICAgICBbZGlzY3Jl dGVHUFVzIGFkZE9iamVjdDpkZXZpY2VdOworICAgICAgICB9CisgICAgfQorICAgIC8vVE9ETzog RXh0ZXJuYWwgR1BVIHN1cHBvcnQuIERvIHdlIHByZWZlciBoaWdoIHBvd2VyIC8gbG93IGJhbmR3 aWR0aCBmb3IgZ2VuZXJhbCBXZWJHTCBhcHBsaWNhdGlvbnM/CisgICAgLy8gICAgICBDYW4gd2Ug c3VwcG9ydCBob3Qtc3dhcHBpbmcgaW4gR1BVJ3M/CisgICAgaWYgKGF0dHJpYnMuZ2V0KEVHTF9Q T1dFUl9QUkVGRVJFTkNFX0FOR0xFLCBFR0xfTE9XX1BPV0VSX0FOR0xFKSA9PSBFR0xfSElHSF9Q T1dFUl9BTkdMRSkKKyAgICB7CisgICAgICAgIC8vU2VhcmNoIGZvciBhIGRpc2NyZXRlIEdQVSBm aXJzdC4KKyAgICAgICAgZm9yIChpZDxNVExEZXZpY2U+IGRldmljZSBpbiBkaXNjcmV0ZUdQVXMp IHsKKyAgICAgICAgICAgIGlmKCFbZGV2aWNlIGlzSGVhZGxlc3NdKQorICAgICAgICAgICAgICAg IHJldHVybiBkZXZpY2U7CisgICAgICAgIH0KKyAgICB9CisgICAgLy9JZiB3ZSd2ZSBzZWxlY3Rl ZCBhIGxvdyBwb3dlciBkZXZpY2UsIGxvb2sgdGhyb3VnaCBpbnRlZ3JhdGVkIGRldmljZXMuCisg ICAgZm9yIChpZDxNVExEZXZpY2U+IGRldmljZSBpbiBpbnRlZ3JhdGVkR1BVcykgeworICAgICAg ICBpZighW2RldmljZSBpc0hlYWRsZXNzXSkKKyAgICAgICAgICAgIHJldHVybiBkZXZpY2U7Cisg ICAgfQorICAgIC8vSWYgd2Ugc2VsZWN0ZWQgYSBsb3cgcG93ZXIgZGV2aWNlIGFuZCB0aGVyZSdz IG5vIGxvdy1wb3dlciBkZXZpY2VzIGF2YWlhbGJsZSwgcmV0dXJuIHRoZSBmaXJzdCAoZGVmYXVs dCkgZGV2aWNlLgorICAgIGlmKGRldmljZUxpc3QuY291bnQgPiAwKQorICAgICAgICByZXR1cm4g ZGV2aWNlTGlzdFswXTsKKyNlbmRpZgorICAgIC8vSWYgd2UgY2FuJ3QgZmluZCBhbnl0aGluZywg b3IgYXJlIG9uIGEgcGxhdGZvcm0gdGhhdCBkb2Vzbid0IHN1cHBvcnQgcG93ZXIgb3B0aW9ucywg Y3JlYXRlIGEgZGVmYXVsdCBkZXZpY2UuCisgICAgcmV0dXJuIE1UTENyZWF0ZVN5c3RlbURlZmF1 bHREZXZpY2UoKTsKK30KKworCiBlZ2w6OkVycm9yIERpc3BsYXlNdGw6OndhaXROYXRpdmUoY29u c3QgZ2w6OkNvbnRleHQgKmNvbnRleHQsIEVHTGludCBlbmdpbmUpCiB7CiAgICAgVU5JTVBMRU1F TlRFRCgpOwpAQCAtMzg0LDYgKzQyOSw3IEBAIHZvaWQgRGlzcGxheU10bDo6Z2VuZXJhdGVFeHRl bnNpb25zKGVnbDo6RGlzcGxheUV4dGVuc2lvbnMgKm91dEV4dGVuc2lvbnMpIGNvbnN0CiAgICAg Ly8gdGhpcyBleHRlbnNpb24gc28gdGhhdCBBTkdMRSBjYW4gYmUgaW5pdGlhbGl6ZWQgaW4gQ2hy b21lLiBXZWJHTCB3aWxsIGZhaWwgdG8gdXNlCiAgICAgLy8gdGhpcyBleHRlbnNpb24gKGFuZ2xl YnVnLmNvbS80OTI5KQogICAgIG91dEV4dGVuc2lvbnMtPnJvYnVzdFJlc291cmNlSW5pdGlhbGl6 YXRpb24gPSB0cnVlOworICAgIG91dEV4dGVuc2lvbnMtPnBvd2VyUHJlZmVyZW5jZSA9IHRydWU7 CiB9CiAKIHZvaWQgRGlzcGxheU10bDo6Z2VuZXJhdGVDYXBzKGVnbDo6Q2FwcyAqb3V0Q2Fwcykg Y29uc3Qge30K