224336 2021-04-08 12:42:00 -0700 EWS should keep working when Bugzilla is down 2021-06-19 09:51:28 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1748431 0 aakash_jain 2021-04-08 12:42:00 -0700 Few days back when bugs.webkit.org went down for some time, some of the EWS builds failed with an exception while checking bug/patch status from bugs.webkit.org. e.g.: https://ews-build.webkit.org/#/builders/45/builds/3283, https://ews-build.webkit.org/#/builders/60/builds/915 EWS should gracefully handle the situation when bugs.webkit.org is down, and keep working. EWS builds do not need to talk to bugs.webkit.org to run the builds (buildbot already have a copy of the patch). The validate-patch step talks to Bugzilla only for efficiency purposes (to check if the bugs/patch is closed/obsolete/r- etc, and EWS can stop processing it). 1748432 1 425533 aakash_jain 2021-04-08 12:46:07 -0700 Created attachment 425533 [fast-cq] Patch 1748442 2 ews-feeder 2021-04-08 13:02:08 -0700 Committed r275671 (236307@main): <https://commits.webkit.org/236307@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425533. 1748445 3 webkit-bug-importer 2021-04-08 13:03:16 -0700 <rdar://problem/76417253> 1771099 4 aakash_jain 2021-06-19 09:51:28 -0700 This helped today. When Bugzilla went down, EWS builds didn't fail and kept working. e.g.: validate-patch gracefully handled Bugzilla being down in https://ews-build.webkit.org/#/builders/51/builds/15957 425533 2021-04-08 12:46:07 -0700 2021-04-08 13:02:08 -0700 [fast-cq] Patch bug-224336-20210408154606.patch text/plain 1972 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NTY3MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA0LTA4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBFV1Mgc2hvdWxkIGtlZXAgd29ya2luZyB3aGVuIEJ1Z3ppbGxhIGlzIGRv d24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDMz NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ0lT dXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKEJ1Z3ppbGxhTWl4aW4uZ2V0X3Bh dGNoX2pzb24pOgorICAgICAgICAoQnVnemlsbGFNaXhpbi5nZXRfYnVnX2pzb24pOgorCiAyMDIx LTA0LTA4ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBwcmVwYXJl LUNoYW5nZUxvZyBmYWlscyB0byBmaW5kIGRlbGV0ZWQgZnVuY3Rpb25zIGluIGZpbGVzIHdpdGgg c3BhY2VzIGluIHRoZWlyIHBhdGggaW4gR2l0IHJlcG9zaXRvcmllcwpJbmRleDogVG9vbHMvQ0lT dXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DSVN1cHBvcnQv ZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNzU2NzApCisrKyBUb29scy9DSVN1cHBvcnQv ZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC01NzIsNyArNTcyLDExIEBAIGNs YXNzIEJ1Z3ppbGxhTWl4aW4ob2JqZWN0KToKICAgICAgICAgcGF0Y2ggPSBzZWxmLmZldGNoX2Rh dGFfZnJvbV91cmxfd2l0aF9hdXRoZW50aWNhdGlvbihwYXRjaF91cmwpCiAgICAgICAgIGlmIG5v dCBwYXRjaDoKICAgICAgICAgICAgIHJldHVybiBOb25lCi0gICAgICAgIHBhdGNoX2pzb24gPSBw YXRjaC5qc29uKCkuZ2V0KCdhdHRhY2htZW50cycpCisgICAgICAgIHRyeToKKyAgICAgICAgICAg IHBhdGNoX2pzb24gPSBwYXRjaC5qc29uKCkuZ2V0KCdhdHRhY2htZW50cycpCisgICAgICAgIGV4 Y2VwdCBFeGNlcHRpb24gYXMgZToKKyAgICAgICAgICAgIHByaW50KCdGYWlsZWQgdG8gZmV0Y2gg cGF0Y2gganNvbiBmcm9tIHt9LCBlcnJvcjoge30nLmZvcm1hdChwYXRjaF91cmwsIGUpKQorICAg ICAgICAgICAgcmV0dXJuIE5vbmUKICAgICAgICAgaWYgbm90IHBhdGNoX2pzb24gb3IgbGVuKHBh dGNoX2pzb24pID09IDA6CiAgICAgICAgICAgICByZXR1cm4gTm9uZQogICAgICAgICByZXR1cm4g cGF0Y2hfanNvbi5nZXQoc3RyKHBhdGNoX2lkKSkKQEAgLTU4Miw3ICs1ODYsMTEgQEAgY2xhc3Mg QnVnemlsbGFNaXhpbihvYmplY3QpOgogICAgICAgICBidWcgPSBzZWxmLmZldGNoX2RhdGFfZnJv bV91cmxfd2l0aF9hdXRoZW50aWNhdGlvbihidWdfdXJsKQogICAgICAgICBpZiBub3QgYnVnOgog ICAgICAgICAgICAgcmV0dXJuIE5vbmUKLSAgICAgICAgYnVnc19qc29uID0gYnVnLmpzb24oKS5n ZXQoJ2J1Z3MnKQorICAgICAgICB0cnk6CisgICAgICAgICAgICBidWdzX2pzb24gPSBidWcuanNv bigpLmdldCgnYnVncycpCisgICAgICAgIGV4Y2VwdCBFeGNlcHRpb24gYXMgZToKKyAgICAgICAg ICAgIHByaW50KCdGYWlsZWQgdG8gZmV0Y2ggYnVnIGpzb24gZnJvbSB7fSwgZXJyb3I6IHt9Jy5m b3JtYXQoYnVnX3VybCwgZSkpCisgICAgICAgICAgICByZXR1cm4gTm9uZQogICAgICAgICBpZiBu b3QgYnVnc19qc29uIG9yIGxlbihidWdzX2pzb24pID09IDA6CiAgICAgICAgICAgICByZXR1cm4g Tm9uZQogICAgICAgICByZXR1cm4gYnVnc19qc29uWzBdCg==