224332 2021-04-08 11:45:18 -0700 Remove virtual from RenderBox::availableLogicalWidth 2021-04-08 13:47:13 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis changseok darin esprehn+autocc ews-watchlist glenn kondapallykalyan pdr webkit-bug-importer oldest_to_newest 1748394 0 rbuis 2021-04-08 11:45:18 -0700 Remove virtual from RenderBox::availableLogicalWidth since it is not overwritten. 1748396 1 425526 rbuis 2021-04-08 11:46:26 -0700 Created attachment 425526 Patch 1748433 2 425526 darin 2021-04-08 12:50:32 -0700 Comment on attachment 425526 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425526&action=review > Source/WebCore/ChangeLog:9 > + it is not overwritten. overwritten -> overridden 1748435 3 425526 rbuis 2021-04-08 12:53:39 -0700 Comment on attachment 425526 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425526&action=review >> Source/WebCore/ChangeLog:9 >> + it is not overwritten. > > overwritten -> overridden Thanks, was doing too many things at once. I think for mistakes like this it would be nice to be able to edit the commit message and spare the re-upload. 1748438 4 425535 rbuis 2021-04-08 12:56:24 -0700 Created attachment 425535 Patch 1748457 5 ews-feeder 2021-04-08 13:46:29 -0700 Committed r275675 (236311@main): <https://commits.webkit.org/236311@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425535. 1748459 6 webkit-bug-importer 2021-04-08 13:47:13 -0700 <rdar://problem/76419632> 425526 2021-04-08 11:46:26 -0700 2021-04-08 12:56:18 -0700 Patch bug-224332-20210408204625.patch text/plain 1513 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjU2NDAyYmZjY2RiZmFj NWU4NWE4MWYzYTFjYWRiOWE0YmI5ZjJhMi4uZmUxZDVmNDFlZGE4MmU3N2ViYjc1NzA5YjRiMTc3 ODM4YzUyYTRjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA0LTA4ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHZpcnR1YWwgZnJvbSBS ZW5kZXJCb3g6OmF2YWlsYWJsZUxvZ2ljYWxXaWR0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MzMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHZpcnR1YWwgZnJvbSBSZW5kZXJCb3g6OmF2 YWlsYWJsZUxvZ2ljYWxXaWR0aCBzaW5jZQorICAgICAgICBpdCBpcyBub3Qgb3ZlcndyaXR0ZW4u CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94Lmg6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJCb3g6OmF2YWlsYWJsZUxvZ2ljYWxXaWR0aCBjb25zdCk6CisKIDIwMjEtMDQtMDggIEFu dHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmVydCByMjczNjIx IGJlY2F1c2UgaVBob25lIFBMVCByZWdyZXNzaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQm94LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Qm94LmgKaW5kZXggOGVlMTFhMzgxYTMxZmY4N2IzYjBiZTk3YmZlYTM0NDEwODZhN2NmNC4uOTM3 NjM0M2MxYmFjYmQwNTVjNWNjMDUyZWJhMWZiMjcwMjk5MTdlMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCb3guaApAQCAtNDU2LDcgKzQ1Niw3IEBAIG92ZXJyaWRlOwogCiAgICAgT3B0 aW9uYWw8TGF5b3V0VW5pdD4gY29tcHV0ZVBlcmNlbnRhZ2VMb2dpY2FsSGVpZ2h0KGNvbnN0IExl bmd0aCYgaGVpZ2h0KSBjb25zdDsKIAotICAgIHZpcnR1YWwgTGF5b3V0VW5pdCBhdmFpbGFibGVM b2dpY2FsV2lkdGgoKSBjb25zdCB7IHJldHVybiBjb250ZW50TG9naWNhbFdpZHRoKCk7IH0KKyAg ICBMYXlvdXRVbml0IGF2YWlsYWJsZUxvZ2ljYWxXaWR0aCgpIGNvbnN0IHsgcmV0dXJuIGNvbnRl bnRMb2dpY2FsV2lkdGgoKTsgfQogICAgIHZpcnR1YWwgTGF5b3V0VW5pdCBhdmFpbGFibGVMb2dp Y2FsSGVpZ2h0KEF2YWlsYWJsZUxvZ2ljYWxIZWlnaHRUeXBlKSBjb25zdDsKICAgICBMYXlvdXRV bml0IGF2YWlsYWJsZUxvZ2ljYWxIZWlnaHRVc2luZyhjb25zdCBMZW5ndGgmLCBBdmFpbGFibGVM b2dpY2FsSGVpZ2h0VHlwZSkgY29uc3Q7CiAgICAgCg== 425535 2021-04-08 12:56:24 -0700 2021-04-08 13:46:30 -0700 Patch bug-224332-20210408215622.patch text/plain 1502 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NjcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjYzMDA5NDcwNTVhOWQx N2E4Y2U5N2RlZDFjYTI3NWM3NDgwODg3MS4uODAwZmE2OTA2NDIyMTM3ODI0OTg5YTljMTAyNWQx NmIyNzM2NWY5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA0LTA4ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHZpcnR1YWwgZnJvbSBS ZW5kZXJCb3g6OmF2YWlsYWJsZUxvZ2ljYWxXaWR0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MzMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCisKKyAgICAgICAgUmVtb3ZlIHZpcnR1YWwgZnJvbSBSZW5kZXJCb3g6OmF2YWls YWJsZUxvZ2ljYWxXaWR0aCBzaW5jZQorICAgICAgICBpdCBpcyBub3Qgb3ZlcnJpZGRlbi4KKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3guaDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckJveDo6YXZhaWxhYmxlTG9naWNhbFdpZHRoIGNvbnN0KToKKwogMjAyMS0wNC0wOCAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIE9mZmxpbmVBdWRpb0NvbnRleHQg b2JqZWN0cyBhcmUgbGVha2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJveC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCmluZGV4 IDhlZTExYTM4MWEzMWZmODdiM2IwYmU5N2JmZWEzNDQxMDg2YTdjZjQuLjkzNzYzNDNjMWJhY2Jk MDU1YzVjYzA1MmViYTFmYjI3MDI5OTE3ZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCb3guaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Qm94LmgKQEAgLTQ1Niw3ICs0NTYsNyBAQCBvdmVycmlkZTsKIAogICAgIE9wdGlvbmFsPExheW91 dFVuaXQ+IGNvbXB1dGVQZXJjZW50YWdlTG9naWNhbEhlaWdodChjb25zdCBMZW5ndGgmIGhlaWdo dCkgY29uc3Q7CiAKLSAgICB2aXJ0dWFsIExheW91dFVuaXQgYXZhaWxhYmxlTG9naWNhbFdpZHRo KCkgY29uc3QgeyByZXR1cm4gY29udGVudExvZ2ljYWxXaWR0aCgpOyB9CisgICAgTGF5b3V0VW5p dCBhdmFpbGFibGVMb2dpY2FsV2lkdGgoKSBjb25zdCB7IHJldHVybiBjb250ZW50TG9naWNhbFdp ZHRoKCk7IH0KICAgICB2aXJ0dWFsIExheW91dFVuaXQgYXZhaWxhYmxlTG9naWNhbEhlaWdodChB dmFpbGFibGVMb2dpY2FsSGVpZ2h0VHlwZSkgY29uc3Q7CiAgICAgTGF5b3V0VW5pdCBhdmFpbGFi bGVMb2dpY2FsSGVpZ2h0VXNpbmcoY29uc3QgTGVuZ3RoJiwgQXZhaWxhYmxlTG9naWNhbEhlaWdo dFR5cGUpIGNvbnN0OwogICAgIAo=