224313 2021-04-07 16:53:08 -0700 Copy-constructed Vectors should not have excess capacity 2021-04-08 09:14:10 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224159 InRadar P2 Normal --- 1 simon.fraser simon.fraser benjamin cdumez cmarcelo darin ews-watchlist simon.fraser webkit-bug-importer ysuzuki oldest_to_newest 1748149 0 simon.fraser 2021-04-07 16:53:08 -0700 Copy-constructed Vectors should not have excess capacity 1748151 1 425456 simon.fraser 2021-04-07 16:55:08 -0700 Created attachment 425456 Patch 1748154 2 webkit-bug-importer 2021-04-07 16:59:43 -0700 <rdar://problem/76372593> 1748161 3 simon.fraser 2021-04-07 17:08:02 -0700 I'm perf-testing this change, which will take a while. 1748177 4 darin 2021-04-07 18:42:25 -0700 That’s great! I will be shocked if it slows something down. 1748306 5 simon.fraser 2021-04-08 08:44:53 -0700 *** Bug 224159 has been marked as a duplicate of this bug. *** 1748316 6 ews-feeder 2021-04-08 09:14:07 -0700 Committed r275658 (236294@main): <https://commits.webkit.org/236294@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425456. 425456 2021-04-07 16:55:08 -0700 2021-04-08 09:14:09 -0700 Patch bug-224313-20210407165508.patch text/plain 4379 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNhZjU0OTRkYzg2ZGIzZGZkZmI5MWVl YzBjNjk2ZWFhMTIzM2Q4NGMuLjRjMGM0ZDRhNDk0M2Y1NTdjMzNlYzMwNjI4NTgzZjAwYTA3NzVh MTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDQtMDcgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ29weS1jb25zdHJ1Y3RlZCBWZWN0b3JzIHNo b3VsZCBub3QgaGF2ZSBleGNlc3MgY2FwYWNpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDMxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gY29weS1jb25zdHJ1Y3RpbmcgYSBWZWN0b3I8Piwg c2V0IHRoZSBjYXBhY2l0eSB0byB0aGUgc2l6ZSBvZiB0aGUgaW5wdXQuCisgICAgICAgIFRoaXMg YXZvaWRzIHdhc3RlZCB2ZWN0b3IgY2FwYWNpdHkgYXQgY2FsbCBzaXRlcyB0aGF0IGR5bmFtaWNh bGx5IGJ1aWxkIHZlY3RvcnMKKyAgICAgICAgYW5kIHRoZW4gY29weSB0aGVtIGludG8gcmVhZC1v bmx5IGNhY2hlcy4KKworICAgICAgICAqIHd0Zi9WZWN0b3IuaDoKKyAgICAgICAgKFdURjo6TWFs bG9jPjo6VmVjdG9yKToKKwogMjAyMS0wNC0wNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBw bGUuY29tPgogCiAgICAgICAgIFtKU0NdIFVzZSBGaXhlZFZlY3RvciBtb3JlIGluIGJ5dGVjb2Rl IGRpciBhbmQgSnVtcFRhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9WZWN0b3IuaCBi L1NvdXJjZS9XVEYvd3RmL1ZlY3Rvci5oCmluZGV4IDFjOThjMGQ5MjlhNzBhZDQyN2MzODk2MTA3 NGUyNGM1YWI3OWQyMDMuLjVhNzkxYmIzMjc1ZDlmZWQzYjQwMjU5OTZmNGI1NTI5MjIwMDUwMzMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1ZlY3Rvci5oCisrKyBiL1NvdXJjZS9XVEYvd3Rm L1ZlY3Rvci5oCkBAIC04OTEsNyArODkxLDcgQEAgcHJpdmF0ZToKIAogdGVtcGxhdGU8dHlwZW5h bWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5LCB0eXBlbmFtZSBPdmVyZmxvd0hhbmRsZXIsIHNp emVfdCBtaW5DYXBhY2l0eSwgdHlwZW5hbWUgTWFsbG9jPgogVmVjdG9yPFQsIGlubGluZUNhcGFj aXR5LCBPdmVyZmxvd0hhbmRsZXIsIG1pbkNhcGFjaXR5LCBNYWxsb2M+OjpWZWN0b3IoY29uc3Qg VmVjdG9yJiBvdGhlcikKLSAgICA6IEJhc2Uob3RoZXIuY2FwYWNpdHkoKSwgb3RoZXIuc2l6ZSgp KQorICAgIDogQmFzZShvdGhlci5zaXplKCksIG90aGVyLnNpemUoKSkKIHsKICAgICBhc2FuU2V0 SW5pdGlhbEJ1ZmZlclNpemVUbyhvdGhlci5zaXplKCkpOwogCkBAIC05MDIsNyArOTAyLDcgQEAg VmVjdG9yPFQsIGlubGluZUNhcGFjaXR5LCBPdmVyZmxvd0hhbmRsZXIsIG1pbkNhcGFjaXR5LCBN YWxsb2M+OjpWZWN0b3IoY29uc3QgVmUKIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHNpemVfdCBpbmxp bmVDYXBhY2l0eSwgdHlwZW5hbWUgT3ZlcmZsb3dIYW5kbGVyLCBzaXplX3QgbWluQ2FwYWNpdHks IHR5cGVuYW1lIE1hbGxvYz4KIHRlbXBsYXRlPHNpemVfdCBvdGhlckNhcGFjaXR5LCB0eXBlbmFt ZSBvdGhlck92ZXJmbG93QmVoYXZpb3VyLCBzaXplX3Qgb3RoZXJNaW5pbXVtQ2FwYWNpdHksIHR5 cGVuYW1lIE90aGVyTWFsbG9jPgogVmVjdG9yPFQsIGlubGluZUNhcGFjaXR5LCBPdmVyZmxvd0hh bmRsZXIsIG1pbkNhcGFjaXR5LCBNYWxsb2M+OjpWZWN0b3IoY29uc3QgVmVjdG9yPFQsIG90aGVy Q2FwYWNpdHksIG90aGVyT3ZlcmZsb3dCZWhhdmlvdXIsIG90aGVyTWluaW11bUNhcGFjaXR5LCBP dGhlck1hbGxvYz4mIG90aGVyKQotICAgIDogQmFzZShvdGhlci5jYXBhY2l0eSgpLCBvdGhlci5z aXplKCkpCisgICAgOiBCYXNlKG90aGVyLnNpemUoKSwgb3RoZXIuc2l6ZSgpKQogewogICAgIGFz YW5TZXRJbml0aWFsQnVmZmVyU2l6ZVRvKG90aGVyLnNpemUoKSk7CiAKZGlmZiAtLWdpdCBhL1Rv b2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4ZTI3ZWIwY2ZkZTdkOWE2NGFj MmM4N2Q5YmVjNDlhZGNiZDdjZDIyLi4zYjNjYTcwY2Y1ZjZkZGI1YjhjNWYyYTU5Yzg2N2YxMTJm OTZkODA5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDQtMDcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNl ckBhcHBsZS5jb20+CisKKyAgICAgICAgQ29weS1jb25zdHJ1Y3RlZCBWZWN0b3JzIHNob3VsZCBu b3QgaGF2ZSBleGNlc3MgY2FwYWNpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyNDMxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5ldyBBUEkgdGVzdHMgZm9yIHRlc3RpbmcgY2FwYWNpdHkgb24gY29w eS1jb25zdHJ1Y3QsIHdpdGggdGVzdHMgZm9yIGNvcHktY29uc3RydWN0aW5nCisgICAgICAgIHdp dGggdmFyaW91cyBjb25maWdzIG9mIGlubGluZSBjYXBhY2l0eS4KKworICAgICAgICAqIFRlc3RX ZWJLaXRBUEkvVGVzdHMvV1RGL1ZlY3Rvci5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpU RVNUKToKKwogMjAyMS0wNC0wNyAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+ CiAKICAgICAgICAgW3dlYmtpdHNjbXB5XSBIYW5kbGUgbXVsdGlwbGUgZG91YmxlLWJyYW5jaCBj b21taXRzCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9WZWN0b3Iu Y3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvVmVjdG9yLmNwcAppbmRleCA1NTky MGQ4ZWY2MDAzOWE4NDg5NDhiMjQxNDEyNzA5ZTNlZmM1NDM4Li44YzYxZmQ5ZGRjZWJkOTk4MGNj NDU3YmU0OTljNzNjNjdkYzA0OTZjIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dURi9WZWN0b3IuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1Zl Y3Rvci5jcHAKQEAgLTE3Niw2ICsxNzYsMTUgQEAgVEVTVChXVEZfVmVjdG9yLCBDb25zdHJ1Y3RX aXRoRnJvbU1vdmVPbmx5KQogfQogCiBURVNUKFdURl9WZWN0b3IsIEluaXRpYWxpemVGcm9tT3Ro ZXJJbml0aWFsQ2FwYWNpdHkpCit7CisgICAgVmVjdG9yPGludD4gdmVjdG9yID0geyAxLCAzLCAy LCA0LCA1IH07CisgICAgVmVjdG9yPGludD4gdmVjdG9yQ29weSh2ZWN0b3IpOworICAgIEVYUEVD VF9FUSg1VSwgdmVjdG9yLnNpemUoKSk7CisgICAgRVhQRUNUX0VRKDVVLCB2ZWN0b3JDb3B5LnNp emUoKSk7CisgICAgRVhQRUNUX0VRKDVVLCB2ZWN0b3JDb3B5LmNhcGFjaXR5KCkpOworfQorCitU RVNUKFdURl9WZWN0b3IsIEluaXRpYWxpemVGcm9tT3RoZXJJbmxpbmVJbml0aWFsQ2FwYWNpdHkp CiB7CiAgICAgVmVjdG9yPGludCwgMz4gdmVjdG9yID0geyAxLCAzLCAyLCA0IH07CiAgICAgVmVj dG9yPGludCwgNT4gdmVjdG9yQ29weSh2ZWN0b3IpOwpAQCAtMTkyLDYgKzIwMSwyNCBAQCBURVNU KFdURl9WZWN0b3IsIEluaXRpYWxpemVGcm9tT3RoZXJJbml0aWFsQ2FwYWNpdHkpCiAgICAgRVhQ RUNUX0ZBTFNFKHZlY3RvciAhPSB2ZWN0b3JDb3B5KTsKIH0KIAorVEVTVChXVEZfVmVjdG9yLCBJ bml0aWFsaXplRnJvbU90aGVySW5saW5lQmlnVG9TbWFsbEluaXRpYWxDYXBhY2l0eSkKK3sKKyAg ICBWZWN0b3I8aW50LCA1PiB2ZWN0b3IgPSB7IDEsIDMsIDIsIDQgfTsKKyAgICBWZWN0b3I8aW50 LCAzPiB2ZWN0b3JDb3B5KHZlY3Rvcik7CisgICAgRVhQRUNUX0VRKDRVLCB2ZWN0b3Iuc2l6ZSgp KTsKKyAgICBFWFBFQ1RfRVEoNVUsIHZlY3Rvci5jYXBhY2l0eSgpKTsKKyAgICBFWFBFQ1RfRVEo NFUsIHZlY3RvckNvcHkuc2l6ZSgpKTsKKyAgICBFWFBFQ1RfRVEoNFUsIHZlY3RvckNvcHkuY2Fw YWNpdHkoKSk7CisKKyAgICBFWFBFQ1RfRVEoMSwgdmVjdG9yQ29weVswXSk7CisgICAgRVhQRUNU X0VRKDMsIHZlY3RvckNvcHlbMV0pOworICAgIEVYUEVDVF9FUSgyLCB2ZWN0b3JDb3B5WzJdKTsK KyAgICBFWFBFQ1RfRVEoNCwgdmVjdG9yQ29weVszXSk7CisKKyAgICBFWFBFQ1RfVFJVRSh2ZWN0 b3IgPT0gdmVjdG9yQ29weSk7CisgICAgRVhQRUNUX0ZBTFNFKHZlY3RvciAhPSB2ZWN0b3JDb3B5 KTsKK30KKwogVEVTVChXVEZfVmVjdG9yLCBDb3B5RnJvbU90aGVySW5pdGlhbENhcGFjaXR5KQog ewogICAgIFZlY3RvcjxpbnQsIDM+IHZlY3RvciA9IHsgMSwgMywgMiwgNCB9Owo=