224309 2021-04-07 15:31:41 -0700 [WPE] Segfault on atexit handler when loading webkit://gpu 2021-10-08 08:08:36 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=217655 P2 Normal --- 1 aperez csaavedra bugs-noreply cgarcia csaavedra mcatanzaro oldest_to_newest 1748098 0 aperez 2021-04-07 15:31:41 -0700 Steps to reproduce: 1. Run: cog -P fdo webkit://gpu 2. Press Ctrl-W to close Cog (or run “cogctl quit”) Backtrace: (gdb) bt #0 0x00007ffff2dbf744 in wpe_renderer_backend_egl_destroy () at /usr/lib/libwpe-1.0.so.1 #1 0x00007ffff544629c in () at /usr/lib/libWPEWebKit-1.0.so.4 #2 0x00007ffff54462ba in () at /usr/lib/libWPEWebKit-1.0.so.4 #3 0x00007ffff2c2b697 in __run_exit_handlers () at /usr/lib/libc.so.6 #4 0x00007ffff2c2b83e in () at /usr/lib/libc.so.6 #5 0x00007ffff2c13b2c in __libc_start_main () at /usr/lib/libc.so.6 #6 0x000055555555654e in _start () (gdb) While I could try and get a backtrace from a build with debug symbols, it won't add much more. I can see with GDB that wpe_renderer_backend_egl_create() gets called and returns something sensible, but then wpe_renderer_backend_egl_destroy() ends up receiving a null pointer 🤷️ This issue can be reproduced with current ToT of WPE WebKit, libwpe and WPEBackend-fdo; but also with the most recent releases. 1748101 1 aperez 2021-04-07 15:33:51 -0700 Interestingly enough, opening https://duckduckgo.com or anything else over HTTP does not trigger this issue. 1748104 2 aperez 2021-04-07 15:36:54 -0700 (In reply to Adrian Perez from comment #1) > Interestingly enough, opening https://duckduckgo.com or anything > else over HTTP does not trigger this issue. …which makes me wonder whether in the HTTP(s) case the atexit handlers maybe are not even being run, which would make this related to bug #217655 1748497 3 aperez 2021-04-08 15:15:29 -0700 Traceback with a build that has symbols: % lldb -- cog -P fdo webkit://gpu” ... Process 685007 stopped * thread #1, name = 'cog', stop reason = signal SIGSEGV: invalid address (fault address: 0x0) frame #0: 0x00007ffff3e4caa6 libwpe-1.0.so.1`::wpe_renderer_backend_egl_destroy(backend=0x0000000000000000) at renderer-backend-egl.c:58:28 55 { 56 fprintf(stderr, "** %s <- %p\n", __func__, backend); 57 -> 58 backend->base.interface->destroy(backend->base.interface_data); 59 backend->base.interface_data = 0; 60 61 free(backend); (lldb) bt * thread #1, name = 'cog', stop reason = signal SIGSEGV: invalid address (fault address: 0x0) * frame #0: 0x00007ffff3e4caa6 libwpe-1.0.so.1`::wpe_renderer_backend_egl_destroy(backend=0x0000000000000000) at renderer-backend-egl.c:58:28 frame #1: 0x00007ffff59b6bcb libWPEWebKit-1.0.so.3`WebCore::PlatformDisplayLibWPE::~PlatformDisplayLibWPE() [inlined] WebCore::PlatformDisplayLibWPE::~PlatformDisplayLibWPE(this=0x00007fffef6f7240) at PlatformDisplayLibWPE.cpp:71:5 frame #2: 0x00007ffff59b6bb4 libWPEWebKit-1.0.so.3`WebCore::PlatformDisplayLibWPE::~PlatformDisplayLibWPE(this=0x00007fffef6f7240) at PlatformDisplayLibWPE.cpp:70 frame #3: 0x00007ffff597cf52 libWPEWebKit-1.0.so.3`std::unique_ptr<WebCore::PlatformDisplay, std::default_delete<WebCore::PlatformDisplay> >::~unique_ptr() [inlined] std::default_delete<WebCore::PlatformDisplay>::operator(this=<unavailable>, __ptr=<unavailable>)(WebCore::PlatformDisplay*) const at unique_ptr.h:85:2 frame #4: 0x00007ffff597cf4c libWPEWebKit-1.0.so.3`std::unique_ptr<WebCore::PlatformDisplay, std::default_delete<WebCore::PlatformDisplay> >::~unique_ptr(this=0x00007ffff7f5e300) at unique_ptr.h:361 frame #5: 0x00007ffff38ce697 libc.so.6`__run_exit_handlers + 247 frame #6: 0x00007ffff38ce83e libc.so.6`exit + 30 frame #7: 0x00007ffff38b6b2c libc.so.6`__libc_start_main + 220 frame #8: 0x000055555555765e cog`_start + 46 (lldb) 1748501 4 aperez 2021-04-08 15:20:53 -0700 Okay, an observation: The backtrace above is from the UIProcess, which I am quite sure it is NOT expected to instantiate PlatformDisplayLibWPE. This may explain why wpe_renderer_backend_egl_create() is never called in the UIProcess (which is good) but somehow the display object is created and when the atexit handlers run of course they try to destroy an instance that is not all valid. Running “cog -P fdo http://wpewebkit.org” indeed does not instantiate a display object in the UIProcess. 1748509 5 aperez 2021-04-08 15:29:03 -0700 Here's the traceback following up to the of PlatformDisplayLibWPE in the *UIProcess* when running “cog -P fdo webkit://gpu”: Process 686494 stopped * thread #1, name = 'cog', stop reason = breakpoint 3.2 frame #0: 0x00007ffff59b6b34 libWPEWebKit-1.0.so.3`WebCore::PlatformDisplayLibWPE::create() [inlined] WebCore::PlatformDisplayLibWPE::PlatformDisplayLibWPE(this=0x00007fffef6f7240) at PlatformDisplayLibWPE.cpp:62:7 59 } 60 61 PlatformDisplayLibWPE::PlatformDisplayLibWPE() -> 62 : PlatformDisplay(NativeDisplayOwned::No) 63 { 64 #if PLATFORM(GTK) 65 PlatformDisplay::setSharedDisplayForCompositing(*this); (lldb) bt * thread #1, name = 'cog', stop reason = breakpoint 3.2 * frame #0: 0x00007ffff59b6b34 libWPEWebKit-1.0.so.3`WebCore::PlatformDisplayLibWPE::create() [inlined] WebCore::PlatformDisplayLibWPE::PlatformDisplayLibWPE(this=0x00007fffef6f7240) at PlatformDisplayLibWPE.cpp:62:7 frame #1: 0x00007ffff59b6b34 libWPEWebKit-1.0.so.3`WebCore::PlatformDisplayLibWPE::create() at PlatformDisplayLibWPE.cpp:58 frame #2: 0x00007ffff597aadc libWPEWebKit-1.0.so.3`void std::call_once<WebCore::PlatformDisplay::sharedDisplay()::$_0>(std::once_flag&, WebCore::PlatformDisplay::sharedDisplay()::$_0&&)::'lambda0'()::__invoke() [inlined] WebCore::PlatformDisplay::createPlatformDisplay() at PlatformDisplay.cpp:123:12 frame #3: 0x00007ffff597aad7 libWPEWebKit-1.0.so.3`void std::call_once<WebCore::PlatformDisplay::sharedDisplay()::$_0>(std::once_flag&, WebCore::PlatformDisplay::sharedDisplay()::$_0&&)::'lambda0'()::__invoke() [inlined] WebCore::PlatformDisplay::sharedDisplay(this=<unavailable>)::$_0::operator()() const at PlatformDisplay.cpp:143 frame #4: 0x00007ffff597aad7 libWPEWebKit-1.0.so.3`void std::call_once<WebCore::PlatformDisplay::sharedDisplay()::$_0>(std::once_flag&, WebCore::PlatformDisplay::sharedDisplay()::$_0&&)::'lambda0'()::__invoke() [inlined] void std::__invoke_impl<void, WebCore::PlatformDisplay::sharedDisplay()::$_0>(__f=<unavailable>)::$_0&&) at invoke.h:60 frame #5: 0x00007ffff597aad7 libWPEWebKit-1.0.so.3`void std::call_once<WebCore::PlatformDisplay::sharedDisplay()::$_0>(std::once_flag&, WebCore::PlatformDisplay::sharedDisplay()::$_0&&)::'lambda0'()::__invoke() [inlined] std::__invoke_result<WebCore::PlatformDisplay::sharedDisplay()::$_0>::type std::__invoke<WebCore::PlatformDisplay::sharedDisplay(__fn=<unavailable>)::$_0>(WebCore::PlatformDisplay::sharedDisplay()::$_0&&) at invoke.h:95 frame #6: 0x00007ffff597aad7 libWPEWebKit-1.0.so.3`void std::call_once<WebCore::PlatformDisplay::sharedDisplay()::$_0>(std::once_flag&, WebCore::PlatformDisplay::sharedDisplay()::$_0&&)::'lambda0'()::__invoke() [inlined] void std::call_once<WebCore::PlatformDisplay::sharedDisplay()::$_0>(this=<unavailable>)::$_0&&)::'lambda'()::operator()() const at mutex:717 frame #7: 0x00007ffff597aad7 libWPEWebKit-1.0.so.3`void std::call_once<WebCore::PlatformDisplay::sharedDisplay()::$_0>(std::once_flag&, WebCore::PlatformDisplay::sharedDisplay()::$_0&&)::'lambda0'()::__invoke() [inlined] void std::call_once<WebCore::PlatformDisplay::sharedDisplay()::$_0>(this=<unavailable>)::$_0&&)::'lambda0'()::operator()() const at mutex:722 frame #8: 0x00007ffff597aad7 libWPEWebKit-1.0.so.3`void std::call_once<WebCore::PlatformDisplay::sharedDisplay()::$_0>(std::once_flag&, WebCore::PlatformDisplay::sharedDisplay()::$_0&&)::'lambda0'()::__invoke() at mutex:722 frame #9: 0x00007ffff13bfc9f libpthread.so.0`__pthread_once_slow + 191 frame #10: 0x00007ffff5974136 libWPEWebKit-1.0.so.3`WebCore::PlatformDisplay::sharedDisplay() [inlined] __gthread_once(__func=<unavailable>)()) at gthr-default.h:700:12 frame #11: 0x00007ffff5974119 libWPEWebKit-1.0.so.3`WebCore::PlatformDisplay::sharedDisplay() [inlined] void std::call_once<WebCore::PlatformDisplay::sharedDisplay()::$_0>(__once=<unavailable>, __f=0x00007fffffffc258)::$_0&&) at mutex:729 frame #12: 0x00007ffff59740e2 libWPEWebKit-1.0.so.3`WebCore::PlatformDisplay::sharedDisplay() at PlatformDisplay.cpp:142 frame #13: 0x00007ffff59741d3 libWPEWebKit-1.0.so.3`WebCore::GLContext::createOffscreenContext(platformDisplay=<unavailable>) at GLContext.cpp:105:75 frame #14: 0x00007ffff4852e92 libWPEWebKit-1.0.so.3`WebKit::WebKitProtocolHandler::handleGPU(this=<unavailable>, request=0x00005555557dada0) at WebKitProtocolHandler.cpp:366:22 frame #15: 0x00007ffff4852b52 libWPEWebKit-1.0.so.3`WebKit::WebKitProtocolHandler::handleRequest(this=<unavailable>, request=0x00005555557dada0) at WebKitProtocolHandler.cpp:93:9 frame #16: 0x00007ffff4868f31 libWPEWebKit-1.0.so.3`WebKitURISchemeHandler::platformStartTask(this=0x00007fffef6e3000, page=<unavailable>, task=0x00007fffef6ceb40) at WebKitWebContext.cpp:170:9 frame #17: 0x00007ffff47fa8e9 libWPEWebKit-1.0.so.3`WebKit::WebURLSchemeHandler::startTask(this=0x00007fffef6e3000, page=0x00007fffaf2f3000, process=0x00007fffaf4fc340, webPageID=<unavailable>, parameters=0x00007fffffffcc70, completionHandler=0x00007fffffffc620)>&&) at WebURLSchemeHandler.cpp:62:5 frame #18: 0x00007ffff47c33b8 libWPEWebKit-1.0.so.3`WebKit::WebPageProxy::startURLSchemeTaskShared(this=<unavailable>, process=0x00007fffffffc658, webPageID=<unavailable>, parameters=<unavailable>) at WebPageProxy.cpp:9579:22 frame #19: 0x00007ffff47c3234 libWPEWebKit-1.0.so.3`WebKit::WebPageProxy::startURLSchemeTask(this=<unavailable>, parameters=<unavailable>) at WebPageProxy.cpp:9570:5 frame #20: 0x00007ffff45093d5 libWPEWebKit-1.0.so.3`WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) [inlined] void IPC::callMemberFunctionImpl<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebKit::URLSchemeTaskParameters&&), std::tuple<WebKit::URLSchemeTaskParameters>, 0ul>(object=0x00007fffaf2f3000, function=00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00, args=0x00007fffffffcc70)(WebKit::URLSchemeTaskParameters&&), std::tuple<WebKit::URLSchemeTaskParameters>&&, std::integer_sequence<unsigned long, 0ul>) at HandleMessage.h:43:5 frame #21: 0x00007ffff45093c5 libWPEWebKit-1.0.so.3`WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) [inlined] void IPC::callMemberFunction<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebKit::URLSchemeTaskParameters&&), std::tuple<WebKit::URLSchemeTaskParameters>, std::integer_sequence<unsigned long, 0ul> >(args=0x00007fffffffcc70, object=0x00007fffaf2f3000, function=00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00)(WebKit::URLSchemeTaskParameters&&)) at HandleMessage.h:49 frame #22: 0x00007ffff45093c5 libWPEWebKit-1.0.so.3`WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) [inlined] void IPC::handleMessage<Messages::WebPageProxy::StartURLSchemeTask, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebKit::URLSchemeTaskParameters&&)>(decoder=0x00007fffef6d1480, object=0x00007fffaf2f3000, function=00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00)(WebKit::URLSchemeTaskParameters&&)) at HandleMessage.h:121 frame #23: 0x00007ffff4509397 libWPEWebKit-1.0.so.3`WebKit::WebPageProxy::didReceiveMessage(this=0x00007fffaf2f3000, connection=0x00007fffef6cd168, decoder=0x00007fffef6d1480) at WebPageProxyMessageReceiver.cpp:1602 frame #24: 0x00007ffff47103a8 libWPEWebKit-1.0.so.3`IPC::MessageReceiverMap::dispatchMessage(this=<unavailable>, connection=0x00007fffef6cd168, decoder=0x00007fffef6d1480) at MessageReceiverMap.cpp:0 frame #25: 0x00007ffff47f538a libWPEWebKit-1.0.so.3`non-virtual thunk to WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) [inlined] WebKit::WebProcessProxy::didReceiveMessage(this=0x00007fffaf4fc340, connection=0x00007fffef6cd168, decoder=0x00007fffef6d1480) at WebProcessProxy.cpp:819:9 frame #26: 0x00007ffff47f5382 libWPEWebKit-1.0.so.3`non-virtual thunk to WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) at WebProcessProxy.cpp:0 frame #27: 0x00007ffff470951e libWPEWebKit-1.0.so.3`IPC::Connection::dispatchMessage(this=<unavailable>, decoder=0x00007fffef6d1480) at Connection.cpp:1020:14 frame #28: 0x00007ffff470981d libWPEWebKit-1.0.so.3`IPC::Connection::dispatchMessage(this=0x00007fffef6cd168, message=0x7fffef6d1480) at Connection.cpp:1065:9 frame #29: 0x00007ffff4708bce libWPEWebKit-1.0.so.3`IPC::Connection::dispatchIncomingMessages(this=0x00007fffef6cd168) at Connection.cpp:1169:5 frame #30: 0x00007ffff70fb3d0 libWPEWebKit-1.0.so.3`WTF::RunLoop::performWork() [inlined] WTF::Function<void ()>::operator(this=<unavailable>)() const at Function.h:83:35 frame #31: 0x00007ffff70fb3c7 libWPEWebKit-1.0.so.3`WTF::RunLoop::performWork(this=0x00007fffef6f9000) at RunLoop.cpp:133 frame #32: 0x00007ffff71593e6 libWPEWebKit-1.0.so.3`WTF::RunLoop::RunLoop()::$_1::__invoke(void*) [inlined] WTF::RunLoop::RunLoop(this=<unavailable>, userData=<unavailable>)::$_1::operator()(void*) const at RunLoopGLib.cpp:80:42 frame #33: 0x00007ffff71593e1 libWPEWebKit-1.0.so.3`WTF::RunLoop::RunLoop(userData=0x00007fffef6f9000)::$_1::__invoke(void*) at RunLoopGLib.cpp:79 frame #34: 0x00007ffff715885a libWPEWebKit-1.0.so.3`WTF::RunLoop::$_0::__invoke(_GSource*, int (*)(void*), void*) [inlined] WTF::RunLoop::$_0::operator(this=<unavailable>, source=0x0000555555589460, callback=(libWPEWebKit-1.0.so.3`WTF::RunLoop::RunLoop()::$_1::__invoke(void*) at RunLoopGLib.cpp:79), userData=0x00007fffef6f9000)(_GSource*, int (*)(void*), void*) const at RunLoopGLib.cpp:53:28 frame #35: 0x00007ffff7158821 libWPEWebKit-1.0.so.3`WTF::RunLoop::$_0::__invoke(source=0x0000555555589460, callback=(libWPEWebKit-1.0.so.3`WTF::RunLoop::RunLoop()::$_1::__invoke(void*) at RunLoopGLib.cpp:79), userData=0x00007fffef6f9000)(void*), void*) at RunLoopGLib.cpp:45 frame #36: 0x00007ffff3aaff30 libglib-2.0.so.0`g_main_context_dispatch + 352 frame #37: 0x00007ffff3b03b59 libglib-2.0.so.0`___lldb_unnamed_symbol449$$libglib-2.0.so.0 + 521 frame #38: 0x00007ffff3aad781 libglib-2.0.so.0`g_main_context_iteration + 49 frame #39: 0x00007ffff3cba22e libgio-2.0.so.0`g_application_run + 462 frame #40: 0x000055555555760c cog`main(argc=4, argv=0x00007fffffffd6f8) at cog.c:457:12 frame #41: 0x00007ffff38b6b25 libc.so.6`__libc_start_main + 213 frame #42: 0x000055555555765e cog`_start + 46 (lldb) 1748513 6 mcatanzaro 2021-04-08 15:33:08 -0700 (In reply to Adrian Perez from comment #4) > Okay, an observation: The backtrace above is from the UIProcess, which > I am quite sure it is NOT expected to instantiate PlatformDisplayLibWPE. Hm, I think that's only true for GTK port, where the PlatformDisplayLibWPE is created in WebProcess::platformInitializeWebProcess, and PlatformDisplay::createPlatformDisplay should never create a PlatformDisplayLibWPE. But this is a WPE port bug. For WPE port, PlatformDisplay::createPlatformDisplay is always going to create a PlatformDisplayLibWPE, and PlatformDisplay::sharedDisplay is routinely used in the UI process. 1748521 7 aperez 2021-04-08 15:45:10 -0700 So, loading webkit://gpu creates a GL context, which in turn lazily creates a PlatformDisplayLibWPE singleton by means of a call to the PlatformDisplay::sharedDisplay() function. The thing here is that PlatformDisplayLibWPE::initialize() never gets called, so its m_backend point is never set to a non-NULL value. OTOH, PlatformDisplay::initializeEGLDisplay() does get called, and there is where the atexit() call is done. 1802023 8 440602 csaavedra 2021-10-08 07:08:14 -0700 Created attachment 440602 Patch 1802060 9 440602 aperez 2021-10-08 08:04:41 -0700 Comment on attachment 440602 Patch rs=me :) 1802063 10 csaavedra 2021-10-08 08:08:36 -0700 Committed r283801 (242694@main): <https://commits.webkit.org/242694@main> 440602 2021-10-08 07:08:14 -0700 2021-10-08 07:30:27 -0700 Patch bug-224309-20211008170813.patch text/plain 2471 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzNzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ3YWViNzRhMmZjOGEy YWVkNWY5ZmU3MzE2MzM3MWUwZmM4ZWU1MC4uM2JmNmQyZTI4Y2E2ZTZhMWFlY2I0NDg3MTcyN2I0 OTExYzA5OWYwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTEwLTA4ICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0xpYldQRV0g RG8gbm90IGRlc3Ryb3kgRUdMIGJhY2tlbmQgaWYgbm90IGNyZWF0ZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDMwOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGFib3V0OmdwdSB3aWxsIGNyZWF0ZSBh IFBsYXRmb3JtRGlzcGxheSB0byBmaWxsIGluIEdQVQorICAgICAgICBpbmZvcm1hdGlvbiwgYnV0 IHRoaXMgZG9lc24ndCBjYWxsCisgICAgICAgIExpYldQRVBsYXRmb3JtRGlzcGxheTo6aW5pdGlh bGl6ZSgpIGFzIGl0IGRvZXNuJ3QgbmVlZCB0bywgc28gdGhlCisgICAgICAgIGJhY2tlbmQgbWVt YmVyIGlzIG5vdCBpbml0aWFsaXplZC4gTWFrZSBzdXJlIHRoYXQgdGhlIGJhY2tlbmQgaXMKKyAg ICAgICAgbm90IGEgbnVsbHB0ciBiZWZvcmUgYXR0ZW1wdGluZyB0byBkZXN0cm95IGl0IHdoZW4g dGhlIGRpc3BsYXkgaXMKKyAgICAgICAgZGVzdHJveWVkLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvbGlid3BlL1BsYXRmb3JtRGlzcGxheUxpYldQRS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpQbGF0Zm9ybURpc3BsYXlMaWJXUEU6On5QbGF0Zm9ybURpc3BsYXlMaWJXUEUpOgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2xpYndwZS9QbGF0Zm9ybURpc3BsYXlMaWJXUEUuaDoK KwogMjAyMS0xMC0wOCAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgog CiAgICAgICAgIGZvbnQtZmFtaWxpZXMgaW5zaWRlIEBmb250LXBhbGV0dGUtdmFsdWVzIG5lZWQg dG8gYmUgY2FzZSBpbnNlbnNpdGl2ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvbGlid3BlL1BsYXRmb3JtRGlzcGxheUxpYldQRS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9saWJ3cGUvUGxhdGZvcm1EaXNwbGF5TGliV1BFLmNwcApp bmRleCBiMjEyY2QxNGE5OGMwYmRlNWQ1NzUyZGFlODc1OGYxODkxMTdlODcxLi5kYTJkOTQ1OTIz ZDNjZTJjODBlZWUxM2FkNmUyODA1NzUwNzRkZWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9saWJ3cGUvUGxhdGZvcm1EaXNwbGF5TGliV1BFLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9saWJ3cGUvUGxhdGZvcm1EaXNwbGF5 TGliV1BFLmNwcApAQCAtNjgsNyArNjgsOCBAQCBQbGF0Zm9ybURpc3BsYXlMaWJXUEU6OlBsYXRm b3JtRGlzcGxheUxpYldQRSgpCiAKIFBsYXRmb3JtRGlzcGxheUxpYldQRTo6flBsYXRmb3JtRGlz cGxheUxpYldQRSgpCiB7Ci0gICAgd3BlX3JlbmRlcmVyX2JhY2tlbmRfZWdsX2Rlc3Ryb3kobV9i YWNrZW5kKTsKKyAgICBpZiAobV9iYWNrZW5kKQorICAgICAgICB3cGVfcmVuZGVyZXJfYmFja2Vu ZF9lZ2xfZGVzdHJveShtX2JhY2tlbmQpOwogfQogCiBib29sIFBsYXRmb3JtRGlzcGxheUxpYldQ RTo6aW5pdGlhbGl6ZShpbnQgaG9zdEZkKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvbGlid3BlL1BsYXRmb3JtRGlzcGxheUxpYldQRS5oIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbGlid3BlL1BsYXRmb3JtRGlzcGxheUxpYldQRS5oCmlu ZGV4IGEzODI0NDU3NWMwMDcxYmUyY2UxMDM1ODJjNDYwYTczMzRjMzEzOGMuLjlhOGQyMjZhYTAx ZmYxZjU3ZDFmM2MyMjA2Zjk5YjBmYzUyMzdhNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2xpYndwZS9QbGF0Zm9ybURpc3BsYXlMaWJXUEUuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9saWJ3cGUvUGxhdGZvcm1EaXNwbGF5TGli V1BFLmgKQEAgLTQ4LDcgKzQ4LDcgQEAgcHJpdmF0ZToKIAogICAgIFR5cGUgdHlwZSgpIGNvbnN0 IG92ZXJyaWRlIHsgcmV0dXJuIFBsYXRmb3JtRGlzcGxheTo6VHlwZTo6V1BFOyB9CiAKLSAgICBz dHJ1Y3Qgd3BlX3JlbmRlcmVyX2JhY2tlbmRfZWdsKiBtX2JhY2tlbmQ7CisgICAgc3RydWN0IHdw ZV9yZW5kZXJlcl9iYWNrZW5kX2VnbCogbV9iYWNrZW5kIHsgbnVsbHB0ciB9OwogfTsKIAogfSAv LyBuYW1lc3BhY2UgV2ViQ29yZQo=