<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>224283</bug_id>
          
          <creation_ts>2021-04-07 08:44:05 -0700</creation_ts>
          <short_desc>[CMake] Mark _LIBRARY not _LIBRARIES in find modules</short_desc>
          <delta_ts>2021-04-07 09:26:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CMake</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Don Olmstead">don.olmstead</reporter>
          <assigned_to name="Don Olmstead">don.olmstead</assigned_to>
          <cc>annulen</cc>
    
    <cc>aperez</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>sergio</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1747895</commentid>
    <comment_count>0</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2021-04-07 08:44:05 -0700</bug_when>
    <thetext>For migrated find modules _LIBRARY should be marked and then used in _LIBRARIES.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1747897</commentid>
    <comment_count>1</comment_count>
      <attachid>425400</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2021-04-07 08:49:06 -0700</bug_when>
    <thetext>Created attachment 425400
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1747920</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-04-07 09:26:42 -0700</bug_when>
    <thetext>Committed r275608: &lt;https://commits.webkit.org/r275608&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425400.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>425400</attachid>
            <date>2021-04-07 08:49:06 -0700</date>
            <delta_ts>2021-04-07 09:26:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-224283.diff</filename>
            <type>text/plain</type>
            <size>2215</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBlMjA1OTQxOGJmOTIuLjZi
NzQxMWJhZmQzMCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE3IEBACisyMDIxLTA0LTA3ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5j
b20+CisKKyAgICAgICAgW0NNYWtlXSBNYXJrIF9MSUJSQVJZIG5vdCBfTElCUkFSSUVTIGluIGZp
bmQgbW9kdWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MjI0MjgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgQSBmZXcgZmluZCBtb2R1bGVzIGFyZSBlcnJvbmlvdXNseSBzZW5kaW5nIF9MSUJSQVJJRVMg
dG8gbWFya19hc19hZHZhbmNlZCByYXRoZXIgdGhhbgorICAgICAgICBfTElCUkFSWS4gVGhlIGZv
cm1lciBpcyBjcmVhdGVkIGZyb20gdGhlIF9MSUJSQVJZIHZhbHVlIHNvIGl0IGlzbid0IHZhbGlk
IGF0IHRoYXQgcG9pbnQuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZENhaXJvLmNtYWtl
OgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kRm9udGNvbmZpZy5jbWFrZToKKyAgICAgICAg
KiBTb3VyY2UvY21ha2UvRmluZFNRTGl0ZTMuY21ha2U6CisKIDIwMjEtMDQtMDcgIEtpbW1vIEtp
bm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KIAogICAgICAgICAuZ2l0aWdub3JlIGNvbnRh
aW5zICdidWlsZC8nIHdoaWNoIGNhdXNlcyBhbGwgZGlyZWN0b3JpZXMgbmFtZWQgJ2J1aWxkLycg
dG8gYmUgaWdub3JlZApkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL0ZpbmRDYWlyby5jbWFrZSBi
L1NvdXJjZS9jbWFrZS9GaW5kQ2Fpcm8uY21ha2UKaW5kZXggYTliNjM3MDc2Y2MyLi5jNWE0YTgy
NDJiYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9GaW5kQ2Fpcm8uY21ha2UKKysrIGIvU291
cmNlL2NtYWtlL0ZpbmRDYWlyby5jbWFrZQpAQCAtMTAxLDcgKzEwMSw3IEBAIGlmIChDYWlyb19M
SUJSQVJZIEFORCBOT1QgVEFSR0VUIENhaXJvOjpDYWlybykKICAgICApCiBlbmRpZiAoKQogCi1t
YXJrX2FzX2FkdmFuY2VkKENhaXJvX0lOQ0xVREVfRElSIENhaXJvX0xJQlJBUklFUykKK21hcmtf
YXNfYWR2YW5jZWQoQ2Fpcm9fSU5DTFVERV9ESVIgQ2Fpcm9fTElCUkFSWSkKIAogaWYgKENhaXJv
X0ZPVU5EKQogICAgIHNldChDYWlyb19MSUJSQVJJRVMgJHtDYWlyb19MSUJSQVJZfSkKZGlmZiAt
LWdpdCBhL1NvdXJjZS9jbWFrZS9GaW5kRm9udGNvbmZpZy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9G
aW5kRm9udGNvbmZpZy5jbWFrZQppbmRleCA0NDk1NDQxMWVkYzQuLmJkNDRlNmQ2ODdjMCAxMDA2
NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRGb250Y29uZmlnLmNtYWtlCisrKyBiL1NvdXJjZS9j
bWFrZS9GaW5kRm9udGNvbmZpZy5jbWFrZQpAQCAtMTAzLDcgKzEwMyw3IEBAIGlmIChGb250Y29u
ZmlnX0xJQlJBUlkgQU5EIE5PVCBUQVJHRVQgRm9udGNvbmZpZzo6Rm9udGNvbmZpZykKICAgICAp
CiBlbmRpZiAoKQogCi1tYXJrX2FzX2FkdmFuY2VkKEZvbnRjb25maWdfSU5DTFVERV9ESVIgRm9u
dGNvbmZpZ19MSUJSQVJJRVMpCittYXJrX2FzX2FkdmFuY2VkKEZvbnRjb25maWdfSU5DTFVERV9E
SVIgRm9udGNvbmZpZ19MSUJSQVJZKQogCiBpZiAoRm9udGNvbmZpZ19GT1VORCkKICAgICBzZXQo
Rm9udGNvbmZpZ19MSUJSQVJJRVMgJHtGb250Y29uZmlnX0xJQlJBUll9KQpkaWZmIC0tZ2l0IGEv
U291cmNlL2NtYWtlL0ZpbmRTUUxpdGUzLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRTUUxpdGUz
LmNtYWtlCmluZGV4IGEyYTVjMDBhYTNlOC4uODAzZjJmYWI2ZDgxIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvY21ha2UvRmluZFNRTGl0ZTMuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL0ZpbmRTUUxpdGUz
LmNtYWtlCkBAIC05Niw3ICs5Niw3IEBAIGlmIChTUUxpdGUzX0xJQlJBUlkgQU5EIE5PVCBUQVJH
RVQgU1FMaXRlOjpTUUxpdGUzKQogICAgICkKIGVuZGlmICgpCiAKLW1hcmtfYXNfYWR2YW5jZWQo
U1FMaXRlM19JTkNMVURFX0RJUiBTUUxpdGUzX0xJQlJBUklFUykKK21hcmtfYXNfYWR2YW5jZWQo
U1FMaXRlM19JTkNMVURFX0RJUiBTUUxpdGUzX0xJQlJBUlkpCiAKIGlmIChTUUxpdGUzX0ZPVU5E
KQogICAgIHNldChTUUxpdGUzX0xJQlJBUklFUyAke1NRTGl0ZTNfTElCUkFSWX0pCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>