224266 2021-04-06 21:10:35 -0700 Wasted vector capacity under CSSFontFace::setUnicodeRange() 2021-04-07 15:48:33 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser esprehn+autocc ews-watchlist glenn gyuyoung.kim hi macpherson menard mmaxfield simon.fraser webkit-bug-importer oldest_to_newest 1747762 0 simon.fraser 2021-04-06 21:10:35 -0700 Wasted vector capacity under CSSFontFace::setUnicodeRange() 1747763 1 425352 simon.fraser 2021-04-06 21:11:06 -0700 Created attachment 425352 Patch 1747929 2 425352 hi 2021-04-07 09:54:30 -0700 Comment on attachment 425352 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425352&action=review r=me > Source/WebCore/css/CSSFontFace.cpp:274 > auto& list = downcast<CSSValueList>(unicodeRange); What about using `map` instead? ``` auto ranges = WTF::map(downcast<CSSValueList>(unicodeRange), [] (auto& rangeValue) -> UnicodeRange { return { range.from(), range.to() }; }); ``` 1748102 3 simon.fraser 2021-04-07 15:33:58 -0700 (In reply to Devin Rousso from comment #2) > Comment on attachment 425352 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=425352&action=review > > r=me > > > Source/WebCore/css/CSSFontFace.cpp:274 > > auto& list = downcast<CSSValueList>(unicodeRange); > > What about using `map` instead? > ``` > auto ranges = WTF::map(downcast<CSSValueList>(unicodeRange), [] (auto& > rangeValue) -> UnicodeRange { > return { range.from(), range.to() }; > }); > ``` CSSValueList doesn't quite allow map() to work. 1748106 4 simon.fraser 2021-04-07 15:47:36 -0700 https://trac.webkit.org/changeset/275638/webkit 1748111 5 webkit-bug-importer 2021-04-07 15:48:33 -0700 <rdar://problem/76369477> 425352 2021-04-06 21:11:06 -0700 2021-04-07 09:54:30 -0700 Patch bug-224266-20210406211105.patch text/plain 1599 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjc1OTgxMzliYzlhYjM1 ZGJhYTYxNTRjZmZjYmE1NWFkNzBlMjk2OC4uZDU5YmVlMDQ2NDgwYTgzMWVmMTZlMWYzMDIwZjIx ZDk5MzlkMTJkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA0LTA2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFdhc3RlZCB2ZWN0 b3IgY2FwYWNpdHkgdW5kZXIgQ1NTRm9udEZhY2U6OnNldFVuaWNvZGVSYW5nZSgpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQyNjYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBrbm93IGhvdyBiaWcg dGhlIFZlY3RvcjxVbmljb2RlUmFuZ2U+IGlzIHVwLWZyb250LgorCisgICAgICAgICogY3NzL0NT U0ZvbnRGYWNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU0ZvbnRGYWNlOjpzZXRVbmljb2Rl UmFuZ2UpOgorCiAyMDIxLTA0LTA2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIFdhc3RlZCB2ZWN0b3IgY2FwYWNpdHkgaW4gU3R5bGVSdWxlS2V5ZnJh bWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9udEZhY2UuY3BwIGIvU291 cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRGYWNlLmNwcAppbmRleCA4MTcxYWNjZWE3ZWY0N2NiMTUz OTk1ZTk0YWE4YTAxMTlkN2FlMzYwLi5mOTBiM2IyZDA5YThkZjRhYTk0OGM4MjcxYWViZmM4ZTFk NjlmZGQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9udEZhY2UuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250RmFjZS5jcHAKQEAgLTI3MSwxMSArMjcxLDE0 IEBAIGJvb2wgQ1NTRm9udEZhY2U6OnNldFVuaWNvZGVSYW5nZShDU1NWYWx1ZSYgdW5pY29kZVJh bmdlKQogICAgIGlmICghaXM8Q1NTVmFsdWVMaXN0Pih1bmljb2RlUmFuZ2UpKQogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAKLSAgICBWZWN0b3I8VW5pY29kZVJhbmdlPiByYW5nZXM7CiAgICAgYXV0 byYgbGlzdCA9IGRvd25jYXN0PENTU1ZhbHVlTGlzdD4odW5pY29kZVJhbmdlKTsKKworICAgIFZl Y3RvcjxVbmljb2RlUmFuZ2U+IHJhbmdlczsKKyAgICByYW5nZXMucmVzZXJ2ZUluaXRpYWxDYXBh Y2l0eShsaXN0Lmxlbmd0aCgpKTsKKwogICAgIGZvciAoYXV0byYgcmFuZ2VWYWx1ZSA6IGxpc3Qp IHsKICAgICAgICAgYXV0byYgcmFuZ2UgPSBkb3duY2FzdDxDU1NVbmljb2RlUmFuZ2VWYWx1ZT4o cmFuZ2VWYWx1ZS5nZXQoKSk7Ci0gICAgICAgIHJhbmdlcy5hcHBlbmQoeyByYW5nZS5mcm9tKCks IHJhbmdlLnRvKCkgfSk7CisgICAgICAgIHJhbmdlcy51bmNoZWNrZWRBcHBlbmQoeyByYW5nZS5m cm9tKCksIHJhbmdlLnRvKCkgfSk7CiAgICAgfQogCiAgICAgaWYgKHJhbmdlcyA9PSBtX3Jhbmdl cykK