224248 2021-04-06 15:09:03 -0700 Wasted vector capacity under RuleFeatureSet::collectFeatures() 2021-04-07 15:48:52 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser hi koivisto simon.fraser webkit-bug-importer oldest_to_newest 1747658 0 simon.fraser 2021-04-06 15:09:03 -0700 Wasted vector capacity under RuleFeatureSet::collectFeatures() 1747662 1 425330 simon.fraser 2021-04-06 15:10:36 -0700 Created attachment 425330 Patch 1747937 2 425330 hi 2021-04-07 09:59:28 -0700 Comment on attachment 425330 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425330&action=review r=me > Source/WebCore/style/StyleScopeRuleSets.cpp:253 > + if (matchElementArray[i]) { NIT: you could save this as `auto* matchElementItem = matchElementArray[i]` to avoid repeated access > Source/WebCore/style/StyleScopeRuleSets.cpp:255 > + invalidationRuleSets->uncheckedAppend({ static_cast<MatchElement>(i), *matchElementArray[i], WTFMove(invalidationSelectorArray[i]) }); NIT: Could this be `matchElementItem.releaseNonNull()` since it's created above? 1747938 3 425330 koivisto 2021-04-07 10:01:37 -0700 Comment on attachment 425330 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425330&action=review > Source/WebCore/style/StyleScopeRuleSets.cpp:245 > + unsigned ruleSetCount = 0; > for (unsigned i = 0; i < matchElementArray.size(); ++i) { > if (matchElementArray[i]) This loop could now use range-for. 1748107 4 simon.fraser 2021-04-07 15:47:47 -0700 https://trac.webkit.org/changeset/275637/webkit 1748112 5 webkit-bug-importer 2021-04-07 15:48:52 -0700 <rdar://problem/76369495> 425330 2021-04-06 15:10:36 -0700 2021-04-07 09:59:28 -0700 Patch bug-224248-20210406151035.patch text/plain 2465 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjY0OGIxMGVmNGMyMTAz OWJlYjNlNDY3OWMxMDg4ODFiYTkwNTc0Ny4uZTcxNmYzNWYxMDhiNDg2NGVlMDc4YjZjOTI3OGVk NTFiMDlkZTM3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA0LTA2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFdhc3RlZCB2ZWN0 b3IgY2FwYWNpdHkgdW5kZXIgUnVsZUZlYXR1cmVTZXQ6OmNvbGxlY3RGZWF0dXJlcygpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQyNDgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgUnVsZVNldHMg Y29uc3RydWN0ZWQgZW5zdXJlSW52YWxpZGF0aW9uUnVsZVNldHMoKSB3ZXJlIG5ldmVyIHNocnVu aywKKyAgICAgICAgY2F1c2luZyB1cCB0byA1MDBLQiBvZiB3YXN0ZWQgdmVjdG9yIGNhcGFjaXR5 IG9uIHlvdXR1YmUuY29tLgorCisgICAgICAgIFRoaXMgY2hhbmdlIGNhbGxzIHNocmlua1RvRml0 KCkgb24gdGhlIFJ1bGVTZXRzLCBhbmQgb24gdGhlIEludmFsaWRhdGlvblJ1bGVTZXQKKyAgICAg ICAgdmVjdG9yLgorCisgICAgICAgICogc3R5bGUvU3R5bGVTY29wZVJ1bGVTZXRzLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlN0eWxlOjplbnN1cmVJbnZhbGlkYXRpb25SdWxlU2V0cyk6CisKIDIw MjEtMDQtMDMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAg ICAgV2FzdGVkIHZlY3RvciBjYXBhY2l0eSBpbiBGRUNvbG9yTWF0cml4IGFuZCBmaWx0ZXJzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVNjb3BlUnVsZVNldHMuY3BwIGIv U291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVTY29wZVJ1bGVTZXRzLmNwcAppbmRleCA3ZGU2MzNh ZDFkOTViODM4NjM5M2RhNzI2ZGU4MWI4ZDI4Y2YzOGIwLi5iMDlkZmI3MWI4YWFiYzExMDVhOGY4 NDZkZWZiMGEyZDJmMDcyOWVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHls ZVNjb3BlUnVsZVNldHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlU2NvcGVS dWxlU2V0cy5jcHAKQEAgLTIzOSwxMCArMjM5LDIxIEBAIHN0YXRpYyBWZWN0b3I8SW52YWxpZGF0 aW9uUnVsZVNldD4qIGVuc3VyZUludmFsaWRhdGlvblJ1bGVTZXRzKGNvbnN0IEtleVR5cGUmIGtl CiAgICAgICAgICAgICAgICAgICAgIGludmFsaWRhdGlvblNlbGVjdG9yQXJyYXlbYXJyYXlJbmRl eF0uYXBwZW5kKGZlYXR1cmUuaW52YWxpZGF0aW9uU2VsZWN0b3IpOwogICAgICAgICAgICAgfQog ICAgICAgICB9Ci0gICAgICAgIGF1dG8gaW52YWxpZGF0aW9uUnVsZVNldHMgPSBtYWtlVW5pcXVl PFZlY3RvcjxJbnZhbGlkYXRpb25SdWxlU2V0Pj4oKTsKKworICAgICAgICB1bnNpZ25lZCBydWxl U2V0Q291bnQgPSAwOwogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbWF0Y2hFbGVt ZW50QXJyYXkuc2l6ZSgpOyArK2kpIHsKICAgICAgICAgICAgIGlmIChtYXRjaEVsZW1lbnRBcnJh eVtpXSkKLSAgICAgICAgICAgICAgICBpbnZhbGlkYXRpb25SdWxlU2V0cy0+YXBwZW5kKHsgc3Rh dGljX2Nhc3Q8TWF0Y2hFbGVtZW50PihpKSwgKm1hdGNoRWxlbWVudEFycmF5W2ldLCBXVEZNb3Zl KGludmFsaWRhdGlvblNlbGVjdG9yQXJyYXlbaV0pIH0pOworICAgICAgICAgICAgICAgICsrcnVs ZVNldENvdW50OworICAgICAgICB9CisKKyAgICAgICAgYXV0byBpbnZhbGlkYXRpb25SdWxlU2V0 cyA9IG1ha2VVbmlxdWU8VmVjdG9yPEludmFsaWRhdGlvblJ1bGVTZXQ+PigpOworICAgICAgICBp bnZhbGlkYXRpb25SdWxlU2V0cy0+cmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShydWxlU2V0Q291bnQp OworCisgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtYXRjaEVsZW1lbnRBcnJheS5z aXplKCk7ICsraSkgeworICAgICAgICAgICAgaWYgKG1hdGNoRWxlbWVudEFycmF5W2ldKSB7Cisg ICAgICAgICAgICAgICAgbWF0Y2hFbGVtZW50QXJyYXlbaV0tPnNocmlua1RvRml0KCk7CisgICAg ICAgICAgICAgICAgaW52YWxpZGF0aW9uUnVsZVNldHMtPnVuY2hlY2tlZEFwcGVuZCh7IHN0YXRp Y19jYXN0PE1hdGNoRWxlbWVudD4oaSksICptYXRjaEVsZW1lbnRBcnJheVtpXSwgV1RGTW92ZShp bnZhbGlkYXRpb25TZWxlY3RvckFycmF5W2ldKSB9KTsKKyAgICAgICAgICAgIH0KICAgICAgICAg fQogICAgICAgICByZXR1cm4gaW52YWxpZGF0aW9uUnVsZVNldHM7CiAgICAgfSkuaXRlcmF0b3It PnZhbHVlLmdldCgpOwo=