224240 2021-04-06 10:22:52 -0700 Web Inspector: Grid overlay label style cleanup 2021-04-06 15:13:48 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 pangle pangle bburg ews-watchlist hi inspector-bugzilla-changes joepeck pangle webkit-bug-importer oldest_to_newest 1747503 0 pangle 2021-04-06 10:22:52 -0700 - Currently line number/name labels have a solid white background, while other labels have a translucent background. These should all use a translucent background. - Label arrows should have their size bumped for legibility. - Label padding should be bumped to improve legibility. 1747504 1 webkit-bug-importer 2021-04-06 10:23:14 -0700 <rdar://problem/76272978> 1747631 2 425325 pangle 2021-04-06 14:22:05 -0700 Created attachment 425325 Patch v1.0 1747649 3 425325 bburg 2021-04-06 14:42:18 -0700 Comment on attachment 425325 Patch v1.0 rs=me 1747666 4 ews-feeder 2021-04-06 15:13:47 -0700 Committed r275560: <https://commits.webkit.org/r275560> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425325. 425325 2021-04-06 14:22:05 -0700 2021-04-06 15:13:47 -0700 Patch v1.0 bug-224240-20210406142204.patch text/plain 6421 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjhmYmFmNjAxMjBhYjcw MjljNmM5ZjYzMmExMTk0MjAyMzEzNzMwNC4uY2I0MWM0M2E1YTAxNDcwM2UzNGIwNzc4OTBiNzgx ZjI0MWUwYjZmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA0LTA2ICBQYXRy aWNrIEFuZ2xlICA8cGFuZ2xlQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBH cmlkIG92ZXJsYXkgbGFiZWwgc3R5bGUgY2xlYW51cAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MjQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xlYW4gdXAgZ3JpZCBvdmVybGF5IGxhYmVsIHN0eWxp bmcgYnk6CisgICAgICAgIC0gTWFrZSBhbGwgbGFiZWxzIHVzZSBhIHRyYW5zbHVjZW50IGJhY2tn cm91bmQuIFRoaXMgcGF0Y2ggY2hvb3NlcyBhIG1pZGRsZSBncm91bmQgYmV0d2VlbiB0aGUgZXhp c3RpbmcKKyAgICAgICAgdHJhbnNsdWNlbnQgbGFiZWxzIHRoYXQgbWF0Y2hlZCB0aGUgY29sb3Ig b2YgdGhlIHJ1bGVycywgYW5kIHRoZSBzb2xpZCB3aGl0ZSBiYWNrZ3JvdW5kIHVzZWQgYnkgbGlu ZQorICAgICAgICBudW1iZXJzL25hbWVzIGZvciBtYXhpbXVtIGxlZ2liaWxpdHkuCisgICAgICAg IC0gQnVtcGluZyB0aGUgbGFiZWwgcGFkZGluZyBieSAxcHggdG8gaW1wcm92ZSBsZWdpYmlsaXR5 LgorICAgICAgICAtIEJ1bXBpbmcgdGhlIGxhYmVsIGFycm93IHNpemUgYnkgMnB4IHRvIG1ha2Ug aXQgZWFzaWVyIHRvIHVuZGVyc3RhbmQgd2hlcmUgYSBsYWJlbCBpcyBwb2ludGluZywgcGFydGlj dWxhcmx5CisgICAgICAgIGZvciBsYWJlbHMgd2hlcmUgdGhlIGVkZ2UgcG9zaXRpb24gaXMgbm90 IGBNaWRkbGVgLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yT3ZlcmxheTo6ZHJhd0dyaWRPdmVybGF5KToKKyAg ICAgICAgKFdlYkNvcmU6Okluc3BlY3Rvck92ZXJsYXk6OmJ1aWxkR3JpZE92ZXJsYXkpOgorCiAy MDIxLTA0LTA2ICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1N0cmVhbWVyXSBBdCBFT1MsIGNoYW5nZSBwb3NpdGlvbiB0byBtYXRjaCBkdXJhdGlv biwgbm90IHRoZSBvdGhlciB3YXkgYXJvdW5kLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCBkYThlNjBhMTQzNTM2ZmQw OGZjY2IwM2IxODMwMjc3Y2NiYTM1ODk4Li5jZDNhZGUwYzk4OGMwYWEyNDg3OTE5ZTg0ODc0ZDU3 MTc1NTcwNzcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA0LTA2ICBQYXRyaWNr IEFuZ2xlICA8cGFuZ2xlQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBHcmlk IG92ZXJsYXkgbGFiZWwgc3R5bGUgY2xlYW51cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MjQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTWlycm9yIGNoYW5nZXMgdG8gY29uc3RhbnRzIGZyb20gYFdl YkNvcmU6Okluc3BlY3Rvck92ZXJsYXlgLgorCisgICAgICAgICogVUlQcm9jZXNzL0luc3BlY3Rv ci9pb3MvV0tJbnNwZWN0b3JIaWdobGlnaHRWaWV3Lm1tOgorICAgICAgICAoY3JlYXRlTGF5b3V0 TGFiZWxMYXllcik6CisgICAgICAgICgtW1dLSW5zcGVjdG9ySGlnaGxpZ2h0VmlldyBfY3JlYXRl R3JpZE92ZXJsYXlMYXllcjpzY2FsZTpdKToKKwogMjAyMS0wNC0wNiAgVHlsZXIgV2lsY29jayAg PHR3aWxjby5vQHByb3Rvbm1haWwuY29tPgogCiAgICAgICAgIE5vbi11bmlmaWVkIGJ1aWxkIGZp eGVzLCBlYXJseSBBcHJpbCAyMDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yT3ZlcmxheS5jcHAKaW5kZXggNTcxMzE4YTMzM2U5NDc4NGJjMDYxNTFiMDBhNzY4MmUzZWU2 N2I5My4uMWE1MjcyNmYwNThiN2RhNTY1NTE4ZDNkYWUyMzMwMTZjZjE3N2ZjYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcApAQCAtODUsOCArODUs OCBAQCBzdGF0aWMgY29uc3RleHByIGZsb2F0IHJ1bGVyU3RlcExlbmd0aCA9IDg7CiBzdGF0aWMg Y29uc3RleHByIGZsb2F0IHJ1bGVyU3ViU3RlcEluY3JlbWVudCA9IDU7CiBzdGF0aWMgY29uc3Rl eHByIGZsb2F0IHJ1bGVyU3ViU3RlcExlbmd0aCA9IDU7CiAKLXN0YXRpYyBjb25zdGV4cHIgZmxv YXQgbGF5b3V0TGFiZWxQYWRkaW5nID0gMzsKLXN0YXRpYyBjb25zdGV4cHIgZmxvYXQgbGF5b3V0 TGFiZWxBcnJvd1NpemUgPSA0Oworc3RhdGljIGNvbnN0ZXhwciBmbG9hdCBsYXlvdXRMYWJlbFBh ZGRpbmcgPSA0Oworc3RhdGljIGNvbnN0ZXhwciBmbG9hdCBsYXlvdXRMYWJlbEFycm93U2l6ZSA9 IDY7CiAKIHN0YXRpYyBjb25zdGV4cHIgVUNoYXIgYnVsbGV0ID0gMHgyMDIyOwogc3RhdGljIGNv bnN0ZXhwciBVQ2hhciBlbGxpcHNpcyA9IDB4MjAyNjsKQEAgLTE0NjUsNyArMTQ2NSw3IEBAIHZv aWQgSW5zcGVjdG9yT3ZlcmxheTo6ZHJhd0xheW91dExhYmVsKEdyYXBoaWNzQ29udGV4dCYgY29u dGV4dCwgU3RyaW5nIGxhYmVsLCBGCiAKIHZvaWQgSW5zcGVjdG9yT3ZlcmxheTo6ZHJhd0dyaWRP dmVybGF5KEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgY29uc3QgSW5zcGVjdG9yT3ZlcmxheTo6 SGlnaGxpZ2h0OjpHcmlkSGlnaGxpZ2h0T3ZlcmxheSYgZ3JpZE92ZXJsYXkpCiB7Ci0gICAgY29u c3RleHByIGF1dG8gdHJhbnNsdWNlbnRMYWJlbEJhY2tncm91bmRDb2xvciA9IENvbG9yOjp3aGl0 ZS5jb2xvcldpdGhBbHBoYUJ5dGUoMTUzKTsKKyAgICBjb25zdGV4cHIgYXV0byB0cmFuc2x1Y2Vu dExhYmVsQmFja2dyb3VuZENvbG9yID0gQ29sb3I6OndoaXRlLmNvbG9yV2l0aEFscGhhQnl0ZSgy MzApOwogCiAgICAgR3JhcGhpY3NDb250ZXh0U3RhdGVTYXZlciBzYXZlcihjb250ZXh0KTsKICAg ICBjb250ZXh0LnNldFN0cm9rZVRoaWNrbmVzcygxKTsKQEAgLTE2MjYsNyArMTYyNiw3IEBAIE9w dGlvbmFsPEluc3BlY3Rvck92ZXJsYXk6OkhpZ2hsaWdodDo6R3JpZEhpZ2hsaWdodE92ZXJsYXk+ IEluc3BlY3Rvck92ZXJsYXk6OmJ1CiAgICAgICAgIHJldHVybiB7IH07CiAgICAgfQogCi0gICAg Y29uc3RleHByIGF1dG8gdHJhbnNsdWNlbnRMYWJlbEJhY2tncm91bmRDb2xvciA9IENvbG9yOjp3 aGl0ZS5jb2xvcldpdGhBbHBoYUJ5dGUoMTUzKTsKKyAgICBjb25zdGV4cHIgYXV0byB0cmFuc2x1 Y2VudExhYmVsQmFja2dyb3VuZENvbG9yID0gQ29sb3I6OndoaXRlLmNvbG9yV2l0aEFscGhhQnl0 ZSgyMzApOwogICAgIAogICAgIEZyYW1lVmlldyogcGFnZVZpZXcgPSBtX3BhZ2UubWFpbkZyYW1l KCkudmlldygpOwogICAgIGlmICghcGFnZVZpZXcpCkBAIC0xODQxLDcgKzE4NDEsNyBAQCBPcHRp b25hbDxJbnNwZWN0b3JPdmVybGF5OjpIaWdobGlnaHQ6OkdyaWRIaWdobGlnaHRPdmVybGF5PiBJ bnNwZWN0b3JPdmVybGF5OjpidQogICAgICAgICAgICAgICAgICAgICBnYXBMYWJlbFBvc2l0aW9u ID0gZ2FwTGFiZWxMaW5lLnBvaW50QXRBYnNvbHV0ZURpc3RhbmNlKGV4cGVjdGVkTGFiZWxTaXpl LmhlaWdodCgpKTsKICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgZ3JpZEhpZ2hsaWdodE92 ZXJsYXkubGFiZWxzLmFwcGVuZChidWlsZExhYmVsKHRleHQsIGdhcExhYmVsUG9zaXRpb24sIENv bG9yOjp3aGl0ZSwgYXJyb3dEaXJlY3Rpb24sIGFycm93RWRnZVBvc2l0aW9uKSk7CisgICAgICAg ICAgICBncmlkSGlnaGxpZ2h0T3ZlcmxheS5sYWJlbHMuYXBwZW5kKGJ1aWxkTGFiZWwodGV4dCwg Z2FwTGFiZWxQb3NpdGlvbiwgdHJhbnNsdWNlbnRMYWJlbEJhY2tncm91bmRDb2xvciwgYXJyb3dE aXJlY3Rpb24sIGFycm93RWRnZVBvc2l0aW9uKSk7CiAgICAgICAgIH0KICAgICB9CiAKQEAgLTE5 MjQsNyArMTkyNCw3IEBAIE9wdGlvbmFsPEluc3BlY3Rvck92ZXJsYXk6OkhpZ2hsaWdodDo6R3Jp ZEhpZ2hsaWdodE92ZXJsYXk+IEluc3BlY3Rvck92ZXJsYXk6OmJ1CiAgICAgICAgICAgICBpZiAo Z2FwTGFiZWxQb3NpdGlvbi54KCkgLSBleHBlY3RlZExhYmVsU2l6ZS53aWR0aCgpICsgc2Nyb2xs UG9zaXRpb24ueCgpIC0gdmlld3BvcnRCb3VuZHMueCgpIDwgMCkKICAgICAgICAgICAgICAgICBh cnJvd0RpcmVjdGlvbiA9IGNvcnJlY3RlZEFycm93RGlyZWN0aW9uKExhYmVsQXJyb3dEaXJlY3Rp b246OkxlZnQsIEdyaWRUcmFja1NpemluZ0RpcmVjdGlvbjo6Rm9yUm93cyk7CiAKLSAgICAgICAg ICAgIGdyaWRIaWdobGlnaHRPdmVybGF5LmxhYmVscy5hcHBlbmQoYnVpbGRMYWJlbCh0ZXh0LCBn YXBMYWJlbFBvc2l0aW9uLCBDb2xvcjo6d2hpdGUsIGFycm93RGlyZWN0aW9uLCBhcnJvd0VkZ2VQ b3NpdGlvbikpOworICAgICAgICAgICAgZ3JpZEhpZ2hsaWdodE92ZXJsYXkubGFiZWxzLmFwcGVu ZChidWlsZExhYmVsKHRleHQsIGdhcExhYmVsUG9zaXRpb24sIHRyYW5zbHVjZW50TGFiZWxCYWNr Z3JvdW5kQ29sb3IsIGFycm93RGlyZWN0aW9uLCBhcnJvd0VkZ2VQb3NpdGlvbikpOwogICAgICAg ICB9CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0 b3IvaW9zL1dLSW5zcGVjdG9ySGlnaGxpZ2h0Vmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0luc3BlY3Rvci9pb3MvV0tJbnNwZWN0b3JIaWdobGlnaHRWaWV3Lm1tCmluZGV4IDgzMTNk NjEzYjA0MDM0ZjYwN2E5MzJjY2MwYTcxMWJlYmIxZmMzNjQuLmM3NjQwYzIwNGZiZmIwOWM5NDQ1 MDQ2M2U5Mzc5MDg1NmRiMGE5YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0luc3BlY3Rvci9pb3MvV0tJbnNwZWN0b3JIaWdobGlnaHRWaWV3Lm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9pb3MvV0tJbnNwZWN0b3JIaWdobGlnaHRWaWV3Lm1t CkBAIC0zMjMsNyArMzIzLDcgQEAgc3RhdGljIENBTGF5ZXIgKiBjcmVhdGVMYXlvdXRMYWJlbExh eWVyKFN0cmluZyBsYWJlbCwgV2ViQ29yZTo6RmxvYXRQb2ludCBwb2ludCwKICAgICBhdXRvIGZv bnQgPSBXZWJDb3JlOjpJbnNwZWN0b3JPdmVybGF5Ojpmb250Rm9yTGF5b3V0TGFiZWwoKTsKIAog ICAgIGNvbnN0ZXhwciBhdXRvIHBhZGRpbmcgPSA0OwotICAgIGNvbnN0ZXhwciBhdXRvIGFycm93 U2l6ZSA9IDQ7CisgICAgY29uc3RleHByIGF1dG8gYXJyb3dTaXplID0gNjsKICAgICBmbG9hdCB0 ZXh0SGVpZ2h0ID0gZm9udC5mb250TWV0cmljcygpLmZsb2F0SGVpZ2h0KCk7CiAKICAgICBmbG9h dCB0ZXh0V2lkdGggPSBmb250LndpZHRoKFdlYkNvcmU6OlRleHRSdW4obGFiZWwpKTsKQEAgLTQ2 MSw3ICs0NjEsNyBAQCAtIChDQUxheWVyICopX2NyZWF0ZUdyaWRPdmVybGF5TGF5ZXI6KGNvbnN0 IFdlYkNvcmU6Okluc3BlY3Rvck92ZXJsYXk6OkhpZ2hsaWdodAogICAgICAgICBbbGF5ZXIgYWRk U3VibGF5ZXI6YXJlYUxheWVyXTsKICAgICB9CiAKLSAgICBjb25zdGV4cHIgYXV0byB0cmFuc2x1 Y2VudExhYmVsQmFja2dyb3VuZENvbG9yID0gV2ViQ29yZTo6Q29sb3I6OndoaXRlLmNvbG9yV2l0 aEFscGhhQnl0ZSgxNTMpOworICAgIGNvbnN0ZXhwciBhdXRvIHRyYW5zbHVjZW50TGFiZWxCYWNr Z3JvdW5kQ29sb3IgPSBXZWJDb3JlOjpDb2xvcjo6d2hpdGUuY29sb3JXaXRoQWxwaGFCeXRlKDIz MCk7CiAKICAgICBmb3IgKGF1dG8gYXJlYSA6IG92ZXJsYXkuYXJlYXMpCiAgICAgICAgIFtsYXll ciBhZGRTdWJsYXllcjpjcmVhdGVMYXlvdXRMYWJlbExheWVyKGFyZWEubmFtZSwgYXJlYS5xdWFk LnAxKCksIFdlYkNvcmU6Okluc3BlY3Rvck92ZXJsYXk6OkxhYmVsQXJyb3dEaXJlY3Rpb246Ok5v bmUsIFdlYkNvcmU6Okluc3BlY3Rvck92ZXJsYXk6OkxhYmVsQXJyb3dFZGdlUG9zaXRpb246Ok5v bmUsIHRyYW5zbHVjZW50TGFiZWxCYWNrZ3JvdW5kQ29sb3IsIG92ZXJsYXkuY29sb3IsIHNjYWxl LCBhcmVhLnF1YWQuYm91bmRpbmdCb3goKS53aWR0aCgpKV07Cg==