224237 2021-04-06 08:12:26 -0700 [GStreamer] At EOS, change position to match duration, not the other way around. 2021-04-06 10:10:36 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj pnormand sergio vjaquez oldest_to_newest 1747434 0 aboya 2021-04-06 08:12:26 -0700 The criteria used to check if playback has finished is currentTime >= duration. Currently MediaPlayerPrivateGStreamer::didEnd() ensures this in an awkward way: by changing the duration so that it matches currentTime, rather than the other way around. This meant a duration change at the end of playback most of the time, with a slightly different duration each time, since currentTime is cached periodically. This patch reworks that function to work more naturally and less racy: First, only if the stream doesn't have a set duration (e.g. live stream), we set a duration to currentTime, as defined in the spec. Second, at EOS we update currentTime to match duration, rather than the other way around. This patch doesn't introduce changes in test results. 1747436 1 425280 aboya 2021-04-06 08:17:19 -0700 Created attachment 425280 Patch 1747492 2 ews-feeder 2021-04-06 10:10:32 -0700 Committed r275528: <https://commits.webkit.org/r275528> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425280. 425280 2021-04-06 08:17:19 -0700 2021-04-06 10:10:34 -0700 Patch bug-224237-20210406171721.patch text/plain 4077 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGMwMGQ3NzEzNmQwMDQy Mzg5NmUyMjA4OTc1M2ZhYTE3YTVmZDJkNC4uZTA0ZmY2ZDYzMTFlMTQwMTNlYWRlYzM1Nzc4NTcz NmU3ZTQwNjI2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDIxLTA0LTA2ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBBdCBFT1MsIGNoYW5nZSBwb3NpdGlvbiB0byBtYXRjaCBkdXJhdGlvbiwgbm90IHRoZSBvdGhl ciB3YXkgYXJvdW5kLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjI0MjM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhlIGNyaXRlcmlhIHVzZWQgdG8gY2hlY2sgaWYgcGxheWJhY2sgaGFzIGZpbmlzaGVk IGlzIGN1cnJlbnRUaW1lID49CisgICAgICAgIGR1cmF0aW9uLiBDdXJyZW50bHkgTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyOjpkaWRFbmQoKSBlbnN1cmVzIHRoaXMKKyAgICAgICAgaW4gYW4g YXdrd2FyZCB3YXk6IGJ5IGNoYW5naW5nIHRoZSBkdXJhdGlvbiBzbyB0aGF0IGl0IG1hdGNoZXMK KyAgICAgICAgY3VycmVudFRpbWUsIHJhdGhlciB0aGFuIHRoZSBvdGhlciB3YXkgYXJvdW5kLgor CisgICAgICAgIFRoaXMgbWVhbnQgYSBkdXJhdGlvbiBjaGFuZ2UgYXQgdGhlIGVuZCBvZiBwbGF5 YmFjayBtb3N0IG9mIHRoZSB0aW1lLAorICAgICAgICB3aXRoIGEgc2xpZ2h0bHkgZGlmZmVyZW50 IGR1cmF0aW9uIGVhY2ggdGltZSwgc2luY2UgY3VycmVudFRpbWUgaXMKKyAgICAgICAgY2FjaGVk IHBlcmlvZGljYWxseS4KKworICAgICAgICBUaGlzIHBhdGNoIHJld29ya3MgdGhhdCBmdW5jdGlv biB0byB3b3JrIG1vcmUgbmF0dXJhbGx5IGFuZCBsZXNzIHJhY3k6CisKKyAgICAgICAgRmlyc3Qs IG9ubHkgaWYgdGhlIHN0cmVhbSBkb2Vzbid0IGhhdmUgYSBzZXQgZHVyYXRpb24gKGUuZy4gbGl2 ZQorICAgICAgICBzdHJlYW0pLCB3ZSBzZXQgYSBkdXJhdGlvbiB0byBjdXJyZW50VGltZSwgYXMg ZGVmaW5lZCBpbiB0aGUgc3BlYy4KKworICAgICAgICBTZWNvbmQsIGF0IEVPUyB3ZSB1cGRhdGUg Y3VycmVudFRpbWUgdG8gbWF0Y2ggZHVyYXRpb24sIHJhdGhlciB0aGFuCisgICAgICAgIHRoZSBv dGhlciB3YXkgYXJvdW5kLgorCisgICAgICAgIFRoaXMgcGF0Y2ggZG9lc24ndCBpbnRyb2R1Y2Ug Y2hhbmdlcyBpbiB0ZXN0IHJlc3VsdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6ZGlkRW5kKToKKwogMjAyMS0wNC0wNiAg WmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0ludGVncmF0 aW9uXSBFbmFibGUgaW5saW5lIGJveCBzdXBwb3J0IChSZW5kZXJJbmxpbmUpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDM2MGZlNzc2ZTVj MTk3YTRlMTBjYzljNzU4NzBjMDM2NWI2YzczOGQuLjZhNjRlMzJjMmRhYzI5YjNhZWJmOGNmMjc5 ODRhZDEwNjg5OWNkMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXIuY3BwCkBAIC0yNTIxLDE5ICsyNTIxLDI4IEBAIGJvb2wgTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyOjpsb2FkTmV4dExvY2F0aW9uKCkKIAogdm9pZCBNZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXI6OmRpZEVuZCgpCiB7Ci0gICAgR1NUX0lORk9fT0JKRUNUKHBpcGVsaW5lKCks ICJQbGF5YmFjayBlbmRlZCIpOwotCi0gICAgLy8gU3luY2hyb25pemUgcG9zaXRpb24gYW5kIGR1 cmF0aW9uIHZhbHVlcyB0byBub3QgY29uZnVzZSB0aGUKLSAgICAvLyBIVE1MTWVkaWFFbGVtZW50 LiBJbiBzb21lIGNhc2VzIGxpa2UgcmV2ZXJzZSBwbGF5YmFjayB0aGUKLSAgICAvLyBwb3NpdGlv biBpcyBub3QgYWx3YXlzIHJlcG9ydGVkIGFzIDAgZm9yIGluc3RhbmNlLgogICAgIG1fY2FjaGVk UG9zaXRpb24gPSBNZWRpYVRpbWU6OmludmFsaWRUaW1lKCk7CiAgICAgTWVkaWFUaW1lIG5vdyA9 IGN1cnJlbnRNZWRpYVRpbWUoKTsKLSAgICBpZiAobm93ID4gTWVkaWFUaW1lOjp6ZXJvVGltZSgp ICYmICFtX2lzU2Vla2luZykgeworICAgIEdTVF9JTkZPX09CSkVDVChwaXBlbGluZSgpLCAiUGxh eWJhY2sgZW5kZWQsIGN1cnJlbnRNZWRpYVRpbWUgPSAlcywgZHVyYXRpb24gPSAlcyIsIG5vdy50 b1N0cmluZygpLnV0ZjgoKS5kYXRhKCksIGR1cmF0aW9uTWVkaWFUaW1lKCkudG9TdHJpbmcoKS51 dGY4KCkuZGF0YSgpKTsKKyAgICBtX2lzRW5kUmVhY2hlZCA9IHRydWU7CisKKyAgICBpZiAoIWR1 cmF0aW9uTWVkaWFUaW1lKCkuaXNGaW5pdGUoKSkgeworICAgICAgICAvLyBGcm9tIHRoZSBIVE1M TWVkaWFFbGVtZW50IHNwZWMuCisgICAgICAgIC8vIElmIGFuICJpbmZpbml0ZSIgc3RyZWFtIGVu ZHMgZm9yIHNvbWUgcmVhc29uLCB0aGVuIHRoZSBkdXJhdGlvbiB3b3VsZCBjaGFuZ2UgZnJvbSBw b3NpdGl2ZSBJbmZpbml0eSB0byB0aGUKKyAgICAgICAgLy8gdGltZSBvZiB0aGUgbGFzdCBmcmFt ZSBvciBzYW1wbGUgaW4gdGhlIHN0cmVhbSwgYW5kIHRoZSBkdXJhdGlvbmNoYW5nZSBldmVudCB3 b3VsZCBiZSBmaXJlZC4KKyAgICAgICAgR1NUX0RFQlVHX09CSkVDVChwaXBlbGluZSgpLCAiSFRN TE1lZGlhRWxlbWVudCBkdXJhdGlvbiBwcmV2aW91c2x5IGluZmluaXRlIG9yIHVua25vd24gKGUu Zy4gbGl2ZSBzdHJlYW0pLCBzZXR0aW5nIGl0IHRvIGN1cnJlbnQgcG9zaXRpb24uIik7CiAgICAg ICAgIG1fY2FjaGVkRHVyYXRpb24gPSBub3c7CiAgICAgICAgIG1fcGxheWVyLT5kdXJhdGlvbkNo YW5nZWQoKTsKICAgICB9CiAKLSAgICBtX2lzRW5kUmVhY2hlZCA9IHRydWU7CisgICAgLy8gU3lu Y2hyb25pemUgcG9zaXRpb24gYW5kIGR1cmF0aW9uIHZhbHVlcyB0byBub3QgY29uZnVzZSB0aGUK KyAgICAvLyBIVE1MTWVkaWFFbGVtZW50LiBJbiBzb21lIGNhc2VzIGxpa2UgcmV2ZXJzZSBwbGF5 YmFjayB0aGUKKyAgICAvLyBwb3NpdGlvbiBpcyBub3QgYWx3YXlzIHJlcG9ydGVkIGFzIDAgZm9y IGluc3RhbmNlLgorICAgIGlmICghbV9pc1NlZWtpbmcpIHsKKyAgICAgICAgbV9jYWNoZWRQb3Np dGlvbiA9IG1fcGxheWJhY2tSYXRlID4gMCA/IGR1cmF0aW9uTWVkaWFUaW1lKCkgOiBNZWRpYVRp bWU6Onplcm9UaW1lKCk7CisgICAgICAgIEdTVF9ERUJVRygiUG9zaXRpb24gYWRqdXN0ZWQ6ICVz IiwgY3VycmVudE1lZGlhVGltZSgpLnRvU3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7CisgICAgfQor CiAgICAgLy8gTm93IHRoYXQgcGxheWJhY2sgaGFzIGVuZGVkIGl0J3MgTk9UIGEgc2FmZSB0aW1l IHRvIHNlbmQgYSBTRUxFQ1RfU1RSRUFNUyBldmVudC4gSW4gZmFjdCwgYXMgb2YgR1N0cmVhbWVy IDEuMTYsCiAgICAgLy8gcGxheWJpbjMgd2lsbCBjcmFzaCBvbiBhIEdTdHJlYW1lciBhc3NlcnRp b24gKGNvbWJpbmUtPnNpbmtwYWQgYmVpbmcgdW5leHBlY3RlZGx5IG51bGwpIGlmIHdlIHRyeS4g SW5zdGVhZCwgd2FpdAogICAgIC8vIHVudGlsIHdlIGdldCB0aGUgaW5pdGlhbCBTVFJFQU1TX1NF TEVDVEVEIG1lc3NhZ2Ugb25lIG1vcmUgdGltZS4K