224235 2021-04-06 06:45:10 -0700 [GStreamer] Only seek to change the rate un updatePlaybackRate() when needed 2021-04-07 02:10:20 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eocanha eocanha aboya bugs-noreply calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj pnormand sergio vjaquez oldest_to_newest 1747403 0 eocanha 2021-04-06 06:45:10 -0700 A seek is used by MediaPlayerPrivateGStreamer to update the playback rate used in the pipeline. There's a special case when the rate is 0.0. This actually means "paused" and, when set, the pipeline is changed to PAUSED and no updatePlaybackRate() call is made because of an early return (and therefore, no seek). When the rate is restored to a non-zero value, the pipeline is set again to PLAYING, but an unconditional call to updatePlaybackRate() is done, leading to a seek. It should be possible to call updatePlaybackRate() only if the non-zero rate changed with respect to the original one, instead of always doing it. This would avoid unneeded seeks, which are complex operations that can trigger collateral issues such as the one addressed in https://bugs.webkit.org/show_bug.cgi?id=223742. 1747448 1 425284 eocanha 2021-04-06 08:45:17 -0700 Created attachment 425284 Patch 1747458 2 425284 aboya 2021-04-06 09:16:51 -0700 Comment on attachment 425284 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425284&action=review LGTM > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:539 > + m_lastPlaybackRate = m_playbackRate; Add a documentation comment in the header file explaining this means the last playback rate sent through a GStreamer seek. 1747470 3 425288 eocanha 2021-04-06 09:39:18 -0700 Created attachment 425288 Patch 1747824 4 ews-feeder 2021-04-07 02:10:16 -0700 Committed r275596: <https://commits.webkit.org/r275596> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425288. 425284 2021-04-06 08:45:17 -0700 2021-04-06 09:39:13 -0700 Patch bug-224235-20210406174516.patch text/plain 3174 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0ODc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjdlMzAwYTVkZmJiOGYw OWFkNjc3OTlkMzMyMGZkYmVhZTI5YmM0Yi4uYzBkMzA3MzJlOTI2OTJjNGVlMDljZDk3ZWM4MDZk NWQ5MWQ0ZGFmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDIxLTA0LTA2ICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gT25seSBzZWVrIHRvIGNoYW5nZSB0aGUgcmF0ZSB1biB1cGRhdGVQbGF5YmFja1Jh dGUoKSB3aGVuIG5lZWRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI0MjM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQSBzZWVrIGlzIHVzZWQgYnkgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyIHRv IHVwZGF0ZSB0aGUgcGxheWJhY2sKKyAgICAgICAgcmF0ZSB1c2VkIGluIHRoZSBwaXBlbGluZS4g VGhlcmUncyBhIHNwZWNpYWwgY2FzZSB3aGVuIHRoZSByYXRlIGlzIDAuMC4KKyAgICAgICAgVGhp cyBhY3R1YWxseSBtZWFucyAicGF1c2VkIiBhbmQsIHdoZW4gc2V0LCB0aGUgcGlwZWxpbmUgaXMg Y2hhbmdlZCB0bworICAgICAgICBQQVVTRUQgYW5kIG5vIHVwZGF0ZVBsYXliYWNrUmF0ZSgpIGNh bGwgaXMgbWFkZSBiZWNhdXNlIG9mIGFuIGVhcmx5CisgICAgICAgIHJldHVybiAoYW5kIHRoZXJl Zm9yZSwgbm8gc2VlaykuIFdoZW4gdGhlIHJhdGUgaXMgcmVzdG9yZWQgdG8gYQorICAgICAgICBu b24temVybyB2YWx1ZSwgdGhlIHBpcGVsaW5lIGlzIHNldCBhZ2FpbiB0byBQTEFZSU5HLCBidXQg YQorICAgICAgICBjYWxsIHRvIHVwZGF0ZVBsYXliYWNrUmF0ZSgpIGlzIGRvbmUsIHdoaWNoIGlt cGxpZXMgYW4gdW5jb25kaXRpb25hbAorICAgICAgICBzZWVrLgorCisgICAgICAgIEl0IHNob3Vs ZCBiZSBwb3NzaWJsZSB0byBkbyB0aGUgc2VlayBpbiB1cGRhdGVQbGF5YmFja1JhdGUoKSBvbmx5 IGlmIHRoZQorICAgICAgICByYXRlIGNoYW5nZWQgd2l0aCByZXNwZWN0IHRvIHRoZSBvcmlnaW5h bCBvbmUsIGluc3RlYWQgb2YgYWx3YXlzIGRvaW5nCisgICAgICAgIGl0LiBUaGlzIHdvdWxkIGF2 b2lkIHVubmVlZGVkIHNlZWtzLCB3aGljaCBhcmUgY29tcGxleCBvcGVyYXRpb25zIHRoYXQKKyAg ICAgICAgY2FuIHRyaWdnZXIgY29sbGF0ZXJhbCBpc3N1ZXMgc3VjaCBhcyB0aGUgb25lIGFkZHJl c3NlZCBpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjIzNzQyLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXI6OnVwZGF0ZVBsYXliYWNrUmF0ZSk6IE9ubHkgc2VlayB3aGVuIHRoZSBw bGF5YmFjayByYXRlIGhhc24ndCBjaGFuZ2VkLgorCiAyMDIxLTAzLTIzICBKZWFuLVl2ZXMgQXZl bmFyZCAgPGp5YUBhcHBsZS5jb20+CiAKICAgICAgICAgT25seSBzZW5kIGltYWdlIGFjcm9zcyBY UEMgdG8gR1BVIHByb2Nlc3MgaWYgaXQgY2hhbmdlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggMmNkYzk0NmRjYTgyZGY1NjI5NGRhMzU5 NGJkOTY5NjJkMWQyOWY5Ni4uMWUyNWVkMDVkZjc0Y2M2NjU0N2ZjMDk3ZjQ2YzVmODZlZmYzMTY1 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAK QEAgLTUzMywxMiArNTMzLDE0IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjp1 cGRhdGVQbGF5YmFja1JhdGUoKQogCiAgICAgR1NUX0lORk9fT0JKRUNUKHBpcGVsaW5lKCksIG11 dGUgPyAiTmVlZCB0byBtdXRlIGF1ZGlvIiA6ICJEbyBub3QgbmVlZCB0byBtdXRlIGF1ZGlvIik7 CiAKLSAgICBpZiAoZG9TZWVrKHBsYXliYWNrUG9zaXRpb24oKSwgbV9wbGF5YmFja1JhdGUsIHN0 YXRpY19jYXN0PEdzdFNlZWtGbGFncz4oR1NUX1NFRUtfRkxBR19GTFVTSCkpKSB7Ci0gICAgICAg IGdfb2JqZWN0X3NldChtX3BpcGVsaW5lLmdldCgpLCAibXV0ZSIsIG11dGUsIG51bGxwdHIpOwot ICAgICAgICBtX2xhc3RQbGF5YmFja1JhdGUgPSBtX3BsYXliYWNrUmF0ZTsKLSAgICB9IGVsc2Ug ewotICAgICAgICBHU1RfRVJST1JfT0JKRUNUKHBpcGVsaW5lKCksICJTZXQgcmF0ZSB0byAlZiBm YWlsZWQiLCBtX3BsYXliYWNrUmF0ZSk7Ci0gICAgICAgIG1fcGxheWJhY2tSYXRlID0gbV9sYXN0 UGxheWJhY2tSYXRlOworICAgIGlmIChtX2xhc3RQbGF5YmFja1JhdGUgIT0gbV9wbGF5YmFja1Jh dGUpIHsKKyAgICAgICAgaWYgKGRvU2VlayhwbGF5YmFja1Bvc2l0aW9uKCksIG1fcGxheWJhY2tS YXRlLCBzdGF0aWNfY2FzdDxHc3RTZWVrRmxhZ3M+KEdTVF9TRUVLX0ZMQUdfRkxVU0gpKSkgewor ICAgICAgICAgICAgZ19vYmplY3Rfc2V0KG1fcGlwZWxpbmUuZ2V0KCksICJtdXRlIiwgbXV0ZSwg bnVsbHB0cik7CisgICAgICAgICAgICBtX2xhc3RQbGF5YmFja1JhdGUgPSBtX3BsYXliYWNrUmF0 ZTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIEdTVF9FUlJPUl9PQkpFQ1QocGlwZWxp bmUoKSwgIlNldCByYXRlIHRvICVmIGZhaWxlZCIsIG1fcGxheWJhY2tSYXRlKTsKKyAgICAgICAg ICAgIG1fcGxheWJhY2tSYXRlID0gbV9sYXN0UGxheWJhY2tSYXRlOworICAgICAgICB9CiAgICAg fQogCiAgICAgaWYgKG1faXNQbGF5YmFja1JhdGVQYXVzZWQpIHsK 425288 2021-04-06 09:39:18 -0700 2021-04-07 02:10:18 -0700 Patch bug-224235-20210406183917.patch text/plain 4008 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0ODc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjdlMzAwYTVkZmJiOGYw OWFkNjc3OTlkMzMyMGZkYmVhZTI5YmM0Yi4uNjM3MzUxMTQ3MTEyYTRhZDk0ZjExMDM0MTdlZDhm MjgxMmQxNzUzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDIxLTA0LTA2ICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gT25seSBzZWVrIHRvIGNoYW5nZSB0aGUgcmF0ZSB1biB1cGRhdGVQbGF5YmFja1Jh dGUoKSB3aGVuIG5lZWRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI0MjM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxpY2lhIEJveWEgR2FyY2lh LgorCisgICAgICAgIEEgc2VlayBpcyB1c2VkIGJ5IE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ciB0byB1cGRhdGUgdGhlIHBsYXliYWNrCisgICAgICAgIHJhdGUgdXNlZCBpbiB0aGUgcGlwZWxp bmUuIFRoZXJlJ3MgYSBzcGVjaWFsIGNhc2Ugd2hlbiB0aGUgcmF0ZSBpcyAwLjAuCisgICAgICAg IFRoaXMgYWN0dWFsbHkgbWVhbnMgInBhdXNlZCIgYW5kLCB3aGVuIHNldCwgdGhlIHBpcGVsaW5l IGlzIGNoYW5nZWQgdG8KKyAgICAgICAgUEFVU0VEIGFuZCBubyB1cGRhdGVQbGF5YmFja1JhdGUo KSBjYWxsIGlzIG1hZGUgYmVjYXVzZSBvZiBhbiBlYXJseQorICAgICAgICByZXR1cm4gKGFuZCB0 aGVyZWZvcmUsIG5vIHNlZWspLiBXaGVuIHRoZSByYXRlIGlzIHJlc3RvcmVkIHRvIGEKKyAgICAg ICAgbm9uLXplcm8gdmFsdWUsIHRoZSBwaXBlbGluZSBpcyBzZXQgYWdhaW4gdG8gUExBWUlORywg YnV0IGEKKyAgICAgICAgY2FsbCB0byB1cGRhdGVQbGF5YmFja1JhdGUoKSBpcyBkb25lLCB3aGlj aCBpbXBsaWVzIGFuIHVuY29uZGl0aW9uYWwKKyAgICAgICAgc2Vlay4KKworICAgICAgICBJdCBz aG91bGQgYmUgcG9zc2libGUgdG8gZG8gdGhlIHNlZWsgaW4gdXBkYXRlUGxheWJhY2tSYXRlKCkg b25seSBpZiB0aGUKKyAgICAgICAgcmF0ZSBjaGFuZ2VkIHdpdGggcmVzcGVjdCB0byB0aGUgb3Jp Z2luYWwgb25lLCBpbnN0ZWFkIG9mIGFsd2F5cyBkb2luZworICAgICAgICBpdC4gVGhpcyB3b3Vs ZCBhdm9pZCB1bm5lZWRlZCBzZWVrcywgd2hpY2ggYXJlIGNvbXBsZXggb3BlcmF0aW9ucyB0aGF0 CisgICAgICAgIGNhbiB0cmlnZ2VyIGNvbGxhdGVyYWwgaXNzdWVzIHN1Y2ggYXMgdGhlIG9uZSBh ZGRyZXNzZWQgaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyMzc0Mi4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyOjp1cGRhdGVQbGF5YmFja1JhdGUpOiBPbmx5IHNlZWsgd2hlbiB0 aGUgcGxheWJhY2sgcmF0ZSBoYXNuJ3QgY2hhbmdlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmg6IERvY3VtZW50IG1f bGFzdFBsYXliYWNrUmF0ZSBwdXJwb3NlLgorCiAyMDIxLTAzLTIzICBKZWFuLVl2ZXMgQXZlbmFy ZCAgPGp5YUBhcHBsZS5jb20+CiAKICAgICAgICAgT25seSBzZW5kIGltYWdlIGFjcm9zcyBYUEMg dG8gR1BVIHByb2Nlc3MgaWYgaXQgY2hhbmdlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggMmNkYzk0NmRjYTgyZGY1NjI5NGRhMzU5NGJk OTY5NjJkMWQyOWY5Ni4uMWUyNWVkMDVkZjc0Y2M2NjU0N2ZjMDk3ZjQ2YzVmODZlZmYzMTY1NyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAg LTUzMywxMiArNTMzLDE0IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjp1cGRh dGVQbGF5YmFja1JhdGUoKQogCiAgICAgR1NUX0lORk9fT0JKRUNUKHBpcGVsaW5lKCksIG11dGUg PyAiTmVlZCB0byBtdXRlIGF1ZGlvIiA6ICJEbyBub3QgbmVlZCB0byBtdXRlIGF1ZGlvIik7CiAK LSAgICBpZiAoZG9TZWVrKHBsYXliYWNrUG9zaXRpb24oKSwgbV9wbGF5YmFja1JhdGUsIHN0YXRp Y19jYXN0PEdzdFNlZWtGbGFncz4oR1NUX1NFRUtfRkxBR19GTFVTSCkpKSB7Ci0gICAgICAgIGdf b2JqZWN0X3NldChtX3BpcGVsaW5lLmdldCgpLCAibXV0ZSIsIG11dGUsIG51bGxwdHIpOwotICAg ICAgICBtX2xhc3RQbGF5YmFja1JhdGUgPSBtX3BsYXliYWNrUmF0ZTsKLSAgICB9IGVsc2Ugewot ICAgICAgICBHU1RfRVJST1JfT0JKRUNUKHBpcGVsaW5lKCksICJTZXQgcmF0ZSB0byAlZiBmYWls ZWQiLCBtX3BsYXliYWNrUmF0ZSk7Ci0gICAgICAgIG1fcGxheWJhY2tSYXRlID0gbV9sYXN0UGxh eWJhY2tSYXRlOworICAgIGlmIChtX2xhc3RQbGF5YmFja1JhdGUgIT0gbV9wbGF5YmFja1JhdGUp IHsKKyAgICAgICAgaWYgKGRvU2VlayhwbGF5YmFja1Bvc2l0aW9uKCksIG1fcGxheWJhY2tSYXRl LCBzdGF0aWNfY2FzdDxHc3RTZWVrRmxhZ3M+KEdTVF9TRUVLX0ZMQUdfRkxVU0gpKSkgeworICAg ICAgICAgICAgZ19vYmplY3Rfc2V0KG1fcGlwZWxpbmUuZ2V0KCksICJtdXRlIiwgbXV0ZSwgbnVs bHB0cik7CisgICAgICAgICAgICBtX2xhc3RQbGF5YmFja1JhdGUgPSBtX3BsYXliYWNrUmF0ZTsK KyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIEdTVF9FUlJPUl9PQkpFQ1QocGlwZWxpbmUo KSwgIlNldCByYXRlIHRvICVmIGZhaWxlZCIsIG1fcGxheWJhY2tSYXRlKTsKKyAgICAgICAgICAg IG1fcGxheWJhY2tSYXRlID0gbV9sYXN0UGxheWJhY2tSYXRlOworICAgICAgICB9CiAgICAgfQog CiAgICAgaWYgKG1faXNQbGF5YmFja1JhdGVQYXVzZWQpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuaAppbmRleCAzZWM3NGU2MTEwNjlkNWI4MDVhYzAzM2Vm ZGUwMWY1OGFmNjU1ZGMxLi5lNjJhMDE5ZDllOGU1NjU2MDY0ODU0NDFkYWUxNmVmN2IwODk5OWVh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCkBAIC00 NjMsNiArNDYzLDcgQEAgcHJpdmF0ZToKICAgICBpbnQgbV9tZWRpYUxvY2F0aW9uQ3VycmVudElu ZGV4IHsgMCB9OwogICAgIGJvb2wgbV9pc1BsYXliYWNrUmF0ZVBhdXNlZCB7IGZhbHNlIH07CiAg ICAgTWVkaWFUaW1lIG1fdGltZU9mT3ZlcmxhcHBpbmdTZWVrOworICAgIC8vIExhc3QgcGxheWJh Y2sgcmF0ZSBzZW50IHRocm91Z2ggYSBHU3RyZWFtZXIgc2Vlay4KICAgICBmbG9hdCBtX2xhc3RQ bGF5YmFja1JhdGUgeyAxIH07CiAgICAgVGltZXIgbV9maWxsVGltZXI7CiAgICAgTWVkaWFUaW1l IG1fbWF4VGltZUxvYWRlZDsK