<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>224234</bug_id>
          
          <creation_ts>2021-04-06 06:05:48 -0700</creation_ts>
          <short_desc>Make synthesizedBaselineFromContentBox return LayoutUnit</short_desc>
          <delta_ts>2021-04-07 02:04:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Rob Buis">rbuis</reporter>
          <assigned_to name="Rob Buis">rbuis</assigned_to>
          <cc>changseok</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>jfernandez</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>pdr</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1747387</commentid>
    <comment_count>0</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2021-04-06 06:05:48 -0700</bug_when>
    <thetext>Make synthesizedBaselineFromContentBox return LayoutUnit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1747388</commentid>
    <comment_count>1</comment_count>
      <attachid>425268</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2021-04-06 06:07:02 -0700</bug_when>
    <thetext>Created attachment 425268
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1747420</commentid>
    <comment_count>2</comment_count>
      <attachid>425277</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2021-04-06 07:40:40 -0700</bug_when>
    <thetext>Created attachment 425277
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1747810</commentid>
    <comment_count>3</comment_count>
      <attachid>425277</attachid>
    <who name="Javier Fernandez">jfernandez</who>
    <bug_when>2021-04-07 01:32:10 -0700</bug_when>
    <thetext>Comment on attachment 425277
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1747820</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-04-07 02:03:13 -0700</bug_when>
    <thetext>Committed r275594: &lt;https://commits.webkit.org/r275594&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425277.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1747822</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-04-07 02:04:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/76326370&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>425268</attachid>
            <date>2021-04-06 06:07:02 -0700</date>
            <delta_ts>2021-04-06 07:40:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-224234-20210406150701.patch</filename>
            <type>text/plain</type>
            <size>2429</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2RiNDMzZDUzOTgwYjIz
MDk3NGRiOTVlZTE1NzllMzdjODI3N2Q4ZC4uOWIzNmVlZGVkOWE5NTllZDllNzgwZTZmYTYxMjll
NGYzYTAwMGMyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA0LTA2ICBSb2Ig
QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTWFrZSBzeW50aGVzaXplZEJhc2Vs
aW5lRnJvbUNvbnRlbnRCb3ggcmV0dXJuIExheW91dFVuaXQKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDIzNAorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdJUC4KKworICAgICAgICAqIHJlbmRlcmluZy9S
ZW5kZXJCdXR0b24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6c3ludGhlc2l6ZWRCYXNlbGluZUZy
b21Db250ZW50Qm94KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJ1dHRvbjo6YmFzZWxpbmVQ
b3NpdGlvbiBjb25zdCk6CisKIDIwMjEtMDQtMDYgIFN0ZXBoYW4gU3phYm8gIDxzdGVwaGFuLnN6
YWJvQHNvbnkuY29tPgogCiAgICAgICAgIFtQbGF5U3RhdGlvbl0gQ2hhbmdlIG1lZGlhQ29udHJv
bHNMb2NhbGl6ZWRTdHJpbmdzIHRvIHVzZSB1bmljb2RlIGVzY2FwZXMKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24uY3BwIGIvU291cmNlL1dlYkNvcmUv
cmVuZGVyaW5nL1JlbmRlckJ1dHRvbi5jcHAKaW5kZXggMjEzNjEwMDc2YTU3YjE1MGFjYzI0YzEx
YTg5MTU1NmI2ZDBjNTI0YS4uOGU1NjMxOWNlYzhlZTUzZmJhZWJiYTNlNzllYWFjMjM4YTNkMGUx
MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJ1dHRvbi5jcHAK
KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJ1dHRvbi5jcHAKQEAgLTE0Myw3
ICsxNDMsNyBAQCBMYXlvdXRSZWN0IFJlbmRlckJ1dHRvbjo6Y29udHJvbENsaXBSZWN0KGNvbnN0
IExheW91dFBvaW50JiBhZGRpdGlvbmFsT2Zmc2V0KSBjbwogICAgIHJldHVybiBMYXlvdXRSZWN0
KGFkZGl0aW9uYWxPZmZzZXQueCgpICsgYm9yZGVyTGVmdCgpLCBhZGRpdGlvbmFsT2Zmc2V0Lnko
KSArIGJvcmRlclRvcCgpLCB3aWR0aCgpIC0gYm9yZGVyTGVmdCgpIC0gYm9yZGVyUmlnaHQoKSwg
aGVpZ2h0KCkgLSBib3JkZXJUb3AoKSAtIGJvcmRlckJvdHRvbSgpKTsKIH0KIAotc3RhdGljIGlu
dCBzeW50aGVzaXplZEJhc2VsaW5lRnJvbUNvbnRlbnRCb3goY29uc3QgUmVuZGVyQm94JiBib3gs
IExpbmVEaXJlY3Rpb25Nb2RlIGRpcmVjdGlvbikKK3N0YXRpYyBMYXlvdXRVbml0IHN5bnRoZXNp
emVkQmFzZWxpbmVGcm9tQ29udGVudEJveChjb25zdCBSZW5kZXJCb3gmIGJveCwgTGluZURpcmVj
dGlvbk1vZGUgZGlyZWN0aW9uKQogewogICAgIHJldHVybiBkaXJlY3Rpb24gPT0gSG9yaXpvbnRh
bExpbmUgPyBib3guYm9yZGVyVG9wKCkgKyBib3gucGFkZGluZ1RvcCgpICsgYm94LmNvbnRlbnRI
ZWlnaHQoKSA6IGJveC5ib3JkZXJSaWdodCgpICsgYm94LnBhZGRpbmdSaWdodCgpICsgYm94LmNv
bnRlbnRXaWR0aCgpOwogfQpAQCAtMTUyLDggKzE1Miw4IEBAIExheW91dFVuaXQgUmVuZGVyQnV0
dG9uOjpiYXNlbGluZVBvc2l0aW9uKEZvbnRCYXNlbGluZSwgYm9vbCwgTGluZURpcmVjdGlvbk1v
ZGUKIHsKICAgICAvLyBXZSBjYW5ub3QgcmVseSBvbiBSZW5kZXJGbGV4aWJsZUJveDo6YmFzZWxp
bmVQb3NpdGlvbigpIGJlY2F1c2Ugb2YgZmxleGJveGVzIGhhdmUgc29tZSBzcGVjaWFsIGJlaGF2
aW9yCiAgICAgLy8gcmVnYXJkaW5nIGJhc2VsaW5lcyB0aGF0IHNob3VsZG4ndCBhcHBseSB0byBi
dXR0b25zLgotICAgIGludCBiYXNlbGluZSA9IGZpcnN0TGluZUJhc2VsaW5lKCkudmFsdWVPcihz
eW50aGVzaXplZEJhc2VsaW5lRnJvbUNvbnRlbnRCb3goKnRoaXMsIGRpcmVjdGlvbikpOwotICAg
IGludCBtYXJnaW5Bc2NlbnQgPSBkaXJlY3Rpb24gPT0gSG9yaXpvbnRhbExpbmUgPyBtYXJnaW5U
b3AoKSA6IG1hcmdpblJpZ2h0KCk7CisgICAgTGF5b3V0VW5pdCBiYXNlbGluZSA9IGZpcnN0TGlu
ZUJhc2VsaW5lKCkudmFsdWVPcihzeW50aGVzaXplZEJhc2VsaW5lRnJvbUNvbnRlbnRCb3goKnRo
aXMsIGRpcmVjdGlvbikpOworICAgIExheW91dFVuaXQgbWFyZ2luQXNjZW50ID0gZGlyZWN0aW9u
ID09IEhvcml6b250YWxMaW5lID8gbWFyZ2luVG9wKCkgOiBtYXJnaW5SaWdodCgpOwogICAgIHJl
dHVybiBiYXNlbGluZSArIG1hcmdpbkFzY2VudDsKIH0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>425277</attachid>
            <date>2021-04-06 07:40:40 -0700</date>
            <delta_ts>2021-04-07 02:03:14 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-224234-20210406164038.patch</filename>
            <type>text/plain</type>
            <size>2555</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2RiNDMzZDUzOTgwYjIz
MDk3NGRiOTVlZTE1NzllMzdjODI3N2Q4ZC4uYTdiNTMzNzY0NTVmMTIzYzA2NzFlMzEyZWE5OWIz
NzE3OTllNjFjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA0LTA2ICBSb2Ig
QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTWFrZSBzeW50aGVzaXplZEJhc2Vs
aW5lRnJvbUNvbnRlbnRCb3ggcmV0dXJuIExheW91dFVuaXQKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDIzNAorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3ludGhlc2l6ZWRCYXNlbGluZUZyb21D
b250ZW50Qm94IHJldHVybiBMYXlvdXRVbml0LiBUaGlzCisgICAgICAgIG1ha2VzIGl0IGNvbnNp
c3RlbnQgd2l0aCBzeW50aGVzaXplZEJhc2VsaW5lRnJvbUJvcmRlckJveC4KKworICAgICAgICAq
IHJlbmRlcmluZy9SZW5kZXJCdXR0b24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6c3ludGhlc2l6
ZWRCYXNlbGluZUZyb21Db250ZW50Qm94KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJ1dHRv
bjo6YmFzZWxpbmVQb3NpdGlvbiBjb25zdCk6CisKIDIwMjEtMDQtMDYgIFN0ZXBoYW4gU3phYm8g
IDxzdGVwaGFuLnN6YWJvQHNvbnkuY29tPgogCiAgICAgICAgIFtQbGF5U3RhdGlvbl0gQ2hhbmdl
IG1lZGlhQ29udHJvbHNMb2NhbGl6ZWRTdHJpbmdzIHRvIHVzZSB1bmljb2RlIGVzY2FwZXMKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24uY3BwIGIvU291
cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJ1dHRvbi5jcHAKaW5kZXggMjEzNjEwMDc2YTU3
YjE1MGFjYzI0YzExYTg5MTU1NmI2ZDBjNTI0YS4uOGU1NjMxOWNlYzhlZTUzZmJhZWJiYTNlNzll
YWFjMjM4YTNkMGUxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl
ckJ1dHRvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJ1dHRvbi5j
cHAKQEAgLTE0Myw3ICsxNDMsNyBAQCBMYXlvdXRSZWN0IFJlbmRlckJ1dHRvbjo6Y29udHJvbENs
aXBSZWN0KGNvbnN0IExheW91dFBvaW50JiBhZGRpdGlvbmFsT2Zmc2V0KSBjbwogICAgIHJldHVy
biBMYXlvdXRSZWN0KGFkZGl0aW9uYWxPZmZzZXQueCgpICsgYm9yZGVyTGVmdCgpLCBhZGRpdGlv
bmFsT2Zmc2V0LnkoKSArIGJvcmRlclRvcCgpLCB3aWR0aCgpIC0gYm9yZGVyTGVmdCgpIC0gYm9y
ZGVyUmlnaHQoKSwgaGVpZ2h0KCkgLSBib3JkZXJUb3AoKSAtIGJvcmRlckJvdHRvbSgpKTsKIH0K
IAotc3RhdGljIGludCBzeW50aGVzaXplZEJhc2VsaW5lRnJvbUNvbnRlbnRCb3goY29uc3QgUmVu
ZGVyQm94JiBib3gsIExpbmVEaXJlY3Rpb25Nb2RlIGRpcmVjdGlvbikKK3N0YXRpYyBMYXlvdXRV
bml0IHN5bnRoZXNpemVkQmFzZWxpbmVGcm9tQ29udGVudEJveChjb25zdCBSZW5kZXJCb3gmIGJv
eCwgTGluZURpcmVjdGlvbk1vZGUgZGlyZWN0aW9uKQogewogICAgIHJldHVybiBkaXJlY3Rpb24g
PT0gSG9yaXpvbnRhbExpbmUgPyBib3guYm9yZGVyVG9wKCkgKyBib3gucGFkZGluZ1RvcCgpICsg
Ym94LmNvbnRlbnRIZWlnaHQoKSA6IGJveC5ib3JkZXJSaWdodCgpICsgYm94LnBhZGRpbmdSaWdo
dCgpICsgYm94LmNvbnRlbnRXaWR0aCgpOwogfQpAQCAtMTUyLDggKzE1Miw4IEBAIExheW91dFVu
aXQgUmVuZGVyQnV0dG9uOjpiYXNlbGluZVBvc2l0aW9uKEZvbnRCYXNlbGluZSwgYm9vbCwgTGlu
ZURpcmVjdGlvbk1vZGUKIHsKICAgICAvLyBXZSBjYW5ub3QgcmVseSBvbiBSZW5kZXJGbGV4aWJs
ZUJveDo6YmFzZWxpbmVQb3NpdGlvbigpIGJlY2F1c2Ugb2YgZmxleGJveGVzIGhhdmUgc29tZSBz
cGVjaWFsIGJlaGF2aW9yCiAgICAgLy8gcmVnYXJkaW5nIGJhc2VsaW5lcyB0aGF0IHNob3VsZG4n
dCBhcHBseSB0byBidXR0b25zLgotICAgIGludCBiYXNlbGluZSA9IGZpcnN0TGluZUJhc2VsaW5l
KCkudmFsdWVPcihzeW50aGVzaXplZEJhc2VsaW5lRnJvbUNvbnRlbnRCb3goKnRoaXMsIGRpcmVj
dGlvbikpOwotICAgIGludCBtYXJnaW5Bc2NlbnQgPSBkaXJlY3Rpb24gPT0gSG9yaXpvbnRhbExp
bmUgPyBtYXJnaW5Ub3AoKSA6IG1hcmdpblJpZ2h0KCk7CisgICAgTGF5b3V0VW5pdCBiYXNlbGlu
ZSA9IGZpcnN0TGluZUJhc2VsaW5lKCkudmFsdWVPcihzeW50aGVzaXplZEJhc2VsaW5lRnJvbUNv
bnRlbnRCb3goKnRoaXMsIGRpcmVjdGlvbikpOworICAgIExheW91dFVuaXQgbWFyZ2luQXNjZW50
ID0gZGlyZWN0aW9uID09IEhvcml6b250YWxMaW5lID8gbWFyZ2luVG9wKCkgOiBtYXJnaW5SaWdo
dCgpOwogICAgIHJldHVybiBiYXNlbGluZSArIG1hcmdpbkFzY2VudDsKIH0KIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>