224232 2021-04-06 05:11:47 -0700 [GTK][WPE] Avif decoder build broken 2021-04-13 04:38:37 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand annulen bugs-noreply cgarcia changseok ews-watchlist gyuyoung.kim ryuan.choi sergio oldest_to_newest 1747374 0 pnormand 2021-04-06 05:11:47 -0700 I´m about to deploy a SDK update shipping avif 0.9.0, the build fails but as this feature is currently disabled by default I think it´s fine ;) ../../Source/WebCore/platform/image-decoders/avif/AVIFImageReader.cpp:52:9: error: no matching function for call to 'avifDecoderParse' if (avifDecoderParse(m_avifDecoder.get(), &avifData) != AVIF_RESULT_OK ^~~~~~~~~~~~~~~~ /usr/include/avif/avif.h:752:21: note: candidate function not viable: requires single argument 'decoder', but 2 arguments were provided avifResult avifDecoderParse(avifDecoder * decoder); ^ ../../Source/WebCore/platform/image-decoders/avif/AVIFImageReader.cpp:75:13: error: no matching function for call to 'avifDecoderParse' if (avifDecoderParse(m_avifDecoder.get(), &avifData) != AVIF_RESULT_OK) { ^~~~~~~~~~~~~~~~ /usr/include/avif/avif.h:752:21: note: candidate function not viable: requires single argument 'decoder', but 2 arguments were provided avifResult avifDecoderParse(avifDecoder * decoder); ^ ../../Source/WebCore/platform/image-decoders/avif/AVIFImageReader.cpp:125:26: warning: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Wsign-compare] for (size_t i = 0; i < m_avifDecoder->imageCount; ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning and 2 errors generated. 1748673 1 425604 pnormand 2021-04-09 02:41:37 -0700 Created attachment 425604 Patch 1749018 2 425604 changseok 2021-04-10 12:05:54 -0700 Comment on attachment 425604 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425604&action=review > Source/WebCore/platform/image-decoders/avif/AVIFImageReader.cpp:43 > + if (avifDecoderSetIOMemory(m_avifDecoder.get(), reinterpret_cast<const uint8_t*>(data.data()), data.size()) != AVIF_RESULT_OK) { Doesn't we need to check if incoming data is compatible to avif or avifs here, first? 1749084 3 425604 pnormand 2021-04-11 05:45:14 -0700 Comment on attachment 425604 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425604&action=review >> Source/WebCore/platform/image-decoders/avif/AVIFImageReader.cpp:43 >> + if (avifDecoderSetIOMemory(m_avifDecoder.get(), reinterpret_cast<const uint8_t*>(data.data()), data.size()) != AVIF_RESULT_OK) { > > Doesn't we need to check if incoming data is compatible to avif or avifs here, first? I don´t think so. The examples I´ve found call avifDecoderSetIOMemory() and then avifDecoderParse() which internally calls avifParse() which should hopefully handle parse errors. Do you think something additional is needed? 1749648 4 ews-feeder 2021-04-13 04:38:33 -0700 Committed r275880 (236445@main): <https://commits.webkit.org/236445@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425604. 425604 2021-04-09 02:41:37 -0700 2021-04-13 04:38:35 -0700 Patch bug-224232-20210409024136.patch text/plain 4121 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NzUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTJlMTJkY2MyNjgzZWNk MmNiZmUxOGJmZjY2YWYwMDI2NWQzY2NlNS4uN2I4MmQxYmNiY2UzOThiMDE5ODJlYzg2YjUzYTAy ZDEzYzE4Yjg1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA0LTA5ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVd IEF2aWYgZGVjb2RlciBidWlsZCBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyNDIzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGxpYmF2aWYgMC45LjAgaW50cm9kdWNlcyBhbiBBUEkgYnJlYWsu IGF2aWZEZWNvZGVyUGFyc2UoKSBubworICAgICAgICBsb25nZXIgdGFrZXMgdGhlIGltYWdlIGRh dGEgYXMgaW5wdXQuIEluc3RlYWQsIGFuIGF2aWZJTyBvYmplY3QKKyAgICAgICAgbmVlZHMgdG8g YmUgYXNzb2NpYXRlZCB3aXRoIGFuIGF2aWZEZWNvZGVyIGFuZCB0aGUgYXZpZkRlY29kZXIKKyAg ICAgICAgY2FsbHMgdGhlIHJlYWQoKSBtZXRob2Qgb2YgdGhlIGF2aWZJTyBvYmplY3QgdG8gcmVh ZCBpbWFnZSBkYXRhCisgICAgICAgIGluY3JlbWVudGFsbHkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9pbWFnZS1kZWNvZGVycy9hdmlmL0FWSUZJbWFnZVJlYWRlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpBVklGSW1hZ2VSZWFkZXI6OnBhcnNlSGVhZGVyKToKKyAgICAgICAgKFdlYkNvcmU6OkFW SUZJbWFnZVJlYWRlcjo6ZGVjb2RlRnJhbWUpOgorCiAyMDIxLTA0LTA5ICBZdXN1a2UgU3V6dWtp ICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgU2VydmljZVdvcmtlciBzaG91bGQgc2F2 ZSBtb2R1bGUgc2NyaXB0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1h Z2UtZGVjb2RlcnMvYXZpZi9BVklGSW1hZ2VSZWFkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vaW1hZ2UtZGVjb2RlcnMvYXZpZi9BVklGSW1hZ2VSZWFkZXIuY3BwCmluZGV4IDUzNTYy OTk0YmE1MDJkYzIzN2M3NDBjZWMwOTNkMzkwYmE3NTIyOWEuLmQxNjQwYzQ2OGNkMTVmMjZhNGVi NmJiOTYxMzM3NjFhNWNlMzNlZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2ltYWdlLWRlY29kZXJzL2F2aWYvQVZJRkltYWdlUmVhZGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9hdmlmL0FWSUZJbWFnZVJlYWRlci5jcHAKQEAg LTQwLDE2ICs0MCwxMiBAQCBBVklGSW1hZ2VSZWFkZXI6On5BVklGSW1hZ2VSZWFkZXIoKSA9IGRl ZmF1bHQ7CiAKIHZvaWQgQVZJRkltYWdlUmVhZGVyOjpwYXJzZUhlYWRlcihjb25zdCBTaGFyZWRC dWZmZXI6OkRhdGFTZWdtZW50JiBkYXRhLCBib29sIGFsbERhdGFSZWNlaXZlZCkKIHsKLSAgICBh dmlmUk9EYXRhIGF2aWZEYXRhOwotICAgIGF2aWZEYXRhLmRhdGEgPSByZWludGVycHJldF9jYXN0 PGNvbnN0IHVpbnQ4X3QqPihkYXRhLmRhdGEoKSk7Ci0gICAgYXZpZkRhdGEuc2l6ZSA9IGRhdGEu c2l6ZSgpOwotCi0gICAgaWYgKCFhdmlmUGVla0NvbXBhdGlibGVGaWxlVHlwZSgmYXZpZkRhdGEp KSB7CisgICAgaWYgKGF2aWZEZWNvZGVyU2V0SU9NZW1vcnkobV9hdmlmRGVjb2Rlci5nZXQoKSwg cmVpbnRlcnByZXRfY2FzdDxjb25zdCB1aW50OF90Kj4oZGF0YS5kYXRhKCkpLCBkYXRhLnNpemUo KSkgIT0gQVZJRl9SRVNVTFRfT0spIHsKICAgICAgICAgbV9kZWNvZGVyLT5zZXRGYWlsZWQoKTsK ICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGlmIChhdmlmRGVjb2RlclBhcnNlKG1fYXZp ZkRlY29kZXIuZ2V0KCksICZhdmlmRGF0YSkgIT0gQVZJRl9SRVNVTFRfT0sKKyAgICBpZiAoYXZp ZkRlY29kZXJQYXJzZShtX2F2aWZEZWNvZGVyLmdldCgpKSAhPSBBVklGX1JFU1VMVF9PSwogICAg ICAgICB8fCBhdmlmRGVjb2Rlck5leHRJbWFnZShtX2F2aWZEZWNvZGVyLmdldCgpKSAhPSBBVklG X1JFU1VMVF9PSykgewogICAgICAgICBtX2RlY29kZXItPnNldEZhaWxlZCgpOwogICAgICAgICBy ZXR1cm47CkBAIC02OCwxMSArNjQsMTIgQEAgdm9pZCBBVklGSW1hZ2VSZWFkZXI6OmRlY29kZUZy YW1lKHNpemVfdCBmcmFtZUluZGV4LCBTY2FsYWJsZUltYWdlRGVjb2RlckZyYW1lJgogICAgICAg ICByZXR1cm47CiAKICAgICBpZiAoIW1fZGF0YVBhcnNlZCkgewotICAgICAgICBhdmlmUk9EYXRh IGF2aWZEYXRhOwotICAgICAgICBhdmlmRGF0YS5kYXRhID0gcmVpbnRlcnByZXRfY2FzdDxjb25z dCB1aW50OF90Kj4oZGF0YS5kYXRhKCkpOwotICAgICAgICBhdmlmRGF0YS5zaXplID0gZGF0YS5z aXplKCk7CisgICAgICAgIGlmIChhdmlmRGVjb2RlclNldElPTWVtb3J5KG1fYXZpZkRlY29kZXIu Z2V0KCksIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgdWludDhfdCo+KGRhdGEuZGF0YSgpKSwgZGF0 YS5zaXplKCkpICE9IEFWSUZfUkVTVUxUX09LKSB7CisgICAgICAgICAgICBtX2RlY29kZXItPnNl dEZhaWxlZCgpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CiAKLSAgICAgICAgaWYg KGF2aWZEZWNvZGVyUGFyc2UobV9hdmlmRGVjb2Rlci5nZXQoKSwgJmF2aWZEYXRhKSAhPSBBVklG X1JFU1VMVF9PSykgeworICAgICAgICBpZiAoYXZpZkRlY29kZXJQYXJzZShtX2F2aWZEZWNvZGVy LmdldCgpKSAhPSBBVklGX1JFU1VMVF9PSykgewogICAgICAgICAgICAgbV9kZWNvZGVyLT5zZXRG YWlsZWQoKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291 cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFr ZQppbmRleCBiODU1MTkxMjE2ZjZjOTI1ZWZhNjY1Y2JlNmJmOWExNzM5ZmVmNTliLi5mMzE0NWEx M2YwZGY4NTM3YzNhOGU4ZmQwNWY5YmM1ZGZkNWNhMDYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21h a2UvT3B0aW9uc0dUSy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpA QCAtNDM1LDkgKzQzNSw5IEBAIGlmIChVU0VfV09GRjIpCiBlbmRpZiAoKQogCiBpZiAoVVNFX0FW SUYpCi0gICAgZmluZF9wYWNrYWdlKEFWSUYgMC43LjMpCisgICAgZmluZF9wYWNrYWdlKEFWSUYg MC45LjApCiAgICAgaWYgKE5PVCBBVklGX0ZPVU5EKQotICAgICAgICBtZXNzYWdlKEZBVEFMX0VS Uk9SICJsaWJhdmlmIDAuNy4zIGlzIHJlcXVpcmVkIGZvciBVU0VfQVZJRi4iKQorICAgICAgICBt ZXNzYWdlKEZBVEFMX0VSUk9SICJsaWJhdmlmIDAuOS4wIGlzIHJlcXVpcmVkIGZvciBVU0VfQVZJ Ri4iKQogICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9D aGFuZ2VMb2cKaW5kZXggNDM5ZGQ3YWNkNWE2YzNlZDMxZTFjMDFiNDA5MWFmNDQyZTE0MjZmNi4u ZTc4ZDRkNGY1ODk1Y2M0ZGFhN2Y3Y2IxZjUzZWNhNDZiM2QxZTc2MiAxMDA2NDQKLS0tIGEvQ2hh bmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA0LTA5ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVd IEF2aWYgZGVjb2RlciBidWlsZCBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyNDIzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6IFJlcXVp cmUgMC45LjAgZHVlIHRvIGF2aWZJTyB1c2FnZSBpbiB0aGUgZGVjb2Rlci4KKwogMjAyMS0wNC0w NyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9yZz4KIAogICAgICAgICBb R1RLXSB3ZWJraXQ6Ly9ncHUgc2hvdWxkIHByaW50IHJ1bnRpbWUgbGlid3BlIGFuZCB3cGViYWNr ZW5kLWZkbyB2ZXJzaW9ucwo=