224227 2021-04-05 23:48:44 -0700 .gitignore contains 'build/' which causes all directories named 'build/' to be ignored 2021-04-07 04:39:27 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=223988 https://bugs.webkit.org/show_bug.cgi?id=223921 https://bugs.webkit.org/show_bug.cgi?id=30951 InRadar P2 Normal --- 1 kkinnunen kkinnunen ap rniwa webkit-bug-importer oldest_to_newest 1747295 0 kkinnunen 2021-04-05 23:48:44 -0700 .gitignore contains 'build/' which causes all directories named 'build/' to be ignored * Has caused some WebGL tests to be missing and untested for multiple years. ** Has caused ANGLE METAL backend implementation to contain crashes that would have been caught by the tests. 1747296 1 425247 kkinnunen 2021-04-05 23:51:35 -0700 Created attachment 425247 Patch 1747297 2 kkinnunen 2021-04-05 23:52:31 -0700 https://git-scm.com/docs/gitignore > If there is a separator at the beginning or middle (or both) of the pattern, then the pattern is relative to the directory level of the particular .gitignore file itself. Otherwise the pattern may also match at any level below the .gitignore level. I think all these are intended to be here, if some of them are intended: find . -iname 'build' ./LayoutTests/webgl/1.0.3/resources/webgl_test_files/conformance/ogles/GL/build ./PerformanceTests/Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/director/build ./PerformanceTests/Speedometer/resources/todomvc/architecture-examples/vuejs-cli/build ./PerformanceTests/Speedometer/resources/todomvc/architecture-examples/react/node_modules/director/build ./Websites/browserbench.org/Speedometer2.0/resources/todomvc/labs/architecture-examples/react/bower_components/director/build ./Websites/browserbench.org/Speedometer2.0/resources/todomvc/architecture-examples/vuejs-cli/build ./Websites/browserbench.org/Speedometer2.0/resources/todomvc/architecture-examples/react/node_modules/director/build Since there was an explicit non-ignore pattern for one of these directories, I assume this intention is just missing for the other one by mistake. 1747300 3 425247 rniwa 2021-04-06 00:00:18 -0700 Comment on attachment 425247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425247&action=review > .gitignore:7 > +/build/ I think we should just get rid of this line. This was relevant 11 years ago (https://trac.webkit.org/r50325). If I recall correctly, chromium back then used "build" directory. I don't believe we have any port that adds build directory anymore. 1747302 4 425249 kkinnunen 2021-04-06 00:05:22 -0700 Created attachment 425249 Patch 1747306 5 ews-feeder 2021-04-06 00:19:36 -0700 /Volumes/Data/worker/Commit-Queue/build/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 1747842 6 425378 kkinnunen 2021-04-07 03:50:26 -0700 Created attachment 425378 Patch 1747849 7 ews-feeder 2021-04-07 04:38:21 -0700 Committed r275601: <https://commits.webkit.org/r275601> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425378. 1747850 8 webkit-bug-importer 2021-04-07 04:39:27 -0700 <rdar://problem/76335650> 425247 2021-04-05 23:51:35 -0700 2021-04-06 00:05:18 -0700 Patch bug-224227-20210406095133.patch text/plain 1257 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDkyCmRpZmYgLS1naXQgYS8uZ2l0aWdub3JlIGIvLmdp dGlnbm9yZQppbmRleCA5MzkwMzFkYTY2NGNjZGEyNmJhMmY4N2Q0MTNjZjI1NDY4OTY1MmMxLi43 YzJlNmQ1NTBiOTQyYzYwNWViODg1NjU2M2Y4YTQ4NjI0NDE0M2FhIDEwMDY0NAotLS0gYS8uZ2l0 aWdub3JlCisrKyBiLy5naXRpZ25vcmUKQEAgLTQsOCArNCw3IEBACiAqLnB5YwogLkRTX1N0b3Jl CiAuZGlyZWN0b3J5Ci1idWlsZC8KLSEvUGVyZm9ybWFuY2VUZXN0cy9TcGVlZG9tZXRlci8qKi9i dWlsZC8KKy9idWlsZC8KIC9XZWJLaXRCdWlsZC8KIC90ZXN0MjYyLXJlc3VsdHMvCiBhdXRvaW5z dGFsbC5jYWNoZS5kCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMzBm N2UyZDBiYjYzNmZlZjQ3Mzk0YjQ0Yjk2MGU4MWU4ZTVkMDdhMy4uNDg2YzlmZTA1ZWNkZjhhOTNk M2Y4YmIzYjhhOGJhZTI0OGY4MzQ0MCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA0LTA1ICBLaW1tbyBLaW5udW5lbiAgPGtraW5u dW5lbkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViR0wgY29uZm9ybWFuY2UgdGVzdHMgYXJlIG1p c3NpbmcgZmlsZXMgZHVlIHRvIHRvbyB3aWRlbHkgbWF0Y2hpbmcgLmdpdGlnbm9yZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MjI3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZKE9PUFMpLgorCisgICAgICAgIENoYW5nZSBpZ25vcmUgdG8g aWdub3JlIHRoZSByb290IC9idWlsZC8gZGlyZWN0b3J5IGluc3RlYWQKKyAgICAgICAgb2YgYWxs IGJ1aWxkLyBzdWJkaXJlY3Rvcmllcy4gTW9zdCBsaWtlbHkgdGhlIG9yaWdpbmFsIGlkZWEKKyAg ICAgICAgd2FzIG5vdCB0byBleGNsdWRlIGFsbCBzdWJkaXJlY3RvcmllcyBuYW1lZCBidWlsZC8s IGFuZCBpdAorICAgICAgICBhcHBlYXJzIHRoYXQgb3RoZXIgcGFydHMgb2YgdGhlIHByb2plY3Qg YWxyZWFkeSByYW4gaW50bworICAgICAgICB0aGUgcHJvYmxlbS4KKworICAgICAgICBXZWJHTCBj b25mb3JtYW5jZSB0ZXN0IHN1aXRlIGZpbGVzIGhhdmUgYnVpbGQvIGluIGl0cyBwYXRoLgorCisg ICAgICAgICogLmdpdGlnbm9yZToKKwogMjAyMS0wNC0wNSAgQWxleCBDaHJpc3RlbnNlbiAgPGFj aHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlc3VycmVjdCBNYWMgQ01ha2UgYnVp bGQK 425249 2021-04-06 00:05:22 -0700 2021-04-07 03:50:21 -0700 Patch bug-224227-20210406100521.patch text/plain 1190 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDkyCmRpZmYgLS1naXQgYS8uZ2l0aWdub3JlIGIvLmdp dGlnbm9yZQppbmRleCA5MzkwMzFkYTY2NGNjZGEyNmJhMmY4N2Q0MTNjZjI1NDY4OTY1MmMxLi42 ZGU1M2Y2ODhmODk4OTIwNjYwMDJkYjAwOTAxNWFhZGJkOGY4N2M1IDEwMDY0NAotLS0gYS8uZ2l0 aWdub3JlCisrKyBiLy5naXRpZ25vcmUKQEAgLTQsOCArNCw2IEBACiAqLnB5YwogLkRTX1N0b3Jl CiAuZGlyZWN0b3J5Ci1idWlsZC8KLSEvUGVyZm9ybWFuY2VUZXN0cy9TcGVlZG9tZXRlci8qKi9i dWlsZC8KIC9XZWJLaXRCdWlsZC8KIC90ZXN0MjYyLXJlc3VsdHMvCiBhdXRvaW5zdGFsbC5jYWNo ZS5kCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMzBmN2UyZDBiYjYz NmZlZjQ3Mzk0YjQ0Yjk2MGU4MWU4ZTVkMDdhMy4uOWVlNmEwNzZjMDU0YjFiNDJiN2U4ZDM2OTZm ZDNiZjFiYTY1MTk5YiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE4IEBACisyMDIxLTA0LTA1ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBs ZS5jb20+CisKKyAgICAgICAgLmdpdGlnbm9yZSBjb250YWlucyAnYnVpbGQvJyB3aGljaCBjYXVz ZXMgYWxsIGRpcmVjdG9yaWVzIG5hbWVkICdidWlsZC8nIHRvIGJlIGlnbm9yZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDIyNworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWShPT1BTKS4KKworICAgICAgICBSZW1vdmUgJ2J1aWxkLycgZnJv bSAuZ2l0aWdub3JlLCBpdCB3YXMgY2F1c2luZyBlcnJvcnMgYnkgaGlkaW5nIGZpbGVzLgorICAg ICAgICBXZWJHTCBjb25mb3JtYW5jZSB0ZXN0IHN1aXRlIGZpbGVzIGhhdmUgZGlyZWN0aW9yaWVz IHdpdGggJ2J1aWxkLycgaW4gaXRzIHBhdGguCisKKyAgICAgICAgTW9zdCBsaWtlbHkgJy9idWls ZC8nIGlzIG5vdCBhIGNvbW1vbiBidWlsZCBkaXJlY3RvcnksIHNpbmNlIHRoZSBzY3JpcHRzCisg ICAgICAgIHNlZW0gdG8gZGVmYXVsdCB0byAnL1dlYktpdEJ1aWxkLycuCisKKyAgICAgICAgKiAu Z2l0aWdub3JlOgorCiAyMDIxLTA0LTA1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2Vu QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVzdXJyZWN0IE1hYyBDTWFrZSBidWlsZAo= 425378 2021-04-07 03:50:26 -0700 2021-04-07 04:38:22 -0700 Patch bug-224227-20210407135024.patch text/plain 1223 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NTg4CmRpZmYgLS1naXQgYS8uZ2l0aWdub3JlIGIvLmdp dGlnbm9yZQppbmRleCA5MzkwMzFkYTY2NGNjZGEyNmJhMmY4N2Q0MTNjZjI1NDY4OTY1MmMxLi42 ZGU1M2Y2ODhmODk4OTIwNjYwMDJkYjAwOTAxNWFhZGJkOGY4N2M1IDEwMDY0NAotLS0gYS8uZ2l0 aWdub3JlCisrKyBiLy5naXRpZ25vcmUKQEAgLTQsOCArNCw2IEBACiAqLnB5YwogLkRTX1N0b3Jl CiAuZGlyZWN0b3J5Ci1idWlsZC8KLSEvUGVyZm9ybWFuY2VUZXN0cy9TcGVlZG9tZXRlci8qKi9i dWlsZC8KIC9XZWJLaXRCdWlsZC8KIC90ZXN0MjYyLXJlc3VsdHMvCiBhdXRvaW5zdGFsbC5jYWNo ZS5kCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYjg4NTg4YmIwN2Yx YWMyNTAzODZiMjU2YWFkYTVlMDUxYzExNDA4OC4uNTk2ZjhjNDQyODFlNjU4YzcyYTlhZDc1ZDA4 Yjg4OWViNGU0MzI0YiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE4IEBACisyMDIxLTA0LTA1ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBs ZS5jb20+CisKKyAgICAgICAgLmdpdGlnbm9yZSBjb250YWlucyAnYnVpbGQvJyB3aGljaCBjYXVz ZXMgYWxsIGRpcmVjdG9yaWVzIG5hbWVkICdidWlsZC8nIHRvIGJlIGlnbm9yZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDIyNworCisgICAgICAg IFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KKworICAgICAgICBSZW1vdmUgJ2J1aWxkLycgZnJv bSAuZ2l0aWdub3JlLCBpdCB3YXMgY2F1c2luZyBlcnJvcnMgYnkgaGlkaW5nIGZpbGVzLgorICAg ICAgICBXZWJHTCBjb25mb3JtYW5jZSB0ZXN0IHN1aXRlIGZpbGVzIGhhdmUgZGlyZWN0aW9yaWVz IHdpdGggJ2J1aWxkLycgaW4gaXRzIHBhdGguCisKKyAgICAgICAgTW9zdCBsaWtlbHkgJy9idWls ZC8nIGlzIG5vdCBhIGNvbW1vbiBidWlsZCBkaXJlY3RvcnksIHNpbmNlIHRoZSBzY3JpcHRzCisg ICAgICAgIHNlZW0gdG8gZGVmYXVsdCB0byAnL1dlYktpdEJ1aWxkLycuCisKKyAgICAgICAgKiAu Z2l0aWdub3JlOgorCiAyMDIxLTA0LTA2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdh bGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNzUyNzUpOiBCcm9rZSBzb21lIGJ1aWxk IGNvbmZpZ3MgbGFja2luZyBvcGVuaDI2NAo=