224209 2021-04-05 14:52:29 -0700 [WPE][GTK] Null pointer dereference when child process exits immediately 2021-04-07 06:13:40 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply cgarcia mcatanzaro oldest_to_newest 1747122 0 mcatanzaro 2021-04-05 14:52:29 -0700 In https://github.com/flathub/org.gnome.Epiphany/issues/21 we discovered that when the child process exits immediately after it is spawned, g_subprocess_get_identifier() will return nullptr. In this case, we should crash cleanly with SIGABRT via g_error(), rather than crashing with a null pointer dereference inside g_ascii_strtoll(). SIGABRT is much nicer than SIGSEGV and indicates that we really do want to crash here, whereas SIGSEGV is just a bug. 1747123 1 425210 mcatanzaro 2021-04-05 14:55:06 -0700 Created attachment 425210 Patch 1747443 2 mcatanzaro 2021-04-06 08:33:26 -0700 The crashing test is TestWebsiteData -p /webkit/WebKitWebsiteData/configuration: ERROR:../../Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:220:void testWebsiteDataConfiguration(WebsiteDataTest*, gconstpointer): 'test->fetch(persistentCaches)' should be nullptr Bail out! ERROR:../../Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:220:void testWebsiteDataConfiguration(WebsiteDataTest*, gconstpointer): 'test->fetch(persistentCaches)' should be nullptr My patch causes this test to fail on EWS, but the test crashes for me locally in the same way without my change. I can only imagine what's going wrong with the website data.... 1747783 3 cgarcia 2021-04-07 00:12:05 -0700 I think the api test failure is unrelated. 1747864 4 425210 mcatanzaro 2021-04-07 06:05:19 -0700 Comment on attachment 425210 Patch Let's find out, then.... 1747867 5 ews-feeder 2021-04-07 06:13:38 -0700 Committed r275605: <https://commits.webkit.org/r275605> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425210. 425210 2021-04-05 14:55:06 -0700 2021-04-07 06:13:39 -0700 Patch bug-224209-20210405165506.patch text/plain 2520 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY1ZDY3NTE3ZmYyMGM3NWM4 NzBlNjJlMDE4OWFhMmI5ZDllNGI1ODEuLjA2ZTJkYTgxNzQ5M2JhMDlmZTRlOGI3MWYxZTViZWM2 YmIzODliN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjEtMDQtMDUgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW1dQRV1bR1RLXSBO dWxsIHBvaW50ZXIgZGVyZWZlcmVuY2Ugd2hlbiBjaGlsZCBwcm9jZXNzIGV4aXRzIGltbWVkaWF0 ZWx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQy MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBk aXNjb3ZlcmVkIHRoYXQgd2hlbiB0aGUgY2hpbGQgcHJvY2VzcyBleGl0cyBpbW1lZGlhdGVseSBh ZnRlciBpdCBpcyBzcGF3bmVkLAorICAgICAgICBnX3N1YnByb2Nlc3NfZ2V0X2lkZW50aWZpZXIo KSB3aWxsIHJldHVybiBudWxscHRyLiBJbiB0aGlzIGNhc2UsIHdlIHNob3VsZCBjcmFzaCBjbGVh bmx5CisgICAgICAgIHdpdGggU0lHQUJSVCB2aWEgZ19lcnJvcigpLCByYXRoZXIgdGhhbiBjcmFz aGluZyB3aXRoIGEgbnVsbCBwb2ludGVyIGRlcmVmZXJlbmNlIGluc2lkZQorICAgICAgICBnX2Fz Y2lpX3N0cnRvbGwoKS4gU0lHQUJSVCBpcyBtdWNoIG5pY2VyIHRoYW4gU0lHU0VHViBhbmQgaW5k aWNhdGVzIHRoYXQgd2UgcmVhbGx5IGRvIHdhbnQKKyAgICAgICAgdG8gY3Jhc2ggaGVyZSwgd2hl cmVhcyBTSUdTRUdWIGlzIGp1c3QgYSBidWcuCisKKyAgICAgICAgQWxzbywgbGV0J3MgYmUgY2Fy ZWZ1bCB3aXRoIG91ciB0ZXJtaW5vbG9neSBpbiB0aGUgZXhpc3RpbmcgZXJyb3IgbWVzc2FnZSBo ZXJlLiBBbHRob3VnaAorICAgICAgICBHU3VicHJvY2VzcyBjdXJyZW50bHkgYWx3YXlzIGZvcmtz LCBJJ20gd29ya2luZyB0byBtYWtlIGl0IHVzZSBwb3NpeF9zcGF3bigpIGluc3RlYWQsIHNvCisg ICAgICAgIGxldCdzIG5vdCBjbGFpbSB0aGF0IGZvcmsoKSBoYXMgZmFpbGVkIHdoZW4gaXQgc29v biBtaWdodCBub3QgYmUgdXNlZCBhdCBhbGwuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNo ZXIvZ2xpYi9Qcm9jZXNzTGF1bmNoZXJHTGliLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UHJvY2Vz c0xhdW5jaGVyOjpsYXVuY2hQcm9jZXNzKToKKwogMjAyMS0wNC0wMiAgSmVyIE5vYmxlICA8amVy Lm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbR1BVUF0gUG93ZXIgcmVncmVzc2lvbjogYXVk aW8gaGFyZHdhcmUgaXMgY29uZmlndXJlZCBmb3IgMTI4IGZyYW1lIHByZWZlcnJlZCBidWZmZXIg c2l6ZSBkdXJpbmcgVmlkZW9BdWRpbyBwbGF5YmFjawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9Qcm9jZXNzTGF1bmNoZXJHTGliLmNwcCBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvUHJvY2Vzc0xhdW5jaGVyR0xpYi5jcHAK aW5kZXggOTQwOGMxNmRjMzliNjkxZGVmNGY3Njc3NTQ3OGRkYWEzOGFlZmZmNi4uNDJmNGQ4MzQ0 MTFjOWI0MWZkMjQ5MTFhYzY4NGQzOTUxNTljYzhhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9Qcm9jZXNzTGF1bmNoZXJHTGliLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL1Byb2Nlc3NMYXVuY2hlckdMaWIu Y3BwCkBAIC0xODQsOSArMTg0LDEyIEBAIHZvaWQgUHJvY2Vzc0xhdW5jaGVyOjpsYXVuY2hQcm9j ZXNzKCkKICAgICAgICAgcHJvY2VzcyA9IGFkb3B0R1JlZihnX3N1YnByb2Nlc3NfbGF1bmNoZXJf c3Bhd252KGxhdW5jaGVyLmdldCgpLCBhcmd2LCAmZXJyb3Iub3V0UHRyKCkpKTsKIAogICAgIGlm ICghcHJvY2Vzcy5nZXQoKSkKLSAgICAgICAgZ19lcnJvcigiVW5hYmxlIHRvIGZvcmsgYSBuZXcg Y2hpbGQgcHJvY2VzczogJXMiLCBlcnJvci0+bWVzc2FnZSk7CisgICAgICAgIGdfZXJyb3IoIlVu YWJsZSB0byBzcGF3biBhIG5ldyBjaGlsZCBwcm9jZXNzOiAlcyIsIGVycm9yLT5tZXNzYWdlKTsK IAogICAgIGNvbnN0IGNoYXIqIHByb2Nlc3NJZFN0ciA9IGdfc3VicHJvY2Vzc19nZXRfaWRlbnRp Zmllcihwcm9jZXNzLmdldCgpKTsKKyAgICBpZiAoIXByb2Nlc3NJZFN0cikKKyAgICAgICAgZ19l cnJvcigiU3Bhd25lZCBwcm9jZXNzIGRpZWQgaW1tZWRpYXRlbHkuIFRoaXMgc2hvdWxkIG5vdCBo YXBwZW4uIik7CisKICAgICBtX3Byb2Nlc3NJZGVudGlmaWVyID0gZ19hc2NpaV9zdHJ0b2xsKHBy b2Nlc3NJZFN0ciwgbnVsbHB0ciwgMCk7CiAgICAgUkVMRUFTRV9BU1NFUlQobV9wcm9jZXNzSWRl bnRpZmllcik7CiAK