224207 2021-04-05 14:44:05 -0700 Suppress -Warray-bounds warning spam in Bitmap.h 2021-04-07 16:49:49 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build PC Linux RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 mcatanzaro mcatanzaro benjamin bugs-noreply cdumez cmarcelo don.olmstead ews-watchlist mcatanzaro oldest_to_newest 1747118 0 mcatanzaro 2021-04-05 14:44:05 -0700 With GCC 11, there is a huge warning spam coming from Bitmap.h: In file included from ../../Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp:27: DerivedSources/ForwardingHeaders/wtf/Bitmap.h: In function ‘void TestWebKitAPI::testBitmapIsFull() [with WordType = unsigned int]’: DerivedSources/ForwardingHeaders/wtf/Bitmap.h:229:24: warning: array subscript ‘_Type {aka const unsigned int [4]}[0]’ is partly outside array bounds of ‘WTF::Bitmap<9, unsigned int> [1]’ [-Warray-bounds] 229 | bits[n / wordSize] &= ~(one << (n % wordSize)); | ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp:104:33: note: while referencing ‘smallBitmap1’ 104 | Bitmap<smallSize, WordType> smallBitmap1; /* Will hold values specified in expectedSmallBits1. */ \ | ^~~~~~~~~~~~ ../../Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp:108:5: note: in expansion of macro ‘DECLARE_BITMAPS_FOR_TEST’ 108 | DECLARE_BITMAPS_FOR_TEST() \ | ^~~~~~~~~~~~~~~~~~~~~~~~ ../../Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp:441:5: note: in expansion of macro ‘DECLARE_AND_INIT_BITMAPS_FOR_TEST’ 441 | DECLARE_AND_INIT_BITMAPS_FOR_TEST(); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ It prints over 3000 lines of warnings for every translation unit that includes Bitmap.h. After squinting at this for a while, I failed to understand why GCC thought there was a problem here, so instead I added a runtime assert to see if the array bounds are ever exceeded. They are not, at least not by TestWTF nor when smoketesting Epiphany. 1747119 1 mcatanzaro 2021-04-05 14:45:59 -0700 (Note the debug assert might be controversial because this function seems to be called very frequently. I don't mind taking that out if requested.) 1747120 2 425209 mcatanzaro 2021-04-05 14:46:40 -0700 Created attachment 425209 Patch 1748077 3 mcatanzaro 2021-04-07 14:45:50 -0700 Let's land without the ASSERT. I don't think it matters very much either way. 1748079 4 425442 mcatanzaro 2021-04-07 14:46:41 -0700 Created attachment 425442 Patch for landing 1748147 5 ews-feeder 2021-04-07 16:49:45 -0700 Committed r275646: <https://commits.webkit.org/r275646> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425442. 425209 2021-04-05 14:46:40 -0700 2021-04-07 14:46:38 -0700 Patch bug-224207-20210405164640.patch text/plain 1404 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDAxZGRmNTUyODhiN2Q3ZmQ5NzQzNGNj YjI5ZDliMTA4MTg3OGJmMzAuLmI3OTM3YjliMDU0MGVjNTY3OGEzYjI4M2EyNDI1ZjY3Y2MyNDg4 NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDQtMDUgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgU3VwcHJlc3MgLVdhcnJheS1ib3VuZHMg d2FybmluZyBzcGFtIGluIEJpdG1hcC5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjQyMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTdXBwcmVzcyB0aGlzIHdhcm5pbmcuIEFkZCBhIGRlYnVnIEFTU0VS VCB0byB2ZXJpZnkgdGhlIGFycmF5IGJvdW5kcyBhcmUgbmV2ZXIgZXhjZWVkZWQsCisgICAgICAg IGp1c3QgaW4gY2FzZS4KKworICAgICAgICAqIHd0Zi9CaXRtYXAuaDoKKyAgICAgICAgKFdURjo6 V29yZFR5cGU+OjpjbGVhcik6CisKIDIwMjEtMDQtMDIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZy YXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxlIFByZWZlclBhZ2VSZW5kZXJpbmdVcGRh dGVzTmVhcjYwRlBTRW5hYmxlZCBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0 Zi9CaXRtYXAuaCBiL1NvdXJjZS9XVEYvd3RmL0JpdG1hcC5oCmluZGV4IDFhM2E2NzdjZTg4ZTk5 ZTdjZTJiYjc5NTE4ZjFhMzZhN2U0NzczYWEuLmM5ZjgzZmIzMzE1ZWY0NWY3MTJiNmU2ODFjODM0 ZTMzM2FhMGNhYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0JpdG1hcC5oCisrKyBiL1Nv dXJjZS9XVEYvd3RmL0JpdG1hcC5oCkBAIC0yMjYsNyArMjI2LDEwIEBAIEFMV0FZU19JTkxJTkUg Ym9vbCBCaXRtYXA8Yml0bWFwU2l6ZSwgV29yZFR5cGU+Ojpjb25jdXJyZW50VGVzdEFuZENsZWFy KHNpemVfdCBuCiB0ZW1wbGF0ZTxzaXplX3QgYml0bWFwU2l6ZSwgdHlwZW5hbWUgV29yZFR5cGU+ CiBpbmxpbmUgdm9pZCBCaXRtYXA8Yml0bWFwU2l6ZSwgV29yZFR5cGU+OjpjbGVhcihzaXplX3Qg bikKIHsKK0lHTk9SRV9XQVJOSU5HU19CRUdJTigiYXJyYXktYm91bmRzIikKKyAgICBBU1NFUlQo biAvIHdvcmRTaXplIDwgd29yZHMpOwogICAgIGJpdHNbbiAvIHdvcmRTaXplXSAmPSB+KG9uZSA8 PCAobiAlIHdvcmRTaXplKSk7CitJR05PUkVfV0FSTklOR1NfRU5ECiB9CiAKIHRlbXBsYXRlPHNp emVfdCBiaXRtYXBTaXplLCB0eXBlbmFtZSBXb3JkVHlwZT4K 425442 2021-04-07 14:46:41 -0700 2021-04-07 16:49:47 -0700 Patch for landing bug-224207-20210407164641.patch text/plain 1262 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGNhOGE3ZWM5MjAwYmQxZjM2MjFhY2Vh NDVjOGVlNDhiZDBiZTQ1NzcuLjJiZDc0YjRlYmRlYTBjMjMwZmRkZDAyOGI1OTZkZWQ3MTBhZGE3 ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDQtMDcgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgU3VwcHJlc3MgLVdhcnJheS1ib3VuZHMg d2FybmluZyBzcGFtIGluIEJpdG1hcC5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjQyMDcKKworICAgICAgICBSZXZpZXdlZCBieSBEb24gT2xtc3Rl YWQuCisKKyAgICAgICAgU3VwcHJlc3MgdGhpcyB3YXJuaW5nLgorCisgICAgICAgICogd3RmL0Jp dG1hcC5oOgorICAgICAgICAoV1RGOjpXb3JkVHlwZT46OmNsZWFyKToKKwogMjAyMS0wNC0wNiAg WW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxlIE5TVVJM U2Vzc2lvbiBXZWJTb2NrZXQgY29kZSBwYXRoIGJ5IGRlZmF1bHQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XVEYvd3RmL0JpdG1hcC5oIGIvU291cmNlL1dURi93dGYvQml0bWFwLmgKaW5kZXggMWEzYTY3 N2NlODhlOTllN2NlMmJiNzk1MThmMWEzNmE3ZTQ3NzNhYS4uNWE1YThkY2NmZTFhYWMxNjE2ZjNk MDE1NjYwMDUyYjEyYjIzMzQyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQml0bWFwLmgK KysrIGIvU291cmNlL1dURi93dGYvQml0bWFwLmgKQEAgLTIyNiw3ICsyMjYsOSBAQCBBTFdBWVNf SU5MSU5FIGJvb2wgQml0bWFwPGJpdG1hcFNpemUsIFdvcmRUeXBlPjo6Y29uY3VycmVudFRlc3RB bmRDbGVhcihzaXplX3QgbgogdGVtcGxhdGU8c2l6ZV90IGJpdG1hcFNpemUsIHR5cGVuYW1lIFdv cmRUeXBlPgogaW5saW5lIHZvaWQgQml0bWFwPGJpdG1hcFNpemUsIFdvcmRUeXBlPjo6Y2xlYXIo c2l6ZV90IG4pCiB7CitJR05PUkVfV0FSTklOR1NfQkVHSU4oImFycmF5LWJvdW5kcyIpCiAgICAg Yml0c1tuIC8gd29yZFNpemVdICY9IH4ob25lIDw8IChuICUgd29yZFNpemUpKTsKK0lHTk9SRV9X QVJOSU5HU19FTkQKIH0KIAogdGVtcGxhdGU8c2l6ZV90IGJpdG1hcFNpemUsIHR5cGVuYW1lIFdv cmRUeXBlPgo=