224206 2021-04-05 14:42:48 -0700 Web Inspector: remove duplicate Box Model section from Layout panel in Elements Tab 2022-03-01 02:24:56 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg ews-watchlist hi inspector-bugzilla-changes nvasilyev webkit-bug-importer oldest_to_newest 1747116 0 bburg 2021-04-05 14:42:48 -0700 After 220987 was fixed, we now have two Box Model locations. There should only be one. Option A. Leave in the "Computed" section alongside Computed Properties. This section is of questionable value as it is, and due for rethinking. The list of computed properties is not particularly helpful. Option B. Leave it in Layout section alongside Grid Inspector tools. This would leave the Computed section rather empty, just with the Computed Properties pane. 1747117 1 webkit-bug-importer 2021-04-05 14:43:04 -0700 <rdar://problem/76235731> 1747478 2 425290 bburg 2021-04-06 09:51:24 -0700 Created attachment 425290 Patch v1.0 1747482 3 nvasilyev 2021-04-06 09:57:16 -0700 Nit: can we retitle the bug "remove Box Model section from Computed" or something like that? This goes to STP changelogs. 1747485 4 425292 bburg 2021-04-06 10:03:41 -0700 Created attachment 425292 Patch v1.1 1747550 5 425292 hi 2021-04-06 11:44:31 -0700 Comment on attachment 425292 Patch v1.1 r=me 1747605 6 bburg 2021-04-06 13:26:48 -0700 Committed r275545 (236201@main): <https://commits.webkit.org/236201@main> 425290 2021-04-06 09:51:24 -0700 2021-04-06 10:03:39 -0700 Patch v1.0 bug-224206-20210406095124.patch text/plain 3136 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj MzA1M2ZiNmEwM2E0YjFmZmU2NjhhMmVjOWQyYTQxMDU0MWI1YjRlLi5lMTcyZThlNDBhOTI2NTg5 ODllMGRkNjBiZGJmZmQ1MTU4YWNmMjI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMS0wNC0wNiAgQkogQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKworICAg ICAgICBXZWIgSW5zcGVjdG9yOiBmaWd1cmUgb3V0IHdoZXJlIEJveCBNb2RlbCBzaG91bGQgYmVs b25nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQy MDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc2MjM1NzMxPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciBub3csIHJlbW92ZSBpdCBmcm9tIExh eW91dCBwYW5lbC4gSXQgbWF5IGdvIGJhY2sgdGhlcmUKKyAgICAgICAgd2hlbiBpdCBpcyBhYmxl IHRvIHNob3cgdXNlZCB2YWx1ZXMuIEl0IGN1cnJlbnRseSBvbmx5IHNob3dzIGNvbXB1dGVkLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9MYXlvdXREZXRhaWxzU2lkZWJhclBhbmVs LmpzOgorICAgICAgICAoV0kuTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbC5wcm90b3R5cGUuaW5p dGlhbExheW91dCk6CisgICAgICAgIChXSS5MYXlvdXREZXRhaWxzU2lkZWJhclBhbmVsLnByb3Rv dHlwZS5sYXlvdXQpOgorICAgICAgICAoV0kuTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbC5wcm90 b3R5cGUuZ2V0IG1pbmltdW1XaWR0aCk6IERlbGV0ZWQuCisKIDIwMjEtMDMtMzEgIFBhdHJpY2sg QW5nbGUgIDxwYW5nbGVAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlZ3Jl c3Npb24gKHIyNzAxMzQpIFRpbWVsaW5lIHJlY29yZGluZ3MgMiBhbmQgYmV5b25kIGRvIG5vdCBz aG93IGEgdGltZXNjYWxlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xheW91dERldGFpbHNTaWRlYmFyUGFuZWwu anMKaW5kZXggZDVjOTQ4OWFhYjk3OWIwMDNmMjg2Y2Q5M2UyZTU1N2IwNzFjMzI0Zi4uZDQyMmE4 OTlkMjdiZTMyZjJhYjY2YWRmYzgzOWU2MTU3ZDdjZTAxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5l bC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9MYXlv dXREZXRhaWxzU2lkZWJhclBhbmVsLmpzCkBAIC0zNiwxMSArMzYsNiBAQCBXSS5MYXlvdXREZXRh aWxzU2lkZWJhclBhbmVsID0gY2xhc3MgTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbCBleHRlbmRz IFdJLkRPTURldAogCiAgICAgLy8gUHVibGljCiAKLSAgICBnZXQgbWluaW11bVdpZHRoKCkKLSAg ICB7Ci0gICAgICAgIHJldHVybiB0aGlzLl9ib3hNb2RlbERpYWdyYW1Sb3c/Lm1pbmltdW1XaWR0 aCA/PyAwOwotICAgIH0KLQogICAgIGluc3BlY3Qob2JqZWN0cykKICAgICB7CiAgICAgICAgIC8v IExheW91dCBwYW5lbCBkb2Vzbid0IHNob3cgd2hlbiBoYXNET01Ob2RlIGlzIGZhbHNlLgpAQCAt MTAyLDExICs5Nyw2IEBAIFdJLkxheW91dERldGFpbHNTaWRlYmFyUGFuZWwgPSBjbGFzcyBMYXlv dXREZXRhaWxzU2lkZWJhclBhbmVsIGV4dGVuZHMgV0kuRE9NRGV0CiAKICAgICBpbml0aWFsTGF5 b3V0KCkKICAgICB7Ci0gICAgICAgIHRoaXMuX2JveE1vZGVsRGlhZ3JhbVJvdyA9IG5ldyBXSS5C b3hNb2RlbERldGFpbHNTZWN0aW9uUm93OwotICAgICAgICBsZXQgYm94TW9kZWxHcm91cCA9IG5l dyBXSS5EZXRhaWxzU2VjdGlvbkdyb3VwKFt0aGlzLl9ib3hNb2RlbERpYWdyYW1Sb3ddKTsKLSAg ICAgICAgbGV0IGJveE1vZGVsU2VjdGlvbiA9IG5ldyBXSS5EZXRhaWxzU2VjdGlvbigibGF5b3V0 LWJveC1tb2RlbCIsIFdJLlVJU3RyaW5nKCJCb3ggTW9kZWwiKSwgW2JveE1vZGVsR3JvdXBdKTsK LSAgICAgICAgdGhpcy5jb250ZW50Vmlldy5lbGVtZW50LmFwcGVuZENoaWxkKGJveE1vZGVsU2Vj dGlvbi5lbGVtZW50KTsKLQogICAgICAgICB0aGlzLl9ncmlkRGV0YWlsc1NlY3Rpb25Sb3cgPSBu ZXcgV0kuRGV0YWlsc1NlY3Rpb25Sb3coV0kuVUlTdHJpbmcoIk5vIENTUyBHcmlkIENvbnRleHRz IiwgIk5vIENTUyBHcmlkIENvbnRleHRzIEAgTGF5b3V0IERldGFpbHMgU2lkZWJhciBQYW5lbCIs ICJNZXNzYWdlIHNob3duIHdoZW4gdGhlcmUgYXJlIG5vIENTUyBHcmlkIGNvbnRleHRzIG9uIHRo ZSBpbnNwZWN0ZWQgcGFnZS4iKSk7CiAgICAgICAgIGxldCBncmlkR3JvdXAgPSBuZXcgV0kuRGV0 YWlsc1NlY3Rpb25Hcm91cChbdGhpcy5fZ3JpZERldGFpbHNTZWN0aW9uUm93XSk7CiAgICAgICAg IGxldCBncmlkRGV0YWlsc1NlY3Rpb24gPSBuZXcgV0kuRGV0YWlsc1NlY3Rpb24oImxheW91dC1j c3MtZ3JpZCIsIFdJLlVJU3RyaW5nKCJHcmlkIiwgIkdyaWQgQCBFbGVtZW50cyBkZXRhaWxzIHNp ZGViYXIiLCAiQ1NTIEdyaWQgbGF5b3V0IHNlY3Rpb24gbmFtZSIpLCBbZ3JpZEdyb3VwXSk7CkBA IC0xMzQsOSArMTI0LDYgQEAgV0kuTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbCA9IGNsYXNzIExh eW91dERldGFpbHNTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXSS5ET01EZXQKIAogICAgICAgICAgICAg dGhpcy5fZ3JpZFNlY3Rpb24uZ3JpZE5vZGVTZXQgPSB0aGlzLl9ncmlkTm9kZVNldDsKICAgICAg ICAgfQotCi0gICAgICAgIGlmICh0aGlzLl9ib3hNb2RlbERpYWdyYW1Sb3cubm9kZVN0eWxlcyAh PT0gdGhpcy5fbm9kZVN0eWxlcykKLSAgICAgICAgICAgIHRoaXMuX2JveE1vZGVsRGlhZ3JhbVJv dy5ub2RlU3R5bGVzID0gdGhpcy5fbm9kZVN0eWxlczsKICAgICB9CiAKICAgICAvLyBQcml2YXRl Cg== 425292 2021-04-06 10:03:41 -0700 2022-03-01 02:24:56 -0800 Patch v1.1 bug-224206-20210406100340.patch text/plain 3164 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj MzA1M2ZiNmEwM2E0YjFmZmU2NjhhMmVjOWQyYTQxMDU0MWI1YjRlLi41NDllNzNjNmQwNzVmOTY5 M2EwZGE2ZjVjOTU0ZGJlZTlhNWU2OGI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMS0wNC0wNiAgQkogQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKworICAg ICAgICBXZWIgSW5zcGVjdG9yOiByZW1vdmUgZHVwbGljYXRlIEJveCBNb2RlbCBzZWN0aW9uIGZy b20gTGF5b3V0IHBhbmVsIGluIEVsZW1lbnRzIFRhYgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MjA2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83 NjIzNTczMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGb3Igbm93LCByZW1vdmUgaXQgZnJvbSBMYXlvdXQgcGFuZWwuIEl0IG1heSBnbyBiYWNrIHRo ZXJlCisgICAgICAgIHdoZW4gaXQgaXMgYWJsZSB0byBzaG93IHVzZWQgdmFsdWVzLiBJdCBjdXJy ZW50bHkgb25seSBzaG93cyBjb21wdXRlZC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmll d3MvTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdJLkxheW91dERldGFp bHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLmluaXRpYWxMYXlvdXQpOgorICAgICAgICAoV0kuTGF5 b3V0RGV0YWlsc1NpZGViYXJQYW5lbC5wcm90b3R5cGUubGF5b3V0KToKKyAgICAgICAgKFdJLkxh eW91dERldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLmdldCBtaW5pbXVtV2lkdGgpOiBEZWxl dGVkLgorCiAyMDIxLTAzLTMxICBQYXRyaWNrIEFuZ2xlICA8cGFuZ2xlQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZWdyZXNzaW9uIChyMjcwMTM0KSBUaW1lbGluZSByZWNv cmRpbmdzIDIgYW5kIGJleW9uZCBkbyBub3Qgc2hvdyBhIHRpbWVzY2FsZS4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xheW91dERldGFpbHNT aWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9MYXlvdXREZXRhaWxzU2lkZWJhclBhbmVsLmpzCmluZGV4IGQ1Yzk0ODlhYWI5NzliMDAzZjI4 NmNkOTNlMmU1NTdiMDcxYzMyNGYuLmQ0MjJhODk5ZDI3YmUzMmYyYWI2NmFkZmM4MzllNjE1N2Q3 Y2UwMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0xheW91dERldGFpbHNTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbC5qcwpAQCAt MzYsMTEgKzM2LDYgQEAgV0kuTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbCA9IGNsYXNzIExheW91 dERldGFpbHNTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXSS5ET01EZXQKIAogICAgIC8vIFB1YmxpYwog Ci0gICAgZ2V0IG1pbmltdW1XaWR0aCgpCi0gICAgewotICAgICAgICByZXR1cm4gdGhpcy5fYm94 TW9kZWxEaWFncmFtUm93Py5taW5pbXVtV2lkdGggPz8gMDsKLSAgICB9Ci0KICAgICBpbnNwZWN0 KG9iamVjdHMpCiAgICAgewogICAgICAgICAvLyBMYXlvdXQgcGFuZWwgZG9lc24ndCBzaG93IHdo ZW4gaGFzRE9NTm9kZSBpcyBmYWxzZS4KQEAgLTEwMiwxMSArOTcsNiBAQCBXSS5MYXlvdXREZXRh aWxzU2lkZWJhclBhbmVsID0gY2xhc3MgTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbCBleHRlbmRz IFdJLkRPTURldAogCiAgICAgaW5pdGlhbExheW91dCgpCiAgICAgewotICAgICAgICB0aGlzLl9i b3hNb2RlbERpYWdyYW1Sb3cgPSBuZXcgV0kuQm94TW9kZWxEZXRhaWxzU2VjdGlvblJvdzsKLSAg ICAgICAgbGV0IGJveE1vZGVsR3JvdXAgPSBuZXcgV0kuRGV0YWlsc1NlY3Rpb25Hcm91cChbdGhp cy5fYm94TW9kZWxEaWFncmFtUm93XSk7Ci0gICAgICAgIGxldCBib3hNb2RlbFNlY3Rpb24gPSBu ZXcgV0kuRGV0YWlsc1NlY3Rpb24oImxheW91dC1ib3gtbW9kZWwiLCBXSS5VSVN0cmluZygiQm94 IE1vZGVsIiksIFtib3hNb2RlbEdyb3VwXSk7Ci0gICAgICAgIHRoaXMuY29udGVudFZpZXcuZWxl bWVudC5hcHBlbmRDaGlsZChib3hNb2RlbFNlY3Rpb24uZWxlbWVudCk7Ci0KICAgICAgICAgdGhp cy5fZ3JpZERldGFpbHNTZWN0aW9uUm93ID0gbmV3IFdJLkRldGFpbHNTZWN0aW9uUm93KFdJLlVJ U3RyaW5nKCJObyBDU1MgR3JpZCBDb250ZXh0cyIsICJObyBDU1MgR3JpZCBDb250ZXh0cyBAIExh eW91dCBEZXRhaWxzIFNpZGViYXIgUGFuZWwiLCAiTWVzc2FnZSBzaG93biB3aGVuIHRoZXJlIGFy ZSBubyBDU1MgR3JpZCBjb250ZXh0cyBvbiB0aGUgaW5zcGVjdGVkIHBhZ2UuIikpOwogICAgICAg ICBsZXQgZ3JpZEdyb3VwID0gbmV3IFdJLkRldGFpbHNTZWN0aW9uR3JvdXAoW3RoaXMuX2dyaWRE ZXRhaWxzU2VjdGlvblJvd10pOwogICAgICAgICBsZXQgZ3JpZERldGFpbHNTZWN0aW9uID0gbmV3 IFdJLkRldGFpbHNTZWN0aW9uKCJsYXlvdXQtY3NzLWdyaWQiLCBXSS5VSVN0cmluZygiR3JpZCIs ICJHcmlkIEAgRWxlbWVudHMgZGV0YWlscyBzaWRlYmFyIiwgIkNTUyBHcmlkIGxheW91dCBzZWN0 aW9uIG5hbWUiKSwgW2dyaWRHcm91cF0pOwpAQCAtMTM0LDkgKzEyNCw2IEBAIFdJLkxheW91dERl dGFpbHNTaWRlYmFyUGFuZWwgPSBjbGFzcyBMYXlvdXREZXRhaWxzU2lkZWJhclBhbmVsIGV4dGVu ZHMgV0kuRE9NRGV0CiAKICAgICAgICAgICAgIHRoaXMuX2dyaWRTZWN0aW9uLmdyaWROb2RlU2V0 ID0gdGhpcy5fZ3JpZE5vZGVTZXQ7CiAgICAgICAgIH0KLQotICAgICAgICBpZiAodGhpcy5fYm94 TW9kZWxEaWFncmFtUm93Lm5vZGVTdHlsZXMgIT09IHRoaXMuX25vZGVTdHlsZXMpCi0gICAgICAg ICAgICB0aGlzLl9ib3hNb2RlbERpYWdyYW1Sb3cubm9kZVN0eWxlcyA9IHRoaXMuX25vZGVTdHls ZXM7CiAgICAgfQogCiAgICAgLy8gUHJpdmF0ZQo=