224200 2021-04-05 13:12:36 -0700 Web Inspector: Grid overlay line numbers should not include implicit tracks in negative line number calculations. 2021-04-06 16:14:39 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 224199 1 pangle pangle bburg ews-watchlist hi inspector-bugzilla-changes joepeck pangle webkit-bug-importer oldest_to_newest 1747075 0 pangle 2021-04-05 13:12:36 -0700 The negative line numbers should only be counting from the last explicit track in each direction. Currently they are being shown as counting from the last track, including implicit tracks. 1747501 1 webkit-bug-importer 2021-04-06 10:20:18 -0700 <rdar://problem/76272817> 1747617 2 425321 pangle 2021-04-06 13:48:39 -0700 Created attachment 425321 Patch v1.0 1747620 3 425321 bburg 2021-04-06 13:52:56 -0700 Comment on attachment 425321 Patch v1.0 r=me 1747659 4 ews-feeder 2021-04-06 15:09:15 -0700 Committed r275558: <https://commits.webkit.org/r275558> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425321. 425321 2021-04-06 13:48:39 -0700 2021-04-06 16:14:39 -0700 Patch v1.0 bug-224200-20210406134838.patch text/plain 3815 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjhmYmFmNjAxMjBhYjcw MjljNmM5ZjYzMmExMTk0MjAyMzEzNzMwNC4uYWUxMDBjODZmZDA2NDY1NzIwZGEwODkwZjk2Y2Zk YTYxMWRkOGQ5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA0LTA2ICBQYXRy aWNrIEFuZ2xlICA8cGFuZ2xlQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBH cmlkIG92ZXJsYXkgbGluZSBudW1iZXJzIHNob3VsZCBub3QgaW5jbHVkZSBpbXBsaWNpdCB0cmFj a3MgaW4gbmVnYXRpdmUgbGluZSBudW1iZXIgY2FsY3VsYXRpb25zLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MjAwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHRoZSBgYXV0aG9yZWRUcmFja0Nv bHVtblNpemVzYC9gYXV0aG9yZWRUcmFja1Jvd1NpemVzYCB0byBkZXRlcm1pbmUgaWYgdGhlIGxp bmUgaXMgYW4gZXhwbGljaXQgZ3JpZCBsaW5lIG9yCisgICAgICAgIGltcGxpY2l0IGdyaWQgbGlu ZSAoc3RhcnRpbmcgd2l0aCB0aGUgcGF0Y2ggZm9yIGJ1ZyAyMjQxOTkgdGhvc2UgdmVjdG9ycyB3 aWxsIG9ubHkgY29udGFpbiB0aGUgZXhwbGljaXQgbGluZXMpLgorICAgICAgICBPbmx5IGV4cGxp Y2l0IGxpbmVzIHNob3VsZCBoYXZlIGEgbmVnYXRpdmUgbnVtYmVyIGZvciBhZGRyZXNzaW5nIHRo ZSBsaW5lLCBhbmQgdGhvc2UgbnVtYmVycyBzaG91bGQgc3RhcnQgd2l0aAorICAgICAgICB0aGUg bGFzdCBleHBsaWNpdCBsaW5lLiBCZWNhdXNlIGVhY2ggdHJhY2sgaXMgYm91bmRlZCBieSB0d28g bGluZXMsIHRoZXJlIHdpbGwgYWx3YXlzIGJlIG9uZSBtb3JlIGV4cGxpY2l0IGxpbmUKKyAgICAg ICAgdGhhbiB0aGVyZSBpcyBleHBsaWNpdCB0cmFjaywgaW5jbHVkaW5nIHRoZSBjYXNlIHdoZXJl IHRoZXJlIGFyZSBubyBleHBsaWNpdCB0cmFja3MsIHdoaWNoIHdpbGwgc3RpbGwgaGF2ZSBhCisg ICAgICAgIHNpbmdsZSBleHBsaWNpdCBsaW5lIG51bWJlcmVkIGAtMWAuCisKKyAgICAgICAgQWRk aXRpb25hbGx5LCBsaW5lIG51bWJlcnMgYXJlIG5vdyBzZXBhcmF0ZWQgYnkgYW4gZW0tc3BhY2Ug dG8gaW1wcm92ZSBsZWdpYmlsaXR5LCB3aGVyZSBwcmV2aW91c2x5IHRoZSBidWxsZXQKKyAgICAg ICAgbG9va2VkIGxpa2UgYSBtdWx0aXBsaWNhdGlvbiBzeW1ib2wgYmV0d2VlbiB0d28gbnVtYmVy cy4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Okluc3BlY3Rvck92ZXJsYXk6OmJ1aWxkR3JpZE92ZXJsYXkpOgorCiAyMDIxLTA0 LTA2ICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBb R1N0cmVhbWVyXSBBdCBFT1MsIGNoYW5nZSBwb3NpdGlvbiB0byBtYXRjaCBkdXJhdGlvbiwgbm90 IHRoZSBvdGhlciB3YXkgYXJvdW5kLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3Rvck92ZXJsYXkuY3BwCmluZGV4IDU3MTMxOGEzMzNlOTQ3ODRiYzA2MTUxYjAwYTc2ODJlM2Vl NjdiOTMuLjQ2Njk3MzU0ZDcxMjQ2YmJjMDJmNTI1MmM0YzFiYTFjNjZmZWMwOWQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAKQEAgLTkyLDYgKzky LDcgQEAgc3RhdGljIGNvbnN0ZXhwciBVQ2hhciBidWxsZXQgPSAweDIwMjI7CiBzdGF0aWMgY29u c3RleHByIFVDaGFyIGVsbGlwc2lzID0gMHgyMDI2Owogc3RhdGljIGNvbnN0ZXhwciBVQ2hhciBt dWx0aXBsaWNhdGlvblNpZ24gPSAweDAwRDc7CiBzdGF0aWMgY29uc3RleHByIFVDaGFyIHRoaW5T cGFjZSA9IDB4MjAwOTsKK3N0YXRpYyBjb25zdGV4cHIgVUNoYXIgZW1TcGFjZSA9IDB4MjAwMzsK IAogc3RhdGljIHZvaWQgdHJ1bmNhdGVXaXRoRWxsaXBzaXMoU3RyaW5nJiBzdHJpbmcsIHNpemVf dCBsZW5ndGgpCiB7CkBAIC0xODA2LDggKzE4MDcsMTEgQEAgT3B0aW9uYWw8SW5zcGVjdG9yT3Zl cmxheTo6SGlnaGxpZ2h0OjpHcmlkSGlnaGxpZ2h0T3ZlcmxheT4gSW5zcGVjdG9yT3ZlcmxheTo6 YnUKICAgICAgICAgICAgIHByZXZpb3VzQ29sdW1uRW5kTGluZSA9IGNvbHVtblN0YXJ0TGluZTsK IAogICAgICAgICBTdHJpbmdCdWlsZGVyIGxpbmVMYWJlbDsKLSAgICAgICAgaWYgKGdyaWRPdmVy bGF5LmNvbmZpZy5zaG93TGluZU51bWJlcnMpCi0gICAgICAgICAgICBsaW5lTGFiZWwuYXBwZW5k KGkgKyAxLCB0aGluU3BhY2UsIGJ1bGxldCwgdGhpblNwYWNlLCAtc3RhdGljX2Nhc3Q8aW50Pihj b2x1bW5Qb3NpdGlvbnMuc2l6ZSgpIC0gaSkpOworICAgICAgICBpZiAoZ3JpZE92ZXJsYXkuY29u ZmlnLnNob3dMaW5lTnVtYmVycykgeworICAgICAgICAgICAgbGluZUxhYmVsLmFwcGVuZChpICsg MSk7CisgICAgICAgICAgICBpZiAoaSA8PSBhdXRob3JlZFRyYWNrQ29sdW1uU2l6ZXMuc2l6ZSgp KQorICAgICAgICAgICAgICAgIGxpbmVMYWJlbC5hcHBlbmQoZW1TcGFjZSwgLXN0YXRpY19jYXN0 PGludD4oYXV0aG9yZWRUcmFja0NvbHVtblNpemVzLnNpemUoKSAtIGkgKyAxKSk7CisgICAgICAg IH0KICAgICAgICAgaWYgKGdyaWRPdmVybGF5LmNvbmZpZy5zaG93TGluZU5hbWVzICYmIGNvbHVt bkxpbmVOYW1lcy5jb250YWlucyhpKSkgewogICAgICAgICAgICAgZm9yIChhdXRvIGxpbmVOYW1l IDogY29sdW1uTGluZU5hbWVzLmdldChpKSkgewogICAgICAgICAgICAgICAgIGlmICghbGluZUxh YmVsLmlzRW1wdHkoKSkKQEAgLTE5MDAsOCArMTkwNCwxMSBAQCBPcHRpb25hbDxJbnNwZWN0b3JP dmVybGF5OjpIaWdobGlnaHQ6OkdyaWRIaWdobGlnaHRPdmVybGF5PiBJbnNwZWN0b3JPdmVybGF5 OjpidQogICAgICAgICAgICAgcHJldmlvdXNSb3dFbmRMaW5lID0gcm93U3RhcnRMaW5lOwogCiAg ICAgICAgIFN0cmluZ0J1aWxkZXIgbGluZUxhYmVsOwotICAgICAgICBpZiAoZ3JpZE92ZXJsYXku Y29uZmlnLnNob3dMaW5lTnVtYmVycykKLSAgICAgICAgICAgIGxpbmVMYWJlbC5hcHBlbmQoaSAr IDEsIHRoaW5TcGFjZSwgYnVsbGV0LCB0aGluU3BhY2UsIC1zdGF0aWNfY2FzdDxpbnQ+KHJvd1Bv c2l0aW9ucy5zaXplKCkgLSBpKSk7CisgICAgICAgIGlmIChncmlkT3ZlcmxheS5jb25maWcuc2hv d0xpbmVOdW1iZXJzKSB7CisgICAgICAgICAgICBsaW5lTGFiZWwuYXBwZW5kKGkgKyAxKTsKKyAg ICAgICAgICAgIGlmIChpIDw9IGF1dGhvcmVkVHJhY2tSb3dTaXplcy5zaXplKCkpCisgICAgICAg ICAgICAgICAgbGluZUxhYmVsLmFwcGVuZChlbVNwYWNlLCAtc3RhdGljX2Nhc3Q8aW50PihhdXRo b3JlZFRyYWNrUm93U2l6ZXMuc2l6ZSgpIC0gaSArIDEpKTsKKyAgICAgICAgfQogICAgICAgICBp ZiAoZ3JpZE92ZXJsYXkuY29uZmlnLnNob3dMaW5lTmFtZXMgJiYgcm93TGluZU5hbWVzLmNvbnRh aW5zKGkpKSB7CiAgICAgICAgICAgICBmb3IgKGF1dG8gbGluZU5hbWUgOiByb3dMaW5lTmFtZXMu Z2V0KGkpKSB7CiAgICAgICAgICAgICAgICAgaWYgKCFsaW5lTGFiZWwuaXNFbXB0eSgpKQo=