224199 2021-04-05 13:11:08 -0700 Web Inspector: Grid overlay track size labels should show implicit `auto` value and no computed size 2021-04-06 15:09:30 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 224200 1 pangle pangle bburg ews-watchlist hi inspector-bugzilla-changes joepeck pangle webkit-bug-importer oldest_to_newest 1747074 0 pangle 2021-04-05 13:11:08 -0700 Track size labels currently do not show a value of `auto` when `auto` is implicit. Additionally, we don't want to show computed sizes in these labels as they are 1. additional noise when looking for information and 2. information that should not be a focal point of modern page layout. Children in the grid can still have their computed sizes looked up in the Box Model diagram. 1747502 1 webkit-bug-importer 2021-04-06 10:20:45 -0700 <rdar://problem/76272845> 1747603 2 425319 pangle 2021-04-06 13:22:00 -0700 Created attachment 425319 Patch v1.0 1747606 3 425319 bburg 2021-04-06 13:31:32 -0700 Comment on attachment 425319 Patch v1.0 r=me 1747660 4 ews-feeder 2021-04-06 15:09:29 -0700 Committed r275559: <https://commits.webkit.org/r275559> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425319. 425319 2021-04-06 13:22:00 -0700 2021-04-06 15:09:30 -0700 Patch v1.0 bug-224199-20210406132200.patch text/plain 5663 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjhmYmFmNjAxMjBhYjcw MjljNmM5ZjYzMmExMTk0MjAyMzEzNzMwNC4uMjViNTM2NDY5ZTc1NzdiY2FkMDk4YTNlOTMxZTJh MmFlN2I0MGZjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA0LTA2ICBQYXRy aWNrIEFuZ2xlICA8cGFuZ2xlQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBH cmlkIG92ZXJsYXkgdHJhY2sgc2l6ZSBsYWJlbHMgc2hvdWxkIHNob3cgaW1wbGljaXQgYGF1dG9g IHZhbHVlIGFuZCBubyBjb21wdXRlZCBzaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQxOTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBQcmV2aW91c2x5LCBpbXBsaWNpdCBgYXV0b2AgdHJhY2sgc2l6 ZXMgd2VyZSBvbmx5IHNob3duIGlmIHRoZXJlIHdlcmUgc29tZSBudW1iZXIgb2YgZXhwbGljaXQg dHJhY2sgc2l6ZXMgZm9yCisgICAgICAgIHRoYXQgdHJhY2sgZGlyZWN0aW9uIChyb3dzL2NvbHVt bnMpLiBUbyByZXNvbHZlIHRoaXMsIGBhdXRob3JlZEdyaWRUcmFja1NpemVzYCBub3cgb25seSBy ZXR1cm5zIGV4cGxpY2l0CisgICAgICAgIGF1dGhvcmVkIHRyYWNrIHNpemVzLCBhbmQgYnVpbGRH cmlkT3ZlcmxheSB0aGVuIGluZmVycyBgYXV0b2AgZm9yIGFsbCByZW1haW5pbmcgdHJhY2tzLiBU aGlzIHdpbGwgYWxzbyBoZWxwCisgICAgICAgIHJlc29sdmUgYnVnIDIyNDIwMCBieSBwcm92aWRp bmcgYSB3YXkgdG8gZGlzdGluZ3Vpc2ggZXhwbGljaXQgYW5kIGltcGxpY2l0IHRyYWNrcy4KKwor ICAgICAgICBBZnRlciBkaXNjdXNzaW9uLCB0aGlzIHBhdGNoIGFsc28gcmVtb3ZlcyB0aGUgY29t cHV0ZWQgc2l6ZSBvZiB0cmFja3MgZnJvbSBsYWJlbHMsIGFzIHRoYXQgaW5mb3JtYXRpb24gaXMK KyAgICAgICAgYXZhaWxhYmxlIGluIHRoZSBib3ggbW9kZWwgZGlhZ3JhbSBmb3IgY2hpbGRyZW4g ZWxlbWVudHMgYW5kIGhhdmluZyB0aGF0IGluZm9ybWF0aW9uIGluIHRoZXNlIGxhYmVscyBmdXJ0 aGVyCisgICAgICAgIGNyYW1wZWQgb2Z0ZW4gbGltaXRlZCBzcGFjZSBmb3Igb3ZlcmxheSBsYWJl bHMuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHA6CisgICAgICAg IChXZWJDb3JlOjphdXRob3JlZEdyaWRUcmFja1NpemVzKToKKyAgICAgICAgKFdlYkNvcmU6Oklu c3BlY3Rvck92ZXJsYXk6OmJ1aWxkR3JpZE92ZXJsYXkpOgorCiAyMDIxLTA0LTA2ICBBbGljaWEg Qm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBB dCBFT1MsIGNoYW5nZSBwb3NpdGlvbiB0byBtYXRjaCBkdXJhdGlvbiwgbm90IHRoZSBvdGhlciB3 YXkgYXJvdW5kLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ck92ZXJsYXkuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXku Y3BwCmluZGV4IDU3MTMxOGEzMzNlOTQ3ODRiYzA2MTUxYjAwYTc2ODJlM2VlNjdiOTMuLjU5NDMy MzVlYWNlMmNlMjljZDhkM2NiNDY5Y2ZjYTM2Zjk1ODg4YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAKQEAgLTE1NTAsMTAgKzE1NTAsNiBAQCBz dGF0aWMgVmVjdG9yPFN0cmluZz4gYXV0aG9yZWRHcmlkVHJhY2tTaXplcyhOb2RlKiBub2RlLCBH cmlkVHJhY2tTaXppbmdEaXJlY3RpbwogCiAgICAgICAgIGhhbmRsZVZhbHVlSWdub3JpbmdMaW5l TmFtZXMoY3VycmVudFZhbHVlKTsKICAgICB9Ci0KLSAgICAvLyBSZW1haW5pbmcgdHJhY2tzIHdp bGwgYmUgYGF1dG9gLgotICAgIHdoaWxlICh0cmFja1NpemVzLnNpemUoKSA8IGV4cGVjdGVkVHJh Y2tDb3VudCkKLSAgICAgICAgdHJhY2tTaXplcy5hcHBlbmQoImF1dG8iX3MpOwogICAgIAogICAg IHJldHVybiB0cmFja1NpemVzOwogfQpAQCAtMTc4NSwyMiArMTc4MSw5IEBAIE9wdGlvbmFsPElu c3BlY3Rvck92ZXJsYXk6OkhpZ2hsaWdodDo6R3JpZEhpZ2hsaWdodE92ZXJsYXk+IEluc3BlY3Rv ck92ZXJsYXk6OmJ1CiAgICAgICAgICAgICBwcmV2aW91c0NvbHVtbkVuZExpbmUgPSBjb2x1bW5F bmRMaW5lOwogICAgICAgICAgICAgCiAgICAgICAgICAgICBpZiAoZ3JpZE92ZXJsYXkuY29uZmln LnNob3dUcmFja1NpemVzKSB7Ci0gICAgICAgICAgICAgICAgYXV0byB0cmFja1NpemVMYWJlbCA9 IFN0cmluZzo6bnVtYmVyKHJvdW5kZih3aWR0aCkpOwotICAgICAgICAgICAgICAgIHRyYWNrU2l6 ZUxhYmVsLmFwcGVuZCgicHgiX3MpOwotCi0gICAgICAgICAgICAgICAgU3RyaW5nIGF1dGhvcmVk VHJhY2tTaXplOwotICAgICAgICAgICAgICAgIGlmIChpIDwgYXV0aG9yZWRUcmFja0NvbHVtblNp emVzLnNpemUoKSkgewotICAgICAgICAgICAgICAgICAgICBhdXRvIGF1dGhvcmVkVHJhY2tTaXpl ID0gYXV0aG9yZWRUcmFja0NvbHVtblNpemVzW2ldOwotICAgICAgICAgICAgICAgICAgICBpZiAo YXV0aG9yZWRUcmFja1NpemUubGVuZ3RoKCkgJiYgYXV0aG9yZWRUcmFja1NpemUgIT0gdHJhY2tT aXplTGFiZWwpIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIHRyYWNrU2l6ZUxhYmVsLmFwcGVu ZCh0aGluU3BhY2UpOwotICAgICAgICAgICAgICAgICAgICAgICAgdHJhY2tTaXplTGFiZWwuYXBw ZW5kKGJ1bGxldCk7Ci0gICAgICAgICAgICAgICAgICAgICAgICB0cmFja1NpemVMYWJlbC5hcHBl bmQodGhpblNwYWNlKTsKLSAgICAgICAgICAgICAgICAgICAgICAgIHRyYWNrU2l6ZUxhYmVsLmFw cGVuZChhdXRob3JlZFRyYWNrU2l6ZSk7Ci0gICAgICAgICAgICAgICAgICAgIH0KLSAgICAgICAg ICAgICAgICB9Ci0KKyAgICAgICAgICAgICAgICBhdXRvIGF1dGhvcmVkVHJhY2tTaXplID0gaSA8 IGF1dGhvcmVkVHJhY2tDb2x1bW5TaXplcy5zaXplKCkgPyBhdXRob3JlZFRyYWNrQ29sdW1uU2l6 ZXNbaV0gOiAiYXV0byJfczsKICAgICAgICAgICAgICAgICBGbG9hdExpbmUgdHJhY2tUb3BMaW5l ID0geyBjb2x1bW5TdGFydExpbmUuc3RhcnQoKSwgY29sdW1uRW5kTGluZS5zdGFydCgpIH07Ci0g ICAgICAgICAgICAgICAgZ3JpZEhpZ2hsaWdodE92ZXJsYXkubGFiZWxzLmFwcGVuZChidWlsZExh YmVsKHRyYWNrU2l6ZUxhYmVsLCB0cmFja1RvcExpbmUucG9pbnRBdFJlbGF0aXZlRGlzdGFuY2Uo MC41KSwgdHJhbnNsdWNlbnRMYWJlbEJhY2tncm91bmRDb2xvciwgY29ycmVjdGVkQXJyb3dEaXJl Y3Rpb24oTGFiZWxBcnJvd0RpcmVjdGlvbjo6VXAsIEdyaWRUcmFja1NpemluZ0RpcmVjdGlvbjo6 Rm9yQ29sdW1ucyksIExhYmVsQXJyb3dFZGdlUG9zaXRpb246Ok1pZGRsZSkpOworICAgICAgICAg ICAgICAgIGdyaWRIaWdobGlnaHRPdmVybGF5LmxhYmVscy5hcHBlbmQoYnVpbGRMYWJlbChhdXRo b3JlZFRyYWNrU2l6ZSwgdHJhY2tUb3BMaW5lLnBvaW50QXRSZWxhdGl2ZURpc3RhbmNlKDAuNSks IHRyYW5zbHVjZW50TGFiZWxCYWNrZ3JvdW5kQ29sb3IsIGNvcnJlY3RlZEFycm93RGlyZWN0aW9u KExhYmVsQXJyb3dEaXJlY3Rpb246OlVwLCBHcmlkVHJhY2tTaXppbmdEaXJlY3Rpb246OkZvckNv bHVtbnMpLCBMYWJlbEFycm93RWRnZVBvc2l0aW9uOjpNaWRkbGUpKTsKICAgICAgICAgICAgIH0K ICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICBwcmV2aW91c0NvbHVtbkVuZExpbmUgPSBjb2x1 bW5TdGFydExpbmU7CkBAIC0xODc5LDIyICsxODYyLDkgQEAgT3B0aW9uYWw8SW5zcGVjdG9yT3Zl cmxheTo6SGlnaGxpZ2h0OjpHcmlkSGlnaGxpZ2h0T3ZlcmxheT4gSW5zcGVjdG9yT3ZlcmxheTo6 YnUKICAgICAgICAgICAgIHByZXZpb3VzUm93RW5kTGluZSA9IHJvd0VuZExpbmU7CiAKICAgICAg ICAgICAgIGlmIChncmlkT3ZlcmxheS5jb25maWcuc2hvd1RyYWNrU2l6ZXMpIHsKLSAgICAgICAg ICAgICAgICBhdXRvIHRyYWNrU2l6ZUxhYmVsID0gU3RyaW5nOjpudW1iZXIocm91bmRmKGhlaWdo dCkpOwotICAgICAgICAgICAgICAgIHRyYWNrU2l6ZUxhYmVsLmFwcGVuZCgicHgiX3MpOwotCi0g ICAgICAgICAgICAgICAgU3RyaW5nIGF1dGhvcmVkVHJhY2tTaXplOwotICAgICAgICAgICAgICAg IGlmIChpIDwgYXV0aG9yZWRUcmFja1Jvd1NpemVzLnNpemUoKSkgewotICAgICAgICAgICAgICAg ICAgICBhdXRvIGF1dGhvcmVkVHJhY2tTaXplID0gYXV0aG9yZWRUcmFja1Jvd1NpemVzW2ldOwot ICAgICAgICAgICAgICAgICAgICBpZiAoYXV0aG9yZWRUcmFja1NpemUubGVuZ3RoKCkgJiYgYXV0 aG9yZWRUcmFja1NpemUgIT0gdHJhY2tTaXplTGFiZWwpIHsKLSAgICAgICAgICAgICAgICAgICAg ICAgIHRyYWNrU2l6ZUxhYmVsLmFwcGVuZCh0aGluU3BhY2UpOwotICAgICAgICAgICAgICAgICAg ICAgICAgdHJhY2tTaXplTGFiZWwuYXBwZW5kKGJ1bGxldCk7Ci0gICAgICAgICAgICAgICAgICAg ICAgICB0cmFja1NpemVMYWJlbC5hcHBlbmQodGhpblNwYWNlKTsKLSAgICAgICAgICAgICAgICAg ICAgICAgIHRyYWNrU2l6ZUxhYmVsLmFwcGVuZChhdXRob3JlZFRyYWNrU2l6ZSk7Ci0gICAgICAg ICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICB9Ci0KKyAgICAgICAgICAgICAgICBhdXRv IGF1dGhvcmVkVHJhY2tTaXplID0gaSA8IGF1dGhvcmVkVHJhY2tSb3dTaXplcy5zaXplKCkgPyBh dXRob3JlZFRyYWNrUm93U2l6ZXNbaV0gOiAiYXV0byJfczsKICAgICAgICAgICAgICAgICBGbG9h dExpbmUgdHJhY2tMZWZ0TGluZSA9IHsgcm93U3RhcnRMaW5lLnN0YXJ0KCksIHJvd0VuZExpbmUu c3RhcnQoKSB9OwotICAgICAgICAgICAgICAgIGdyaWRIaWdobGlnaHRPdmVybGF5LmxhYmVscy5h cHBlbmQoYnVpbGRMYWJlbCh0cmFja1NpemVMYWJlbCwgdHJhY2tMZWZ0TGluZS5wb2ludEF0UmVs YXRpdmVEaXN0YW5jZSgwLjUpLCB0cmFuc2x1Y2VudExhYmVsQmFja2dyb3VuZENvbG9yLCBjb3Jy ZWN0ZWRBcnJvd0RpcmVjdGlvbihMYWJlbEFycm93RGlyZWN0aW9uOjpMZWZ0LCBHcmlkVHJhY2tT aXppbmdEaXJlY3Rpb246OkZvclJvd3MpLCBMYWJlbEFycm93RWRnZVBvc2l0aW9uOjpNaWRkbGUp KTsKKyAgICAgICAgICAgICAgICBncmlkSGlnaGxpZ2h0T3ZlcmxheS5sYWJlbHMuYXBwZW5kKGJ1 aWxkTGFiZWwoYXV0aG9yZWRUcmFja1NpemUsIHRyYWNrTGVmdExpbmUucG9pbnRBdFJlbGF0aXZl RGlzdGFuY2UoMC41KSwgdHJhbnNsdWNlbnRMYWJlbEJhY2tncm91bmRDb2xvciwgY29ycmVjdGVk QXJyb3dEaXJlY3Rpb24oTGFiZWxBcnJvd0RpcmVjdGlvbjo6TGVmdCwgR3JpZFRyYWNrU2l6aW5n RGlyZWN0aW9uOjpGb3JSb3dzKSwgTGFiZWxBcnJvd0VkZ2VQb3NpdGlvbjo6TWlkZGxlKSk7CiAg ICAgICAgICAgICB9CiAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgcHJldmlvdXNSb3dFbmRM aW5lID0gcm93U3RhcnRMaW5lOwo=