<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>224195</bug_id>
          
          <creation_ts>2021-04-05 12:16:36 -0700</creation_ts>
          <short_desc>[PlayStation] Change mediaControlsLocalizedStrings to use unicode escapes</short_desc>
          <delta_ts>2021-04-06 04:26:29 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Stephan Szabo">stephan.szabo</reporter>
          <assigned_to name="Stephan Szabo">stephan.szabo</assigned_to>
          <cc>don.olmstead</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>jer.noble</cc>
    
    <cc>joepeck</cc>
    
    <cc>philipj</cc>
    
    <cc>ross.kirsling</cc>
    
    <cc>sergio</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1747049</commentid>
    <comment_count>0</comment_count>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2021-04-05 12:16:36 -0700</bug_when>
    <thetext>With the change to use --fail-if-non-ascii on building the arrays for the user agent scripts because we do not want to load UTF-8 string into the heap, we started breaking on mediaControlsLocalizedStrings as it was using smart quotes. Switch to using the unicode escapes in the file so that the content as per slack discussion with Yusuke.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1747050</commentid>
    <comment_count>1</comment_count>
      <attachid>425185</attachid>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2021-04-05 12:19:51 -0700</bug_when>
    <thetext>Created attachment 425185
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1747148</commentid>
    <comment_count>2</comment_count>
      <attachid>425185</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-04-05 16:04:36 -0700</bug_when>
    <thetext>Comment on attachment 425185
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1747362</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-04-06 04:25:39 -0700</bug_when>
    <thetext>Committed r275504: &lt;https://commits.webkit.org/r275504&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425185.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1747363</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-04-06 04:26:29 -0700</bug_when>
    <thetext>&lt;rdar://problem/76261746&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>425185</attachid>
            <date>2021-04-05 12:19:51 -0700</date>
            <delta_ts>2021-04-06 04:25:40 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>224195.1.diff</filename>
            <type>text/plain</type>
            <size>1350</size>
            <attacher name="Stephan Szabo">stephan.szabo</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA5OGE4ZmUxOWY3NDMuLmVjMWFiODYzMGU0YSAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt
MSwzICsxLDE0IEBACisyMDIxLTA0LTA1ICBTdGVwaGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bz
b255LmNvbT4KKworICAgICAgICBbUGxheVN0YXRpb25dIENoYW5nZSBtZWRpYUNvbnRyb2xzTG9j
YWxpemVkU3RyaW5ncyB0byB1c2UgdW5pY29kZSBlc2NhcGVzCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQxOTUKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGVuLmxwcm9qL21lZGlhQ29udHJvbHNMb2Nh
bGl6ZWRTdHJpbmdzLmpzOgorCisgICAgICAgIFN3aXRjaCBmcm9tIGxpdGVyYWwgc21hcnQgcXVv
dGVzIHRvIHVuaWNvZGUgZXNjYXBlcy4KKwogMjAyMS0wMy0zMSAgQ2hyaXMgTG9yZCAgPGNsb3Jk
QGlnYWxpYS5jb20+CiAKICAgICAgICAgTWFrZSBGb250Q2FjaGUgc2VsZi1jb250YWluZWQgKHJl
bW92ZSBzdGF0aWMgZ2xvYmFsIHZhcmlhYmxlcykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L2VuLmxwcm9qL21lZGlhQ29udHJvbHNMb2NhbGl6ZWRTdHJpbmdzLmpzIGIvU291cmNlL1dlYkNv
cmUvZW4ubHByb2ovbWVkaWFDb250cm9sc0xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggYmM0MTZi
ZGEzYTEzLi4zMTA1MGYzMDZiODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VuLmxwcm9q
L21lZGlhQ29udHJvbHNMb2NhbGl6ZWRTdHJpbmdzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Vu
Lmxwcm9qL21lZGlhQ29udHJvbHNMb2NhbGl6ZWRTdHJpbmdzLmpzCkBAIC0xLDYgKzEsNiBAQAog
dmFyIFVJU3RyaW5nVGFibGUgPSB7CiAgICAgJyMjV0lSRUxFU1NfUExBWUJBQ0tfREVWSUNFX1RZ
UEUjIyc6ICdBaXJQbGF5JywKLSAgICAnIyNXSVJFTEVTU19QTEFZQkFDS19ERVZJQ0VfTkFNRSMj
JzogJ1RoaXMgdmlkZW8gaXMgcGxheWluZyBvbiDigJwjI0RFVklDRV9OQU1FIyPigJ0uJywKKyAg
ICAnIyNXSVJFTEVTU19QTEFZQkFDS19ERVZJQ0VfTkFNRSMjJzogJ1RoaXMgdmlkZW8gaXMgcGxh
eWluZyBvbiBcdTIwMUMjI0RFVklDRV9OQU1FIyNcdTIwMUQuJywKIAogICAgICcjI1RWT1VUX0RF
VklDRV9UWVBFIyMnOiAnVFYgQ29ubmVjdGVkJywKICAgICAnIyNUVk9VVF9ERVZJQ0VfTkFNRSMj
JzogJ1RoaXMgdmlkZW8gaXMgcGxheWluZyBvbiB0aGUgVFYuJywK
</data>

          </attachment>
      

    </bug>

</bugzilla>