224190 2021-04-05 09:43:03 -0700 set-webkit-configuration should print current settings 2021-04-06 11:04:04 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer aakash_jain ap ews-watchlist jbedard mark.lam ryanhaddad webkit-bug-importer oldest_to_newest 1746983 0 ddkilzer 2021-04-05 09:43:03 -0700 set-webkit-configuration should print current settings when it's run so there's no guessing about the current configuration settings. No arguments: $ ./Tools/Scripts/set-webkit-configuration Usage: set-webkit-configuration [options] --32-bit Set the default architecture to 32-bit --64-bit Set the default architecture to 64-bit --[no-]asan Enable or disable clang address sanitizer --[no-]tsan Enable or disable clang thread sanitizer --[no-]ubsan Enable or disable clang undefined behavior sanitizer --[no-]coverage Enable or disable LLVM Source-based Code Coverage --force-optimization-level=<level> Optimization level: O3, O2, O1, O0, Os, Ofast, Og, or none --lto-mode=<mode> Set LTO mode: full, thin, or none --debug Set the default configuration to debug --release Set the default configuration to release --reset Reset configurations Current settings: Configuration:Release Arch:x86_64 Using --reset: $ ./Tools/Scripts/set-webkit-configuration --reset Current settings: Configuration:Release Arch:x86_64 Some switches: $ ./Tools/Scripts/set-webkit-configuration --release --asan --ubsan Current settings: Configuration:Release Arch:x86_64 ASan UBSan Some other switches: $ ./Tools/Scripts/set-webkit-configuration --debug Current settings: Configuration:Debug Arch:x86_64 1746987 1 425164 ddkilzer 2021-04-05 09:54:26 -0700 Created attachment 425164 Patch v1 1746988 2 ddkilzer 2021-04-05 09:57:13 -0700 Just realized this might affect EWS since set-webkit-configuration will not print out its current config when run, so added a few folks to the CC list. 1747147 3 ddkilzer 2021-04-05 16:04:02 -0700 (In reply to David Kilzer (:ddkilzer) from comment #2) > Just realized this might affect EWS since set-webkit-configuration will not > print out its current config when run, so added a few folks to the CC list. The jsc-mips-tests failure has nothing to do with this change: OSError: [Errno 28] No space left on device: '/home/buildbot/igalia-jsc32-mipsel-ews-02/JSC-MIPSEL-32bits-Tests-EWS/build/WebKitBuild/Release' 1747151 4 425164 mark.lam 2021-04-05 16:18:00 -0700 Comment on attachment 425164 Patch v1 r=me 1747528 5 ews-feeder 2021-04-06 11:02:30 -0700 Committed r275534: <https://commits.webkit.org/r275534> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425164. 1747529 6 webkit-bug-importer 2021-04-06 11:04:04 -0700 <rdar://problem/76274997> 425164 2021-04-05 09:54:26 -0700 2021-04-06 11:02:31 -0700 Patch v1 bug-224190-20210405095425.patch text/plain 5812 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDUwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTA0ZDY3ODk2Mzg3MjMzNmE0ZjEwZThiMzg0YmViZWIx N2RjM2ViYS4uZWM0NzZhOWIwNzJhNWJmY2M2MDUzMzhhYjgwNmE5ZjUyOGE3NjJhMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDIxLTA0LTA1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgc2V0LXdlYmtpdC1jb25maWd1cmF0aW9uIHNob3VsZCBwcmludCBjdXJyZW50IHNldHRp bmdzCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMjQxOTA+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3NldC13ZWJraXQt Y29uZmlndXJhdGlvbjoKKyAgICAgICAgLSBSZW9yZGVyIHN3aXRjaGVzIHRvIHB1dCBzYW5pdGl6 ZXJzIHRvZ2V0aGVyLgorICAgICAgICAtIERlY2xhcmUgc3Vicm91dGluZXMuCisgICAgICAgIC0g Q2FsbCBwcmludEN1cnJlbnRTZXR0aW5ncygpIG9yIHByaW50VXNhZ2UoKSBhcyBuZWVkZWQuCisg ICAgICAgIChwcmludEN1cnJlbnRTZXR0aW5ncyk6IEFkZC4KKyAgICAgICAgKHByaW50VXNhZ2Up OiBBZGQuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAtIFJlb3Jk ZXIgc3dpdGNoIHZhcmlhYmxlcyB0byBtYXRjaCBvdGhlciBjb2RlLgorICAgICAgICAoY292ZXJh Z2VJc0VuYWJsZWQpOiBBZGQgZm9yIHNldC13ZWJraXQtY29uZmlndXJhdGlvbi4KKwogMjAyMS0w NC0wMiAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIFdL VVJMU2NoZW1lVGFzayByZWRpcmVjdCBBUEkuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3Nl dC13ZWJraXQtY29uZmlndXJhdGlvbiBiL1Rvb2xzL1NjcmlwdHMvc2V0LXdlYmtpdC1jb25maWd1 cmF0aW9uCmluZGV4IDkyNjY0NDI3ZDJiOTVmMTRlNTQwMGJiMWQ4NGE0OTM5YmI5OTQwYWYuLmU2 ODc2NDVjZDA4NzcyNmI3ZjRiYjBkMzc2Y2Q4YmQwNTE5MGQyOWIgMTAwNzU1Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvc2V0LXdlYmtpdC1jb25maWd1cmF0aW9uCisrKyBiL1Rvb2xzL1NjcmlwdHMvc2V0 LXdlYmtpdC1jb25maWd1cmF0aW9uCkBAIC0zOSw5ICszOSw5IEBAIFVzYWdlOiAkcHJvZ3JhbU5h bWUgW29wdGlvbnNdCiAgIC0tMzItYml0ICAgICAgICAgICAgICAgICAgICAgICAgICAgU2V0IHRo ZSBkZWZhdWx0IGFyY2hpdGVjdHVyZSB0byAzMi1iaXQKICAgLS02NC1iaXQgICAgICAgICAgICAg ICAgICAgICAgICAgICBTZXQgdGhlIGRlZmF1bHQgYXJjaGl0ZWN0dXJlIHRvIDY0LWJpdAogICAt LVtuby1dYXNhbiAgICAgICAgICAgICAgICAgICAgICAgIEVuYWJsZSBvciBkaXNhYmxlIGNsYW5n IGFkZHJlc3Mgc2FuaXRpemVyCi0gIC0tW25vLV1jb3ZlcmFnZSAgICAgICAgICAgICAgICAgICAg RW5hYmxlIG9yIGRpc2FibGUgTExWTSBTb3VyY2UtYmFzZWQgQ29kZSBDb3ZlcmFnZQogICAtLVtu by1ddHNhbiAgICAgICAgICAgICAgICAgICAgICAgIEVuYWJsZSBvciBkaXNhYmxlIGNsYW5nIHRo cmVhZCBzYW5pdGl6ZXIKICAgLS1bbm8tXXVic2FuICAgICAgICAgICAgICAgICAgICAgICBFbmFi bGUgb3IgZGlzYWJsZSBjbGFuZyB1bmRlZmluZWQgYmVoYXZpb3Igc2FuaXRpemVyCisgIC0tW25v LV1jb3ZlcmFnZSAgICAgICAgICAgICAgICAgICAgRW5hYmxlIG9yIGRpc2FibGUgTExWTSBTb3Vy Y2UtYmFzZWQgQ29kZSBDb3ZlcmFnZQogICAtLWZvcmNlLW9wdGltaXphdGlvbi1sZXZlbD08bGV2 ZWw+IE9wdGltaXphdGlvbiBsZXZlbDogTzMsIE8yLCBPMSwgTzAsIE9zLCBPZmFzdCwgT2csIG9y IG5vbmUKICAgLS1sdG8tbW9kZT08bW9kZT4gICAgICAgICAgICAgICAgICBTZXQgTFRPIG1vZGU6 IGZ1bGwsIHRoaW4sIG9yIG5vbmUKICAgLS1kZWJ1ZyAgICAgICAgICAgICAgICAgICAgICAgICAg ICBTZXQgdGhlIGRlZmF1bHQgY29uZmlndXJhdGlvbiB0byBkZWJ1ZwpAQCAtNDksMTYgKzQ5LDIw IEBAIFVzYWdlOiAkcHJvZ3JhbU5hbWUgW29wdGlvbnNdCiAgIC0tcmVzZXQgICAgICAgICAgICAg ICAgICAgICAgICAgICAgUmVzZXQgY29uZmlndXJhdGlvbnMKIEVPRgogCitzdWIgcHJpbnRDdXJy ZW50U2V0dGluZ3MoKTsKK3N1YiBwcmludFVzYWdlKCk7CitzdWIgdXBkYXRlT3JEZWxldGVDb25m aWd1cmF0aW9uRmlsZSgkJCk7CisKIG15ICRjb25maWd1cmF0aW9uID0gcGFzc2VkQ29uZmlndXJh dGlvbigpOwogbXkgJGFyY2hpdGVjdHVyZSA9IHBhc3NlZEFyY2hpdGVjdHVyZSgpOwogbXkgJGVu YWJsZUFTQU4gPSBjaGVja0ZvckFyZ3VtZW50QW5kUmVtb3ZlRnJvbUFSR1YoIi0tYXNhbiIpOwog bXkgJGRpc2FibGVBU0FOID0gY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCItLW5v LWFzYW4iKTsKLW15ICRlbmFibGVDb3ZlcmFnZSA9IGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVG cm9tQVJHVigiLS1jb3ZlcmFnZSIpOwotbXkgJGRpc2FibGVDb3ZlcmFnZSA9IGNoZWNrRm9yQXJn dW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS1uby1jb3ZlcmFnZSIpOwogbXkgJGVuYWJsZVRTQU4g PSBjaGVja0ZvckFyZ3VtZW50QW5kUmVtb3ZlRnJvbUFSR1YoIi0tdHNhbiIpOwogbXkgJGRpc2Fi bGVUU0FOID0gY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCItLW5vLXRzYW4iKTsK IG15ICRlbmFibGVVQlNBTiA9IGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS11 YnNhbiIpOwogbXkgJGRpc2FibGVVQlNBTiA9IGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9t QVJHVigiLS1uby11YnNhbiIpOworbXkgJGVuYWJsZUNvdmVyYWdlID0gY2hlY2tGb3JBcmd1bWVu dEFuZFJlbW92ZUZyb21BUkdWKCItLWNvdmVyYWdlIik7CitteSAkZGlzYWJsZUNvdmVyYWdlID0g Y2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCItLW5vLWNvdmVyYWdlIik7CiBteSAk bHRvTW9kZTsKIGlmICghY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWR2V0dGluZ1Zh bHVlKCItLWx0by1tb2RlIiwgXCRsdG9Nb2RlKSkgewogICAgICRsdG9Nb2RlPSIiOwpAQCAtODcs NiArOTEsNyBAQCBpZiAoY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCItLXJlc2V0 IikpIHsKICAgICBmb3IgbXkgJGZpbGVOYW1lIChxdyhBcmNoaXRlY3R1cmUgQVNhbiBDb25maWd1 cmF0aW9uIENvdmVyYWdlIEZvcmNlT3B0aW1pemF0aW9uTGV2ZWwgTFRPIFRTYW4gVUJTYW4pKSB7 CiAgICAgICAgIHVubGluayBGaWxlOjpTcGVjLT5jYXRmaWxlKCRiYXNlUHJvZHVjdERpciwgJGZp bGVOYW1lKTsKICAgICB9CisgICAgcHJpbnRDdXJyZW50U2V0dGluZ3MoKTsKICAgICBleGl0IDA7 CiB9CiAKQEAgLTk2LDE4ICsxMDEsMTggQEAgaWYgKCghJGNvbmZpZ3VyYXRpb24gJiYgISRhcmNo aXRlY3R1cmUgJiYgISRlbmFibGVBU0FOICYmICEkZGlzYWJsZUFTQU4gJiYgISRlbmEKICAgICB8 fCAoJGVuYWJsZVRTQU4gJiYgJGRpc2FibGVUU0FOKQogICAgIHx8ICgkZW5hYmxlVUJTQU4gJiYg JGRpc2FibGVVQlNBTikKICAgICApIHsKLSAgICBwcmludCBTVERFUlIgJHVzYWdlOworICAgIHBy aW50VXNhZ2UoKTsKICAgICBleGl0IDE7CiB9CiAKIGlmICgkZW5hYmxlQVNBTiAmJiAkZW5hYmxl VFNBTikgewogICAgIHByaW50IFNUREVSUiAiRVJST1I6IEFkZHJlc3MgU2FuaXRpemVyIGFuZCBU aHJlYWQgU2FuaXR6ZXIgY2FuJ3QgYmUgZW5hYmxlZCB0b2dldGhlci5cbiI7Ci0gICAgcHJpbnQg U1RERVJSICR1c2FnZTsKKyAgICBwcmludFVzYWdlKCk7CiAgICAgZXhpdCAxOwogfQogCiBpZiAo JGx0b01vZGUgJiYgJGx0b01vZGUgbmUgImZ1bGwiICYmICRsdG9Nb2RlIG5lICJ0aGluIiAmJiAk bHRvTW9kZSBuZSAibm9uZSIpIHsKLSAgICBwcmludCBTVERFUlIgJHVzYWdlOworICAgIHByaW50 VXNhZ2UoKTsKICAgICBleGl0IDE7CiB9CiAKQEAgLTEyMCw3ICsxMjUsNyBAQCBpZiAoJGZvcmNl T3B0aW1pemF0aW9uTGV2ZWwKICAgICAmJiAkZm9yY2VPcHRpbWl6YXRpb25MZXZlbCBuZSAiT3Mi CiAgICAgJiYgJGZvcmNlT3B0aW1pemF0aW9uTGV2ZWwgbmUgIk9mYXN0IgogICAgICYmICRmb3Jj ZU9wdGltaXphdGlvbkxldmVsIG5lICJPZyIpIHsKLSAgICBwcmludCBTVERFUlIgJHVzYWdlOwor ICAgIHByaW50VXNhZ2UoKTsKICAgICBleGl0IDE7CiB9CiAKQEAgLTE3MSwzICsxNzYsMjggQEAg aWYgKCRsdG9Nb2RlKSB7CiAgICAgcHJpbnQgTFRPICIkbHRvTW9kZSI7CiAgICAgY2xvc2UgTFRP OwogfQorCitwcmludEN1cnJlbnRTZXR0aW5ncygpOworCitleGl0IDA7CisKK3N1YiBwcmludEN1 cnJlbnRTZXR0aW5ncygpCit7CisgICAgbXkgJHJlc3VsdCA9ICJDdXJyZW50IHNldHRpbmdzOiI7 CisgICAgJHJlc3VsdCAuPSAiIENvbmZpZ3VyYXRpb246IiAuIGNvbmZpZ3VyYXRpb24oKTsKKyAg ICAkcmVzdWx0IC49ICIgQXJjaDoiIC4gYXJjaGl0ZWN0dXJlKCkgaWYgYXJjaGl0ZWN0dXJlKCk7 CisgICAgJHJlc3VsdCAuPSAiIEFTYW4iIGlmIGFzYW5Jc0VuYWJsZWQoKTsKKyAgICAkcmVzdWx0 IC49ICIgVFNhbiIgaWYgdHNhbklzRW5hYmxlZCgpOworICAgICRyZXN1bHQgLj0gIiBVQlNhbiIg aWYgdWJzYW5Jc0VuYWJsZWQoKTsKKyAgICAkcmVzdWx0IC49ICIgQ292ZXJhZ2UiIGlmIGNvdmVy YWdlSXNFbmFibGVkKCk7CisgICAgJHJlc3VsdCAuPSAiIExUT01vZGU6IiAuIGx0b01vZGUoKSBp ZiBsdG9Nb2RlKCk7CisgICAgJHJlc3VsdCAuPSAiIEZvcmNlT3B0aW1pemF0aW9uTGV2ZWw6TyIg LiBmb3JjZU9wdGltaXphdGlvbkxldmVsKCkgaWYgZm9yY2VPcHRpbWl6YXRpb25MZXZlbCgpOwor CisgICAgcHJpbnQgU1RERVJSICRyZXN1bHQsICJcbiI7Cit9CisKK3N1YiBwcmludFVzYWdlKCkK K3sKKyAgICBwcmludCBTVERFUlIgJHVzYWdlLCAiXG4iOworICAgIHByaW50Q3VycmVudFNldHRp bmdzKCk7Cit9CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggZjk5MjNmMzQ1MzZmNWQ3OGIxY2MzNjk3YWQ2 YjZhNTUyZDdlMWQ1NS4uOTkxNzc4OTA2MTEyMGQ4YWQ4ODNmZTJjNGNkNzgzY2MxNWQ0YmExNiAx MDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbQpAQCAtMTMyLDggKzEzMiw4IEBAIG15ICVuYXRpdmVBcmNoaXRlY3R1 cmVNYXAgPSAoKTsKIG15ICRhc2FuSXNFbmFibGVkOwogbXkgJHRzYW5Jc0VuYWJsZWQ7CiBteSAk dWJzYW5Jc0VuYWJsZWQ7Ci1teSAkZm9yY2VPcHRpbWl6YXRpb25MZXZlbDsKIG15ICRjb3ZlcmFn ZUlzRW5hYmxlZDsKK215ICRmb3JjZU9wdGltaXphdGlvbkxldmVsOwogbXkgJGx0b01vZGU7CiBt eSAkbnVtYmVyT2ZDUFVzOwogbXkgJG1heENQVUxvYWQ7CkBAIC05MzUsNiArOTM1LDEyIEBAIHN1 YiB1YnNhbklzRW5hYmxlZCgpCiAgICAgcmV0dXJuICR1YnNhbklzRW5hYmxlZDsKIH0KIAorc3Vi IGNvdmVyYWdlSXNFbmFibGVkKCkKK3sKKyAgICBkZXRlcm1pbmVDb3ZlcmFnZUlzRW5hYmxlZCgp OworICAgIHJldHVybiAkY292ZXJhZ2VJc0VuYWJsZWQ7Cit9CisKIHN1YiBmb3JjZU9wdGltaXph dGlvbkxldmVsKCkKIHsKICAgICBkZXRlcm1pbmVGb3JjZU9wdGltaXphdGlvbkxldmVsKCk7Cg==