224189 2021-04-05 09:38:05 -0700 [iOS] Prevent background blur when presenting date/time pickers 2021-04-06 13:01:49 -0700 1 1 1 Unclassified WebKit Forms Other iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 akeerthi akeerthi aakash_jain cdumez webkit-bug-importer wenson_hsieh oldest_to_newest 1746971 0 akeerthi 2021-04-05 09:38:05 -0700 ... 1746973 1 akeerthi 2021-04-05 09:38:18 -0700 <rdar://problem/76220352> 1746976 2 425159 akeerthi 2021-04-05 09:39:35 -0700 Created attachment 425159 Patch 1746982 3 akeerthi 2021-04-05 09:42:08 -0700 Thanks for the review! Will commit once the tree is open. 1747043 4 425159 aakash_jain 2021-04-05 12:00:23 -0700 Comment on attachment 425159 Patch From https://ews-build.webkit.org/#/builders/53/builds/11856: WKDateTimeInputControl.mm:162:11: error: property 'preferredBackgroundEffects' not found on object of type '_UIContextMenuStyle *' 1747045 5 425159 wenson_hsieh 2021-04-05 12:02:49 -0700 Comment on attachment 425159 Patch Restoring the r+ (and adding cq- instead). The build fix here is straightforward (we probably just need to update UIKitSPI.h) 1747046 6 425184 akeerthi 2021-04-05 12:08:39 -0700 Created attachment 425184 Patch for landing 1747056 7 aakash_jain 2021-04-05 12:26:53 -0700 I did the r- so that rest of EWS bots do not process that patch (since they have backlog of patches to process currently). Since there is a new patch uploaded, we can also mark the older patch as obsolete, so that all the EWS queue do not need to process that patch. EWS skips r- and obsolete patches. 1747058 8 425159 wenson_hsieh 2021-04-05 12:28:42 -0700 Comment on attachment 425159 Patch (In reply to Aakash Jain from comment #7) > I did the r- so that rest of EWS bots do not process that patch (since they > have backlog of patches to process currently). Since there is a new patch > uploaded, we can also mark the older patch as obsolete, so that all the EWS > queue do not need to process that patch. > > EWS skips r- and obsolete patches. I see. In that case, we could mark the patch as obsolete. 1747522 9 ews-feeder 2021-04-06 10:54:15 -0700 Committed r275532: <https://commits.webkit.org/r275532> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425184. 425159 2021-04-05 09:39:35 -0700 2021-04-05 12:28:42 -0700 Patch bug-224189-20210405123934.patch text/plain 2111 akeerthi U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEzZTU4ZjE5OWE5YTRlZWU2 ZWQ5NjE3Y2Y0OTQxNTZkMTZjZmQ5ODguLjBkOWRhODFiNjI2MzU3YTIxODZkZDRjMTM3YmViMTFl YzhiY2U5MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDQtMDUgIEFkaXR5YSBL ZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFByZXZlbnQgYmFj a2dyb3VuZCBibHVyIHdoZW4gcHJlc2VudGluZyBkYXRlL3RpbWUgcGlja2VycworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MTg5CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83NjIyMDM1Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZm9ybXMvV0tEYXRlVGltZUlucHV0Q29u dHJvbC5tbToKKyAgICAgICAgKC1bV0tEYXRlVGltZVBpY2tlciBfY29udGV4dE1lbnVJbnRlcmFj dGlvbjpzdHlsZUZvck1lbnVXaXRoQ29uZmlndXJhdGlvbjpdKToKKworICAgICAgICBQcmVzZW50 aW5nIGEgVUlDb250ZXh0TWVudUludGVyYWN0aW9uIHJlc3VsdHMgaW4gdGhlIGFwcGxpY2F0aW9u IG9mIGEKKyAgICAgICAgYmx1ciBlZmZlY3QgdG8gdGhlIGJhY2tncm91bmQgdmlldy4gSG93ZXZl ciwgdGhlIHBlcmlwaGVyYWwgcHJlc2VudGVkCisgICAgICAgIHdoZW4gaW50ZXJhY3Rpbmcgd2l0 aCBhIFVJRGF0ZVBpY2tlciBhY3Jvc3MgdGhlIHJlc3Qgb2YgdGhlIHN5c3RlbQorICAgICAgICBk b2VzIG5vdCBibHVyIHRoZSBiYWNrZ3JvdW5kLgorCisgICAgICAgIFRvIGFsaWduIG91ciBiZWhh dmlvciB3aXRoIHRoZSByZXN0IG9mIHRoZSBzeXN0ZW0sIHJlbW92ZSB0aGUgYmx1cgorICAgICAg ICBlZmZlY3QgYnkgc3BlY2lmeWluZyBhbiBlbXB0eSBVSVZpc3VhbEVmZmVjdCBmb3IgdGhlCisg ICAgICAgIF9VSUNvbnRleHRNZW51U3R5bGUncyBwcmVmZXJyZWRCYWNrZ3JvdW5kRWZmZWN0cy4g VGhlIGVtcHR5IGVmZmVjdAorICAgICAgICBtdXN0IGJlIGV4cGxpY2l0bHkgc3BlY2lmaWVkLCBz aW5jZSBzZXR0aW5nIGFuIGVtcHR5IGFycmF5IHdpbGwgcmVzdWx0CisgICAgICAgIGluIHRoZSBk ZWZhdWx0IGVmZmVjdCBiZWluZyBhcHBsaWVkLgorCiAyMDIxLTA0LTA1ICBBZGl0eWEgS2VlcnRo aSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBVcGRhdGUgVUlEYXRlUGlj a2VyU3R5bGUgZm9yIDxpbnB1dCB0eXBlPXRpbWU+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tEYXRlVGltZUlucHV0Q29udHJvbC5tbSBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0RhdGVUaW1lSW5wdXRDb250cm9sLm1tCmluZGV4 IDI2NTdkMTQwOWZmNzM3NjQyMTIyNjU4OTljMzcwMDBlNGVhZGFiNDQuLjMwZDE1NjQzZmE3ZDI0 ODJlOGY2OTdjNDVjMmEwM2VkYWJhY2ZlMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9mb3Jtcy9XS0RhdGVUaW1lSW5wdXRDb250cm9sLm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0RhdGVUaW1lSW5wdXRDb250cm9sLm1tCkBAIC0x NjMsNiArMTYzLDcgQEAgc3RhdGljIGNvbnN0IE5TVGltZUludGVydmFsIGtNaWxsaXNlY29uZHNQ ZXJTZWNvbmQgPSAxMDAwOwogewogICAgIF9VSUNvbnRleHRNZW51U3R5bGUgKnN0eWxlID0gW19V SUNvbnRleHRNZW51U3R5bGUgZGVmYXVsdFN0eWxlXTsKICAgICBzdHlsZS5oYXNJbnRlcmFjdGl2 ZVByZXZpZXcgPSBZRVM7CisgICAgc3R5bGUucHJlZmVycmVkQmFja2dyb3VuZEVmZmVjdHMgPSBA WyBbVUlWaXN1YWxFZmZlY3QgZW1wdHlFZmZlY3RdIF07CiAgICAgc3R5bGUucHJlZmVycmVkTGF5 b3V0ID0gX1VJQ29udGV4dE1lbnVMYXlvdXRBdXRvbWF0aWM7CiAgICAgcmV0dXJuIHN0eWxlOwog fQo= 425184 2021-04-05 12:08:39 -0700 2021-04-06 13:01:49 -0700 Patch for landing bug-224189-20210405150838.patch text/plain 2788 akeerthi U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEzZTU4ZjE5OWE5YTRlZWU2 ZWQ5NjE3Y2Y0OTQxNTZkMTZjZmQ5ODguLjdlYzU1NmI3YzhlZTM0NjAyOTdiZDMxNzllZDQ1OWMz NDJkMTU4NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMjEtMDQtMDUgIEFkaXR5YSBL ZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFByZXZlbnQgYmFj a2dyb3VuZCBibHVyIHdoZW4gcHJlc2VudGluZyBkYXRlL3RpbWUgcGlja2VycworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MTg5CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83NjIyMDM1Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBXZW5zb24gSHNp ZWguCisKKyAgICAgICAgKiBQbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmg6CisgICAgICAgICog VUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0RhdGVUaW1lSW5wdXRDb250cm9sLm1tOgorICAgICAgICAo LVtXS0RhdGVUaW1lUGlja2VyIF9jb250ZXh0TWVudUludGVyYWN0aW9uOnN0eWxlRm9yTWVudVdp dGhDb25maWd1cmF0aW9uOl0pOgorCisgICAgICAgIFByZXNlbnRpbmcgYSBVSUNvbnRleHRNZW51 SW50ZXJhY3Rpb24gcmVzdWx0cyBpbiB0aGUgYXBwbGljYXRpb24gb2YgYQorICAgICAgICBibHVy IGVmZmVjdCB0byB0aGUgYmFja2dyb3VuZCB2aWV3LiBIb3dldmVyLCB0aGUgcGVyaXBoZXJhbCBw cmVzZW50ZWQKKyAgICAgICAgd2hlbiBpbnRlcmFjdGluZyB3aXRoIGEgVUlEYXRlUGlja2VyIGFj cm9zcyB0aGUgcmVzdCBvZiB0aGUgc3lzdGVtCisgICAgICAgIGRvZXMgbm90IGJsdXIgdGhlIGJh Y2tncm91bmQuCisKKyAgICAgICAgVG8gYWxpZ24gb3VyIGJlaGF2aW9yIHdpdGggdGhlIHJlc3Qg b2YgdGhlIHN5c3RlbSwgcmVtb3ZlIHRoZSBibHVyCisgICAgICAgIGVmZmVjdCBieSBzcGVjaWZ5 aW5nIGFuIGVtcHR5IFVJVmlzdWFsRWZmZWN0IGZvciB0aGUKKyAgICAgICAgX1VJQ29udGV4dE1l bnVTdHlsZSdzIHByZWZlcnJlZEJhY2tncm91bmRFZmZlY3RzLiBUaGUgZW1wdHkgZWZmZWN0Cisg ICAgICAgIG11c3QgYmUgZXhwbGljaXRseSBzcGVjaWZpZWQsIHNpbmNlIHNldHRpbmcgYW4gZW1w dHkgYXJyYXkgd2lsbCByZXN1bHQKKyAgICAgICAgaW4gdGhlIGRlZmF1bHQgZWZmZWN0IGJlaW5n IGFwcGxpZWQuCisKIDIwMjEtMDQtMDUgIEFkaXR5YSBLZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUu Y29tPgogCiAgICAgICAgIFtpT1NdIFVwZGF0ZSBVSURhdGVQaWNrZXJTdHlsZSBmb3IgPGlucHV0 IHR5cGU9dGltZT4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9V SUtpdFNQSS5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKaW5k ZXggODk5NjdlZGZkNDZjMTE3ODI5NzQ4NTY3Y2NjOWVkMzJkNTVjNWQ5OS4uY2RkM2FiNmFkYmQ2 OWYyOTk3OTE0Y2NmMTI5ZGM1ZTRhM2M3ZjhmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9Q bGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9z cGkvaW9zL1VJS2l0U1BJLmgKQEAgLTEyMTMsNiArMTIxMyw3IEBAIHR5cGVkZWYgTlNfRU5VTShO U1VJbnRlZ2VyLCBfVUlDb250ZXh0TWVudUxheW91dCkgewogQGludGVyZmFjZSBfVUlDb250ZXh0 TWVudVN0eWxlIDogTlNPYmplY3QgPE5TQ29weWluZz4KIEBwcm9wZXJ0eSAobm9uYXRvbWljKSBf VUlDb250ZXh0TWVudUxheW91dCBwcmVmZXJyZWRMYXlvdXQ7CiBAcHJvcGVydHkgKG5vbmF0b21p YykgQk9PTCBoYXNJbnRlcmFjdGl2ZVByZXZpZXc7CitAcHJvcGVydHkgKG5vbmF0b21pYywgc3Ry b25nKSBOU0FycmF5ICpwcmVmZXJyZWRCYWNrZ3JvdW5kRWZmZWN0czsKICsgKGluc3RhbmNldHlw ZSlkZWZhdWx0U3R5bGU7CiBAZW5kCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2lvcy9mb3Jtcy9XS0RhdGVUaW1lSW5wdXRDb250cm9sLm1tIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL2Zvcm1zL1dLRGF0ZVRpbWVJbnB1dENvbnRyb2wubW0KaW5kZXggMjY1N2Qx NDA5ZmY3Mzc2NDIxMjI2NTg5OWMzNzAwMGU0ZWFkYWI0NC4uMzBkMTU2NDNmYTdkMjQ4MmU4ZjY5 N2M0NWMyYTAzZWRhYmFjZmUyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv aW9zL2Zvcm1zL1dLRGF0ZVRpbWVJbnB1dENvbnRyb2wubW0KKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL2Zvcm1zL1dLRGF0ZVRpbWVJbnB1dENvbnRyb2wubW0KQEAgLTE2Myw2ICsx NjMsNyBAQCBzdGF0aWMgY29uc3QgTlNUaW1lSW50ZXJ2YWwga01pbGxpc2Vjb25kc1BlclNlY29u ZCA9IDEwMDA7CiB7CiAgICAgX1VJQ29udGV4dE1lbnVTdHlsZSAqc3R5bGUgPSBbX1VJQ29udGV4 dE1lbnVTdHlsZSBkZWZhdWx0U3R5bGVdOwogICAgIHN0eWxlLmhhc0ludGVyYWN0aXZlUHJldmll dyA9IFlFUzsKKyAgICBzdHlsZS5wcmVmZXJyZWRCYWNrZ3JvdW5kRWZmZWN0cyA9IEBbIFtVSVZp c3VhbEVmZmVjdCBlbXB0eUVmZmVjdF0gXTsKICAgICBzdHlsZS5wcmVmZXJyZWRMYXlvdXQgPSBf VUlDb250ZXh0TWVudUxheW91dEF1dG9tYXRpYzsKICAgICByZXR1cm4gc3R5bGU7CiB9Cg==