224186 2021-04-05 09:17:59 -0700 Move synthesizedBaselineFromBorderBox to RenderBox 2021-04-06 01:40:45 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis changseok esprehn+autocc ews-watchlist glenn jfernandez kondapallykalyan pdr rego svillar webkit-bug-importer oldest_to_newest 1746958 0 rbuis 2021-04-05 09:17:59 -0700 Move synthesizedBaselineFromBorderBox to RenderBox since there are various call sites using it. 1746964 1 425156 rbuis 2021-04-05 09:23:18 -0700 Created attachment 425156 Patch 1747319 2 425156 jfernandez 2021-04-06 01:08:19 -0700 Comment on attachment 425156 Patch r=me 1747324 3 ews-feeder 2021-04-06 01:37:37 -0700 Committed r275494: <https://commits.webkit.org/r275494> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425156. 1747328 4 webkit-bug-importer 2021-04-06 01:40:45 -0700 <rdar://problem/76257936> 425156 2021-04-05 09:23:18 -0700 2021-04-06 01:37:38 -0700 Patch bug-224186-20210405182317.patch text/plain 5135 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzA5ZmRjYzBkZWVkYmI0 NDFlOGI3MWEyZTliYjQ5OTliY2IwZjQ2Ni4uYjY5ODNjN2Q1YzVhZjM4ZGYzNTNkODc5NDc0OGY3 YWY0ODViMzMzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA0LTA1ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTW92ZSBzeW50aGVzaXplZEJhc2Vs aW5lRnJvbUJvcmRlckJveCB0byBSZW5kZXJCb3gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDE4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgc3ludGhlc2l6ZWRCYXNlbGluZUZyb21Cb3JkZXJC b3ggdG8gUmVuZGVyQm94IHNpbmNlIHRoZXJlIGFyZQorICAgICAgICB2YXJpb3VzIGNhbGwgc2l0 ZXMgdXNpbmcgaXQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrRmxvdzo6aW5saW5lQmxvY2tCYXNlbGluZSBj b25zdCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpzeW50aGVzaXplZEJhc2VsaW5lRnJvbUJvcmRlckJveCk6CisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckJveC5oOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpzeW50aGVzaXplZEJhc2VsaW5lRnJvbUJvcmRlckJveCk6 IERlbGV0ZWQuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6c3ludGhlc2l6ZWRCYXNlbGluZUZyb21Cb3JkZXJCb3gpOiBEZWxldGVkLgorCiAy MDIxLTA0LTAyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFBl bmRpbmdJbWFnZUJpdG1hcCBnZXRzIGNyZWF0ZWQgb24gYSBzdG9wcGVkIHNjcmlwdCBleGVjdXRp b24gY29udGV4dC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC bG9ja0Zsb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5j cHAKaW5kZXggYTQ0YWEyZjI3MTQwNjRhYjc5Yzc1NGQzMTQwOGE0YzkxODkzZjU2Yy4uMjJmM2Zh MDZlNWQ0YjM4ZjQ0MmVjMjg0MDU3ZDcxNzFjYTZiNTUzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKQEAgLTMxNDEsNyArMzE0MSw3IEBAIE9wdGlv bmFsPExheW91dFVuaXQ+IFJlbmRlckJsb2NrRmxvdzo6aW5saW5lQmxvY2tCYXNlbGluZShMaW5l RGlyZWN0aW9uTW9kZSBsaW5lCiAgICAgICAgICAgICByZXR1cm4gV1RGOjpudWxsb3B0OwogICAg IH0KICAgICAvLyBOb3RlIHRoYXQgaGVyZSB3ZSBvbmx5IHRha2UgdGhlIGxlZnQgYW5kIGJvdHRv bSBpbnRvIGNvbnNpZGVyYXRpb24uIE91ciBjYWxsZXIgdGFrZXMgdGhlIHJpZ2h0IGFuZCB0b3Ag aW50byBjb25zaWRlcmF0aW9uLgotICAgIGZsb2F0IGJveEhlaWdodCA9IGxpbmVEaXJlY3Rpb24g PT0gSG9yaXpvbnRhbExpbmUgPyBoZWlnaHQoKSArIG1fbWFyZ2luQm94LmJvdHRvbSgpIDogd2lk dGgoKSArIG1fbWFyZ2luQm94LmxlZnQoKTsKKyAgICBmbG9hdCBib3hIZWlnaHQgPSBzeW50aGVz aXplZEJhc2VsaW5lRnJvbUJvcmRlckJveCgqdGhpcywgbGluZURpcmVjdGlvbikgKyAobGluZURp cmVjdGlvbiA9PSBIb3Jpem9udGFsTGluZSA/IG1fbWFyZ2luQm94LmJvdHRvbSgpIDogbV9tYXJn aW5Cb3gubGVmdCgpKTsKICAgICBmbG9hdCBsYXN0QmFzZWxpbmUgPSAwOwogICAgIGlmICghY2hp bGRyZW5JbmxpbmUoKSkgewogICAgICAgICBhdXRvIGlubGluZUJsb2NrQmFzZWxpbmUgPSBSZW5k ZXJCbG9jazo6aW5saW5lQmxvY2tCYXNlbGluZShsaW5lRGlyZWN0aW9uKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJveC5jcHAKaW5kZXggNGYwZjA2YTRkMzExN2FkZGYzZjE5YjJjZGNi OTNkMmU4ZWQwNzI2NC4uYzcxZGJhOTI1ZTVjM2Q3MDk4MDBmYTNhOWNmMDRkMDY1YjIzMWJkMCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKQEAgLTUyMzcsNCArNTIzNyw5 IEBAIExheW91dEJveEV4dGVudCBSZW5kZXJCb3g6OnNjcm9sbFBhZGRpbmdGb3JWaWV3cG9ydFJl Y3QoY29uc3QgTGF5b3V0UmVjdCYgdmlld3BvCiAgICAgICAgIG1pbmltdW1WYWx1ZUZvckxlbmd0 aChwYWRkaW5nLmJvdHRvbSgpLCB2aWV3cG9ydFJlY3QuaGVpZ2h0KCkpLCBtaW5pbXVtVmFsdWVG b3JMZW5ndGgocGFkZGluZy5sZWZ0KCksIHZpZXdwb3J0UmVjdC53aWR0aCgpKSk7CiB9CiAKK0xh eW91dFVuaXQgc3ludGhlc2l6ZWRCYXNlbGluZUZyb21Cb3JkZXJCb3goY29uc3QgUmVuZGVyQm94 JiBib3gsIExpbmVEaXJlY3Rpb25Nb2RlIGRpcmVjdGlvbikKK3sKKyAgICByZXR1cm4gZGlyZWN0 aW9uID09IEhvcml6b250YWxMaW5lID8gYm94LmhlaWdodCgpIDogYm94LndpZHRoKCk7Cit9CisK IH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCb3guaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaApp bmRleCAyNjQ4Y2Q5OGY4ZmY4NTE0YTk4MmY2YjU3OTNjMDcwM2ZiZGE3YWI5Li5kODdmMjJiNTgy OTEwNjIyMjE4MzU3YTUyOWVhOTlmNDQ5ZTkyZGFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckJveC5oCkBAIC04NDcsNiArODQ3LDggQEAgaW5saW5lIHZvaWQgUmVuZGVyQm94OjpzZXRJ bmxpbmVCb3hXcmFwcGVyKElubGluZUVsZW1lbnRCb3gqIGJveFdyYXBwZXIpCiAgICAgbV9pbmxp bmVCb3hXcmFwcGVyID0gYm94V3JhcHBlcjsKIH0KIAorTGF5b3V0VW5pdCBzeW50aGVzaXplZEJh c2VsaW5lRnJvbUJvcmRlckJveChjb25zdCBSZW5kZXJCb3gmLCBMaW5lRGlyZWN0aW9uTW9kZSk7 CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogU1BFQ0lBTElaRV9UWVBFX1RSQUlUU19SRU5E RVJfT0JKRUNUKFJlbmRlckJveCwgaXNCb3goKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyRmxleGlibGVCb3guY3BwCmluZGV4IDk2MWI1NGZiOWU1NjNjZTA4ZjE2OGJlNjNi OTU1ZjdmYzc3Zjc3MWUuLmU2MmZlMGI3MmRkZWY4YmE4Yjc1YWYxYjBiNDA2MDU3NTkyOGZkYTcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcApA QCAtMTQ0LDExICsxNDQsNiBAQCB2b2lkIFJlbmRlckZsZXhpYmxlQm94Ojpjb21wdXRlSW50cmlu c2ljTG9naWNhbFdpZHRocyhMYXlvdXRVbml0JiBtaW5Mb2dpY2FsV2lkdAogICAgIG1pbkxvZ2lj YWxXaWR0aCArPSBzY3JvbGxiYXJXaWR0aDsKIH0KIAotc3RhdGljIExheW91dFVuaXQgc3ludGhl c2l6ZWRCYXNlbGluZUZyb21Cb3JkZXJCb3goY29uc3QgUmVuZGVyQm94JiBib3gsIExpbmVEaXJl Y3Rpb25Nb2RlIGRpcmVjdGlvbikKLXsKLSAgICByZXR1cm4gZGlyZWN0aW9uID09IEhvcml6b250 YWxMaW5lID8gYm94LnNpemUoKS5oZWlnaHQoKSA6IGJveC5zaXplKCkud2lkdGgoKTsKLX0KLQog TGF5b3V0VW5pdCBSZW5kZXJGbGV4aWJsZUJveDo6YmFzZWxpbmVQb3NpdGlvbihGb250QmFzZWxp bmUsIGJvb2wsIExpbmVEaXJlY3Rpb25Nb2RlIGRpcmVjdGlvbiwgTGluZVBvc2l0aW9uTW9kZSkg Y29uc3QKIHsKICAgICBhdXRvIGJhc2VsaW5lID0gZmlyc3RMaW5lQmFzZWxpbmUoKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcAppbmRleCA4NDdjZjk4NDVjM2MwYmE1YmY4 NWJhZmYyMzZhNjU5YzYzZThmZmU3Li5lZjUwNzY4NTU3ZGRiNDY5ODU0ODMzNWI0NzJkZDA2YWU4 ZWI5YjFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCkBAIC0xMjMy LDEyICsxMjMyLDYgQEAgdm9pZCBSZW5kZXJHcmlkOjp1cGRhdGVBdXRvTWFyZ2luc0luQ29sdW1u QXhpc0lmTmVlZGVkKFJlbmRlckJveCYgY2hpbGQpCiAgICAgfQogfQogCi0vLyBGSVhNRTogVGhp cyBsb2dpYyBjb3VsZCBiZSByZWZhY3RvcmVkIHNvbWVob3cgYW5kIGRlZmluZWQgaW4gUmVuZGVy Qm94Lgotc3RhdGljIExheW91dFVuaXQgc3ludGhlc2l6ZWRCYXNlbGluZUZyb21Cb3JkZXJCb3go Y29uc3QgUmVuZGVyQm94JiBib3gsIExpbmVEaXJlY3Rpb25Nb2RlIGRpcmVjdGlvbikKLXsKLSAg ICByZXR1cm4gKGRpcmVjdGlvbiA9PSBIb3Jpem9udGFsTGluZSA/IGJveC5zaXplKCkuaGVpZ2h0 KCkgOiBib3guc2l6ZSgpLndpZHRoKCkpLnRvSW50KCk7Ci19Ci0KIGJvb2wgUmVuZGVyR3JpZDo6 aXNCYXNlbGluZUFsaWdubWVudEZvckNoaWxkKGNvbnN0IFJlbmRlckJveCYgY2hpbGQpIGNvbnN0 CiB7CiAgICAgcmV0dXJuIGlzQmFzZWxpbmVBbGlnbm1lbnRGb3JDaGlsZChjaGlsZCwgR3JpZFJv d0F4aXMpIHx8IGlzQmFzZWxpbmVBbGlnbm1lbnRGb3JDaGlsZChjaGlsZCwgR3JpZENvbHVtbkF4 aXMpOwo=