224149 2021-04-03 06:37:30 -0700 [GTK] Properly use CompletionHandler when USE_OPENGL_OR_ES is set to OFF 2021-04-10 15:03:01 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 julianaito webkit-unassigned achristensen bugs-noreply cdumez cmarcelo ews-watchlist fujii gyuyoung.kim julianaito luiz ryuan.choi sergio zeno oldest_to_newest 1746778 0 julianaito 2021-04-03 06:37:30 -0700 Properly use CompletionHandler when USE_OPENGL_OR_ES is set to OFF 1746779 1 425093 julianaito 2021-04-03 06:38:36 -0700 Created attachment 425093 Patch 1746781 2 julianaito 2021-04-03 06:41:45 -0700 When trying to build WebKit with USE_OPENGL_OR_ES set to off, the build fails with: LayerTreeHost.h:216:28: error: out-of-line definition of 'forceRepaintAsync' +does not match any declaration in 'WebKit::LayerTreeHost' LayerTreeHost.h:82:28: note: type of 1st parameter of member declaration does not match definition ('CompletionHandler<void ()> &&' vs 'CompletionHandler<void ()> &') It has been introduced by that change : https://trac.webkit.org/changeset/271171/webkit The attached patch fixes that issue. 1746952 3 425093 achristensen 2021-04-05 08:56:25 -0700 Comment on attachment 425093 Patch You might consider calling it. 1747089 4 425093 fujii 2021-04-05 13:32:16 -0700 Comment on attachment 425093 Patch style-checker failed. Please fix it. Otherwise, commit bot will complain. 1747106 5 425205 julianaito 2021-04-05 14:20:50 -0700 Created attachment 425205 Revised patch Here is it is. It passes check-webkit-style this time. 1747215 6 425205 achristensen 2021-04-05 18:34:20 -0700 Comment on attachment 425205 Revised patch View in context: https://bugs.webkit.org/attachment.cgi?id=425205&action=review > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:216 > +inline void LayerTreeHost::forceRepaintAsync(CompletionHandler<void()>&&) { } I recommend calling the completion handler. 1748039 7 fujii 2021-04-07 13:18:30 -0700 Charlene, what's your opinion on Alex's review point? I think it's just a stub to avoid linkage errors, not called from anywhere. I think it's no problem. Adding ASSERT_NOT_REACHED() might be another idea. inline void LayerTreeHost::forceRepaintAsync(CompletionHandler<void()>&&) { ASSERT_NOT_REACHED(); } 1748224 8 julianaito 2021-04-08 00:29:42 -0700 (In reply to Fujii Hironori from comment #7) > Charlene, what's your opinion on Alex's review point? > I think it's just a stub to avoid linkage errors, not called from anywhere. > I think it's no problem. > Adding ASSERT_NOT_REACHED() might be another idea. > inline void LayerTreeHost::forceRepaintAsync(CompletionHandler<void()>&&) { > ASSERT_NOT_REACHED(); } In fact, while i reported the build failure and proposed a possible fix, i'm not able to define what would be the proper course of action. 1749029 9 ews-feeder 2021-04-10 15:02:57 -0700 Committed r275802 (236373@main): <https://commits.webkit.org/236373@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425205. 425093 2021-04-03 06:38:36 -0700 2021-04-05 14:21:15 -0700 Patch bug-224149-20210403153835.patch text/plain 1877 julianaito U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY1ZDY3NTE3ZmYyMGM3NWM4 NzBlNjJlMDE4OWFhMmI5ZDllNGI1ODEuLmViNzJjZTgxMzBmMWU2ZDIyNjE4YTYwNTEwODM0NjBm YzhjMTNlY2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDQtMDMgIENoYXJsw6hu ZSBXZW5kbGluZyAgPGp1bGlhbmFpdG9AcG9zdGVvLmpwPgorCisgICAgICAgIFByb3Blcmx5IHVz ZSBDb21wbGV0aW9uSGFuZGxlciB3aGVuIFVTRV9PUEVOR0xfT1JfRVMgaXMgc2V0IHRvIE9GRgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MTQ5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRH cmFwaGljcy9MYXllclRyZWVIb3N0Lmg6CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZUhvc3Q6 OmZvcmNlUmVwYWludEFzeW5jKToKKwogMjAyMS0wNC0wMiAgSmVyIE5vYmxlICA8amVyLm5vYmxl QGFwcGxlLmNvbT4KIAogICAgICAgICBbR1BVUF0gUG93ZXIgcmVncmVzc2lvbjogYXVkaW8gaGFy ZHdhcmUgaXMgY29uZmlndXJlZCBmb3IgMTI4IGZyYW1lIHByZWZlcnJlZCBidWZmZXIgc2l6ZSBk dXJpbmcgVmlkZW9BdWRpbyBwbGF5YmFjawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVIb3N0LmggYi9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJl ZUhvc3QuaAppbmRleCA2NzI3ZDE2YzhjMGI4NmMxNWZmMzFhZjAzOGFhOWQ3NTg4NTI3NTQ1Li5k YjY1ZjgxMzI2N2RmOTg2YjcxNTZjMzhmOGQwMjU5YmMyNjZhNjBiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJl ZUhvc3QuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRl ZEdyYXBoaWNzL0xheWVyVHJlZUhvc3QuaApAQCAtMjEzLDcgKzIxMyw3IEBAIGlubGluZSB2b2lk IExheWVyVHJlZUhvc3Q6OnNldFJvb3RDb21wb3NpdGluZ0xheWVyKFdlYkNvcmU6OkdyYXBoaWNz TGF5ZXIqKSB7IH0KIGlubGluZSB2b2lkIExheWVyVHJlZUhvc3Q6OnNldFZpZXdPdmVybGF5Um9v dExheWVyKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqKSB7IH0KIGlubGluZSB2b2lkIExheWVyVHJl ZUhvc3Q6OnNjcm9sbE5vbkNvbXBvc2l0ZWRDb250ZW50cyhjb25zdCBXZWJDb3JlOjpJbnRSZWN0 JikgeyB9CiBpbmxpbmUgdm9pZCBMYXllclRyZWVIb3N0Ojpmb3JjZVJlcGFpbnQoKSB7IH0KLWlu bGluZSBib29sIExheWVyVHJlZUhvc3Q6OmZvcmNlUmVwYWludEFzeW5jKENvbXBsZXRpb25IYW5k bGVyPHZvaWQoKT4mKSB7IHJldHVybiBmYWxzZTsgfQoraW5saW5lIHZvaWQgTGF5ZXJUcmVlSG9z dDo6Zm9yY2VSZXBhaW50QXN5bmMoQ29tcGxldGlvbkhhbmRsZXI8dm9pZCgpPiYmKSB7IH0KIGlu bGluZSB2b2lkIExheWVyVHJlZUhvc3Q6OnNpemVEaWRDaGFuZ2UoY29uc3QgV2ViQ29yZTo6SW50 U2l6ZSYpIHsgfQogaW5saW5lIHZvaWQgTGF5ZXJUcmVlSG9zdDo6cGF1c2VSZW5kZXJpbmcoKSB7 IH0KIGlubGluZSB2b2lkIExheWVyVHJlZUhvc3Q6OnJlc3VtZVJlbmRlcmluZygpIHsgfQo= 425205 2021-04-05 14:20:50 -0700 2021-04-10 15:02:59 -0700 Revised patch 224149p0.diff text/plain 1704 julianaito ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZjVkNjc1MTdmZjIwLi5hMzlmMDA1NzM5MjcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMjEtMDQtMDMgIENoYXJsw6huZSBXZW5kbGluZyAgPGp1bGlhbmFpdG9AcG9z dGVvLmpwPgorCisgICAgICAgIFByb3Blcmx5IHVzZSBDb21wbGV0aW9uSGFuZGxlciB3aGVuIFVT RV9PUEVOR0xfT1JfRVMgaXMgc2V0IHRvIE9GRgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFw aGljcy9MYXllclRyZWVIb3N0Lmg6CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZUhvc3Q6OmZv cmNlUmVwYWludEFzeW5jKToKKwogMjAyMS0wNC0wMiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFw cGxlLmNvbT4KIAogICAgICAgICBbR1BVUF0gUG93ZXIgcmVncmVzc2lvbjogYXVkaW8gaGFyZHdh cmUgaXMgY29uZmlndXJlZCBmb3IgMTI4IGZyYW1lIHByZWZlcnJlZCBidWZmZXIgc2l6ZSBkdXJp bmcgVmlkZW9BdWRpbyBwbGF5YmFjawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVIb3N0LmggYi9Tb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZUhv c3QuaAppbmRleCA2NzI3ZDE2YzhjMGIuLmRiNjVmODEzMjY3ZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVI b3N0LmgKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRH cmFwaGljcy9MYXllclRyZWVIb3N0LmgKQEAgLTIxMyw3ICsyMTMsNyBAQCBpbmxpbmUgdm9pZCBM YXllclRyZWVIb3N0OjpzZXRSb290Q29tcG9zaXRpbmdMYXllcihXZWJDb3JlOjpHcmFwaGljc0xh eWVyKikgeyB9CiBpbmxpbmUgdm9pZCBMYXllclRyZWVIb3N0OjpzZXRWaWV3T3ZlcmxheVJvb3RM YXllcihXZWJDb3JlOjpHcmFwaGljc0xheWVyKikgeyB9CiBpbmxpbmUgdm9pZCBMYXllclRyZWVI b3N0OjpzY3JvbGxOb25Db21wb3NpdGVkQ29udGVudHMoY29uc3QgV2ViQ29yZTo6SW50UmVjdCYp IHsgfQogaW5saW5lIHZvaWQgTGF5ZXJUcmVlSG9zdDo6Zm9yY2VSZXBhaW50KCkgeyB9Ci1pbmxp bmUgYm9vbCBMYXllclRyZWVIb3N0Ojpmb3JjZVJlcGFpbnRBc3luYyhDb21wbGV0aW9uSGFuZGxl cjx2b2lkKCk+JikgeyByZXR1cm4gZmFsc2U7IH0KK2lubGluZSB2b2lkIExheWVyVHJlZUhvc3Q6 OmZvcmNlUmVwYWludEFzeW5jKENvbXBsZXRpb25IYW5kbGVyPHZvaWQoKT4mJikgeyB9CiBpbmxp bmUgdm9pZCBMYXllclRyZWVIb3N0OjpzaXplRGlkQ2hhbmdlKGNvbnN0IFdlYkNvcmU6OkludFNp emUmKSB7IH0KIGlubGluZSB2b2lkIExheWVyVHJlZUhvc3Q6OnBhdXNlUmVuZGVyaW5nKCkgeyB9 CiBpbmxpbmUgdm9pZCBMYXllclRyZWVIb3N0OjpyZXN1bWVSZW5kZXJpbmcoKSB7IH0K