224136 2021-04-02 15:30:27 -0700 Enable QuotaExceededError on non GSTREAMER platforms 2021-04-06 10:51:20 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 224139 1 saam saam bfulgham calvaris eric.carlson ews-watchlist glenn jer.noble keith_miller mark.lam peng.liu6 philipj sergio webkit-bug-importer ysuzuki oldest_to_newest 1746696 0 saam 2021-04-02 15:30:27 -0700 ... 1746697 1 saam 2021-04-02 15:31:06 -0700 <rdar://71219720> 1746699 2 425061 saam 2021-04-02 15:35:57 -0700 Created attachment 425061 patch 1746739 3 425072 saam 2021-04-02 18:09:19 -0700 Created attachment 425072 patch for landing 1746992 4 425072 bfulgham 2021-04-05 10:03:28 -0700 Comment on attachment 425072 patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=425072&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:-500 > -#endif Oh, wow! Did we audit other GSTREAMER-only code to make sure nothing else was missed? 1747025 5 425072 saam 2021-04-05 11:19:29 -0700 Comment on attachment 425072 patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=425072&action=review >> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:-500 >> -#endif > > Oh, wow! Did we audit other GSTREAMER-only code to make sure nothing else was missed? I haven't. Probably best for someone who truly understands the media code to do this. Also, this change isn't sufficient for media in gpu process. That'll be done by Peng in: https://bugs.webkit.org/show_bug.cgi?id=224139 1747201 6 ews-feeder 2021-04-05 18:06:27 -0700 Committed r275466: <https://commits.webkit.org/r275466> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425072. 1747521 7 425072 peng.liu6 2021-04-06 10:51:20 -0700 Comment on attachment 425072 patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=425072&action=review >>> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:-500 >>> -#endif >> >> Oh, wow! Did we audit other GSTREAMER-only code to make sure nothing else was missed? > > I haven't. Probably best for someone who truly understands the media code to do this. > > Also, this change isn't sufficient for media in gpu process. That'll be done by Peng in: > https://bugs.webkit.org/show_bug.cgi?id=224139 By the way, the code is GStreamer port only because some sites did not work well if we enable the exception, and it was the only one case in the current MSE implementation as far as I know. 425061 2021-04-02 15:35:57 -0700 2021-04-02 18:09:19 -0700 patch c-backup.diff text/plain 1916 saam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3NTQ0NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA0LTAyICBTYWFtIEJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIEVuYWJsZSBRdW90YUV4Y2VlZGVk RXJyb3Igb24gbm9uIEdTVFJFQU1FUiBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDEzNgorICAgICAgICA8cmRhcjovLzcxMjE5NzIw PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg Zml4ZXMgYSBtZW1vcnkgbGVhayBpbiBEaXNuZXkrIHdoZXJlIHdlIGVuZCB1cCBxdWV1aW5nIHVw IHRoZSBlbnRpcmUKKyAgICAgICAgdmlkZW8gYmVjYXVzZSB3ZSBuZXZlciBjb21tdW5pY2F0ZSB0 byB0aGUgcGFnZSB0aGF0IHRoZXkgc2hvdWxkIHN0b3AgcXVldWluZworICAgICAgICBtb3JlIGRh dGEuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXI6OmFwcGVuZEJ1ZmZlckludGVybmFsKToKKwog MjAyMS0wNC0wMiAgQWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVzaEBnbWFpbC5jb20+CiAKICAg ICAgICAgUmVtb3ZlIFtSZXBsYWNlYWJsZV0gZXh0ZW5kZWQgYXR0cmlidXRlIGZyb20gYGRvY3Vt ZW50LmFsbGAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvU291cmNl QnVmZmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291 cmNlL1NvdXJjZUJ1ZmZlci5jcHAJKHJldmlzaW9uIDI3NTMwMCkKKysrIFNvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NDkwLDE0ICs0OTAsMTEgQEAgRXhjZXB0aW9uT3I8dm9pZD4gU291cmNlQnVmZmVyOjphcHBlbmRC dQogICAgIC8vIDQuIFJ1biB0aGUgY29kZWQgZnJhbWUgZXZpY3Rpb24gYWxnb3JpdGhtLgogICAg IG1fcHJpdmF0ZS0+ZXZpY3RDb2RlZEZyYW1lcyhzaXplLCBtX3BlbmRpbmdBcHBlbmREYXRhLmNh cGFjaXR5KCksIG1heGltdW1CdWZmZXJTaXplKCksIG1fc291cmNlLT5jdXJyZW50VGltZSgpLCBt X3NvdXJjZS0+ZHVyYXRpb24oKSwgbV9zb3VyY2UtPmlzRW5kZWQoKSk7CiAKLSAgICAvLyBGSVhN RTogZW5hYmxlIHRoaXMgY29kZSB3aGVuIE1TRSBsaWJyYXJpZXMgaGF2ZSBiZWVuIHVwZGF0ZWQg dG8gc3VwcG9ydCBpdC4KLSNpZiBVU0UoR1NUUkVBTUVSKQogICAgIC8vIDUuIElmIHRoZSBidWZm ZXIgZnVsbCBmbGFnIGVxdWFscyB0cnVlLCB0aGVuIHRocm93IGEgUXVvdGFFeGNlZWRlZEVycm9y IGV4Y2VwdGlvbiBhbmQgYWJvcnQgdGhlc2Ugc3RlcC4KICAgICBpZiAobV9wcml2YXRlLT5idWZm ZXJGdWxsKCkpIHsKICAgICAgICAgRVJST1JfTE9HKExPR0lERU5USUZJRVIsICJidWZmZXIgZnVs bCwgZmFpbGluZyB3aXRoIFF1b3RhRXhjZWVkZWRFcnJvciBlcnJvciIpOwogICAgICAgICByZXR1 cm4gRXhjZXB0aW9uIHsgUXVvdGFFeGNlZWRlZEVycm9yIH07CiAgICAgfQotI2VuZGlmCiAKICAg ICAvLyBOT1RFOiBSZXR1cm4gdG8gMy4yIGFwcGVuZEJ1ZmZlcigpCiAgICAgLy8gMy4gQWRkIGRh dGEgdG8gdGhlIGVuZCBvZiB0aGUgaW5wdXQgYnVmZmVyLgo= 425072 2021-04-02 18:09:19 -0700 2021-04-05 18:06:29 -0700 patch for landing c-backup.diff text/plain 3545 saam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3NTQ1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA0LTAyICBTYWFtIEJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIEVuYWJsZSBRdW90YUV4Y2VlZGVk RXJyb3Igb24gbm9uIEdTVFJFQU1FUiBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDEzNgorICAgICAgICA8cmRhcjovLzcxMjE5NzIw PgorCisgICAgICAgIFJldmlld2VkIGJ5IEplciBOb2JsZS4KKworICAgICAgICBUaGlzIGZpeGVz IGEgbWVtb3J5IGxlYWsgaW4gRGlzbmV5KyB3aGVyZSB3ZSBlbmQgdXAgcXVldWluZyB1cCB0aGUg ZW50aXJlCisgICAgICAgIHZpZGVvIGJlY2F1c2Ugd2UgbmV2ZXIgY29tbXVuaWNhdGUgdG8gdGhl IHBhZ2UgdGhhdCB0aGV5IHNob3VsZCBzdG9wIHF1ZXVpbmcKKyAgICAgICAgbW9yZSBkYXRhLgor CisgICAgICAgICogTW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6U291cmNlQnVmZmVyOjphcHBlbmRCdWZmZXJJbnRlcm5hbCk6CisKIDIwMjEt MDQtMDIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUGVuZGlu Z0ltYWdlQml0bWFwIGdldHMgY3JlYXRlZCBvbiBhIHN0b3BwZWQgc2NyaXB0IGV4ZWN1dGlvbiBj b250ZXh0LgpJbmRleDogU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VC dWZmZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3Vy Y2UvU291cmNlQnVmZmVyLmNwcAkocmV2aXNpb24gMjc1MzAwKQorKysgU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00 OTAsMTQgKzQ5MCwxMSBAQCBFeGNlcHRpb25Pcjx2b2lkPiBTb3VyY2VCdWZmZXI6OmFwcGVuZEJ1 CiAgICAgLy8gNC4gUnVuIHRoZSBjb2RlZCBmcmFtZSBldmljdGlvbiBhbGdvcml0aG0uCiAgICAg bV9wcml2YXRlLT5ldmljdENvZGVkRnJhbWVzKHNpemUsIG1fcGVuZGluZ0FwcGVuZERhdGEuY2Fw YWNpdHkoKSwgbWF4aW11bUJ1ZmZlclNpemUoKSwgbV9zb3VyY2UtPmN1cnJlbnRUaW1lKCksIG1f c291cmNlLT5kdXJhdGlvbigpLCBtX3NvdXJjZS0+aXNFbmRlZCgpKTsKIAotICAgIC8vIEZJWE1F OiBlbmFibGUgdGhpcyBjb2RlIHdoZW4gTVNFIGxpYnJhcmllcyBoYXZlIGJlZW4gdXBkYXRlZCB0 byBzdXBwb3J0IGl0LgotI2lmIFVTRShHU1RSRUFNRVIpCiAgICAgLy8gNS4gSWYgdGhlIGJ1ZmZl ciBmdWxsIGZsYWcgZXF1YWxzIHRydWUsIHRoZW4gdGhyb3cgYSBRdW90YUV4Y2VlZGVkRXJyb3Ig ZXhjZXB0aW9uIGFuZCBhYm9ydCB0aGVzZSBzdGVwLgogICAgIGlmIChtX3ByaXZhdGUtPmJ1ZmZl ckZ1bGwoKSkgewogICAgICAgICBFUlJPUl9MT0coTE9HSURFTlRJRklFUiwgImJ1ZmZlciBmdWxs LCBmYWlsaW5nIHdpdGggUXVvdGFFeGNlZWRlZEVycm9yIGVycm9yIik7CiAgICAgICAgIHJldHVy biBFeGNlcHRpb24geyBRdW90YUV4Y2VlZGVkRXJyb3IgfTsKICAgICB9Ci0jZW5kaWYKIAogICAg IC8vIE5PVEU6IFJldHVybiB0byAzLjIgYXBwZW5kQnVmZmVyKCkKICAgICAvLyAzLiBBZGQgZGF0 YSB0byB0aGUgZW5kIG9mIHRoZSBpbnB1dCBidWZmZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzUz MDApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MyBAQAorMjAyMS0wNC0wMiAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAg ICAgICBFbmFibGUgUXVvdGFFeGNlZWRlZEVycm9yIG9uIG5vbiBHU1RSRUFNRVIgcGxhdGZvcm1z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQxMzYK KyAgICAgICAgPHJkYXI6Ly83MTIxOTcyMD4KKworICAgICAgICBSZXZpZXdlZCBieSBKZXIgTm9i bGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNv dXJjZS1hcHBlbmQtYmVmb3JlLWxhc3QtcmFuZ2Utbm8tcXVvdGEtZXhjZWVkZWQtZXhwZWN0ZWQu dHh0OgorCiAyMDIxLTAzLTMxICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAog ICAgICAgICBJbiBjYXNlIFdlYlJUQyBWVEIgZGVjb2RlciByZXR1cm5zIGEgbnVsbCBmcmFtZSwg bWFyayB0aGUgZGVjb2RlciBhcyBmYWlsaW5nCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJjZS1hcHBlbmQtYmVmb3JlLWxhc3QtcmFu Z2Utbm8tcXVvdGEtZXhjZWVkZWQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL3BsYXRmb3JtL21hYy9tZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNlLWFwcGVuZC1i ZWZvcmUtbGFzdC1yYW5nZS1uby1xdW90YS1leGNlZWRlZC1leHBlY3RlZC50eHQJKHJldmlzaW9u IDI3NTMwMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9tZWRpYS9tZWRpYS1zb3VyY2Uv bWVkaWEtc291cmNlLWFwcGVuZC1iZWZvcmUtbGFzdC1yYW5nZS1uby1xdW90YS1leGNlZWRlZC1l eHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTExNSw5ICsxMTUsOCBAQCBFVkVOVCh1cGRh dGVlbmQpCiBBcHBlbmRpbmcgUFRTPTE3NQogRVZFTlQodXBkYXRlZW5kKQogQXBwZW5kaW5nIFBU Uz0xNzYKLUVWRU5UKHVwZGF0ZWVuZCkKLUVYUEVDVEVEIChleGNlcHRpb24gPT0gJ1F1b3RhRXhj ZWVkZWRFcnJvcjogVGhlIHF1b3RhIGhhcyBiZWVuIGV4Y2VlZGVkLicpLCBPQlNFUlZFRCAnbnVs bCcgRkFJTAotRVhQRUNURUQgKGJ1ZmZlcmVkUmFuZ2VzKCkgPT0gJ1sgMTIwLi4uMTc2IF0nKSwg T0JTRVJWRUQgJ1sgMTIwLi4uMTc3IF0nIEZBSUwKK0VYUEVDVEVEIChleGNlcHRpb24gPT0gJ1F1 b3RhRXhjZWVkZWRFcnJvcjogVGhlIHF1b3RhIGhhcyBiZWVuIGV4Y2VlZGVkLicpIE9LCitFWFBF Q1RFRCAoYnVmZmVyZWRSYW5nZXMoKSA9PSAnWyAxMjAuLi4xNzYgXScpIE9LCiBFWFBFQ1RFRCAo dmlkZW8uY3VycmVudFRpbWUgPT0gJzExNScpIE9LCiBBcHBlbmRpbmcgUFRTPTExNQogRVZFTlQo dXBkYXRlZW5kKQo=