224124 2021-04-02 12:48:20 -0700 Allow the WebAuthn UI to inform users about BiometryLockout 2021-04-05 21:49:51 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jiewen_tan jiewen_tan bfulgham garrett_davidson jiewen_tan webkit-bug-importer oldest_to_newest 1746616 0 jiewen_tan 2021-04-02 12:48:20 -0700 Allow the WebAuthn UI to inform users about BiometryLockout. 1746617 1 jiewen_tan 2021-04-02 12:49:01 -0700 rdar://74815938 1746621 2 425043 jiewen_tan 2021-04-02 12:53:29 -0700 Created attachment 425043 Patch 1746645 3 garrett_davidson 2021-04-02 13:45:39 -0700 How did you test this? 1746734 4 425043 bfulgham 2021-04-02 17:14:19 -0700 Comment on attachment 425043 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425043&action=review The test failures on iOS-wk2 don't seem related to this change. r=me > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49 > + if ((!result || error) && error.code != LAErrorBiometryLockout) { Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover? 1746750 5 425043 jiewen_tan 2021-04-02 19:19:06 -0700 Comment on attachment 425043 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425043&action=review Thanks Brent for r+ this patch. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49 >> + if ((!result || error) && error.code != LAErrorBiometryLockout) { > > Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover? We just need to let the operation continue. The UI itself has a way to detect the LAErrorBiometryLockout and then inform the user. 1747086 6 425043 garrett_davidson 2021-04-05 13:29:06 -0700 Comment on attachment 425043 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425043&action=review >>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49 >>> + if ((!result || error) && error.code != LAErrorBiometryLockout) { >> >> Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover? > > We just need to let the operation continue. The UI itself has a way to detect the LAErrorBiometryLockout and then inform the user. Yep, the UI should take care of it, but we’ve never been able to hit that code path before. Jiewen, can you test this change and send us a bug before landing if that isn’t going to work? 1747175 7 ews-feeder 2021-04-05 17:08:08 -0700 commit-queue failed to commit attachment 425043 to WebKit repository. To retry, please set cq+ flag again. 1747276 8 ews-feeder 2021-04-05 21:49:50 -0700 Committed r275492: <https://commits.webkit.org/r275492> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425043. 425043 2021-04-02 12:53:29 -0700 2021-04-05 21:49:50 -0700 Patch bug-224124-20210402125328.patch text/plain 1705 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZiMzU2Mzg3NWU4OTA1OGJl NTVkZDExYjNkNWM5YjBjODhjZWZlMjEuLjUxNTg0YTYyODEzMTliMDdmODRmNjZhYjNhM2Y3MTU1 MGJhODUyNDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDQtMDIgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBbGxvdyB0aGUgV2ViQXV0aG4g VUkgdG8gaW5mb3JtIHVzZXJzIGFib3V0IEJpb21ldHJ5TG9ja291dAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MTI0CisgICAgICAgIDxyZGFyOi8v NzQ4MTU5Mzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvTG9jYWxTZXJ2aWNlLm1tOgor ICAgICAgICAoV2ViS2l0OjpMb2NhbFNlcnZpY2U6OmlzQXZhaWxhYmxlKToKKyAgICAgICAgVGhl IExvY2FsU2VydmljZSBpcyBzdGlsbCBhdmFpbGFibGUgd2l0aGluIHRoZSBCaW9tZXRyeUxvY2tv dXQgcGVyaW9kLgorCiAyMDIxLTAzLTMxICBKaWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5j b20+CiAKICAgICAgICAgQWxsb3cgQVNDV2ViS2l0U1BJU3VwcG9ydCB0byBiZSB1c2VkIG9uIG1h Y09TCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlv bi9Db2NvYS9Mb2NhbFNlcnZpY2UubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRo ZW50aWNhdGlvbi9Db2NvYS9Mb2NhbFNlcnZpY2UubW0KaW5kZXggMTYzYmJkYTMzMmE2NjNmYzQy YWE1MTFmZjE1ZmQ2M2QwMTIzMjhlMi4uMjYwNzdkOTQzZmQxYzkxMWRhMzY3OTMwMzk0MjYxOWNj MjUyYWQzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGlj YXRpb24vQ29jb2EvTG9jYWxTZXJ2aWNlLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0xvY2FsU2VydmljZS5tbQpAQCAtNDUsNyArNDUsOCBA QCBib29sIExvY2FsU2VydmljZTo6aXNBdmFpbGFibGUoKQogewogICAgIGF1dG8gY29udGV4dCA9 IGFkb3B0TlMoW2FsbG9jTEFDb250ZXh0SW5zdGFuY2UoKSBpbml0XSk7CiAgICAgTlNFcnJvciAq ZXJyb3IgPSBuaWw7Ci0gICAgaWYgKCFbY29udGV4dCBjYW5FdmFsdWF0ZVBvbGljeTpMQVBvbGlj eURldmljZU93bmVyQXV0aGVudGljYXRpb25XaXRoQmlvbWV0cmljcyBlcnJvcjomZXJyb3JdKSB7 CisgICAgYXV0byByZXN1bHQgPSBbY29udGV4dCBjYW5FdmFsdWF0ZVBvbGljeTpMQVBvbGljeURl dmljZU93bmVyQXV0aGVudGljYXRpb25XaXRoQmlvbWV0cmljcyBlcnJvcjomZXJyb3JdOworICAg IGlmICgoIXJlc3VsdCB8fCBlcnJvcikgJiYgZXJyb3IuY29kZSAhPSBMQUVycm9yQmlvbWV0cnlM b2Nrb3V0KSB7CiAgICAgICAgIExPR19FUlJPUigiQ291bGRuJ3QgZmluZCBsb2NhbCBhdXRoZW50 aWNhdG9yczogJUAiLCBlcnJvcik7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9Cg==