224099 2021-04-02 02:26:51 -0700 [WPE] Enable Cog's GTK4 backend 2021-04-06 07:58:45 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand annulen aperez bugs-noreply ews-watchlist glenn gyuyoung.kim jbedard ryuan.choi sergio oldest_to_newest 1746432 0 pnormand 2021-04-02 02:26:51 -0700 . 1746436 1 424999 pnormand 2021-04-02 02:31:10 -0700 Created attachment 424999 Patch 1746931 2 424999 aperez 2021-04-05 05:38:06 -0700 Comment on attachment 424999 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424999&action=review > Tools/Scripts/webkitpy/port/wpe.py:155 > + args = ['-P', 'gtk4'] + args If somebody passes “--platform=foo”, then the final command line will end up with “--platform=foo -P gtk4”. It would be good to add a check here for that. For example, from the top of my mind (that is, untested): has_platform_arg = any((a == "-P" or a.startswith("--platform=") for a in args)) if not has_platform_arg: args.insert(0, "--platform=gtk4") 1746932 3 aperez 2021-04-05 05:39:12 -0700 FWIW, other than the missing check for “--platform=”, I agree that it's nicer to have Cog use GTK4 by default while Cog does not have support for detecting what to use :) 1747410 4 425273 pnormand 2021-04-06 07:07:58 -0700 Created attachment 425273 Patch 1747429 5 ews-feeder 2021-04-06 07:58:41 -0700 Committed r275517: <https://commits.webkit.org/r275517> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425273. 424999 2021-04-02 02:31:10 -0700 2021-04-06 07:07:52 -0700 Patch bug-224099-20210402023108.patch text/plain 2214 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTU1ODNmODYxNThmNmUwMDJmMGJmMzUwMGUwMmEzNjY4 M2NkNGRkZC4uY2RhMWMyMTc1NTk1NWNmNzc3ZmU0NDg5YzM1ZDgxNTJhMTM3YzA5OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIxLTA0LTAyICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbV1BFXSBFbmFibGUgQ29nJ3MgR1RLNCBiYWNrZW5kCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQwOTkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgQ29nIEdUSzQgcGxhdGZvcm0g cGx1Z2luIGlzIG1vcmUgc3VpdGFibGUgZm9yIGRldmVsb3BlciBidWlsZHMgb24gZGVza3RvcCwg Y29tcGFyZWQgdG8KKyAgICAgICAgdGhlIGZkbyBiYWNrZW5kIHdoaWNoIHByb3ZpZGVzIG5vIHdp bmRvdyBkZWNvcmF0aW9ucyBvbiBtb3N0IFdheWxhbmQgY29tcG9zaXRvcnMuCisKKyAgICAgICAg KiBQbGF0Zm9ybVdQRS5jbWFrZToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvd3Bl LnB5OgorICAgICAgICAoV1BFUG9ydC5ydW5fbWluaWJyb3dzZXIpOgorCiAyMDIxLTA0LTAxICBZ dXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dURl0gSW50cm9k dWNlIFJvYmluSG9vZEhhc2hUYWJsZQpkaWZmIC0tZ2l0IGEvVG9vbHMvUGxhdGZvcm1XUEUuY21h a2UgYi9Ub29scy9QbGF0Zm9ybVdQRS5jbWFrZQppbmRleCA3N2E4NzRhOGU4ZjZmZTVlZjM3OWFi OTkxYWE3OGMzODE2ZDkwNDkxLi40ZGNkMjBhNGRjYjM2MzczOTljM2RlYjFhODIzMGU2YzIyZDAy NjY5IDEwMDY0NAotLS0gYS9Ub29scy9QbGF0Zm9ybVdQRS5jbWFrZQorKysgYi9Ub29scy9QbGF0 Zm9ybVdQRS5jbWFrZQpAQCAtMjIsNiArMjIsNyBAQCBpZiAoREVWRUxPUEVSX01PREUgQU5EIEVO QUJMRV9DT0cpCiAgICAgRXh0ZXJuYWxQcm9qZWN0X0FkZChjb2cKICAgICAgICAgR0lUX1JFUE9T SVRPUlkgImh0dHBzOi8vZ2l0aHViLmNvbS9JZ2FsaWEvY29nLmdpdCIKICAgICAgICAgU09VUkNF X0RJUiAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Ub29scy93cGUvY29nIgorICAgICAgICBDTUFLRV9B UkdTICItRENPR19QTEFURk9STV9HVEs0PU9OIgogICAgICAgICBJTlNUQUxMX0NPTU1BTkQgIiIp CiAgICAgRXh0ZXJuYWxQcm9qZWN0X0FkZF9TdGVwRGVwZW5kZW5jaWVzKGNvZyBidWlsZCBXZWJL aXQpCiBlbmRpZiAoKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dw ZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93cGUucHkKaW5kZXggYjI1YTM2OTk4 NDIxODQ4YjA5YTY4NTU4YTk3ZjQxZmRiZGEyYTliNS4uMTZmMzE1ZjBkZmNmMzU1NWI2NGZmY2I3 Y2VmMGRkOTFmMTFlYzY1YSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0 L3dwZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd3BlLnB5CkBAIC0xNTEs NyArMTUxLDggQEAgY2xhc3MgV1BFUG9ydChQb3J0KToKICAgICAgICAgICAgIGVudiA9IG9zLmVu dmlyb24uY29weSgpCiAgICAgICAgICAgICBlbnYudXBkYXRlKHsnV0VCS0lUX0VYRUNfUEFUSCc6 IHNlbGYuX2J1aWxkX3BhdGgoJ2JpbicpLAogICAgICAgICAgICAgICAgICAgICAgICAgJ1dFQktJ VF9JTkpFQ1RFRF9CVU5ETEVfUEFUSCc6IHNlbGYuX2J1aWxkX3BhdGgoJ2xpYicpfSkKLSAgICAg ICAgICAgIGFyZ3MgPSBbJy1QJywgJ2ZkbyddICsgYXJncworICAgICAgICAgICAgaWYgJy1QJyBu b3QgaW4gYXJnczoKKyAgICAgICAgICAgICAgICBhcmdzID0gWyctUCcsICdndGs0J10gKyBhcmdz CiAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICBwcmludCgiQ29nIG5vdCBmb3VuZCDwn5iiLiBJ ZiB5b3Ugd2lzaCB0byBlbmFibGUgaXQsIHJlYnVpbGQgd2l0aCBgLURFTkFCTEVfQ09HPU9OYC4g RmFsbGluZyBiYWNrIHRvIGdvb2Qgb2xkIE1pbmlCcm93c2VyIikKICAgICAgICAgICAgIG1pbmlC cm93c2VyID0gc2VsZi5fYnVpbGRfcGF0aCgnYmluJywgJ01pbmlCcm93c2VyJykK 425273 2021-04-06 07:07:58 -0700 2021-04-06 07:58:43 -0700 Patch bug-224099-20210406070756.patch text/plain 4041 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNmZTVkNDM2YjUxZDc3NmEw YWZlNjgwNTcxNWZmMjcwZDNjMWQ5OWUuLmJiZGJmYzFkYWRlOWY5OTQyMGM5ODEwM2VlZjU1NDRk Y2IzZmU5ZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjEtMDQtMDYgIFBoaWxpcHBl IE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdIEVuYWJsZSBD b2cncyBHVEs0IGJhY2tlbmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIyNDA5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogd3BlL3dwZS13ZWJraXQtdW5pbnN0YWxsZWQucGMuaW46IEZpeCBwYXRocyB0 byBkZXJpdmVkIHNvdXJjZXMuCisKIDIwMjEtMDQtMDYgIElhbiBHaWxiZXJ0ICA8aWFuZ0BhcHBs ZS5jb20+CiAKICAgICAgICAgSVBDOjpkZWNvZGVPYmplY3QgbnVsbCBkZXJlZmVyZW5jZSBpbiBk ZWNvZGVBcnJheUludGVybmFsKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvd3BlL3dwZS13 ZWJraXQtdW5pbnN0YWxsZWQucGMuaW4gYi9Tb3VyY2UvV2ViS2l0L3dwZS93cGUtd2Via2l0LXVu aW5zdGFsbGVkLnBjLmluCmluZGV4IDk3YWNlOTc0YWIzZjA0OWYxMTdiYWJiMTQzMjNhYjg0MmI0 ZmI0ODQuLjM1NTk5N2ZhMGEyYTg2ODEyOTIzNjgzMmM0ZTg5ZmIzMmNlNTJlM2YgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvd3BlL3dwZS13ZWJraXQtdW5pbnN0YWxsZWQucGMuaW4KKysrIGIv U291cmNlL1dlYktpdC93cGUvd3BlLXdlYmtpdC11bmluc3RhbGxlZC5wYy5pbgpAQCAtMSw3ICsx LDcgQEAKIHByZWZpeD1AQ01BS0VfQklOQVJZX0RJUkAKIGV4ZWNfcHJlZml4PSR7cHJlZml4fQog bGliZGlyPSR7cHJlZml4fS9saWIKLWluY2x1ZGVkaXI9JHtwcmVmaXh9L0Rlcml2ZWRTb3VyY2Vz CitpbmNsdWRlZGlyPSR7cHJlZml4fQogCiBOYW1lOiBXUEUgV2ViS2l0CiBEZXNjcmlwdGlvbjog RW1iZWRkYWJsZSBXZWIgY29udGVudCBlbmdpbmUKQEAgLTksNCArOSw0IEBAIFVSTDogaHR0cHM6 Ly93cGV3ZWJraXQub3JnCiBWZXJzaW9uOiBAUFJPSkVDVF9WRVJTSU9OQAogUmVxdWlyZXM6IGds aWItMi4wIGxpYnNvdXAtQFNPVVBfQVBJX1ZFUlNJT05AIHdwZS0xLjAKIExpYnM6IC1MJHtsaWJk aXJ9IC1sV1BFV2ViS2l0LUBXUEVfQVBJX1ZFUlNJT05ACi1DZmxhZ3M6IC1JJHtpbmNsdWRlZGly fS9Gb3J3YXJkaW5nSGVhZGVycy93cGUgLUkke2luY2x1ZGVkaXJ9L1dlYktpdC8gLUkke2luY2x1 ZGVkaXJ9L0ZvcndhcmRpbmdIZWFkZXJzL3dwZS1qc2MgLUkke2luY2x1ZGVkaXJ9L0phdmFTY3Jp cHRDb3JlL2phdmFzY3JpcHRjb3Jld3BlLworQ2ZsYWdzOiAtSSR7aW5jbHVkZWRpcn0vRGVyaXZl ZFNvdXJjZXMvRm9yd2FyZGluZ0hlYWRlcnMvd3BlIC1JJHtpbmNsdWRlZGlyfS9EZXJpdmVkU291 cmNlcy9XZWJLaXQvIC1JJHtpbmNsdWRlZGlyfS9EZXJpdmVkU291cmNlcy9Gb3J3YXJkaW5nSGVh ZGVycy93cGUtanNjIC1JJHtpbmNsdWRlZGlyfS9KYXZhU2NyaXB0Q29yZS9EZXJpdmVkU291cmNl cy9qYXZhc2NyaXB0Y29yZXdwZS8KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xz L0NoYW5nZUxvZwppbmRleCA0NWE4ZjdlMzgzODg3MjljODdjZjQ4MmMyYzZjZDgwZDM4MmExMGE2 Li44Yjg1MTdjNGEzYzgwZTdjOWVmZWU5NDllZjk0OWY1NTYzNTExYTA4IDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIw MjEtMDQtMDIgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtXUEVdIEVuYWJsZSBDb2cncyBHVEs0IGJhY2tlbmQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDA5OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBDb2cgR1RLNCBwbGF0Zm9ybSBwbHVnaW4g aXMgbW9yZSBzdWl0YWJsZSBmb3IgZGV2ZWxvcGVyIGJ1aWxkcyBvbiBkZXNrdG9wLCBjb21wYXJl ZCB0bworICAgICAgICB0aGUgZmRvIGJhY2tlbmQgd2hpY2ggcHJvdmlkZXMgbm8gd2luZG93IGRl Y29yYXRpb25zIG9uIG1vc3QgV2F5bGFuZCBjb21wb3NpdG9ycy4KKworICAgICAgICAqIFBsYXRm b3JtV1BFLmNtYWtlOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC93cGUucHk6Cisg ICAgICAgIChXUEVQb3J0LnJ1bl9taW5pYnJvd3Nlcik6CisKIDIwMjEtMDQtMDYgIEFha2FzaCBK YWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtyZXN1bHRzZGJweV0gUmVt b3ZlIG9ic29sZXRlIEJ1aWxkYm90RWlnaHRVUkxGYWN0b3J5CmRpZmYgLS1naXQgYS9Ub29scy9Q bGF0Zm9ybVdQRS5jbWFrZSBiL1Rvb2xzL1BsYXRmb3JtV1BFLmNtYWtlCmluZGV4IDc3YTg3NGE4 ZThmNmZlNWVmMzc5YWI5OTFhYTc4YzM4MTZkOTA0OTEuLjRkY2QyMGE0ZGNiMzYzNzM5OWMzZGVi MWE4MjMwZTZjMjJkMDI2NjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1BsYXRmb3JtV1BFLmNtYWtlCisr KyBiL1Rvb2xzL1BsYXRmb3JtV1BFLmNtYWtlCkBAIC0yMiw2ICsyMiw3IEBAIGlmIChERVZFTE9Q RVJfTU9ERSBBTkQgRU5BQkxFX0NPRykKICAgICBFeHRlcm5hbFByb2plY3RfQWRkKGNvZwogICAg ICAgICBHSVRfUkVQT1NJVE9SWSAiaHR0cHM6Ly9naXRodWIuY29tL0lnYWxpYS9jb2cuZ2l0Igog ICAgICAgICBTT1VSQ0VfRElSICIke0NNQUtFX1NPVVJDRV9ESVJ9L1Rvb2xzL3dwZS9jb2ciCisg ICAgICAgIENNQUtFX0FSR1MgIi1EQ09HX1BMQVRGT1JNX0dUSzQ9T04iCiAgICAgICAgIElOU1RB TExfQ09NTUFORCAiIikKICAgICBFeHRlcm5hbFByb2plY3RfQWRkX1N0ZXBEZXBlbmRlbmNpZXMo Y29nIGJ1aWxkIFdlYktpdCkKIGVuZGlmICgpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3BvcnQvd3BlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dwZS5weQpp bmRleCBiMjVhMzY5OTg0MjE4NDhiMDlhNjg1NThhOTdmNDFmZGJkYTJhOWI1Li44NjljNWQxMzYz YWU4ODcyMzJiMjY4MzI1MzBhY2U0ZDBkN2NhZGM0IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvd3BlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93 cGUucHkKQEAgLTE1MSw3ICsxNTEsOSBAQCBjbGFzcyBXUEVQb3J0KFBvcnQpOgogICAgICAgICAg ICAgZW52ID0gb3MuZW52aXJvbi5jb3B5KCkKICAgICAgICAgICAgIGVudi51cGRhdGUoeydXRUJL SVRfRVhFQ19QQVRIJzogc2VsZi5fYnVpbGRfcGF0aCgnYmluJyksCiAgICAgICAgICAgICAgICAg ICAgICAgICAnV0VCS0lUX0lOSkVDVEVEX0JVTkRMRV9QQVRIJzogc2VsZi5fYnVpbGRfcGF0aCgn bGliJyl9KQotICAgICAgICAgICAgYXJncyA9IFsnLVAnLCAnZmRvJ10gKyBhcmdzCisgICAgICAg ICAgICBoYXNfcGxhdGZvcm1fYXJnID0gYW55KChhID09ICItUCIgb3IgYS5zdGFydHN3aXRoKCIt LXBsYXRmb3JtPSIpIGZvciBhIGluIGFyZ3MpKQorICAgICAgICAgICAgaWYgbm90IGhhc19wbGF0 Zm9ybV9hcmc6CisgICAgICAgICAgICAgICAgYXJncy5pbnNlcnQoMCwgIi0tcGxhdGZvcm09Z3Rr NCIpCiAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICBwcmludCgiQ29nIG5vdCBmb3VuZCDwn5ii LiBJZiB5b3Ugd2lzaCB0byBlbmFibGUgaXQsIHJlYnVpbGQgd2l0aCBgLURFTkFCTEVfQ09HPU9O YC4gRmFsbGluZyBiYWNrIHRvIGdvb2Qgb2xkIE1pbmlCcm93c2VyIikKICAgICAgICAgICAgIG1p bmlCcm93c2VyID0gc2VsZi5fYnVpbGRfcGF0aCgnYmluJywgJ01pbmlCcm93c2VyJykK