224081 2021-04-01 15:03:20 -0700 Add a macro to help staging logDiagnosticMessageWithDomain in Safari 2021-04-01 22:00:39 -0700 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa achristensen thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1746286 0 sabouhallawa 2021-04-01 15:03:20 -0700 This macro will tell whether logDiagnosticMessageWithDomain and _WKDiagnosticLoggingDomain are defined or not. So checking macro will allow building the webkit clients with or without r275103. 1746316 1 424959 sabouhallawa 2021-04-01 16:12:46 -0700 Created attachment 424959 Patch 1746322 2 webkit-bug-importer 2021-04-01 16:39:29 -0700 <rdar://problem/76128509> 1746329 3 424959 wenson_hsieh 2021-04-01 17:07:45 -0700 Comment on attachment 424959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424959&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:30 > +#define HAS_DIAGNOSTIC_LOGGING_DOMAIN I think it's common practice to wrap these kinds of `#define`s in `#ifndef/#endif` (though I admittedly can't find many existing examples in WebKit to use as reference :/) 1746388 4 ews-feeder 2021-04-01 22:00:38 -0700 Committed r275404: <https://commits.webkit.org/r275404> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424959. 424959 2021-04-01 16:12:46 -0700 2021-04-01 22:00:38 -0700 Patch bug-224081-20210401161246.patch text/plain 1437 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1Mzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZkMzg5NjhlODBiYjZhYzU3 Njk5ZjNiZjcxMjJhYzg1ZmQ0NWU5YzIuLjhmMGE1NzZiMGQxMjBmYzA5ZjhlODlhM2E5NGZjODEx NjU4N2M0MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDQtMDEgIFNhaWQgQWJv dS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgbWFjcm8gdG8gaGVs cCBzdGFnaW5nIGxvZ0RpYWdub3N0aWNNZXNzYWdlV2l0aERvbWFpbiBpbiBTYWZhcmkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDA4MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoZWNraW5nIHRoaXMg bWFjcm8gd2lsbCBhbGxvdyB0aGUgd2Via2l0IGNsaWVudHMgdG8gaW1wbGVtZW50IHRoaXMgQVBJ CisgICAgICAgIGFuZCBidWlsZCB3aXRoIG9yIHdpdGhvdXQgcjI3NTEwMy4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRGlhZ25vc3RpY0xvZ2dpbmdEZWxlZ2F0ZS5oOgorCiAy MDIxLTA0LTAxICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAg ICAgICAgW0NvY29hXSBSRUdSRVNTSU9OKHIyNzI5OTkpOiBVc2VyLWluc3RhbGxlZCBmb250cyBu byBsb25nZXIgd29yayBpbiBNYWlsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQ29jb2EvX1dLRGlhZ25vc3RpY0xvZ2dpbmdEZWxlZ2F0ZS5oIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0RpYWdub3N0aWNMb2dnaW5nRGVsZWdhdGUuaAppbmRl eCBjZWRjNzJlMTEwYTFiYjA0ZWU3M2Y0OGQzOWEwNzEzMWQ0Njk4MDg4Li4wNGRkMGU2OGI0MDgw YWQ3ZTI3NjRhNWQ4YTU4ZDE2ZmJmNGM5ZTMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvQ29jb2EvX1dLRGlhZ25vc3RpY0xvZ2dpbmdEZWxlZ2F0ZS5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tEaWFnbm9zdGljTG9nZ2luZ0RlbGVn YXRlLmgKQEAgLTI3LDYgKzI3LDggQEAKIAogI2ltcG9ydCA8Rm91bmRhdGlvbi9Gb3VuZGF0aW9u Lmg+CiAKKyNkZWZpbmUgSEFTX0RJQUdOT1NUSUNfTE9HR0lOR19ET01BSU4KKwogdHlwZWRlZiBO U19FTlVNKE5TSW50ZWdlciwgX1dLRGlhZ25vc3RpY0xvZ2dpbmdSZXN1bHRUeXBlKSB7CiAgICAg X1dLRGlhZ25vc3RpY0xvZ2dpbmdSZXN1bHRQYXNzLAogICAgIF9XS0RpYWdub3N0aWNMb2dnaW5n UmVzdWx0RmFpbCwK