224079 2021-04-01 14:48:18 -0700 [check-webkit-style] Check python files in LayoutTests 2021-04-02 15:20:28 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain cgambrell dewei_zhu ews-watchlist glenn ryanhaddad webkit-bug-importer oldest_to_newest 1746269 0 jbedard 2021-04-01 14:48:18 -0700 We should run the style checker over python files in LayoutTests. 1746270 1 webkit-bug-importer 2021-04-01 14:48:58 -0700 <rdar://problem/76122813> 1746276 2 424951 jbedard 2021-04-01 14:52:46 -0700 Created attachment 424951 Patch 1746594 3 424951 dewei_zhu 2021-04-02 12:06:03 -0700 Comment on attachment 424951 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424951&action=review > Tools/Scripts/webkitpy/style/checker.py:640 > - elif basename in _NEVER_SKIPPED_FILES: > - return False > + for suffix in _NEVER_SKIPPED_FILES: > + if basename.endswith(suffix): > + return False I saw some potential behavior change: `A-TestExpectations` will not return False and now it will? 1746642 4 424951 jbedard 2021-04-02 13:38:29 -0700 Comment on attachment 424951 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424951&action=review >> Tools/Scripts/webkitpy/style/checker.py:640 >> + return False > > I saw some potential behavior change: `A-TestExpectations` will not return False and now it will? Yes, although that may not be a bad thing. First, there isn't anything like "*TestExpectations" in LayoutTests. But more importantly, if we do end up picking up a file we don't expect to, we just end up running the style checker more aggressively than we intended to, which is unlikely to be harmful 1746671 5 424951 dewei_zhu 2021-04-02 14:24:26 -0700 Comment on attachment 424951 Patch r=me 1746689 6 ews-feeder 2021-04-02 15:20:27 -0700 Committed r275444: <https://commits.webkit.org/r275444> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424951. 424951 2021-04-01 14:52:46 -0700 2021-04-02 15:20:28 -0700 Patch bug-224079-20210401145245.patch text/plain 2343 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NTM4NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTA0LTAxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbY2hlY2std2Via2l0LXN0eWxlXSBDaGVjayBweXRob24gZmlsZXMgaW4g TGF5b3V0VGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyNDA3OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzYxMjI4MTM+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXIucHk6CisgICAgICAgIChDaGVja2VyRGlzcGF0Y2hlci5zaG91bGRfc2tp cF93aXRob3V0X3dhcm5pbmcpOiBOZXZlciBza2lwIHN0eWxlIGNoZWNrcyBvbiAucHkgZmlsZXMu CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3VuaXR0ZXN0LnB5Ogor ICAgICAgICAoQ2hlY2tlckRpc3BhdGNoZXJTa2lwVGVzdC50ZXN0X3Nob3VsZF9za2lwX3dpdGhv dXRfd2FybmluZ19fZmFsc2UpOgorCiAyMDIxLTA0LTAxICBBYWthc2ggSmFpbiAgPGFha2FzaF9q YWluQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgZXdzIHN0YXR1cyBidWJibGUgZm9yIHN0 cmVzcyB0ZXN0cyBld3MKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl ci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIu cHkJKHJldmlzaW9uIDI3NTM4NCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlci5weQkod29ya2luZyBjb3B5KQpAQCAtMzYyLDYgKzM2Miw3IEBAIF9ORVZFUl9TS0lQUEVE X0pTX0ZJTEVTID0gWwogCiBfTkVWRVJfU0tJUFBFRF9GSUxFUyA9IF9ORVZFUl9TS0lQUEVEX0pT X0ZJTEVTICsgWwogICAgICdUZXN0RXhwZWN0YXRpb25zJywKKyAgICAnLnB5JwogXQogCiAjIEZp bGVzIHRvIHNraXAgdGhhdCBhcmUgbGVzcyBvYnZpb3VzLgpAQCAtNjM0LDggKzYzNSw5IEBAIGNs YXNzIENoZWNrZXJEaXNwYXRjaGVyKG9iamVjdCk6CiAgICAgICAgIGJhc2VuYW1lID0gb3MucGF0 aC5iYXNlbmFtZShmaWxlX3BhdGgpCiAgICAgICAgIGlmIGJhc2VuYW1lLnN0YXJ0c3dpdGgoJ0No YW5nZUxvZycpOgogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCi0gICAgICAgIGVsaWYgYmFzZW5h bWUgaW4gX05FVkVSX1NLSVBQRURfRklMRVM6Ci0gICAgICAgICAgICByZXR1cm4gRmFsc2UKKyAg ICAgICAgZm9yIHN1ZmZpeCBpbiBfTkVWRVJfU0tJUFBFRF9GSUxFUzoKKyAgICAgICAgICAgIGlm IGJhc2VuYW1lLmVuZHN3aXRoKHN1ZmZpeCk6CisgICAgICAgICAgICAgICAgcmV0dXJuIEZhbHNl CiAgICAgICAgIGZvciBza2lwcGVkX2ZpbGUgaW4gX1NLSVBQRURfRklMRVNfV0lUSE9VVF9XQVJO SU5HOgogICAgICAgICAgICAgaWYgc2VsZi5fc2hvdWxkX3NraXBfZmlsZV9wYXRoKGZpbGVfcGF0 aCwgc2tpcHBlZF9maWxlKToKICAgICAgICAgICAgICAgICByZXR1cm4gVHJ1ZQpJbmRleDogVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcl91bml0dGVzdC5weQkocmV2 aXNpb24gMjc1Mzg0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3Vu aXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zNDcsNiArMzQ3LDcgQEAgY2xhc3MgQ2hlY2tl ckRpc3BhdGNoZXJTa2lwVGVzdCh1bml0dGVzdAogICAgICAgICAiIiJUZXN0IHNob3VsZF9za2lw X3dpdGhvdXRfd2FybmluZygpIGZvciBGYWxzZSByZXR1cm4gdmFsdWVzLiIiIgogICAgICAgICBw YXRocyA9IFsnZm9vLnR4dCcsCiAgICAgICAgICAgICAgICAgIG9zLnBhdGguam9pbignTGF5b3V0 VGVzdHMnLCAnQ2hhbmdlTG9nJyksCisgICAgICAgICAgICAgICAgIG9zLnBhdGguam9pbignTGF5 b3V0VGVzdHMnLCAnZm9vLnB5JyksCiAgICAgICAgIF0KIAogICAgICAgICBmb3IgcGF0aCBpbiBw YXRoczoK