224060 2021-04-01 11:49:16 -0700 Remove use of ENABLE from API header 2021-04-01 13:02:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1746128 0 tzagallo 2021-04-01 11:49:16 -0700 <rdar://76111678> 1746144 1 424924 tzagallo 2021-04-01 12:00:14 -0700 Created attachment 424924 Patch 1746148 2 424924 saam 2021-04-01 12:01:18 -0700 Comment on attachment 424924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424924&action=review > Source/JavaScriptCore/API/JSVirtualMachine.mm:288 > +#if ENABLE(DFG_JIT) don't you want to return 0 in an #else? 1746150 3 424924 mark.lam 2021-04-01 12:01:33 -0700 Comment on attachment 424924 Patch r=me 1746152 4 424924 mark.lam 2021-04-01 12:02:22 -0700 Comment on attachment 424924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424924&action=review >> Source/JavaScriptCore/API/JSVirtualMachine.mm:288 >> +#if ENABLE(DFG_JIT) > > don't you want to return 0 in an #else? Yeah, I was about to say that too. Missed it the first time I read this. 1746156 5 424924 tzagallo 2021-04-01 12:08:36 -0700 Comment on attachment 424924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424924&action=review >>> Source/JavaScriptCore/API/JSVirtualMachine.mm:288 >>> +#if ENABLE(DFG_JIT) >> >> don't you want to return 0 in an #else? > > Yeah, I was about to say that too. Missed it the first time I read this. Oops, good catch, thanks 1746158 6 424926 tzagallo 2021-04-01 12:09:10 -0700 Created attachment 424926 Patch for landing 1746206 7 ews-feeder 2021-04-01 13:02:55 -0700 Committed r275374: <https://commits.webkit.org/r275374> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424926. 424924 2021-04-01 12:00:14 -0700 2021-04-01 12:18:53 -0700 Patch bug-224060-20210401120013.patch text/plain 3027 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0ODkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk MWMxYzA2ZGUxZWE0N2FmZTFlZDkwZDIwZjNjNjM2MWU3OGUwZmEwLi5hNDE1OTllY2Y4YWViY2E3 NzFiNWRhNTNkN2NkYzc1YWNkOGVmOGFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMS0wNC0wMSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBSZW1vdmUgdXNlIG9mIEVOQUJMRSBmcm9tIEFQSSBoZWFkZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDA2MAorICAgICAg ICA8cmRhcjovLzc2MTExNjc4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSB1c2Ugb2YgdGhlIEVOQUJMRSBtYWNybyBpbiB0aGVzZSBBUEkgaGVh ZGVycyBoYXMgY2F1c2VkIGJ1aWxkIGZhaWx1cmVzLiBJbnN0ZWFkIG9mCisgICAgICAgIGNvbmRp dGlvbmFsbHkgZXhwb3NpbmcgdGhlc2UgQVBJIG1ldGhvZHMgd2UgbWFrZSB0aGVtIGludG8gbm8t b3BzIGlmIERGRyBpcyBkaXNhYmxlZC4KKworICAgICAgICAqIEFQSS9KU1ZpcnR1YWxNYWNoaW5l Lm1tOgorICAgICAgICAoK1tKU1ZpcnR1YWxNYWNoaW5lIHNldE51bWJlck9mREZHQ29tcGlsZXJU aHJlYWRzOl0pOgorICAgICAgICAoK1tKU1ZpcnR1YWxNYWNoaW5lIHNldE51bWJlck9mRlRMQ29t cGlsZXJUaHJlYWRzOl0pOgorICAgICAgICAqIEFQSS9KU1ZpcnR1YWxNYWNoaW5lUHJpdmF0ZS5o OgorCiAyMDIxLTAzLTIzICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAg ICAgICAgW0pTQ10gVXNlIEVycm9ySW5zdGFuY2UgZm9yIEFnZ3JlZ2F0ZUVycm9yCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmlydHVhbE1hY2hpbmUubW0gYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmlydHVhbE1hY2hpbmUubW0KaW5kZXggMzAzMjI2NDAx ZDQ0ZGNmZDUzOGUwZDgyZmEwYWRjZWI0M2U1MmQ5ZC4uNDNiYWZiMDlhODc5NjBhOTQwODc0M2Y1 MmY4YTAwYmYwMzE3NDhjZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9K U1ZpcnR1YWxNYWNoaW5lLm1tCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNWaXJ0 dWFsTWFjaGluZS5tbQpAQCAtMjcyLDI3ICsyNzIsMjcgQEAgLSAodm9pZClzaHJpbmtGb290cHJp bnRXaGVuSWRsZQogICAgIHZtLT5zaHJpbmtGb290cHJpbnRXaGVuSWRsZSgpOwogfQogCi0jaWYg RU5BQkxFKERGR19KSVQpCi0KICsgKE5TVUludGVnZXIpc2V0TnVtYmVyT2ZERkdDb21waWxlclRo cmVhZHM6KE5TVUludGVnZXIpbnVtYmVyT2ZUaHJlYWRzCiB7CisjaWYgRU5BQkxFKERGR19KSVQp CiAgICAgSlNDOjpERkc6OldvcmtsaXN0KiB3b3JrbGlzdCA9IEpTQzo6REZHOjpleGlzdGluZ0ds b2JhbERGR1dvcmtsaXN0T3JOdWxsKCk7CiAgICAgaWYgKHdvcmtsaXN0KQogICAgICAgICByZXR1 cm4gd29ya2xpc3QtPnNldE51bWJlck9mVGhyZWFkcyhudW1iZXJPZlRocmVhZHMsIEpTQzo6T3B0 aW9uczo6cHJpb3JpdHlEZWx0YU9mREZHQ29tcGlsZXJUaHJlYWRzKCkpOwogICAgIGVsc2UKICAg ICAgICAgcmV0dXJuIEpTQzo6REZHOjpzZXROdW1iZXJPZkRGR0NvbXBpbGVyVGhyZWFkcyhudW1i ZXJPZlRocmVhZHMpOworI2VuZGlmIC8vIEVOQUJMRShERkdfSklUKQogfQogCiArIChOU1VJbnRl Z2VyKXNldE51bWJlck9mRlRMQ29tcGlsZXJUaHJlYWRzOihOU1VJbnRlZ2VyKW51bWJlck9mVGhy ZWFkcwogeworI2lmIEVOQUJMRShERkdfSklUKQogICAgIEpTQzo6REZHOjpXb3JrbGlzdCogd29y a2xpc3QgPSBKU0M6OkRGRzo6ZXhpc3RpbmdHbG9iYWxGVExXb3JrbGlzdE9yTnVsbCgpOwogICAg IGlmICh3b3JrbGlzdCkKICAgICAgICAgcmV0dXJuIHdvcmtsaXN0LT5zZXROdW1iZXJPZlRocmVh ZHMobnVtYmVyT2ZUaHJlYWRzLCBKU0M6Ok9wdGlvbnM6OnByaW9yaXR5RGVsdGFPZkZUTENvbXBp bGVyVGhyZWFkcygpKTsKICAgICBlbHNlCiAgICAgICAgIHJldHVybiBKU0M6OkRGRzo6c2V0TnVt YmVyT2ZGVExDb21waWxlclRocmVhZHMobnVtYmVyT2ZUaHJlYWRzKTsKLX0KLQogI2VuZGlmIC8v IEVOQUJMRShERkdfSklUKQorfQogCiAtIChKU0NvbnRleHRHcm91cFJlZilKU0NvbnRleHRHcm91 cFJlZgogewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1ZpcnR1YWxN YWNoaW5lUHJpdmF0ZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1ZpcnR1YWxNYWNo aW5lUHJpdmF0ZS5oCmluZGV4IDIxMTNlYzliYzA2NzQwOGExYzZlOTBhNWNlZmMxNTBkMzE0MTFh MDcuLjhlODNjOWNmMGY5YTY5OTM1MjA2OTE0NzlkNTczMmE3NWFjYzI1ZTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNWaXJ0dWFsTWFjaGluZVByaXZhdGUuaAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmlydHVhbE1hY2hpbmVQcml2YXRlLmgKQEAg LTQ1LDggKzQ1LDYgQEAKIAogLSAodm9pZClzaHJpbmtGb290cHJpbnRXaGVuSWRsZSBKU0NfQVBJ X0FWQUlMQUJMRShtYWNvcygxMC4xNCksIGlvcygxMi4wKSk7CiAKLSNpZiBFTkFCTEUoREZHX0pJ VCkKLQogLyohCiBAbWV0aG9kCiBAYWJzdHJhY3QgU2V0IHRoZSBudW1iZXIgb2YgdGhyZWFkcyB0 byBiZSB1c2VkIGJ5IHRoZSBERkcgSklUIGNvbXBpbGVyLgpAQCAtODAsOCArNzgsNiBAQAogKi8K ICsgKHZvaWQpc2V0Q3Jhc2hPblZNQ3JlYXRpb246KEJPT0wpc2hvdWxkQ3Jhc2g7CiAKLSNlbmRp ZiAvLyBFTkFCTEUoREZHX0pJVCkKLQogQGVuZAogCiAjZW5kaWYgLy8gSlNDX09CSkNfQVBJX0VO QUJMRUQK 424926 2021-04-01 12:09:10 -0700 2021-04-01 13:02:56 -0700 Patch for landing bug-224060-20210401120909.patch text/plain 3065 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0ODkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk MWMxYzA2ZGUxZWE0N2FmZTFlZDkwZDIwZjNjNjM2MWU3OGUwZmEwLi40ZDEwZDhhY2Q0YTI0OWFl NjJjZDFhZGNlOTg3YmQ5OTQ1OGYzOTRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMS0wNC0wMSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBSZW1vdmUgdXNlIG9mIEVOQUJMRSBmcm9tIEFQSSBoZWFkZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDA2MAorICAgICAg ICA8cmRhcjovLzc2MTExNjc4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgTGFtLgorCisg ICAgICAgIFRoZSB1c2Ugb2YgdGhlIEVOQUJMRSBtYWNybyBpbiB0aGVzZSBBUEkgaGVhZGVycyBo YXMgY2F1c2VkIGJ1aWxkIGZhaWx1cmVzLiBJbnN0ZWFkIG9mCisgICAgICAgIGNvbmRpdGlvbmFs bHkgZXhwb3NpbmcgdGhlc2UgQVBJIG1ldGhvZHMgd2UgbWFrZSB0aGVtIGludG8gbm8tb3BzIGlm IERGRyBpcyBkaXNhYmxlZC4KKworICAgICAgICAqIEFQSS9KU1ZpcnR1YWxNYWNoaW5lLm1tOgor ICAgICAgICAoK1tKU1ZpcnR1YWxNYWNoaW5lIHNldE51bWJlck9mREZHQ29tcGlsZXJUaHJlYWRz Ol0pOgorICAgICAgICAoK1tKU1ZpcnR1YWxNYWNoaW5lIHNldE51bWJlck9mRlRMQ29tcGlsZXJU aHJlYWRzOl0pOgorICAgICAgICAqIEFQSS9KU1ZpcnR1YWxNYWNoaW5lUHJpdmF0ZS5oOgorCiAy MDIxLTAzLTIzICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAg W0pTQ10gVXNlIEVycm9ySW5zdGFuY2UgZm9yIEFnZ3JlZ2F0ZUVycm9yCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmlydHVhbE1hY2hpbmUubW0gYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQVBJL0pTVmlydHVhbE1hY2hpbmUubW0KaW5kZXggMzAzMjI2NDAxZDQ0ZGNm ZDUzOGUwZDgyZmEwYWRjZWI0M2U1MmQ5ZC4uZTEzN2QwODk0NDVmOTE2MGYzZTRhMzYxZDY2OTVk MjcyNmNiMzViYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1ZpcnR1 YWxNYWNoaW5lLm1tCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNWaXJ0dWFsTWFj aGluZS5tbQpAQCAtMjcyLDI3ICsyNzIsMzEgQEAgLSAodm9pZClzaHJpbmtGb290cHJpbnRXaGVu SWRsZQogICAgIHZtLT5zaHJpbmtGb290cHJpbnRXaGVuSWRsZSgpOwogfQogCi0jaWYgRU5BQkxF KERGR19KSVQpCi0KICsgKE5TVUludGVnZXIpc2V0TnVtYmVyT2ZERkdDb21waWxlclRocmVhZHM6 KE5TVUludGVnZXIpbnVtYmVyT2ZUaHJlYWRzCiB7CisjaWYgRU5BQkxFKERGR19KSVQpCiAgICAg SlNDOjpERkc6OldvcmtsaXN0KiB3b3JrbGlzdCA9IEpTQzo6REZHOjpleGlzdGluZ0dsb2JhbERG R1dvcmtsaXN0T3JOdWxsKCk7CiAgICAgaWYgKHdvcmtsaXN0KQogICAgICAgICByZXR1cm4gd29y a2xpc3QtPnNldE51bWJlck9mVGhyZWFkcyhudW1iZXJPZlRocmVhZHMsIEpTQzo6T3B0aW9uczo6 cHJpb3JpdHlEZWx0YU9mREZHQ29tcGlsZXJUaHJlYWRzKCkpOwogICAgIGVsc2UKICAgICAgICAg cmV0dXJuIEpTQzo6REZHOjpzZXROdW1iZXJPZkRGR0NvbXBpbGVyVGhyZWFkcyhudW1iZXJPZlRo cmVhZHMpOworI2Vsc2UKKyAgICByZXR1cm4gMDsKKyNlbmRpZiAvLyBFTkFCTEUoREZHX0pJVCkK IH0KIAogKyAoTlNVSW50ZWdlcilzZXROdW1iZXJPZkZUTENvbXBpbGVyVGhyZWFkczooTlNVSW50 ZWdlciludW1iZXJPZlRocmVhZHMKIHsKKyNpZiBFTkFCTEUoREZHX0pJVCkKICAgICBKU0M6OkRG Rzo6V29ya2xpc3QqIHdvcmtsaXN0ID0gSlNDOjpERkc6OmV4aXN0aW5nR2xvYmFsRlRMV29ya2xp c3RPck51bGwoKTsKICAgICBpZiAod29ya2xpc3QpCiAgICAgICAgIHJldHVybiB3b3JrbGlzdC0+ c2V0TnVtYmVyT2ZUaHJlYWRzKG51bWJlck9mVGhyZWFkcywgSlNDOjpPcHRpb25zOjpwcmlvcml0 eURlbHRhT2ZGVExDb21waWxlclRocmVhZHMoKSk7CiAgICAgZWxzZQogICAgICAgICByZXR1cm4g SlNDOjpERkc6OnNldE51bWJlck9mRlRMQ29tcGlsZXJUaHJlYWRzKG51bWJlck9mVGhyZWFkcyk7 Ci19Ci0KKyNlbHNlCisgICAgcmV0dXJuIDA7CiAjZW5kaWYgLy8gRU5BQkxFKERGR19KSVQpCit9 CiAKIC0gKEpTQ29udGV4dEdyb3VwUmVmKUpTQ29udGV4dEdyb3VwUmVmCiB7CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmlydHVhbE1hY2hpbmVQcml2YXRlLmggYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmlydHVhbE1hY2hpbmVQcml2YXRlLmgKaW5kZXgg MjExM2VjOWJjMDY3NDA4YTFjNmU5MGE1Y2VmYzE1MGQzMTQxMWEwNy4uOGU4M2M5Y2YwZjlhNjk5 MzUyMDY5MTQ3OWQ1NzMyYTc1YWNjMjVlNyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL0FQSS9KU1ZpcnR1YWxNYWNoaW5lUHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9BUEkvSlNWaXJ0dWFsTWFjaGluZVByaXZhdGUuaApAQCAtNDUsOCArNDUsNiBAQAogCiAt ICh2b2lkKXNocmlua0Zvb3RwcmludFdoZW5JZGxlIEpTQ19BUElfQVZBSUxBQkxFKG1hY29zKDEw LjE0KSwgaW9zKDEyLjApKTsKIAotI2lmIEVOQUJMRShERkdfSklUKQotCiAvKiEKIEBtZXRob2QK IEBhYnN0cmFjdCBTZXQgdGhlIG51bWJlciBvZiB0aHJlYWRzIHRvIGJlIHVzZWQgYnkgdGhlIERG RyBKSVQgY29tcGlsZXIuCkBAIC04MCw4ICs3OCw2IEBACiAqLwogKyAodm9pZClzZXRDcmFzaE9u Vk1DcmVhdGlvbjooQk9PTClzaG91bGRDcmFzaDsKIAotI2VuZGlmIC8vIEVOQUJMRShERkdfSklU KQotCiBAZW5kCiAKICNlbmRpZiAvLyBKU0NfT0JKQ19BUElfRU5BQkxFRAo=