224044 2021-04-01 05:03:13 -0700 Cleanup shouldComputeLogicalWidthFromAspectRatio and shouldComputeLogicalWidthFromAspectRatioAndInsets 2021-04-01 08:36:10 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan pdr rbuis simon.fraser webkit-bug-importer zalan oldest_to_newest 1745988 0 zalan 2021-04-01 05:03:13 -0700 turn if (foo) return true; return false; into return !foo; 1745989 1 424886 zalan 2021-04-01 05:08:16 -0700 Created attachment 424886 Patch 1745990 2 424886 koivisto 2021-04-01 05:10:22 -0700 Comment on attachment 424886 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424886&action=review > Source/WebCore/rendering/RenderBox.cpp:5130 > + return style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto()); I'd probably split this into multiple returns. 1745992 3 zalan 2021-04-01 05:22:57 -0700 (In reply to Antti Koivisto from comment #2) > Comment on attachment 424886 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=424886&action=review > > > Source/WebCore/rendering/RenderBox.cpp:5130 > > + return style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto()); > > I'd probably split this into multiple returns. Good idea. I am still trying to understand what this logic is in reference to. will do in a separate patch. 1746017 4 zalan 2021-04-01 07:34:26 -0700 (In reply to zalan from comment #0) > turn > if (foo) > return true; > return false; > > into > return !foo; should read "return foo;" 1746019 5 ews-feeder 2021-04-01 07:47:57 -0700 Committed r275357: <https://commits.webkit.org/r275357> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424886. 1746021 6 webkit-bug-importer 2021-04-01 07:48:14 -0700 <rdar://problem/76103365> 424886 2021-04-01 05:08:16 -0700 2021-04-01 07:47:58 -0700 Patch bug-224044-20210401050815.patch text/plain 2751 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjU0ZjcwODgwNWI5MGQ2 MTlhZGZkMjRjZjQ1ZGNiMjJiNDIxNTIwMi4uODMxMmRlNDM3ODJlNWJlNjZjZjdkZmY2NWZlNjdi NTZjY2JmNzA2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA0LTAxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYW51cCBzaG91bGRDb21w dXRlTG9naWNhbFdpZHRoRnJvbUFzcGVjdFJhdGlvIGFuZCBzaG91bGRDb21wdXRlTG9naWNhbFdp ZHRoRnJvbUFzcGVjdFJhdGlvQW5kSW5zZXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQwNDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBMZXQncyB1c2UgInJldHVybiBmb28oKSIgKG9yICJyZXR1cm4g IWZvbygpIikgaW5zdGVhZCBvZgorICAgICAgICBpZiAoIWZvbygpKQorICAgICAgICAgIHJldHVy biB0cnVlOworICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6c2hvdWxkQ29tcHV0ZUxv Z2ljYWxXaWR0aEZyb21Bc3BlY3RSYXRpbyBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJCb3g6OnNob3VsZENvbXB1dGVMb2dpY2FsV2lkdGhGcm9tQXNwZWN0UmF0aW9BbmRJbnNldHMg Y29uc3QpOgorCiAyMDIxLTA0LTAxICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlh LmNvbT4KIAogICAgICAgICBFeHBvc2UgYW4gYWxpYXMgZm9yIFNjcm9sbFNuYXBPZmZzZXRJbmZv PFQ+IHRvIG1ha2UgaXQgZWFzaWVyIHRvIHVzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Qm94LmNwcAppbmRleCA3ZDlmZGJmZjkyYzE1NThhZDE5M2I0NTA1NjI1ZWI4MjVmOGIyMmNiLi40 ZDc1YWNmMzRlYTA1M2I2OWI2ZTNjZDBjNDhhMjU0YmQwMDA1YWEwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQm94LmNwcApAQCAtNTExNywyMiArNTExNywxNyBAQCBib29sIFJlbmRl ckJveDo6c2hvdWxkQ29tcHV0ZUxvZ2ljYWxXaWR0aEZyb21Bc3BlY3RSYXRpbygpIGNvbnN0CiAg ICAgaWYgKHNob3VsZElnbm9yZUFzcGVjdFJhdGlvKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK IAotICAgIGF1dG8gaXNSZXNvbHZhYmxlUGVyY2VudGFnZUhlaWdodCA9IFt0aGlzXSAoKSB7Cisg ICAgYXV0byBpc1Jlc29sdmFibGVQZXJjZW50YWdlSGVpZ2h0ID0gWyZdIHsKICAgICAgICAgcmV0 dXJuIHN0eWxlKCkubG9naWNhbEhlaWdodCgpLmlzUGVyY2VudE9yQ2FsY3VsYXRlZCgpICYmIChp c091dE9mRmxvd1Bvc2l0aW9uZWQoKSB8fCBwZXJjZW50YWdlTG9naWNhbEhlaWdodElzUmVzb2x2 YWJsZSgpKTsKICAgICB9OwotICAgIGlmICghaGFzT3ZlcnJpZGluZ0xvZ2ljYWxIZWlnaHQoKSAm JiAhc2hvdWxkQ29tcHV0ZUxvZ2ljYWxXaWR0aEZyb21Bc3BlY3RSYXRpb0FuZEluc2V0cygpICYm ICFzdHlsZSgpLmxvZ2ljYWxIZWlnaHQoKS5pc0ZpeGVkKCkgJiYgIWlzUmVzb2x2YWJsZVBlcmNl bnRhZ2VIZWlnaHQoKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgcmV0dXJuIHRydWU7 CisgICAgcmV0dXJuIGhhc092ZXJyaWRpbmdMb2dpY2FsSGVpZ2h0KCkgfHwgc2hvdWxkQ29tcHV0 ZUxvZ2ljYWxXaWR0aEZyb21Bc3BlY3RSYXRpb0FuZEluc2V0cygpIHx8IHN0eWxlKCkubG9naWNh bEhlaWdodCgpLmlzRml4ZWQoKSB8fCBpc1Jlc29sdmFibGVQZXJjZW50YWdlSGVpZ2h0KCk7CiB9 CiAKIGJvb2wgUmVuZGVyQm94OjpzaG91bGRDb21wdXRlTG9naWNhbFdpZHRoRnJvbUFzcGVjdFJh dGlvQW5kSW5zZXRzKCkgY29uc3QKIHsKICAgICBpZiAoIWlzT3V0T2ZGbG93UG9zaXRpb25lZCgp KQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgaWYgKHN0eWxlKCkud2lkdGgoKS5pc0F1dG8o KSAmJiBzdHlsZSgpLmhlaWdodCgpLmlzQXV0bygpICYmICFzdHlsZSgpLmxvZ2ljYWxUb3AoKS5p c0F1dG8oKSAmJiAhc3R5bGUoKS5sb2dpY2FsQm90dG9tKCkuaXNBdXRvKCkgJiYgKHN0eWxlKCku bG9naWNhbExlZnQoKS5pc0F1dG8oKSB8fCBzdHlsZSgpLmxvZ2ljYWxSaWdodCgpLmlzQXV0bygp KSkKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiBz dHlsZSgpLndpZHRoKCkuaXNBdXRvKCkgJiYgc3R5bGUoKS5oZWlnaHQoKS5pc0F1dG8oKSAmJiAh c3R5bGUoKS5sb2dpY2FsVG9wKCkuaXNBdXRvKCkgJiYgIXN0eWxlKCkubG9naWNhbEJvdHRvbSgp LmlzQXV0bygpICYmIChzdHlsZSgpLmxvZ2ljYWxMZWZ0KCkuaXNBdXRvKCkgfHwgc3R5bGUoKS5s b2dpY2FsUmlnaHQoKS5pc0F1dG8oKSk7CiB9CiAKIExheW91dFVuaXQgUmVuZGVyQm94Ojpjb21w dXRlTG9naWNhbFdpZHRoRnJvbUFzcGVjdFJhdGlvKFJlbmRlckZyYWdtZW50Q29udGFpbmVyKiBm cmFnbWVudCkgY29uc3QK