224041 2021-04-01 01:44:31 -0700 Bail out early if encoded frame is written twice 2021-04-02 01:12:12 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1745963 0 youennf 2021-04-01 01:44:31 -0700 Bail out early if encoded frame is written twice 1745964 1 424881 youennf 2021-04-01 01:46:09 -0700 Created attachment 424881 Patch 1746411 2 ews-feeder 2021-04-02 01:11:50 -0700 Committed r275408: <https://commits.webkit.org/r275408> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424881. 1746412 3 webkit-bug-importer 2021-04-02 01:12:12 -0700 <rdar://problem/76141990> 424881 2021-04-01 01:46:09 -0700 2021-04-02 01:11:51 -0700 Patch bug-224041-20210401104607.patch text/plain 6784 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjVkZTQ0ODYxNmI1MDc5 M2JiMzk1NWFiMGU5NmU1MWVjYjc4NGExMS4uNzQ1MGQzYjk4NDlkODA2OWMzNjQyZTc1MzYxZTNj ZTdjZTk2YzFiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA0LTAxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBCYWlsIG91dCBlYXJseSBp ZiBlbmNvZGVkIGZyYW1lIGlzIHdyaXR0ZW4gdHdpY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDA0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGh0dHAvd3B0L3dlYnJ0Yy93cml0ZS10d2lj ZS10cmFuc2Zvcm0uaHRtbAorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3ZWJy dGMvTGliV2ViUlRDUnRwVHJhbnNmb3JtQmFja2VuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpM aWJXZWJSVENSdHBUcmFuc2Zvcm1CYWNrZW5kOjpwcm9jZXNzVHJhbnNmb3JtZWRGcmFtZSk6Cisg ICAgICAgIEluIGNhc2UgdGhlIGZyYW1lIGlzIHdyaXR0ZW4gdHdpY2UsIHRoZSBzZWNvbmQgd3Jp dGUgaXMgY29uc2lkZXJlZCBhcyBhIG5vLW9wLgorCiAyMDIxLTA0LTAxICBZb3Vlbm4gRmFibGV0 ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBTdGFydCBvYnNlcnZpbmcgb3V0Z29pbmcg YXVkaW8vdmlkZW8gc291cmNlcyBhc3luY2hyb25vdXNseQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUnRwVHJhbnNmb3Jt QmFja2VuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0 Yy9MaWJXZWJSVENSdHBUcmFuc2Zvcm1CYWNrZW5kLmNwcAppbmRleCA2Y2FkYjQyNGZkNmNlODY5 YjJjZDNmNDU3YTdlOWI2ZDI5MDg2NDkyLi40OTI2NDc5N2M2MWY4MjU1MDUxZWI3Y2MyYzE3ZWNh ZTY4MWQzNmVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFt L2xpYndlYnJ0Yy9MaWJXZWJSVENSdHBUcmFuc2Zvcm1CYWNrZW5kLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENSdHBUcmFuc2Zv cm1CYWNrZW5kLmNwcApAQCAtNTAsOSArNTAsMTIgQEAgdm9pZCBMaWJXZWJSVENSdHBUcmFuc2Zv cm1CYWNrZW5kOjpzZXRPdXRwdXRDYWxsYmFjayhydGM6OnNjb3BlZF9yZWZwdHI8d2VicnRjOjoK IAogdm9pZCBMaWJXZWJSVENSdHBUcmFuc2Zvcm1CYWNrZW5kOjpwcm9jZXNzVHJhbnNmb3JtZWRG cmFtZShSVENSdHBUcmFuc2Zvcm1hYmxlRnJhbWUmIGZyYW1lKQogeworICAgIGF1dG8gcnRjRnJh bWUgPSBzdGF0aWNfY2FzdDxMaWJXZWJSVENSdHBUcmFuc2Zvcm1hYmxlRnJhbWUmPihmcmFtZSku dGFrZVJUQ0ZyYW1lKCk7CisgICAgaWYgKCFydGNGcmFtZSkKKyAgICAgICAgcmV0dXJuOwogICAg IGF1dG8gbG9ja2VyID0gaG9sZExvY2sobV9vdXRwdXRDYWxsYmFja0xvY2spOwogICAgIGlmICht X291dHB1dENhbGxiYWNrKQotICAgICAgICBtX291dHB1dENhbGxiYWNrLT5PblRyYW5zZm9ybWVk RnJhbWUoc3RhdGljX2Nhc3Q8TGliV2ViUlRDUnRwVHJhbnNmb3JtYWJsZUZyYW1lJj4oZnJhbWUp LnRha2VSVENGcmFtZSgpKTsKKyAgICAgICAgbV9vdXRwdXRDYWxsYmFjay0+T25UcmFuc2Zvcm1l ZEZyYW1lKFdURk1vdmUocnRjRnJhbWUpKTsKIH0KIAogdm9pZCBMaWJXZWJSVENSdHBUcmFuc2Zv cm1CYWNrZW5kOjpUcmFuc2Zvcm0oc3RkOjp1bmlxdWVfcHRyPHdlYnJ0Yzo6VHJhbnNmb3JtYWJs ZUZyYW1lSW50ZXJmYWNlPiBydGNGcmFtZSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkZTM2NDdkOGQ0MzNhZWUwZGQwZjA3 NDA1ZjBhYzc4MTZjMjZiZTkzLi4xOTY1OWRhNGJjOTBkMTRiOGJjYTllZDAzOTA4OGNjMTU1Nzc5 OTYyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDQtMDEgIFlvdWVubiBGYWJsZXQgIDx5 b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIEJhaWwgb3V0IGVhcmx5IGlmIGVuY29kZWQgZnJh bWUgaXMgd3JpdHRlbiB0d2ljZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI0MDQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBodHRwL3dwdC93ZWJydGMvd3JpdGUtdHdpY2UtdHJhbnNmb3JtLWV4cGVj dGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC93cHQvd2VicnRjL3dyaXRlLXR3aWNlLXRy YW5zZm9ybS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3dwdC93ZWJydGMvd3JpdGUtdHdp Y2UtdHJhbnNmb3JtLmpzOiBBZGRlZC4KKyAgICAgICAgKG9ucnRjdHJhbnNmb3JtLnByb2Nlc3Mp OgorICAgICAgICAob25ydGN0cmFuc2Zvcm0pOgorCiAyMDIxLTAzLTMxICBZb3Vlbm4gRmFibGV0 ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBJbiBjYXNlIFdlYlJUQyBWVEIgZGVjb2Rl ciByZXR1cm5zIGEgbnVsbCBmcmFtZSwgbWFyayB0aGUgZGVjb2RlciBhcyBmYWlsaW5nCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3dwdC93ZWJydGMvd3JpdGUtdHdpY2UtdHJhbnNmb3Jt LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvd3B0L3dlYnJ0Yy93cml0ZS10d2ljZS10 cmFuc2Zvcm0tZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmI3NjVmZjA4NGE3MmRlY2Q3ODljMTU2 N2Q3NDdkOTliZjk4Njc4N2UKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3dw dC93ZWJydGMvd3JpdGUtdHdpY2UtdHJhbnNmb3JtLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDQg QEAKKworCitQQVNTIHZpZGVvIGV4Y2hhbmdlIHdpdGggd3JpdGUgdHdpY2UgdHJhbnNmb3JtCisK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvd3B0L3dlYnJ0Yy93cml0ZS10d2ljZS10cmFu c2Zvcm0uaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvd3B0L3dlYnJ0Yy93cml0ZS10d2ljZS10cmFu c2Zvcm0uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zOThiNWEzYzU3MWE0OTI5MmZkMzExM2E0ODgxYjFjZWM3 MDcxZTY4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC93cHQvd2VicnRjL3dy aXRlLXR3aWNlLXRyYW5zZm9ybS5odG1sCkBAIC0wLDAgKzEsNTggQEAKKzwhZG9jdHlwZSBodG1s PgorPGh0bWw+CisgICAgPGhlYWQ+CisgICAgICAgIDxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4KKyAg ICAgICAgPHNjcmlwdCBzcmM9Ii9yZXNvdXJjZXMvdGVzdGhhcm5lc3MuanMiPjwvc2NyaXB0Pgor ICAgICAgICA8c2NyaXB0IHNyYz0iL3Jlc291cmNlcy90ZXN0aGFybmVzc3JlcG9ydC5qcyI+PC9z Y3JpcHQ+CisgICAgPC9oZWFkPgorICAgIDxib2R5PgorICAgICAgICA8dmlkZW8gaWQ9InZpZGVv MSIgYXV0b3BsYXk+PC92aWRlbz4KKyAgICAgICAgPHZpZGVvIGlkPSJ2aWRlbzIiIGF1dG9wbGF5 PjwvdmlkZW8+CisgICAgICAgIDxzY3JpcHQgc3JjID0icm91dGluZXMuanMiPjwvc2NyaXB0Pgor ICAgICAgICA8c2NyaXB0PgorYXN5bmMgZnVuY3Rpb24gd2FpdEZvck1lc3NhZ2Uod29ya2VyLCBk YXRhKQoreworICAgIHdoaWxlICh0cnVlKSB7CisgICAgICAgIGNvbnN0IHJlY2VpdmVkID0gYXdh aXQgbmV3IFByb21pc2UocmVzb2x2ZSA9PiB3b3JrZXIub25tZXNzYWdlID0gKGV2ZW50KSA9PiBy ZXNvbHZlKGV2ZW50LmRhdGEpKTsKKyAgICAgICAgaWYgKGRhdGEgPT09IHJlY2VpdmVkKQorICAg ICAgICAgICAgcmV0dXJuOworICAgIH0KK30KKworcHJvbWlzZV90ZXN0KGFzeW5jICh0ZXN0KSA9 PiB7CisgICAgd29ya2VyID0gbmV3IFdvcmtlcignd3JpdGUtdHdpY2UtdHJhbnNmb3JtLmpzJyk7 CisgICAgY29uc3QgZGF0YSA9IGF3YWl0IG5ldyBQcm9taXNlKHJlc29sdmUgPT4gd29ya2VyLm9u bWVzc2FnZSA9IChldmVudCkgPT4gcmVzb2x2ZShldmVudC5kYXRhKSk7CisgICAgYXNzZXJ0X2Vx dWFscyhkYXRhLCAicmVnaXN0ZXJlZCIpOworCisgICAgY29uc3QgbG9jYWxTdHJlYW0gPSBhd2Fp dCBuYXZpZ2F0b3IubWVkaWFEZXZpY2VzLmdldFVzZXJNZWRpYSh7dmlkZW86IHRydWV9KTsKKwor ICAgIGxldCBzZW5kZXIsIHJlY2VpdmVyOworICAgIGNvbnN0IHNlbmRlclRyYW5zZm9ybSA9IG5l dyBSVENSdHBTY3JpcHRUcmFuc2Zvcm0od29ya2VyLCB7bmFtZTonTW9ja1JUQ1J0cFRyYW5zZm9y bScsIHNpZGU6J3NlbmRlcicsIHJvbGU6J2VuY3J5cHQnfSk7CisgICAgY29uc3QgcmVjZWl2ZXJU cmFuc2Zvcm0gPSBuZXcgUlRDUnRwU2NyaXB0VHJhbnNmb3JtKHdvcmtlciwge25hbWU6J01vY2tS VENSdHBUcmFuc2Zvcm0nLCBzaWRlOidyZWNlaXZlcicsIHJvbGU6J2RlY3J5cHQnfSk7CisKKyAg ICBjb25zdCBzdGFydGVkUHJvbWlzZSA9IG5ldyBQcm9taXNlKHJlc29sdmUgPT4gd29ya2VyLm9u bWVzc2FnZSA9IChldmVudCkgPT4gcmVzb2x2ZShldmVudC5kYXRhKSk7CisKKyAgICBjb25zdCBz dHJlYW0gPSBhd2FpdCBuZXcgUHJvbWlzZSgocmVzb2x2ZSwgcmVqZWN0KSA9PiB7CisgICAgICAg IGNyZWF0ZUNvbm5lY3Rpb25zKChmaXJzdENvbm5lY3Rpb24pID0+IHsKKyAgICAgICAgICAgIHBj MSA9IGZpcnN0Q29ubmVjdGlvbjsKKyAgICAgICAgICAgIHNlbmRlciA9IGZpcnN0Q29ubmVjdGlv bi5hZGRUcmFjayhsb2NhbFN0cmVhbS5nZXRWaWRlb1RyYWNrcygpWzBdLCBsb2NhbFN0cmVhbSk7 CisgICAgICAgICAgICBzZW5kZXIudHJhbnNmb3JtID0gc2VuZGVyVHJhbnNmb3JtOworICAgICAg ICB9LCAoc2Vjb25kQ29ubmVjdGlvbikgPT4geworICAgICAgICAgICAgcGMyID0gc2Vjb25kQ29u bmVjdGlvbjsKKyAgICAgICAgICAgIHNlY29uZENvbm5lY3Rpb24ub250cmFjayA9ICh0cmFja0V2 ZW50KSA9PiB7CisgICAgICAgICAgICAgICAgcmVjZWl2ZXIgPSB0cmFja0V2ZW50LnJlY2VpdmVy OworICAgICAgICAgICAgICAgIHJlY2VpdmVyLnRyYW5zZm9ybSA9IHJlY2VpdmVyVHJhbnNmb3Jt OworICAgICAgICAgICAgICAgIHJlc29sdmUodHJhY2tFdmVudC5zdHJlYW1zWzBdKTsKKyAgICAg ICAgICAgIH07CisgICAgICAgIH0pOworICAgICAgICBzZXRUaW1lb3V0KCgpID0+IHJlamVjdCgi VGVzdCB0aW1lZCBvdXQiKSwgNTAwMCk7CisgICAgfSk7CisKKyAgICBhc3NlcnRfZXF1YWxzKGF3 YWl0IHN0YXJ0ZWRQcm9taXNlLCAic3RhcnRlZCIpOworCisgICAgdmlkZW8xLnNyY09iamVjdCA9 IHN0cmVhbTsKKyAgICBhd2FpdCB2aWRlbzEucGxheSgpOworfSwgInZpZGVvIGV4Y2hhbmdlIHdp dGggd3JpdGUgdHdpY2UgdHJhbnNmb3JtIik7CisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvYm9k eT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvd3B0L3dlYnJ0Yy93cml0 ZS10d2ljZS10cmFuc2Zvcm0uanMgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC93ZWJydGMvd3JpdGUt dHdpY2UtdHJhbnNmb3JtLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZjZDc2OGRiMmIxZGQwYWVhODUxM2Y3Zjkw YjZlZjc5ZDY1ODBjYzYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC93 ZWJydGMvd3JpdGUtdHdpY2UtdHJhbnNmb3JtLmpzCkBAIC0wLDAgKzEsMjMgQEAKK29ucnRjdHJh bnNmb3JtID0gKGV2ZW50KSA9PiB7CisgICAgY29uc3QgdHJhbnNmb3JtZXIgPSBldmVudC50cmFu c2Zvcm1lcjsKKyAgICB0cmFuc2Zvcm1lci5wb3J0Lm9ubWVzc2FnZSA9IChldmVudCkgPT4gdHJh bnNmb3JtZXIucG9ydC5wb3N0TWVzc2FnZShldmVudC5kYXRhKTsKKworICAgIHNlbGYucG9zdE1l c3NhZ2UoInN0YXJ0ZWQiKTsKKworICAgIHRyYW5zZm9ybWVyLnJlYWRlciA9IHRyYW5zZm9ybWVy LnJlYWRhYmxlLmdldFJlYWRlcigpOworICAgIHRyYW5zZm9ybWVyLndyaXRlciA9IHRyYW5zZm9y bWVyLndyaXRhYmxlLmdldFdyaXRlcigpOworICAgIGZ1bmN0aW9uIHByb2Nlc3ModHJhbnNmb3Jt ZXIpCisgICAgeworICAgICAgICB0cmFuc2Zvcm1lci5yZWFkZXIucmVhZCgpLnRoZW4oY2h1bmsg PT4geworICAgICAgICAgICAgaWYgKGNodW5rLmRvbmUpCisgICAgICAgICAgICAgICAgcmV0dXJu OworCisgICAgICAgICAgICB0cmFuc2Zvcm1lci53cml0ZXIud3JpdGUoY2h1bmsudmFsdWUpOwor ICAgICAgICAgICAgdHJhbnNmb3JtZXIud3JpdGVyLndyaXRlKGNodW5rLnZhbHVlKTsKKyAgICAg ICAgICAgIHByb2Nlc3ModHJhbnNmb3JtZXIpOworICAgICAgICB9KTsKKyAgICB9CisKKyAgICBw cm9jZXNzKHRyYW5zZm9ybWVyKTsKK307CitzZWxmLnBvc3RNZXNzYWdlKCJyZWdpc3RlcmVkIik7 Cg==