224022 2021-03-31 15:09:33 -0700 REGRESSION: The NetworkProcess sometimes fails to relaunch after it crashes 2021-04-01 10:25:25 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224024 https://bugs.webkit.org/show_bug.cgi?id=224056 InRadar P2 Normal --- 1 cdumez cdumez achristensen darin ggaren kkinnunen webkit-bug-importer oldest_to_newest 1745803 0 cdumez 2021-03-31 15:09:33 -0700 The NetworkProcess fails to relaunch after it crashes. This is a regression from using a NetworkProcess per ProcessPool to a NetworkProcess per WebsiteDataStore AFAICT. 1745804 1 cdumez 2021-03-31 15:09:52 -0700 <rdar://75148724> 1745808 2 424827 cdumez 2021-03-31 15:15:12 -0700 Created attachment 424827 Patch 1745811 3 424827 achristensen 2021-03-31 15:22:55 -0700 Comment on attachment 424827 Patch didTerminate does this too. 1745813 4 cdumez 2021-03-31 15:25:27 -0700 (In reply to Alex Christensen from comment #3) > Comment on attachment 424827 [details] > Patch > > didTerminate does this too. Indeed, I think the termination and crash logic should share code. I opted not to do it in this patch so to keep the patch small as possible for cherry-picking. Also, there are things the crash handling does and that the termination handling doesn't, which seems like another issue. 1745818 5 424827 cdumez 2021-03-31 15:28:42 -0700 Comment on attachment 424827 Patch I will work in a follow-up to share more code between the termination and crash logic. 1745852 6 ews-feeder 2021-03-31 16:19:54 -0700 Committed r275316: <https://commits.webkit.org/r275316> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424827. 424827 2021-03-31 15:15:12 -0700 2021-03-31 16:19:55 -0700 Patch bug-224022-20210331151511.patch text/plain 2140 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1Mjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM5MzY3ZGJlYzRkNDYwNTc3 MjU3NzJhODYxMDMxZmIyM2YwN2Y2MGQuLjIzYTM4ODlhM2VjMDNjM2Y3OWRhNzVkZDMzYTIzMzk3 N2RlOThiMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjEtMDMtMzEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBUaGUgTmV0d29y a1Byb2Nlc3MgZmFpbHMgdG8gcmVsYXVuY2ggYWZ0ZXIgaXQgY3Jhc2hlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MDIyCisgICAgICAgIDxyZGFy Oi8vNzUxNDg3MjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTmV0d29ya1Byb2Nlc3NQcm94eTo6bmV0d29ya1Byb2Nlc3NDcmFzaGVkKCkgZmFpbGVk IHRvIGNsZWFyIGRlZmF1bHROZXR3b3JrUHJvY2VzcygpIGxpa2Ugd2UgZG8gb24KKyAgICAgICAg bmV0d29yayBwcm9jZXNzIHRlcm1pbmF0aW9uIChpbiBOZXR3b3JrUHJvY2Vzc1Byb3h5OjpkaWRU ZXJtaW5hdGUoKSkuIEFzIGEgcmVzdWx0LCB1cG9uIGEKKyAgICAgICAgbmV0d29yayBwcm9jZXNz IGNyYXNoLCBXZWJzaXRlRGF0YVN0b3JlOjpuZXR3b3JrUHJvY2Vzc0NyYXNoZWQoKSB3b3VsZCBn ZXQgY2FsbGVkIGFuZAorICAgICAgICBwcm9wZXJseSBjbGVhciBXZWJzaXRlRGF0YVN0b3JlOjpt X25ldHdvcmtQcm9jZXNzLiBIb3dldmVyLCB3aGVuIGNhbGxpbmcKKyAgICAgICAgV2Vic2l0ZURh dGFTdG9yZTo6bmV0d29ya1Byb2Nlc3MoKSBsYXRlciBvbiwgaXQgd291bGQgcmUtaW5pdGlhbGl6 ZSBtX25ldHdvcmtQcm9jZXNzIHdpdGgKKyAgICAgICAgdGhlIHNhbWUgZGVhZCBOZXR3b3JrUHJv Y2Vzc1Byb3h5LCBzaW5jZSBuZXR3b3JrUHJvY2Vzc0ZvclNlc3Npb24oKSByZWxpZXMgb24KKyAg ICAgICAgTmV0d29ya1Byb2Nlc3NQcm94eTo6ZGVmYXVsdE5ldHdvcmtQcm9jZXNzKCkuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCB3aWxsIGxhbmQgYW4gQVBJIHRlc3Qgc2hvcnRseSBhcyBhIGZv bGxvdy11cC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJv eHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzc1Byb3h5OjpuZXR3b3JrUHJv Y2Vzc0NyYXNoZWQpOgorCiAyMDIxLTAzLTMxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5j b20+CiAKICAgICAgICAgT25jZSBzYXZlZCB0byBkaXNrLCB0aGVuIG1tYXAnZCBkYXRhIG9mIHNl cnZpY2Ugd29ya2VyIHNjcmlwdHMgYmFjayB0byB0aGUgU2VydmljZVdvcmtlciBwcm9jZXNzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNz UHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vz c1Byb3h5LmNwcAppbmRleCBiZTExOTUwNjU4YmJhMTczZTYxMjY1NzgwMjZhMDQ2NjJmM2MyYWZh Li42OTJmNzMyNGM1ZjZiZDg5MWYwYTNjYWZmNTM4YzQ0Mzg2NzY5NGVjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJveHkuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94eS5j cHAKQEAgLTM0OCw2ICszNDgsOSBAQCB2b2lkIE5ldHdvcmtQcm9jZXNzUHJveHk6OnJlbmFtZU9y aWdpbkluV2Vic2l0ZURhdGEoUEFMOjpTZXNzaW9uSUQgc2Vzc2lvbklELCBjbwogCiB2b2lkIE5l dHdvcmtQcm9jZXNzUHJveHk6Om5ldHdvcmtQcm9jZXNzQ3Jhc2hlZCgpCiB7CisgICAgaWYgKGRl ZmF1bHRQcm9jZXNzKCkgPT0gdGhpcykKKyAgICAgICAgZGVmYXVsdFByb2Nlc3MoKSA9IG51bGxw dHI7CisKICAgICBjbGVhckNhbGxiYWNrU3RhdGVzKCk7CiAKICAgICBSZWY8TmV0d29ya1Byb2Nl c3NQcm94eT4gcHJvdGVjdGVkVGhpcygqdGhpcyk7Cg==