224010 2021-03-31 12:27:01 -0700 Web Inspector: Autocomplete experimental CSS Color values (hwb, lch, lab, color-mix, color-contrast) 2021-03-31 15:32:00 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev bburg ews-watchlist hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1745723 0 nvasilyev 2021-03-31 12:27:01 -0700 Web Inspector should show completions for these when the corresponding experimental settings are enabled. 1745724 1 webkit-bug-importer 2021-03-31 12:27:11 -0700 <rdar://problem/76065217> 1745729 2 424801 nvasilyev 2021-03-31 12:30:35 -0700 Created attachment 424801 Patch 1745737 3 424801 joepeck 2021-03-31 12:44:37 -0700 Comment on attachment 424801 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424801&action=review > Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:166 > +WI.CSSKeywordCompletions.getExperimentalProperties = function(properties) { Style: Put the `{` on the next line? > Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:169 > + if (CSS.supports(test)) The `CSS.supports` is neat, but why not do it all time? You could be on a macOS system that doesn't support the syntax and inspecting an iOS target that does support it. In that case we'd probably still want completion to work. So might as well do it all the time. 1745742 4 424808 nvasilyev 2021-03-31 12:55:17 -0700 Created attachment 424808 Patch 1745805 5 424808 bburg 2021-03-31 15:10:00 -0700 Comment on attachment 424808 Patch r=me 1745822 6 ews-feeder 2021-03-31 15:31:58 -0700 Committed r275310: <https://commits.webkit.org/r275310> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424808. 424801 2021-03-31 12:30:35 -0700 2021-03-31 12:55:17 -0700 Patch patch.txt text/plain 3747 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZkNTQyZGIwYTI2MS4uZjc1ZWFkYjk0ZTRkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAyMS0wMy0zMSAgTmlr aXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBBdXRvY29tcGxldGUgZXhwZXJpbWVudGFsIENTUyBDb2xvciB2YWx1ZXMgKGh3YiwgbGNo LCBsYWIsIGNvbG9yLW1peCwgY29sb3ItY29udHJhc3QpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQwMTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt Lzc2MDY1MjE3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzOgorICAg ICAgICAoYWRkS2V5d29yZHNGb3JOYW1lKToKKyAgICAgICAgKFdJLkNTU0tleXdvcmRDb21wbGV0 aW9ucy5mb3JQcm9wZXJ0eSk6CisgICAgICAgIChXSS5DU1NLZXl3b3JkQ29tcGxldGlvbnMuZm9y RnVuY3Rpb24pOgorICAgICAgICAoV0kuQ1NTS2V5d29yZENvbXBsZXRpb25zLmdldEV4cGVyaW1l bnRhbFByb3BlcnRpZXMpOgorCiAyMDIxLTAzLTE3ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiB1c2UgbmF0aXZlIGRhdGV0aW1lLWxv Y2FsIHBpY2tlciBmb3IgY2hhbmdpbmcgYGV4cGlyZXNgIHZhbHVlIGluIGNvb2tpZSBwb3BvdmVy CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMv Q1NTS2V5d29yZENvbXBsZXRpb25zLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcwppbmRleCA0OGJjNGJmOGIyMGMu LjMzNmFmZDI0NmIzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzCkBA IC00Myw4ICs0MywxMCBAQCBXSS5DU1NLZXl3b3JkQ29tcGxldGlvbnMuZm9yUHJvcGVydHkgPSBm dW5jdGlvbihwcm9wZXJ0eU5hbWUpCiAgICAgICAgIGVsc2UgaWYgKGlzTm90UHJlZml4ZWQgJiYg KCItd2Via2l0LSIgKyBuYW1lKSBpbiBXSS5DU1NLZXl3b3JkQ29tcGxldGlvbnMuX3Byb3BlcnR5 S2V5d29yZE1hcCkKICAgICAgICAgICAgIGFjY2VwdGVkS2V5d29yZHMucHVzaEFsbChXSS5DU1NL ZXl3b3JkQ29tcGxldGlvbnMuX3Byb3BlcnR5S2V5d29yZE1hcFsiLXdlYmtpdC0iICsgbmFtZV0p OwogCi0gICAgICAgIGlmIChXSS5DU1NLZXl3b3JkQ29tcGxldGlvbnMuaXNDb2xvckF3YXJlUHJv cGVydHkobmFtZSkpCisgICAgICAgIGlmIChXSS5DU1NLZXl3b3JkQ29tcGxldGlvbnMuaXNDb2xv ckF3YXJlUHJvcGVydHkobmFtZSkpIHsKICAgICAgICAgICAgIGFjY2VwdGVkS2V5d29yZHMucHVz aEFsbChXSS5DU1NLZXl3b3JkQ29tcGxldGlvbnMuX2NvbG9ycyk7CisgICAgICAgICAgICBhY2Nl cHRlZEtleXdvcmRzLnB1c2hBbGwoV0kuQ1NTS2V5d29yZENvbXBsZXRpb25zLmdldEV4cGVyaW1l bnRhbFByb3BlcnRpZXMoV0kuQ1NTS2V5d29yZENvbXBsZXRpb25zLl9leHBlcmltZW50YWxDb2xv cnMpKTsKKyAgICAgICAgfQogCiAgICAgICAgIC8vIE9ubHkgc3VnZ2VzdCAiaW5oZXJpdCIgb24g aW5oZXJpdGFibGUgcHJvcGVydGllcyBldmVuIHRob3VnaCBpdCBpcyB2YWxpZCBvbiBhbGwgcHJv cGVydGllcy4KICAgICAgICAgaWYgKFdJLkNTU0tleXdvcmRDb21wbGV0aW9ucy5Jbmhlcml0ZWRQ cm9wZXJ0aWVzLmhhcyhuYW1lKSkKQEAgLTExOSw2ICsxMjEsNyBAQCBXSS5DU1NLZXl3b3JkQ29t cGxldGlvbnMuZm9yRnVuY3Rpb24gPSBmdW5jdGlvbihmdW5jdGlvbk5hbWUpCiAgICAgZWxzZSBp ZiAoZnVuY3Rpb25OYW1lLmVuZHNXaXRoKCJncmFkaWVudCIpKSB7CiAgICAgICAgIHN1Z2dlc3Rp b25zLnB1c2goInRvIiwgImxlZnQiLCAicmlnaHQiLCAidG9wIiwgImJvdHRvbSIpOwogICAgICAg ICBzdWdnZXN0aW9ucy5wdXNoQWxsKFdJLkNTU0tleXdvcmRDb21wbGV0aW9ucy5fY29sb3JzKTsK KyAgICAgICAgc3VnZ2VzdGlvbnMucHVzaEFsbChXSS5DU1NLZXl3b3JkQ29tcGxldGlvbnMuZ2V0 RXhwZXJpbWVudGFsUHJvcGVydGllcyhXSS5DU1NLZXl3b3JkQ29tcGxldGlvbnMuX2V4cGVyaW1l bnRhbENvbG9ycykpOwogICAgIH0KIAogICAgIHJldHVybiBuZXcgV0kuQ1NTQ29tcGxldGlvbnMo c3VnZ2VzdGlvbnMsIHRydWUpOwpAQCAtMTYwLDYgKzE2MywxNSBAQCBXSS5DU1NLZXl3b3JkQ29t cGxldGlvbnMuYWRkUHJvcGVydHlDb21wbGV0aW9uVmFsdWVzID0gZnVuY3Rpb24ocHJvcGVydHlO YW1lLCBuZQogICAgIFdJLkNTU0tleXdvcmRDb21wbGV0aW9ucy5fcHJvcGVydHlLZXl3b3JkTWFw W3Byb3BlcnR5TmFtZV0gPSBbLi4udW5pb24udmFsdWVzKCldOwogfTsKIAorV0kuQ1NTS2V5d29y ZENvbXBsZXRpb25zLmdldEV4cGVyaW1lbnRhbFByb3BlcnRpZXMgPSBmdW5jdGlvbihwcm9wZXJ0 aWVzKSB7CisgICAgbGV0IHN1cHBvcnRlZCA9IFtdOworICAgIGZvciAobGV0IHt2YWx1ZSwgdGVz dH0gb2YgcHJvcGVydGllcykgeworICAgICAgICBpZiAoQ1NTLnN1cHBvcnRzKHRlc3QpKQorICAg ICAgICAgICAgc3VwcG9ydGVkLnB1c2godmFsdWUpOworICAgIH0KKyAgICByZXR1cm4gc3VwcG9y dGVkOworfTsKKwogV0kuQ1NTS2V5d29yZENvbXBsZXRpb25zLkFsbFByb3BlcnR5TmFtZXNQbGFj ZWhvbGRlciA9ICJfX2FsbC1wcm9wZXJ0aWVzX18iOwogCiAvLyBQb3B1bGF0ZWQgYnkgQ1NTLmdl dFN1cHBvcnRlZENTU1Byb3BlcnRpZXMuCkBAIC0zMTYsNiArMzI4LDE0IEBAIFdJLkNTU0tleXdv cmRDb21wbGV0aW9ucy5fY29sb3JzID0gWwogICAgICJ3aGVhdCIsICJ3aGl0ZXNtb2tlIiwgInll bGxvd2dyZWVuIiwgInJnYigpIiwgInJnYmEoKSIsICJoc2woKSIsICJoc2xhKCkiLCAiY29sb3Io KSIsCiBdOwogCitXSS5DU1NLZXl3b3JkQ29tcGxldGlvbnMuX2V4cGVyaW1lbnRhbENvbG9ycyA9 IFsKKyAgICB7dmFsdWU6ICJod2IoKSIsIHRlc3Q6IGBjb2xvcjogaHdiKDM2MCAxMDAlIDEwMCUp YH0sCisgICAge3ZhbHVlOiAibGNoKCkiLCB0ZXN0OiBgY29sb3I6IGxjaCgxMDAlIDIzMCAzNjAp YH0sCisgICAge3ZhbHVlOiAibGFiKCkiLCB0ZXN0OiBgY29sb3I6IGxhYigxMDAlIDUwIC01MClg fSwKKyAgICB7dmFsdWU6ICJjb2xvci1taXgoKSIsIHRlc3Q6IGBjb2xvcjogY29sb3ItbWl4KHJl ZCA1MCUsIHdoaXRlKWB9LAorICAgIHt2YWx1ZTogImNvbG9yLWNvbnRyYXN0KCkiLCB0ZXN0OiBg Y29sb3I6IGNvbG9yLWNvbnRyYXN0KHdoaXRlIHZzIHJlZCwgYmxhY2spYH0sCitdOworCiBXSS5D U1NLZXl3b3JkQ29tcGxldGlvbnMuX2NvbG9yQXdhcmVQcm9wZXJ0aWVzID0gbmV3IFNldChbCiAg ICAgImJhY2tncm91bmQiLAogICAgICJiYWNrZ3JvdW5kLWNvbG9yIiwK 424808 2021-03-31 12:55:17 -0700 2021-03-31 15:31:59 -0700 Patch patch.txt text/plain 1801 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZkNTQyZGIwYTI2MS4uNjhhOTkxY2M4Zjc3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMS0wMy0zMSAgTmlr aXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBBdXRvY29tcGxldGUgZXhwZXJpbWVudGFsIENTUyBDb2xvciB2YWx1ZXMgKGh3YiwgbGNo LCBsYWIsIGNvbG9yLW1peCwgY29sb3ItY29udHJhc3QpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQwMTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt Lzc2MDY1MjE3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzOgorCiAy MDIxLTAzLTE3ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiB1c2UgbmF0aXZlIGRhdGV0aW1lLWxvY2FsIHBpY2tlciBmb3IgY2hhbmdp bmcgYGV4cGlyZXNgIHZhbHVlIGluIGNvb2tpZSBwb3BvdmVyCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25z LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdv cmRDb21wbGV0aW9ucy5qcwppbmRleCA0OGJjNGJmOGIyMGMuLmIyNzcxMDU4ZTFkYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdv cmRDb21wbGV0aW9ucy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzCkBAIC0zMTMsNyArMzEzLDggQEAgV0ku Q1NTS2V5d29yZENvbXBsZXRpb25zLl9jb2xvcnMgPSBbCiAgICAgInBhbGV0dXJxdW9pc2UiLCAi cGFsZXZpb2xldHJlZCIsICJwYXBheWF3aGlwIiwgInBlYWNocHVmZiIsICJwZXJ1IiwgInBpbmsi LCAicGx1bSIsICJwb3dkZXJibHVlIiwgInJlYmVjY2FwdXJwbGUiLCAicm9zeWJyb3duIiwKICAg ICAicm95YWxibHVlIiwgInNhZGRsZWJyb3duIiwgInNhbG1vbiIsICJzYW5keWJyb3duIiwgInNl YWdyZWVuIiwgInNlYXNoZWxsIiwgInNpZW5uYSIsICJza3libHVlIiwgInNsYXRlYmx1ZSIsCiAg ICAgInNsYXRlZ3JheSIsICJzbGF0ZWdyZXkiLCAic25vdyIsICJzcHJpbmdncmVlbiIsICJzdGVl bGJsdWUiLCAidGFuIiwgInRoaXN0bGUiLCAidG9tYXRvIiwgInR1cnF1b2lzZSIsICJ2aW9sZXQi LAotICAgICJ3aGVhdCIsICJ3aGl0ZXNtb2tlIiwgInllbGxvd2dyZWVuIiwgInJnYigpIiwgInJn YmEoKSIsICJoc2woKSIsICJoc2xhKCkiLCAiY29sb3IoKSIsCisgICAgIndoZWF0IiwgIndoaXRl c21va2UiLCAieWVsbG93Z3JlZW4iLCAicmdiKCkiLCAicmdiYSgpIiwgImhzbCgpIiwgImhzbGEo KSIsICJjb2xvcigpIiwgImh3YigpIiwgImxjaCgpIiwgImxhYigpIiwKKyAgICAiY29sb3ItbWl4 KCkiLCAiY29sb3ItY29udHJhc3QoKSIsCiBdOwogCiBXSS5DU1NLZXl3b3JkQ29tcGxldGlvbnMu X2NvbG9yQXdhcmVQcm9wZXJ0aWVzID0gbmV3IFNldChbCg==