224009 2021-03-31 12:23:22 -0700 REGRESSION (r275150): set-webkit-configuration is too aggressive at deleting config files when switch is not set 2021-04-08 15:26:08 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224343 InRadar P2 Normal --- 176131 1 ddkilzer ddkilzer mark.lam webkit-bug-importer oldest_to_newest 1745721 0 ddkilzer 2021-03-31 12:23:22 -0700 The set-webkit-configuration is too aggressive at deleting config files when switch is not set. This regressed in r275150 for Bug 176131. 1745725 1 424799 ddkilzer 2021-03-31 12:28:08 -0700 Created attachment 424799 Patch v1 1745734 2 424799 ddkilzer 2021-03-31 12:42:52 -0700 Comment on attachment 424799 Patch v1 Marking cq+ because enough builds have succeeded that I don't think I made the situation any worse, and I want to get this landed sooner rather than later. (I also compared this patch to set-webkit-configuration from r275150 and the subroutines I restored were unchanged as expected.) 1745756 3 ews-feeder 2021-03-31 13:36:16 -0700 Committed r275305: <https://commits.webkit.org/r275305> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424799. 1745757 4 webkit-bug-importer 2021-03-31 13:37:13 -0700 <rdar://problem/76068475> 424799 2021-03-31 12:28:08 -0700 2021-03-31 14:55:58 -0700 Patch v1 bug-224009-20210331122808.patch text/plain 2784 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MTM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjQ5ZTFmOTIyOGYxZDZhZjI5ZDIyOWI2OGY5NzM0ZGU0 ZjAxZGMxMi4uZmMxYzkyOGU0Mjk3YTBkN2U0MjRlNDAwM2JmNGRkMjhlNDFiZjI3MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIxLTAzLTMxICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgUkVHUkVTU0lPTiAocjI3NTE1MCk6IHNldC13ZWJraXQtY29uZmlndXJhdGlvbiBpcyB0 b28gYWdncmVzc2l2ZSBhdCBkZWxldGluZyBjb25maWcgZmlsZXMgd2hlbiBzd2l0Y2ggaXMgbm90 IHNldAorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjI0MDA5PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9zZXQtd2Via2l0 LWNvbmZpZ3VyYXRpb246CisgICAgICAgIC0gUGFydGlhbGx5IHJldmVydCBjaGFuZ2VzIGluIHIy NzUxNTAgd2hlbiB0aGUgY29uZmlnIGZpbGUKKyAgICAgICAgICB3YXNuJ3QgYWx3YXlzIGRlbGV0 ZWQgZm9yICRhcmNoaXRlY3R1cmUsICRjb25maWd1cmF0aW9uLAorICAgICAgICAgICRmb3JjZU9w dGltaXphdGlvbkxldmVsIGFuZCAkbHRvTW9kZS4KKwogMjAyMS0wMy0yOCAgRGF2aWQgS2lsemVy ICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIENvbXBpbGUgV2ViS2l0IHdpdGggVUJT YW4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvc2V0LXdlYmtpdC1jb25maWd1cmF0aW9uIGIv VG9vbHMvU2NyaXB0cy9zZXQtd2Via2l0LWNvbmZpZ3VyYXRpb24KaW5kZXggMjM0ZmJmMWIzNzIy NWIzNGM1OWQ4M2NlMDdhYmNkNjQ3ZTY3Y2M3NC4uOTI2NjQ0MjdkMmI5NWYxNGU1NDAwYmIxZDg0 YTQ5MzliYjk5NDBhZiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9zZXQtd2Via2l0LWNvbmZp Z3VyYXRpb24KKysrIGIvVG9vbHMvU2NyaXB0cy9zZXQtd2Via2l0LWNvbmZpZ3VyYXRpb24KQEAg LTEzNywxMSArMTM3LDM3IEBAIHN1YiB1cGRhdGVPckRlbGV0ZUNvbmZpZ3VyYXRpb25GaWxlKCQk KQogICAgIH0KIH0KIAotdXBkYXRlT3JEZWxldGVDb25maWd1cmF0aW9uRmlsZSgiQ29uZmlndXJh dGlvbiIsICRjb25maWd1cmF0aW9uKTsKLXVwZGF0ZU9yRGVsZXRlQ29uZmlndXJhdGlvbkZpbGUo IkFyY2hpdGVjdHVyZSIsICRhcmNoaXRlY3R1cmUgJiYgJGFyY2hpdGVjdHVyZSBuZSAieDg2XzY0 IiA/ICRhcmNoaXRlY3R1cmUgOiB1bmRlZik7CitpZiAoJGNvbmZpZ3VyYXRpb24pIHsKKyAgICBv cGVuIENPTkZJR1VSQVRJT04sICI+IiwgIiRiYXNlUHJvZHVjdERpci9Db25maWd1cmF0aW9uIiBv ciBkaWU7CisgICAgcHJpbnQgQ09ORklHVVJBVElPTiAkY29uZmlndXJhdGlvbjsKKyAgICBjbG9z ZSBDT05GSUdVUkFUSU9OOworfQorCitpZiAoJGFyY2hpdGVjdHVyZSkgeworICAgIGlmICgkYXJj aGl0ZWN0dXJlIG5lICJ4ODZfNjQiKSB7CisgICAgICAgIG9wZW4gQVJDSElURUNUVVJFLCAiPiIs ICIkYmFzZVByb2R1Y3REaXIvQXJjaGl0ZWN0dXJlIiBvciBkaWU7CisgICAgICAgIHByaW50IEFS Q0hJVEVDVFVSRSAkYXJjaGl0ZWN0dXJlOworICAgICAgICBjbG9zZSBBUkNISVRFQ1RVUkU7Cisg ICAgfSBlbHNlIHsKKyAgICAgICAgdW5saW5rICIkYmFzZVByb2R1Y3REaXIvQXJjaGl0ZWN0dXJl IjsKKyAgICB9Cit9CisKIHVwZGF0ZU9yRGVsZXRlQ29uZmlndXJhdGlvbkZpbGUoIkFTYW4iLCAk ZW5hYmxlQVNBTiA/ICJZRVMiIDogdW5kZWYpOwogdXBkYXRlT3JEZWxldGVDb25maWd1cmF0aW9u RmlsZSgiQ292ZXJhZ2UiLCAkZW5hYmxlQ292ZXJhZ2UgPyAiWUVTIiA6IHVuZGVmKTsKIHVwZGF0 ZU9yRGVsZXRlQ29uZmlndXJhdGlvbkZpbGUoIlRTYW4iLCAkZW5hYmxlVFNBTiA/ICJZRVMiIDog dW5kZWYpOwogdXBkYXRlT3JEZWxldGVDb25maWd1cmF0aW9uRmlsZSgiVUJTYW4iLCAkZW5hYmxl VUJTQU4gPyAiWUVTIiA6IHVuZGVmKTsKLXVwZGF0ZU9yRGVsZXRlQ29uZmlndXJhdGlvbkZpbGUo IkZvcmNlT3B0aW1pemF0aW9uTGV2ZWwiLCAoISRmb3JjZU9wdGltaXphdGlvbkxldmVsIHx8ICRm b3JjZU9wdGltaXphdGlvbkxldmVsIGVxICJub25lIikgPyB1bmRlZiA6IHN1YnN0cigkZm9yY2VP cHRpbWl6YXRpb25MZXZlbCwgMSkgLiAiXG4iKTsKLXVwZGF0ZU9yRGVsZXRlQ29uZmlndXJhdGlv bkZpbGUoIkxUTyIsICRsdG9Nb2RlKTsKKworaWYgKCRmb3JjZU9wdGltaXphdGlvbkxldmVsICYm ICRmb3JjZU9wdGltaXphdGlvbkxldmVsIGVxICJub25lIikgeworICAgIHVubGluayAiJGJhc2VQ cm9kdWN0RGlyL0ZvcmNlT3B0aW1pemF0aW9uTGV2ZWwiOworfSBlbHNpZiAoJGZvcmNlT3B0aW1p emF0aW9uTGV2ZWwpIHsKKyAgICBvcGVuIEZvcmNlT3B0aW1pemF0aW9uTGV2ZWwsICI+IiwgIiRi YXNlUHJvZHVjdERpci9Gb3JjZU9wdGltaXphdGlvbkxldmVsIiBvciBkaWU7CisgICAgcHJpbnQg Rm9yY2VPcHRpbWl6YXRpb25MZXZlbCBzdWJzdHIoJGZvcmNlT3B0aW1pemF0aW9uTGV2ZWwsIDEp IC4gIlxuIjsKKyAgICBjbG9zZSBGb3JjZU9wdGltaXphdGlvbkxldmVsOworfQorCitpZiAoJGx0 b01vZGUpIHsKKyAgICBvcGVuIExUTywgIj4iLCAiJGJhc2VQcm9kdWN0RGlyL0xUTyIgb3IgZGll OworICAgIHByaW50IExUTyAiJGx0b01vZGUiOworICAgIGNsb3NlIExUTzsKK30K