224007 2021-03-31 11:27:31 -0700 Missing exception check in HashMapImpl::add(). 2021-03-31 11:46:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1745700 0 mark.lam 2021-03-31 11:27:31 -0700 rdar://76053163 1745708 1 424793 mark.lam 2021-03-31 11:35:01 -0700 Created attachment 424793 proposed patch. 1745712 2 mark.lam 2021-03-31 11:46:18 -0700 Thanks for the review. Landed in r275299: <http://trac.webkit.org/r275299>. 424793 2021-03-31 11:35:01 -0700 2021-03-31 11:38:14 -0700 proposed patch. bug-224007.patch text/plain 2429 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzUyOTUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDIxLTAzLTMxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBNaXNzaW5nIGV4Y2VwdGlvbiBjaGVjayBpbiBIYXNoTWFwSW1wbDo6YWRk KCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQw MDcKKyAgICAgICAgcmRhcjovLzc2MDUzMTYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvbWlzc2luZy1leGNlcHRpb24tY2hlY2staW4t SGFzaE1hcEltcGwtYWRkLmpzOiBBZGRlZC4KKwogMjAyMS0wMy0zMSAgQWxleGV5IFNodmF5a2Eg IDxzaHZhaWthbGVzaEBnbWFpbC5jb20+CiAKICAgICAgICAgT3B0aW1pemUgY29uc3RydWN0b3Jz IG9mIEVTNiBjb2xsZWN0aW9ucwpJbmRleDogSlNUZXN0cy9zdHJlc3MvbWlzc2luZy1leGNlcHRp b24tY2hlY2staW4tSGFzaE1hcEltcGwtYWRkLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3Ry ZXNzL21pc3NpbmctZXhjZXB0aW9uLWNoZWNrLWluLUhhc2hNYXBJbXBsLWFkZC5qcwkobm9uZXhp c3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9taXNzaW5nLWV4Y2VwdGlvbi1jaGVjay1pbi1IYXNo TWFwSW1wbC1hZGQuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSBAQAorbmV3IE1hcChbe30s IFswXV0pOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzUyOTMpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMjEtMDMtMzEgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisg ICAgICAgIE1pc3NpbmcgZXhjZXB0aW9uIGNoZWNrIGluIEhhc2hNYXBJbXBsOjphZGQoKS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDAwNworICAg ICAgICByZGFyOi8vNzYwNTMxNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHJ1bnRpbWUvSGFzaE1hcEltcGwuaDoKKyAgICAgICAgKEpTQzo6SGFz aE1hcEltcGw6OmFkZCk6CisKIDIwMjEtMDMtMzEgIFhhbiBMb3BleiAgPHhhbkBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtKU0NdIFJlbW92ZSB3YXJuaW5ncyBhYm91dCB1bm5lY2Vzc2FyeSBvcGVy YXRvcj0gZm9yIEFSTXY3QXNzZW1ibGVyIExpbmtSZWNvcmQKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0hhc2hNYXBJbXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSGFzaE1hcEltcGwuaAkocmV2aXNpb24gMjc1MjkzKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSGFzaE1hcEltcGwuaAkod29ya2luZyBjb3B5KQpA QCAtNDgxLDEwICs0ODEsMTUgQEAgcHVibGljOgogCiAgICAgQUxXQVlTX0lOTElORSB2b2lkIGFk ZChKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBKU1ZhbHVlIGtleSwgSlNWYWx1ZSB2YWx1 ZSA9IEpTVmFsdWUoKSkKICAgICB7CisgICAgICAgIFZNJiB2bSA9IGdldFZNKGdsb2JhbE9iamVj dCk7CisgICAgICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX1RIUk9XX1NDT1BFKHZtKTsKKwogICAg ICAgICBrZXkgPSBub3JtYWxpemVNYXBLZXkoa2V5KTsKICAgICAgICAgYWRkTm9ybWFsaXplZElu dGVybmFsKGdsb2JhbE9iamVjdCwga2V5LCB2YWx1ZSwgWyZdIChIYXNoTWFwQnVja2V0VHlwZSog YnVja2V0KSB7CiAgICAgICAgICAgICByZXR1cm4gIWlzRGVsZXRlZChidWNrZXQpICYmIGFyZUtl eXNFcXVhbChnbG9iYWxPYmplY3QsIGtleSwgYnVja2V0LT5rZXkoKSk7CiAgICAgICAgIH0pOwor ICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCB2b2lkKCkpOworICAgICAgICBzY29w ZS5yZWxlYXNlKCk7CiAgICAgICAgIGlmIChzaG91bGRSZWhhc2hBZnRlckFkZCgpKQogICAgICAg ICAgICAgcmVoYXNoKGdsb2JhbE9iamVjdCk7CiAgICAgfQo=