224004 2021-03-31 09:59:11 -0700 Use MACH_PORT_VALID() when wanting to check if a mach port is valid 2021-03-31 17:40:19 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=223982 InRadar P2 Normal --- 1 cdumez cdumez bfulgham darin ggaren kkinnunen webkit-bug-importer oldest_to_newest 1745667 0 cdumez 2021-03-31 09:59:11 -0700 Use MACH_PORT_VALID() when wanting to check if a mach port is valid, instead of checking for MACH_PORT_NULL. MACH_PORT_VALID() is the correct way to check for validity since it also checks for the MACH_PORT_DEAD value. 1745668 1 424783 cdumez 2021-03-31 10:01:17 -0700 Created attachment 424783 Patch 1745872 2 ews-feeder 2021-03-31 17:39:52 -0700 Committed r275327: <https://commits.webkit.org/r275327> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424783. 1745873 3 webkit-bug-importer 2021-03-31 17:40:19 -0700 <rdar://problem/76080057> 424783 2021-03-31 10:01:17 -0700 2021-03-31 17:39:53 -0700 Patch bug-224004-20210331100116.patch text/plain 7109 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1Mjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTE4NmM3ZWNiODQ2NGYw MzEzYTYwNTY4ZTZjMTU0YzU0MmIwMTFjOS4uMWNkMDkwYjE4NmEzMjhmYjM5NjRmMTYzZDljOTIz YjkzZmFlYTlmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAzLTMxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIE1BQ0hfUE9SVF9WQUxJ RCgpIHdoZW4gd2FudGluZyB0byBjaGVjayBpZiBhIG1hY2ggcG9ydCBpcyB2YWxpZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0MDA0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIE1BQ0hfUE9SVF9W QUxJRCgpIHdoZW4gd2FudGluZyB0byBjaGVjayBpZiBhIG1hY2ggcG9ydCBpcyB2YWxpZCwgaW5z dGVhZCBvZiBjaGVja2luZyBmb3IKKyAgICAgICAgTUFDSF9QT1JUX05VTEwuIE1BQ0hfUE9SVF9W QUxJRCgpIGlzIHRoZSBjb3JyZWN0IHdheSB0byBjaGVjayBmb3IgdmFsaWRpdHkgc2luY2UgaXQg YWxzbyBjaGVja3MKKyAgICAgICAgZm9yIHRoZSBNQUNIX1BPUlRfREVBRCB2YWx1ZS4KKworICAg ICAgICAqIHBhZ2UvY29jb2EvUmVzb3VyY2VVc2FnZVRocmVhZENvY29hLm1tOgorICAgICAgICAo V2ViQ29yZTo6UmVzb3VyY2VVc2FnZVRocmVhZDo6cGxhdGZvcm1Db2xsZWN0Q1BVRGF0YSk6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzQ2hlY2tzTWFjLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OmF0dGFjaFRvQXBwbGVHcmFwaGljc0NvbnRyb2wpOgorICAgICAgICAo V2ViQ29yZTo6aGFzTXV4Q2FwYWJpbGl0eSk6CisKIDIwMjEtMDMtMzEgIENocmlzIER1bWV6ICA8 Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTZXJ2aWNlV29ya2VyQ29udGV4dERhdGEgc2hv dWxkIG5vdCBiZSBzYXZlZCBib3RoIG9uIFNlcnZpY2VXb3JrZXJUaHJlYWQgJiBTZXJ2aWNlV29y a2VyR2xvYmFsU2NvcGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwppbmRleCBkMWEwMjI2MjY5 YzJlNzZjMWMzYzQ4YTEzMjgyYmE0NWVkNGNjNTZkLi4yODRiZGNjMTU3Mzc1YTljMDRhZWQwNDBh YzZkOWJhM2FlZGU5N2VmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTkgQEAKKzIwMjEtMDMtMzEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAg ICAgICBVc2UgTUFDSF9QT1JUX1ZBTElEKCkgd2hlbiB3YW50aW5nIHRvIGNoZWNrIGlmIGEgbWFj aCBwb3J0IGlzIHZhbGlkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjQwMDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBVc2UgTUFDSF9QT1JUX1ZBTElEKCkgd2hlbiB3YW50aW5nIHRvIGNoZWNrIGlmIGEg bWFjaCBwb3J0IGlzIHZhbGlkLCBpbnN0ZWFkIG9mIGNoZWNraW5nIGZvcgorICAgICAgICBNQUNI X1BPUlRfTlVMTC4gTUFDSF9QT1JUX1ZBTElEKCkgaXMgdGhlIGNvcnJlY3Qgd2F5IHRvIGNoZWNr IGZvciB2YWxpZGl0eSBzaW5jZSBpdCBhbHNvIGNoZWNrcworICAgICAgICBmb3IgdGhlIE1BQ0hf UE9SVF9ERUFEIHZhbHVlLgorCisgICAgICAgICogUGx1Z2lucy9Ib3N0ZWQvTmV0c2NhcGVQbHVn aW5Ib3N0TWFuYWdlci5tbToKKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW5Ib3N0TWFu YWdlcjo6c3Bhd25QbHVnaW5Ib3N0KToKKyAgICAgICAgKiBQbHVnaW5zL0hvc3RlZC9OZXRzY2Fw ZVBsdWdpbkhvc3RQcm94eS5tbToKKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW5Ib3N0 UHJveHk6OnByb2Nlc3NSZXF1ZXN0cyk6CisKIDIwMjEtMDMtMjggIFNhbSBXZWluaWcgIDx3ZWlu aWdAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBFTkFCTEVfSU5ERVhFRF9EQVRBQkFTRSAm IEVOQUJMRV9JTkRFWEVEX0RBVEFCQVNFX0lOX1dPUktFUlMsIGl0IHNlZW1zIGxpa2UgaXQgaXMg b24gZm9yIGFsbCBwb3J0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9jb2NvYS9S ZXNvdXJjZVVzYWdlVGhyZWFkQ29jb2EubW0gYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL2NvY29hL1Jl c291cmNlVXNhZ2VUaHJlYWRDb2NvYS5tbQppbmRleCA0MGZlYTQwODBkZjRjNzIyMmUxODQ5YTJh ZTFhNDA5NTBlZGE5OGZhLi45OTM1YWRjM2QzYjAxYzMwZTlmZDZjODViNTJhNmZiYTFjZGE0Mzcz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2NvY29hL1Jlc291cmNlVXNhZ2VUaHJl YWRDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL2NvY29hL1Jlc291cmNlVXNhZ2VU aHJlYWRDb2NvYS5tbQpAQCAtMTY0LDcgKzE2NCw3IEBAIHZvaWQgUmVzb3VyY2VVc2FnZVRocmVh ZDo6cGxhdGZvcm1Db2xsZWN0Q1BVRGF0YShKU0M6OlZNKiwgUmVzb3VyY2VVc2FnZURhdGEmIGRh CiAgICAgICAgIGF1dG8gbG9ja2VyID0gaG9sZExvY2soVGhyZWFkOjphbGxUaHJlYWRzTXV0ZXgo KSk7CiAgICAgICAgIGZvciAoYXV0byogdGhyZWFkIDogVGhyZWFkOjphbGxUaHJlYWRzKGxvY2tl cikpIHsKICAgICAgICAgICAgIG1hY2hfcG9ydF90IG1hY2hUaHJlYWQgPSB0aHJlYWQtPm1hY2hU aHJlYWQoKTsKLSAgICAgICAgICAgIGlmIChtYWNoVGhyZWFkICE9IE1BQ0hfUE9SVF9OVUxMKQor ICAgICAgICAgICAgaWYgKE1BQ0hfUE9SVF9WQUxJRChtYWNoVGhyZWFkKSkKICAgICAgICAgICAg ICAgICBrbm93bldlYktpdFRocmVhZHMuYWRkKG1hY2hUaHJlYWQpOwogICAgICAgICB9CiAgICAg fQpAQCAtMTc3LDcgKzE3Nyw3IEBAIHZvaWQgUmVzb3VyY2VVc2FnZVRocmVhZDo6cGxhdGZvcm1D b2xsZWN0Q1BVRGF0YShKU0M6OlZNKiwgUmVzb3VyY2VVc2FnZURhdGEmIGRhCiAgICAgICAgICAg ICBpZiAoIXRocmVhZC0+dGhyZWFkKCkpCiAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAg ICAgICAgICBtYWNoX3BvcnRfdCBtYWNoVGhyZWFkID0gdGhyZWFkLT50aHJlYWQoKS0+bWFjaFRo cmVhZCgpOwotICAgICAgICAgICAgaWYgKG1hY2hUaHJlYWQgIT0gTUFDSF9QT1JUX05VTEwpCisg ICAgICAgICAgICBpZiAoTUFDSF9QT1JUX1ZBTElEKG1hY2hUaHJlYWQpKQogICAgICAgICAgICAg ICAgIGtub3duV29ya2VyVGhyZWFkcy5zZXQobWFjaFRocmVhZCwgdGhyZWFkLT5pZGVudGlmaWVy KCkuaXNvbGF0ZWRDb3B5KCkpOwogICAgICAgICB9CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzQ2hlY2tzTWFjLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9HcmFwaGljc0NoZWNrc01hYy5jcHAK aW5kZXggNmU5OTkwYTg1NTY3MGZlOWNiOWFhODNjYTFmYzA5OGUyMTNjNDVjNS4uMDljNjM2Yzc5 OGRhNDVjMjY1N2UyODU3YzE4ZTZhNTQzZDMwOGNkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzQ2hlY2tzTWFjLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvR3JhcGhpY3NDaGVja3NNYWMuY3BwCkBA IC00NiwzNSArNDYsMzUgQEAgc3RhdGljIGlvX2Nvbm5lY3RfdCBhdHRhY2hUb0FwcGxlR3JhcGhp Y3NDb250cm9sKCkKICAgICBtYWNoX3BvcnRfdCBtYXN0ZXJQb3J0ID0gTUFDSF9QT1JUX05VTEw7 CiAKICAgICBpZiAoSU9NYXN0ZXJQb3J0KE1BQ0hfUE9SVF9OVUxMLCAmbWFzdGVyUG9ydCkgIT0g S0VSTl9TVUNDRVNTKQotICAgICAgICByZXR1cm4gTUFDSF9QT1JUX05VTEw7CisgICAgICAgIHJl dHVybiBJT19PQkpFQ1RfTlVMTDsKIAogICAgIENGRGljdGlvbmFyeVJlZiBjbGFzc1RvTWF0Y2gg PSBJT1NlcnZpY2VNYXRjaGluZygiQXBwbGVHcmFwaGljc0NvbnRyb2wiKTsKICAgICBpZiAoIWNs YXNzVG9NYXRjaCkKLSAgICAgICAgcmV0dXJuIE1BQ0hfUE9SVF9OVUxMOworICAgICAgICByZXR1 cm4gSU9fT0JKRUNUX05VTEw7CiAKICAgICBrZXJuX3JldHVybl90IGtlcm5SZXN1bHQ7CiAgICAg aW9faXRlcmF0b3JfdCBpdGVyYXRvcjsKICAgICBpZiAoKGtlcm5SZXN1bHQgPSBJT1NlcnZpY2VH ZXRNYXRjaGluZ1NlcnZpY2VzKG1hc3RlclBvcnQsIGNsYXNzVG9NYXRjaCwgJml0ZXJhdG9yKSkg IT0gS0VSTl9TVUNDRVNTKQotICAgICAgICByZXR1cm4gTUFDSF9QT1JUX05VTEw7CisgICAgICAg IHJldHVybiBJT19PQkpFQ1RfTlVMTDsKIAogICAgIGlvX3NlcnZpY2VfdCBzZXJ2aWNlT2JqZWN0 ID0gSU9JdGVyYXRvck5leHQoaXRlcmF0b3IpOwogICAgIElPT2JqZWN0UmVsZWFzZShpdGVyYXRv cik7CiAgICAgaWYgKCFzZXJ2aWNlT2JqZWN0KQotICAgICAgICByZXR1cm4gTUFDSF9QT1JUX05V TEw7CisgICAgICAgIHJldHVybiBJT19PQkpFQ1RfTlVMTDsKIAogICAgIGlvX2Nvbm5lY3RfdCBk YXRhUG9ydDsKICAgICBJT09iamVjdFJldGFpbihzZXJ2aWNlT2JqZWN0KTsKICAgICBrZXJuUmVz dWx0ID0gSU9TZXJ2aWNlT3BlbihzZXJ2aWNlT2JqZWN0LCBtYWNoX3Rhc2tfc2VsZigpLCAwLCAm ZGF0YVBvcnQpOwogICAgIElPT2JqZWN0UmVsZWFzZShzZXJ2aWNlT2JqZWN0KTsKIAotICAgIHJl dHVybiAoa2VyblJlc3VsdCA9PSBLRVJOX1NVQ0NFU1MpID8gZGF0YVBvcnQgOiBNQUNIX1BPUlRf TlVMTDsKKyAgICByZXR1cm4gKGtlcm5SZXN1bHQgPT0gS0VSTl9TVUNDRVNTKSA/IGRhdGFQb3J0 IDogSU9fT0JKRUNUX05VTEw7CiB9CiAKIHN0YXRpYyBib29sIGhhc011eENhcGFiaWxpdHkoKQog ewogICAgIGlvX2Nvbm5lY3RfdCBkYXRhUG9ydCA9IGF0dGFjaFRvQXBwbGVHcmFwaGljc0NvbnRy b2woKTsKIAotICAgIGlmIChkYXRhUG9ydCA9PSBNQUNIX1BPUlRfTlVMTCkKKyAgICBpZiAoZGF0 YVBvcnQgPT0gSU9fT0JKRUNUX05VTEwpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGJv b2wgcmVzdWx0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvUGx1Z2lucy9I b3N0ZWQvTmV0c2NhcGVQbHVnaW5Ib3N0TWFuYWdlci5tbSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kv bWFjL1BsdWdpbnMvSG9zdGVkL05ldHNjYXBlUGx1Z2luSG9zdE1hbmFnZXIubW0KaW5kZXggNWZk YTNmYzcxN2YzMTNhNGRiNjVlMjJiODM2OTVkODMzYzk5ZWY4ZC4uNzFiNmQ4MTlmOWQ5Nzc4YWE1 YTYyMWI4MGVhMzBiMTM4NWRlNTZkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9t YWMvUGx1Z2lucy9Ib3N0ZWQvTmV0c2NhcGVQbHVnaW5Ib3N0TWFuYWdlci5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0TGVnYWN5L21hYy9QbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdpbkhvc3RNYW5h Z2VyLm1tCkBAIC0xMzUsNyArMTM1LDcgQEAgYm9vbCBOZXRzY2FwZVBsdWdpbkhvc3RNYW5hZ2Vy OjpzcGF3blBsdWdpbkhvc3QoY29uc3QgU3RyaW5nJiBwbHVnaW5QYXRoLCBjcHVfdHkKICAgICAg ICAgcmV0dXJuIE1BQ0hfUE9SVF9OVUxMOwogCiAgICAgbWFjaF9wb3J0X3QgcmVuZGVyU2VydmVy UG9ydCA9IENBUmVuZGVyU2VydmVyR2V0UG9ydCgpOwotICAgIGlmIChyZW5kZXJTZXJ2ZXJQb3J0 ID09IE1BQ0hfUE9SVF9OVUxMKQorICAgIGlmICghTUFDSF9QT1JUX1ZBTElEKHJlbmRlclNlcnZl clBvcnQpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBOU1N0cmluZyAqcGx1Z2luSG9z dEFwcFBhdGggPSBbW05TQnVuZGxlIGJ1bmRsZUZvckNsYXNzOltXZWJOZXRzY2FwZVBsdWdpblBh Y2thZ2UgY2xhc3NdXSBwYXRoRm9yQXV4aWxpYXJ5RXhlY3V0YWJsZTpwbHVnaW5Ib3N0QXBwTmFt ZV07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9QbHVnaW5zL0hvc3RlZC9O ZXRzY2FwZVBsdWdpbkhvc3RQcm94eS5tbSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1BsdWdp bnMvSG9zdGVkL05ldHNjYXBlUGx1Z2luSG9zdFByb3h5Lm1tCmluZGV4IGM2NDc3NGRjNDdlM2Vl NTk1M2QyZDQ5ZWRlYjdlMGJjNzhkY2IwYzUuLjRmNmZhZDkxZDUyYWZlNTQwOTg4MjNmODI3ZWU5 NDYwNTUwZjUxNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1BsdWdpbnMv SG9zdGVkL05ldHNjYXBlUGx1Z2luSG9zdFByb3h5Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdh Y3kvbWFjL1BsdWdpbnMvSG9zdGVkL05ldHNjYXBlUGx1Z2luSG9zdFByb3h5Lm1tCkBAIC0zMTIs NyArMzEyLDcgQEAgYm9vbCBOZXRzY2FwZVBsdWdpbkhvc3RQcm94eTo6cHJvY2Vzc1JlcXVlc3Rz KCkKICAgICAgICAgX19SZXBseVVuaW9uX19XS1dlYktpdFBsdWdpbkNsaWVudF9zdWJzeXN0ZW0g cmVwbHk7CiAgICAgICAgIG1hY2hfbXNnX2hlYWRlcl90KiByZXBseUhlYWRlciA9IHJlaW50ZXJw cmV0X2Nhc3Q8bWFjaF9tc2dfaGVhZGVyX3QqPigmcmVwbHkpOwogICAgICAgICAKLSAgICAgICAg aWYgKFdlYktpdFBsdWdpbkNsaWVudF9zZXJ2ZXIobXNnLCByZXBseUhlYWRlcikgJiYgcmVwbHlI ZWFkZXItPm1zZ2hfcmVtb3RlX3BvcnQgIT0gTUFDSF9QT1JUX05VTEwpIHsKKyAgICAgICAgaWYg KFdlYktpdFBsdWdpbkNsaWVudF9zZXJ2ZXIobXNnLCByZXBseUhlYWRlcikgJiYgTUFDSF9QT1JU X1ZBTElEKHJlcGx5SGVhZGVyLT5tc2doX3JlbW90ZV9wb3J0KSkgewogICAgICAgICAgICAga3Ig PSBtYWNoX21zZyhyZXBseUhlYWRlciwgTUFDSF9TRU5EX01TRywgcmVwbHlIZWFkZXItPm1zZ2hf c2l6ZSwgMCwgTUFDSF9QT1JUX05VTEwsIDAsIE1BQ0hfUE9SVF9OVUxMKTsKICAgICAgICAgICAg IAogICAgICAgICAgICAgaWYgKGtyICE9IEtFUk5fU1VDQ0VTUykgewo=