223982 2021-03-30 20:43:53 -0700 ASSERT(m_sendPort) in IPC::Connection::open() when running some iOS unit tests 2021-03-31 09:59:11 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224004 InRadar P2 Normal --- 1 cdumez cdumez ap bfulgham darin ggaren kkinnunen pvollan webkit-bug-importer oldest_to_newest 1745492 0 cdumez 2021-03-30 20:43:53 -0700 ASSERT(m_sendPort) in IPC::Connection::open() when running some iOS unit tests: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x0000000436b18d4e WTFCrash + 14 1 com.apple.WebKit 0x00000004204333bb WTFCrashWithInfo(int, char const*, char const*, int) + 27 2 com.apple.WebKit 0x0000000420dbb6ac IPC::Connection::open() + 556 3 com.apple.WebKit 0x0000000420470870 WebKit::AuxiliaryProcess::initialize(WebKit::AuxiliaryProcessInitializationParameters const&) + 464 4 com.apple.WebKit 0x0000000421a6289a void WebKit::initializeAuxiliaryProcess<WebKit::WebProcess>(WebKit::AuxiliaryProcessInitializationParameters&&) + 42 5 com.apple.WebKit 0x0000000421a59921 void WebKit::XPCServiceInitializer<WebKit::WebProcess, WebKit::XPCServiceInitializerDelegate>(WTF::OSObjectPtr<NSObject<OS_xpc_object>*>, NSObject<OS_xpc_object>*, NSObject<OS_xpc_object>*) + 1089 6 com.apple.WebKit 0x0000000421a594a8 WebContentServiceInitializer + 88 7 com.apple.WebKit 0x0000000421061355 WebKit::XPCServiceEventHandler(NSObject<OS_xpc_object>*)::'block-literal'::$_1::operator()() const + 85 8 com.apple.WebKit 0x00000004210612b9 WTF::Detail::CallableWrapper<WebKit::XPCServiceEventHandler(NSObject<OS_xpc_object>*)::'block-literal'::$_1, void>::call() + 25 9 com.apple.JavaScriptCore 0x0000000436b404a2 WTF::Function<void ()>::operator()() const + 130 10 com.apple.JavaScriptCore 0x0000000436c470ad WTF::BlockPtr<void ()> WTF::BlockPtr<void ()>::fromCallable<WTF::Function<void ()> >(WTF::Function<void ()>)::'lambda'(void*)::operator()(void*) const + 29 11 com.apple.JavaScriptCore 0x0000000436c47085 WTF::BlockPtr<void ()> WTF::BlockPtr<void ()>::fromCallable<WTF::Function<void ()> >(WTF::Function<void ()>)::'lambda'(void*)::__invoke(void*) + 21 12 libdispatch.dylib 0x000000041180c88e _dispatch_client_callout + 8 13 libdispatch.dylib 0x000000041181a564 _dispatch_async_and_wait_invoke + 109 14 libdispatch.dylib 0x000000041180c88e _dispatch_client_callout + 8 15 libdispatch.dylib 0x00000004118198bf _dispatch_main_queue_callback_4CF + 1054 16 com.apple.CoreFoundation 0x0000000410526050 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9 17 com.apple.CoreFoundation 0x000000041052089c __CFRunLoopRun + 2772 18 com.apple.CoreFoundation 0x000000041051f8e5 CFRunLoopRunSpecific + 567 19 com.apple.Foundation 0x0000000410e40e90 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 209 20 com.apple.Foundation 0x0000000410e410ad -[NSRunLoop(NSRunLoop) run] + 76 21 libxpc.dylib 0x0000000411b19151 _xpc_objc_main + 440 22 libxpc.dylib 0x0000000411b1b0e6 xpc_main + 122 23 com.apple.WebKit 0x000000042105d801 WebKit::XPCServiceMain(int, char const**) + 449 24 com.apple.WebKit 0x00000004226b63db WKXPCServiceMain + 27 25 com.apple.WebKit.WebContent 0x000000010a395d42 main + 34 26 dyld_sim 0x0000000410003c54 _dyld_start + 423 27 dyld 0x000000011245ea8e dyld::useSimulatorDyld(int, macho_header const*, char const*, int, char const**, char const**, char const**, unsigned long*, unsigned long*) + 2093 28 dyld 0x000000011245c168 dyld::_main(macho_header const*, unsigned long, int, char const**, char const**, char const**, unsigned long*) + 1198 29 dyld 0x0000000112456224 dyldbootstrap::start(dyld3::MachOLoaded const*, int, char const**, dyld3::MachOLoaded const*, unsigned long*) + 450 30 dyld 0x0000000112456025 _dyld_start + 37 31 ??? 0x0000000000000001 0 + 1 1745493 1 cdumez 2021-03-30 20:44:06 -0700 <rdar://75974285> 1745494 2 424732 cdumez 2021-03-30 20:50:51 -0700 Created attachment 424732 Patch 1745508 3 ews-feeder 2021-03-30 22:34:42 -0700 Committed r275268: <https://commits.webkit.org/r275268> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424732. 1745656 4 darin 2021-03-31 09:42:10 -0700 Other places that check against MACH_PORT_NULL but not MACH_PORT_DEAD: ResourceUsageThread::platformCollectCPUData: ResourceUsageThreadCocoa.mm hasMuxCompatibility: GraphicsChecksMac.cpp NetscapePluginHostManager::spawnPluginHost: NetscapePluginHostManager.mm NetscapePluginHostManager::initializeVendorPort: NetscapePluginHostManager.mm NetscapePluginHostProxy::NetscapePluginHostProxy: NetscapePluginHostProxy.mm NetscapePluginHostProxy::processRequests: NetscapePluginHostProxy.mm XPCServiceInitializerDelegate::getConnectionIdentifier: XPCServiceEntryPoint.mm releaseSendRight: MachSendRight.cpp MachSendRight::operator bool: MachSendRight.h Maybe one or more of these should be using MACH_PORT_VALID instead? 1745657 5 cdumez 2021-03-31 09:42:46 -0700 (In reply to Darin Adler from comment #4) > Other places that check against MACH_PORT_NULL but not MACH_PORT_DEAD: > > ResourceUsageThread::platformCollectCPUData: ResourceUsageThreadCocoa.mm > hasMuxCompatibility: GraphicsChecksMac.cpp > NetscapePluginHostManager::spawnPluginHost: NetscapePluginHostManager.mm > NetscapePluginHostManager::initializeVendorPort: > NetscapePluginHostManager.mm > NetscapePluginHostProxy::NetscapePluginHostProxy: > NetscapePluginHostProxy.mm > NetscapePluginHostProxy::processRequests: NetscapePluginHostProxy.mm > XPCServiceInitializerDelegate::getConnectionIdentifier: > XPCServiceEntryPoint.mm > releaseSendRight: MachSendRight.cpp > MachSendRight::operator bool: MachSendRight.h > > Maybe one or more of these should be using MACH_PORT_VALID instead? I will check and follow-up. 424732 2021-03-30 20:50:51 -0700 2021-03-30 22:34:43 -0700 Patch bug-223982-20210330205050.patch text/plain 2650 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MjA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAyNzFlZDM1MDIwNjEyZWMx MjllMTJmYTc2MTg3Zjc0YmYzYjZkMzkuLjU2MGRhNzcyMDZkZjIyZTc0MzgzYTRjZTIzOWVmMjJh NDgwNzIzNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDMtMzAgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBU1NFUlQobV9zZW5kUG9ydCkgaW4g SVBDOjpDb25uZWN0aW9uOjpvcGVuKCkgd2hlbiBydW5uaW5nIHNvbWUgaU9TIHVuaXQgdGVzdHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzk4Mgor ICAgICAgICA8cmRhcjovLzc1OTc0Mjg1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIElmIHRoZSBVSVByb2Nlc3MgZXhpdHMgb3Igc2V2ZXJzIGl0IGNv bm5lY3Rpb24gdG8gdGhlIFdlYlByb2Nlc3Mgd2hpbGUgdGhlIFdlYlByb2Nlc3MgaXMKKyAgICAg ICAgbGF1bmNoaW5nLCB0aGUgV2ViUHJvY2VzcyBlbmRzIHVwIGdldHRpbmcgYW4gaW52YWxpZCBt YWNoIHBvcnQgdXBvbiBpbml0aWFsaXphdGlvbi4gVGhpcworICAgICAgICBpcyBleHBlY3RlZCBh bmQgWFBDU2VydmljZUluaXRpYWxpemVyRGVsZWdhdGU6OmdldENvbm5lY3Rpb25JZGVudGlmaWVy KCkgd2FzIGRlYWxpbmcgd2l0aAorICAgICAgICB0aGlzLiBnZXRDb25uZWN0aW9uSWRlbnRpZmll cigpIHdhcyBjaGVja2luZyBpZiB0aGUgcG9ydCB3YXMgaW52YWxpZCBieSBjaGVja2luZyBpZiBp dCB3YXMKKyAgICAgICAgTUFDSF9QT1JUX05VTEwgYW5kIGNhbGxpbmcgZXhpdCgpIGluIHN1Y2gg Y2FzZS4gSG93ZXZlciwgc29tZXRoaW5nIGhhcyBjaGFuZ2VkIChsaWtlbHkKKyAgICAgICAgYXQg T1MgbGV2ZWwpIGFuZCB3ZSBhcmUgbm93IHNvbWV0aW1lcyBnZXR0aW5nIE1BQ0hfUE9SVF9ERUFE IGluc3RlYWQgb2YgTUFDSF9QT1JUX05VTEwuCisgICAgICAgIFRoZSBwcm9wZXIgd2F5IHRvIGNo ZWNrIGlmIGEgbWFjaCBwb3J0IGlzIHZhbGlkIGlzIHRvIGNhbGwgTUFDSF9QT1JUX1ZBTElEKCks IHdoaWNoIGNoZWNrcworICAgICAgICBmb3IgYm90aCBNQUNIX1BPUlRfTlVMTCBhbmQgTUFDSF9Q T1JUX0RFQUQuIEkgdGhlcmVmb3JlIHVwZGF0ZWQgZ2V0Q29ubmVjdGlvbklkZW50aWZpZXIoKQor ICAgICAgICB0byB1c2UgTUFDSF9QT1JUX1ZBTElEKCkgaW5zdGVhZCBvZiBhbiBleHBsaWNpdCBj aGVjayBmb3IgTUFDSF9QT1JUX05VTEwuIFRoaXMgZ2V0cyByaWQKKyAgICAgICAgb2YgZGVidWcg YXNzZXJ0aW9ucyB3ZSB3ZXJlIHNlZWluZyBpbiB0aGUgb3V0cHV0IG9mIHNvbWUgaU9TIHVuaXQg dGVzdHMuCisKKyAgICAgICAgKiBTaGFyZWQvRW50cnlQb2ludFV0aWxpdGllcy9Db2NvYS9YUENT ZXJ2aWNlL1hQQ1NlcnZpY2VFbnRyeVBvaW50Lm1tOgorICAgICAgICAoV2ViS2l0OjpYUENTZXJ2 aWNlSW5pdGlhbGl6ZXJEZWxlZ2F0ZTo6Z2V0Q29ubmVjdGlvbklkZW50aWZpZXIpOgorCiAyMDIx LTAzLTI2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgU2Vydmlj ZSBXb3JrZXIgc2NyaXB0cyB1c2UgdG9vIG11Y2ggbWVtb3J5IGluIHRoZSBuZXR3b3JrIHByb2Nl c3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMv Q29jb2EvWFBDU2VydmljZS9YUENTZXJ2aWNlRW50cnlQb2ludC5tbSBiL1NvdXJjZS9XZWJLaXQv U2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvQ29jb2EvWFBDU2VydmljZS9YUENTZXJ2aWNlRW50 cnlQb2ludC5tbQppbmRleCAxYTQxMDAwZjEyZjZmN2ZmYzFiNzYxNDJkYWIyODk5YWJmOGQyZjcz Li5kODVjOWYyYzhlNzg1ZDY1OWM0ZjQ4ZGRhZGI1YWEwMWNlYmEwMmViIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL0NvY29hL1hQQ1NlcnZpY2Uv WFBDU2VydmljZUVudHJ5UG9pbnQubW0KKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvRW50cnlQ b2ludFV0aWxpdGllcy9Db2NvYS9YUENTZXJ2aWNlL1hQQ1NlcnZpY2VFbnRyeVBvaW50Lm1tCkBA IC02Miw3ICs2Miw3IEBAIGJvb2wgWFBDU2VydmljZUluaXRpYWxpemVyRGVsZWdhdGU6OmNoZWNr RW50aXRsZW1lbnRzKCkKIGJvb2wgWFBDU2VydmljZUluaXRpYWxpemVyRGVsZWdhdGU6OmdldENv bm5lY3Rpb25JZGVudGlmaWVyKElQQzo6Q29ubmVjdGlvbjo6SWRlbnRpZmllciYgaWRlbnRpZmll cikKIHsKICAgICBtYWNoX3BvcnRfdCBwb3J0ID0geHBjX2RpY3Rpb25hcnlfY29weV9tYWNoX3Nl bmQobV9pbml0aWFsaXplck1lc3NhZ2UsICJzZXJ2ZXItcG9ydCIpOwotICAgIGlmIChwb3J0ID09 IE1BQ0hfUE9SVF9OVUxMKQorICAgIGlmICghTUFDSF9QT1JUX1ZBTElEKHBvcnQpKQogICAgICAg ICByZXR1cm4gZmFsc2U7CiAKICAgICBpZGVudGlmaWVyID0gSVBDOjpDb25uZWN0aW9uOjpJZGVu dGlmaWVyKHBvcnQsIG1fY29ubmVjdGlvbik7Cg==