223961 2021-03-30 14:58:47 -0700 REGRESSION(r274607): media controls script is visible in Web Inspector even without the engineering "Show WebKit-internal scripts" enabled 2021-04-11 21:18:00 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224422 InRadar P2 Normal --- 223309 1 hi hi calvaris cdumez changseok eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim hi jer.noble keith_miller mark.lam msaboff philipj saam sergio tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1745349 0 hi 2021-03-30 14:58:47 -0700 . 1745357 1 424706 hi 2021-03-30 15:05:49 -0700 Created attachment 424706 Patch 1745360 2 424706 ysuzuki 2021-03-30 15:07:36 -0700 Comment on attachment 424706 Patch r=me 1745482 3 ews-feeder 2021-03-30 20:01:16 -0700 Committed r275262: <https://commits.webkit.org/r275262> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424706. 1745484 4 webkit-bug-importer 2021-03-30 20:02:13 -0700 <rdar://problem/76035181> 424706 2021-03-30 15:05:49 -0700 2021-03-30 20:01:18 -0700 Patch 223961.diff text/plain 5254 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGI1ZWFmYTk5MTM5Yi4uYzNlMThkODdhZTIyIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAyMS0wMy0zMCAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjc0 NjA3KTogbWVkaWEgY29udHJvbHMgc2NyaXB0IGlzIHZpc2libGUgaW4gV2ViIEluc3BlY3RvciBl dmVuIHdpdGhvdXQgdGhlIGVuZ2luZWVyaW5nICJTaG93IFdlYktpdC1pbnRlcm5hbCBzY3JpcHRz IiBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjM5NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJdCB0dXJucyBvdXQgdGhhdCBXZWIgSW5zcGVjdG9yIHdpbGwgb25seSBpZ25vcmUgc2NyaXB0 cyB0aGF0IGhhdmUgYSBzb3VyY2UgVVJMIGRpcmVjdGl2ZQorICAgICAgICB0aGF0IG1hdGNoZXMg YF9fSW5qZWN0ZWRTY3JpcHRfKi5qc2AsIG5vdCB0aG9zZSB0aGF0IGhhdmUgYSAoc291cmNlKSBV UkwgbWF0Y2hpbmcgdGhhdC4KKworICAgICAgICBJbiBhZGRpdGlvbiB0byBXZWIgSW5zcGVjdG9y IGlnbm9yaW5nIHRoZXNlIHNjcmlwdHMgaW4gdGhlIFVJLCBpdCB3aWxsIGFsc28gY2F1c2UgdGhl CisgICAgICAgIGBEZWJ1Z2dlcmAgdG8gbm90IHBhdXNlIGluIHNjcmlwdHMgd2l0aCBhIG1hdGNo aW5nIHNvdXJjZSBVUkwgZGlyZWN0aXZlICh1bmxlc3MgdGhlCisgICAgICAgIGxvY2FsIGJ1aWxk IGVuZ2luZWVyaW5nIG9ubHkgIlBhdXNlIGluIFdlYktpdC1pbnRlcm5hbCBzY3JpcHRzIiBpcyBl bmFibGVkKS4KKworICAgICAgICAqIFNjcmlwdHMvbWFrZS1qcy1maWxlLWFycmF5cy5weToKKyAg ICAgICAgKG1haW4pOgorICAgICAgICBBZGQgYSBgLy8jIHNvdXJjZVVSTD1fX0luamVjdGVkU2Ny aXB0XyouanNgIHRvIHRoZSBjb250ZW50cyBiZWZvcmUgaXQncyBlbmNvZGVkLgorCiAyMDIxLTAz LTI4ICBTYW0gV2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgRU5B QkxFX0lOREVYRURfREFUQUJBU0UgJiBFTkFCTEVfSU5ERVhFRF9EQVRBQkFTRV9JTl9XT1JLRVJT LCBpdCBzZWVtcyBsaWtlIGl0IGlzIG9uIGZvciBhbGwgcG9ydHMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9TY3JpcHRzL21ha2UtanMtZmlsZS1hcnJheXMucHkgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvU2NyaXB0cy9tYWtlLWpzLWZpbGUtYXJyYXlzLnB5CmluZGV4IDcyODkz MzUwMDAzYy4uZWVkYTc2MjkyZTFjIDEwMDc1NQotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv U2NyaXB0cy9tYWtlLWpzLWZpbGUtYXJyYXlzLnB5CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9TY3JpcHRzL21ha2UtanMtZmlsZS1hcnJheXMucHkKQEAgLTcwLDYgKzcwLDggQEAgZGVmIG1h aW4oKToKICAgICBwcmludCgnbmFtZXNwYWNlIHswOnN9IHt7Jy5mb3JtYXQobmFtZXNwYWNlKSwg ZmlsZT1zb3VyY2VGaWxlKQogCiAgICAgZm9yIGlucHV0RmlsZU5hbWUgaW4gaW5wdXRQYXRoczoK KyAgICAgICAgdmFyaWFibGVOYW1lID0gb3MucGF0aC5zcGxpdGV4dChvcy5wYXRoLmJhc2VuYW1l KGlucHV0RmlsZU5hbWUpKVswXQorICAgICAgICBzb3VyY2VVUkxEaXJlY3RpdmUgPSAiLy8jIHNv dXJjZVVSTD1fX0luamVjdGVkU2NyaXB0XyIgKyB2YXJpYWJsZU5hbWUgKyAiLmpzXG4iCiAKICAg ICAgICAgaWYgaXNfMzoKICAgICAgICAgICAgIGlucHV0U3RyZWFtID0gaW8ub3BlbihpbnB1dEZp bGVOYW1lLCBlbmNvZGluZz0ndXRmLTgnKQpAQCAtNzksOSArODEsOSBAQCBkZWYgbWFpbigpOgog ICAgICAgICBkYXRhID0gaW5wdXRTdHJlYW0ucmVhZCgpCiAKICAgICAgICAgaWYgbm90IG9wdGlv bnMubm9fbWluaWZ5OgotICAgICAgICAgICAgY2hhcmFjdGVycyA9IGpzbWluKGRhdGEpCisgICAg ICAgICAgICBjaGFyYWN0ZXJzID0gc291cmNlVVJMRGlyZWN0aXZlICsganNtaW4oZGF0YSkKICAg ICAgICAgZWxzZToKLSAgICAgICAgICAgIGNoYXJhY3RlcnMgPSBkYXRhCisgICAgICAgICAgICBj aGFyYWN0ZXJzID0gc291cmNlVVJMRGlyZWN0aXZlICsgZGF0YQogCiAgICAgICAgIGlmIG9wdGlv bnMuZmFpbF9pZl9ub25fYXNjaWk6CiAgICAgICAgICAgICBmb3IgY2hhcmFjdGVyIGluIGNoYXJh Y3RlcnM6CkBAIC05Nyw4ICs5OSw2IEBAIGRlZiBtYWluKCk6CiAgICAgICAgICMgYmVjYXVzZSBV VEYtOCBjaGFyYWN0ZXJzIG1heSBuZWVkIG1vcmUgdGhhbiBvbmUgYnl0ZS4KICAgICAgICAgc2l6 ZSA9IGxlbihjb2RlcG9pbnRzKQogCi0gICAgICAgIHZhcmlhYmxlTmFtZSA9IG9zLnBhdGguc3Bs aXRleHQob3MucGF0aC5iYXNlbmFtZShpbnB1dEZpbGVOYW1lKSlbMF0KLQogICAgICAgICBwcmlu dCgnZXh0ZXJuIGNvbnN0IGNoYXIgezA6c31KYXZhU2NyaXB0W3sxOmR9XTsnLmZvcm1hdCh2YXJp YWJsZU5hbWUsIHNpemUpLCBmaWxlPWhlYWRlckZpbGUpCiAgICAgICAgIHByaW50KCdjb25zdCBj aGFyIHswOnN9SmF2YVNjcmlwdFt7MTpkfV0gPSB7eycuZm9ybWF0KHZhcmlhYmxlTmFtZSwgc2l6 ZSksIGZpbGU9c291cmNlRmlsZSkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDRiOTg4ZGNjYTk0ZC4uMGNlZGFl NDQ3MDkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDMtMzAgIERldmluIFJv dXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI3NDYwNyk6 IG1lZGlhIGNvbnRyb2xzIHNjcmlwdCBpcyB2aXNpYmxlIGluIFdlYiBJbnNwZWN0b3IgZXZlbiB3 aXRob3V0IHRoZSBlbmdpbmVlcmluZyAiU2hvdyBXZWJLaXQtaW50ZXJuYWwgc2NyaXB0cyIgZW5h YmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIz OTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQg dHVybnMgb3V0IHRoYXQgV2ViIEluc3BlY3RvciB3aWxsIG9ubHkgaWdub3JlIHNjcmlwdHMgdGhh dCBoYXZlIGEgc291cmNlIFVSTCBkaXJlY3RpdmUKKyAgICAgICAgdGhhdCBtYXRjaGVzIGBfX0lu amVjdGVkU2NyaXB0XyouanNgLCBub3QgdGhvc2UgdGhhdCBoYXZlIGEgKHNvdXJjZSkgVVJMIG1h dGNoaW5nIHRoYXQuCisKKyAgICAgICAgSW4gYWRkaXRpb24gdG8gV2ViIEluc3BlY3RvciBpZ25v cmluZyB0aGVzZSBzY3JpcHRzIGluIHRoZSBVSSwgaXQgd2lsbCBhbHNvIGNhdXNlIHRoZQorICAg ICAgICBgRGVidWdnZXJgIHRvIG5vdCBwYXVzZSBpbiBzY3JpcHRzIHdpdGggYSBtYXRjaGluZyBz b3VyY2UgVVJMIGRpcmVjdGl2ZSAodW5sZXNzIHRoZQorICAgICAgICBsb2NhbCBidWlsZCBlbmdp bmVlcmluZyBvbmx5ICJQYXVzZSBpbiBXZWJLaXQtaW50ZXJuYWwgc2NyaXB0cyIgaXMgZW5hYmxl ZCkuCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SFRNTE1lZGlhRWxlbWVudDo6ZW5zdXJlTWVkaWFDb250cm9sc0luamVjdGVkU2NyaXB0 KToKKyAgICAgICAgQ2hhbmdlIHRoZSBgU2NyaXB0U291cmNlQ29kZWAgaGVyZSB0byBub3QgaGF2 ZSBhIGBVUkxgIGFuZCBoYXZlIGBtYWtlLWpzLWZpbGUtYXJyYXlzLnB5YAorICAgICAgICBhZGQg YSBgLy8jIHNvdXJjZVVSTD1fX0luamVjdGVkU2NyaXB0XyouanNgIHRvIHRoZSBjb250ZW50cyBi ZWZvcmUgaXQncyBlbmNvZGVkLgorCiAyMDIxLTAzLTI5ICBFcmljIENhcmxzb24gIDxlcmljLmNh cmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gQWRkIHJlbW90ZSBNZWRpYVNlc3Np b25Db29yZGluYXRvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFF bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5k ZXggY2JjNTk5MDA3Zjg3Li5mMzFmMmM2MDEzNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmNwcApAQCAtNzE2MCwxMyArNzE2MCwxMCBAQCBib29sIEhUTUxNZWRpYUVs ZW1lbnQ6OmVuc3VyZU1lZGlhQ29udHJvbHNJbmplY3RlZFNjcmlwdCgpCiAgICAgICAgIGlmIChm dW5jdGlvblZhbHVlLmlzQ2FsbGFibGUodm0pKQogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAK LSAgICAgICAgdW5zaWduZWQgaW5kZXggPSAwOwogICAgICAgICBmb3IgKGF1dG8mIG1lZGlhQ29u dHJvbHNTY3JpcHQgOiBtZWRpYUNvbnRyb2xzU2NyaXB0cykgewogICAgICAgICAgICAgaWYgKG1l ZGlhQ29udHJvbHNTY3JpcHQuaXNFbXB0eSgpKQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwot ICAgICAgICAgICAgLy8gU2V0dGluZyBhIHNjcmlwdFVSTCBhbGxvd3MgdGhlIHNvdXJjZSB0byBi ZSBkZWJ1Z2dhYmxlIGluIHRoZSBpbnNwZWN0b3IuCi0gICAgICAgICAgICBVUkwgc2NyaXB0VVJM ID0gVVJMKHsgfSwgbWFrZVN0cmluZygiX19JbmplY3RlZFNjcmlwdF9tZWRpYUNvbnRyb2xzU2Ny aXB0Il9zLCArK2luZGV4LCAiLmpzIikpOwotICAgICAgICAgICAgc2NyaXB0Q29udHJvbGxlci5l dmFsdWF0ZUluV29ybGRJZ25vcmluZ0V4Y2VwdGlvbihTY3JpcHRTb3VyY2VDb2RlKG1lZGlhQ29u dHJvbHNTY3JpcHQsIFdURk1vdmUoc2NyaXB0VVJMKSksIHdvcmxkKTsKKyAgICAgICAgICAgIHNj cmlwdENvbnRyb2xsZXIuZXZhbHVhdGVJbldvcmxkSWdub3JpbmdFeGNlcHRpb24oU2NyaXB0U291 cmNlQ29kZShtZWRpYUNvbnRyb2xzU2NyaXB0KSwgd29ybGQpOwogICAgICAgICAgICAgaWYgKFVO TElLRUxZKHNjb3BlLmV4Y2VwdGlvbigpKSkgewogICAgICAgICAgICAgICAgIGF1dG8qIGV4Y2Vw dGlvbiA9IHNjb3BlLmV4Y2VwdGlvbigpOwogICAgICAgICAgICAgICAgIHNjb3BlLmNsZWFyRXhj ZXB0aW9uKCk7Cg==