223958 2021-03-30 14:41:57 -0700 Web Inspector: [Cocoa] WKInspectorResourceURLSchemeHandler can exceed the soft thread limit when opening multiple inspectors simultaneously. 2021-03-31 19:31:24 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 pangle pangle bburg ews-watchlist hi inspector-bugzilla-changes joepeck pangle webkit-bug-importer oldest_to_newest 1745336 0 pangle 2021-03-30 14:41:57 -0700 Multiple WKInspectorResourceURLSchemeHandlers may be loading inspectors at the same time, which makes it possible for their combined operations to exceed the soft thread limit. In practice, this should only possible in engineering builds. 1745339 1 pangle 2021-03-30 14:47:25 -0700 <rdar://75847924> 1745343 2 424701 pangle 2021-03-30 14:51:36 -0700 Created attachment 424701 Patch v1.0 1745820 3 424701 bburg 2021-03-31 15:30:28 -0700 Comment on attachment 424701 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=424701&action=review r=me > Source/WebKit/UIProcess/Inspector/mac/WKInspectorResourceURLSchemeHandler.mm:62 > + // The default value (NSOperationQueueDefaultMaxConcurrentOperationCount) results in a large number of threads I think this second comment is nice but redundant with the changelog, and could be removed. 1745915 4 424862 pangle 2021-03-31 19:02:21 -0700 Created attachment 424862 Patch v1.1 - Shorten redundant part of comment 1745926 5 ews-feeder 2021-03-31 19:31:23 -0700 Committed r275341: <https://commits.webkit.org/r275341> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424862. 424701 2021-03-30 14:51:36 -0700 2021-03-31 19:02:19 -0700 Patch v1.0 bug-223958-20210330145135.patch text/plain 2715 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAwZjFlYjg2ZmI5NTBmZjU2 ZThhNzI2MDM4ZmUxMDEzZDU4YmRkZTYuLjIwODFlMmU4NThhMGQxZTgyYTY2MjZjYjU0Nzg4MjY4 MGY0ZGQ5MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDMtMzAgIFBhdHJpY2sg QW5nbGUgIDxwYW5nbGVAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtDb2Nv YV0gV0tJbnNwZWN0b3JSZXNvdXJjZVVSTFNjaGVtZUhhbmRsZXIgY2FuIGV4Y2VlZCB0aGUgc29m dCB0aHJlYWQgbGltaXQgd2hlbiBvcGVuaW5nIG11bHRpcGxlIGluc3BlY3RvcnMgc2ltdWx0YW5l b3VzbHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MjM5NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ biBlbmdpbmVlcmluZyBidWlsZHMsIHRoZSBXZWIgSW5zcGVjdG9yIGlzIGxvYWRlZCBhcyBodW5k cmVkcyBvZiBzZXBhcmF0ZSByZXNvdXJjZXMgaW5zdGVhZCBvZiB0aGUgaGFuZGZ1bCBvZgorICAg ICAgICBtaW5pZmllZCBzb3VyY2VzIHVzZWQgZm9yIHJlbGVhc2VkIGJ1aWxkcy4gV2hlbiB0d28g V2ViIEluc3BlY3RvciB3aW5kb3dzIGFyZSBvcGVuZWQgdGhlaXIgbG9hZHMgY2FuIG92ZXJsYXAK KyAgICAgICAgYW5kIGl0IGlzIHBvc3NpYmxlIGZvciB0aGUgc3VtIHRvdGFsIG9mIGZpbGUgbG9h ZCBvcGVyYXRpb25zIHRvIGV4Y2VlZCB0aGUgZGlzcGF0Y2ggc29mdCB0aHJlYWQgbGltaXQuIFRv CisgICAgICAgIHJlc29sdmUgdGhpcywgd2Ugc2V0IGEgc2Vuc2libGUgbGltaXQgdG8gdGhlIG51 bWJlciBvZiBzaW11bHRhbmVvdXMgaW5zcGVjdG9yIGxvYWRpbmcgb3BlcmF0aW9ucy4gQSBoaWdo ZXIKKyAgICAgICAgbnVtYmVyIG9mIGFsbG93ZWQgY29uY3VycmVudCBvcGVyYXRpb25zIHlpZWxk ZWQgbm8gbm90aWNlYWJsZSBpbmNyZWFzZSBpbiBsb2FkIHNwZWVkcy4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9JbnNwZWN0b3IvbWFjL1dLSW5zcGVjdG9yUmVzb3VyY2VVUkxTY2hlbWVIYW5kbGVy Lm1tOgorICAgICAgICAoLVtXS0luc3BlY3RvclJlc291cmNlVVJMU2NoZW1lSGFuZGxlciB3ZWJW aWV3OnN0YXJ0VVJMU2NoZW1lVGFzazpdKToKKwogMjAyMS0wMy0yOCAgU2FpZCBBYm91LUhhbGxh d2EgIDxzYWlkQGFwcGxlLmNvbT4KIAogICAgICAgICBbR1BVIFByb2Nlc3NdIERvbid0IGV2ZXIg cmVwbGF5IERpc3BsYXlMaXN0IGl0ZW1zIG9mIGEgUmVtb3RlSW1hZ2VCdWZmZXIgaW4gV2ViUHJv Y2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL21hYy9X S0luc3BlY3RvclJlc291cmNlVVJMU2NoZW1lSGFuZGxlci5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0luc3BlY3Rvci9tYWMvV0tJbnNwZWN0b3JSZXNvdXJjZVVSTFNjaGVtZUhhbmRsZXIu bW0KaW5kZXggM2ZiMGQ4MmJkNmUyY2Y1NWE4NGE0NDM1NWIxZGVhY2UwNjhiMTY2Ni4uY2FiNjQx ZDAwNTEzNjU3ZTRmNmE5ODBjNmY2ODc0YmEyMWNmMzY2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL21hYy9XS0luc3BlY3RvclJlc291cmNlVVJMU2NoZW1l SGFuZGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3IvbWFjL1dL SW5zcGVjdG9yUmVzb3VyY2VVUkxTY2hlbWVIYW5kbGVyLm1tCkBAIC01OCw2ICs1OCwxMSBAQCAt ICh2b2lkKXdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgc3RhcnRVUkxTY2hlbWVUYXNrOihp ZCA8V0tVUkxTY2hlbWVUYXNrPil1cgogICAgICAgICBfb3BlcmF0aW9uUXVldWUgPSBhZG9wdE5T KFtbTlNPcGVyYXRpb25RdWV1ZSBhbGxvY10gaW5pdF0pOwogICAgICAgICBfb3BlcmF0aW9uUXVl dWUuZ2V0KCkudW5kZXJseWluZ1F1ZXVlID0gZGlzcGF0Y2hfZ2V0X2dsb2JhbF9xdWV1ZShRT1Nf Q0xBU1NfVVNFUl9JTlRFUkFDVElWRSwgMCk7CiAgICAgICAgIF9vcGVyYXRpb25RdWV1ZS5nZXQo KS5xdWFsaXR5T2ZTZXJ2aWNlID0gTlNPcGVyYXRpb25RdWFsaXR5T2ZTZXJ2aWNlVXNlckludGVy YWN0aXZlOworCisgICAgICAgIC8vIFRoZSBkZWZhdWx0IHZhbHVlIChOU09wZXJhdGlvblF1ZXVl RGVmYXVsdE1heENvbmN1cnJlbnRPcGVyYXRpb25Db3VudCkgcmVzdWx0cyBpbiBhIGxhcmdlIG51 bWJlciBvZiB0aHJlYWRzCisgICAgICAgIC8vIHRoYXQgY2FuIGV4Y2VlZCB0aGUgc29mdCBsaW1p dCBpZiB0d28gV2ViIEluc3BlY3RvciBpbnN0YW5jZXMgYXJlIGJlaW5nIGxvYWRlZCBzaW11bHRh bmVvdXNseSBpbiBlbmdpbmVlcmluZworICAgICAgICAvLyBidWlsZHMsIHdoZXJlIHRoZSBzb3Vy Y2VzIGhhdmUgbm90IGJlZW4gcmVkdWNlZCB0byBhIHNtYWxsIG51bWJlciBvZiBmaWxlcy4KKyAg ICAgICAgX29wZXJhdGlvblF1ZXVlLmdldCgpLm1heENvbmN1cnJlbnRPcGVyYXRpb25Db3VudCA9 IDQ7CiAgICAgfQogCiAgICAgTlNCbG9ja09wZXJhdGlvbiAqb3BlcmF0aW9uID0gW05TQmxvY2tP cGVyYXRpb24gYmxvY2tPcGVyYXRpb25XaXRoQmxvY2s6XnsK 424862 2021-03-31 19:02:21 -0700 2021-03-31 19:31:24 -0700 Patch v1.1 - Shorten redundant part of comment bug-223958-20210331190220.patch text/plain 2606 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAwZjFlYjg2ZmI5NTBmZjU2 ZThhNzI2MDM4ZmUxMDEzZDU4YmRkZTYuLmI2NWM1ODliZjYwN2NiNWYzMjM5OGM3MTk2MDUxNmRk NTQwZmY0ZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDMtMzAgIFBhdHJpY2sg QW5nbGUgIDxwYW5nbGVAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtDb2Nv YV0gV0tJbnNwZWN0b3JSZXNvdXJjZVVSTFNjaGVtZUhhbmRsZXIgY2FuIGV4Y2VlZCB0aGUgc29m dCB0aHJlYWQgbGltaXQgd2hlbiBvcGVuaW5nIG11bHRpcGxlIGluc3BlY3RvcnMgc2ltdWx0YW5l b3VzbHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MjM5NTgKKworICAgICAgICBSZXZpZXdlZCBieSBCSiBCdXJnLgorCisgICAgICAgIEluIGVuZ2lu ZWVyaW5nIGJ1aWxkcywgdGhlIFdlYiBJbnNwZWN0b3IgaXMgbG9hZGVkIGFzIGh1bmRyZWRzIG9m IHNlcGFyYXRlIHJlc291cmNlcyBpbnN0ZWFkIG9mIHRoZSBoYW5kZnVsIG9mCisgICAgICAgIG1p bmlmaWVkIHNvdXJjZXMgdXNlZCBmb3IgcmVsZWFzZWQgYnVpbGRzLiBXaGVuIHR3byBXZWIgSW5z cGVjdG9yIHdpbmRvd3MgYXJlIG9wZW5lZCB0aGVpciBsb2FkcyBjYW4gb3ZlcmxhcAorICAgICAg ICBhbmQgaXQgaXMgcG9zc2libGUgZm9yIHRoZSBzdW0gdG90YWwgb2YgZmlsZSBsb2FkIG9wZXJh dGlvbnMgdG8gZXhjZWVkIHRoZSBkaXNwYXRjaCBzb2Z0IHRocmVhZCBsaW1pdC4gVG8KKyAgICAg ICAgcmVzb2x2ZSB0aGlzLCB3ZSBzZXQgYSBzZW5zaWJsZSBsaW1pdCB0byB0aGUgbnVtYmVyIG9m IHNpbXVsdGFuZW91cyBpbnNwZWN0b3IgbG9hZGluZyBvcGVyYXRpb25zLiBBIGhpZ2hlcgorICAg ICAgICBudW1iZXIgb2YgYWxsb3dlZCBjb25jdXJyZW50IG9wZXJhdGlvbnMgeWllbGRlZCBubyBu b3RpY2VhYmxlIGluY3JlYXNlIGluIGxvYWQgc3BlZWRzLgorCisgICAgICAgICogVUlQcm9jZXNz L0luc3BlY3Rvci9tYWMvV0tJbnNwZWN0b3JSZXNvdXJjZVVSTFNjaGVtZUhhbmRsZXIubW06Cisg ICAgICAgICgtW1dLSW5zcGVjdG9yUmVzb3VyY2VVUkxTY2hlbWVIYW5kbGVyIHdlYlZpZXc6c3Rh cnRVUkxTY2hlbWVUYXNrOl0pOgorCiAyMDIxLTAzLTI4ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNh aWRAYXBwbGUuY29tPgogCiAgICAgICAgIFtHUFUgUHJvY2Vzc10gRG9uJ3QgZXZlciByZXBsYXkg RGlzcGxheUxpc3QgaXRlbXMgb2YgYSBSZW1vdGVJbWFnZUJ1ZmZlciBpbiBXZWJQcm9jZXNzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3IvbWFjL1dLSW5zcGVj dG9yUmVzb3VyY2VVUkxTY2hlbWVIYW5kbGVyLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv SW5zcGVjdG9yL21hYy9XS0luc3BlY3RvclJlc291cmNlVVJMU2NoZW1lSGFuZGxlci5tbQppbmRl eCAzZmIwZDgyYmQ2ZTJjZjU1YTg0YTQ0MzU1YjFkZWFjZTA2OGIxNjY2Li4yMDVmNjIyOTM0ZTg2 MDAwZWYxODlhNDJjNDFiNGJjNzE1YmJkZjA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9JbnNwZWN0b3IvbWFjL1dLSW5zcGVjdG9yUmVzb3VyY2VVUkxTY2hlbWVIYW5kbGVy Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9tYWMvV0tJbnNwZWN0 b3JSZXNvdXJjZVVSTFNjaGVtZUhhbmRsZXIubW0KQEAgLTU4LDYgKzU4LDEwIEBAIC0gKHZvaWQp d2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBzdGFydFVSTFNjaGVtZVRhc2s6KGlkIDxXS1VS TFNjaGVtZVRhc2s+KXVyCiAgICAgICAgIF9vcGVyYXRpb25RdWV1ZSA9IGFkb3B0TlMoW1tOU09w ZXJhdGlvblF1ZXVlIGFsbG9jXSBpbml0XSk7CiAgICAgICAgIF9vcGVyYXRpb25RdWV1ZS5nZXQo KS51bmRlcmx5aW5nUXVldWUgPSBkaXNwYXRjaF9nZXRfZ2xvYmFsX3F1ZXVlKFFPU19DTEFTU19V U0VSX0lOVEVSQUNUSVZFLCAwKTsKICAgICAgICAgX29wZXJhdGlvblF1ZXVlLmdldCgpLnF1YWxp dHlPZlNlcnZpY2UgPSBOU09wZXJhdGlvblF1YWxpdHlPZlNlcnZpY2VVc2VySW50ZXJhY3RpdmU7 CisKKyAgICAgICAgLy8gVGhlIGRlZmF1bHQgdmFsdWUgKE5TT3BlcmF0aW9uUXVldWVEZWZhdWx0 TWF4Q29uY3VycmVudE9wZXJhdGlvbkNvdW50KSByZXN1bHRzIGluIGEgbGFyZ2UgbnVtYmVyIG9m IHRocmVhZHMKKyAgICAgICAgLy8gdGhhdCBjYW4gZXhjZWVkIHRoZSBzb2Z0IGxpbWl0IGlmIHR3 byBXZWIgSW5zcGVjdG9yIGluc3RhbmNlcyBhcmUgYmVpbmcgbG9hZGVkIHNpbXVsdGFuZW91c2x5 LgorICAgICAgICBfb3BlcmF0aW9uUXVldWUuZ2V0KCkubWF4Q29uY3VycmVudE9wZXJhdGlvbkNv dW50ID0gNDsKICAgICB9CiAKICAgICBOU0Jsb2NrT3BlcmF0aW9uICpvcGVyYXRpb24gPSBbTlNC bG9ja09wZXJhdGlvbiBibG9ja09wZXJhdGlvbldpdGhCbG9jazpeewo=